)]}'
{"defaults/main.yml":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"efb01448b428cc26fe21831696009139088c4de3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    l2_population: \"{{ neutron_l2_population }}\""},{"line_number":114,"context_line":"    mechanisms: \"linuxbridge{% if neutron_l2_population | bool %},l2population{% endif %}\""},{"line_number":115,"context_line":"    l3_agent_mode: \"legacy\""},{"line_number":116,"context_line":"    router_distributed: False"},{"line_number":117,"context_line":"    plugin_conf_ini_overrides: \"{{ neutron_ml2_conf_ini_overrides }}\""},{"line_number":118,"context_line":"    plugin_core: neutron.plugins.ml2.plugin.Ml2Plugin"},{"line_number":119,"context_line":"    plugin_ini: plugins/ml2/ml2_conf.ini"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_6285ed05","line":116,"updated":"2016-07-11 15:09:42.000000000","message":"Extraneous setting now that the template defaults to False","commit_id":"14aa51b438f3b45144d4251151c48e3bcb3fdc7a"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"f8e7bddd008756cb2cd6f379d9a41d05d89da943","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    l2_population: \"{{ neutron_l2_population }}\""},{"line_number":114,"context_line":"    mechanisms: \"linuxbridge{% if neutron_l2_population | bool %},l2population{% endif %}\""},{"line_number":115,"context_line":"    l3_agent_mode: \"legacy\""},{"line_number":116,"context_line":"    router_distributed: False"},{"line_number":117,"context_line":"    plugin_conf_ini_overrides: \"{{ neutron_ml2_conf_ini_overrides }}\""},{"line_number":118,"context_line":"    plugin_core: neutron.plugins.ml2.plugin.Ml2Plugin"},{"line_number":119,"context_line":"    plugin_ini: plugins/ml2/ml2_conf.ini"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_b826e213","line":116,"in_reply_to":"1aa78d24_6285ed05","updated":"2016-07-11 15:25:25.000000000","message":"Done","commit_id":"14aa51b438f3b45144d4251151c48e3bcb3fdc7a"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"efb01448b428cc26fe21831696009139088c4de3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    l2_population: \"{{ neutron_l2_population }}\""},{"line_number":125,"context_line":"    mechanisms: \"openvswitch{% if neutron_l2_population | bool %},l2population{% endif %}\""},{"line_number":126,"context_line":"    l3_agent_mode: \"legacy\""},{"line_number":127,"context_line":"    router_distributed: False"},{"line_number":128,"context_line":"    plugin_conf_ini_overrides: \"{{ neutron_ml2_conf_ini_overrides }}\""},{"line_number":129,"context_line":"    plugin_core: neutron.plugins.ml2.plugin.Ml2Plugin"},{"line_number":130,"context_line":"    plugin_ini: plugins/ml2/ml2_conf.ini"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_4288b122","line":127,"updated":"2016-07-11 15:09:42.000000000","message":"Extraneous setting now that the template defaults to False","commit_id":"14aa51b438f3b45144d4251151c48e3bcb3fdc7a"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"f8e7bddd008756cb2cd6f379d9a41d05d89da943","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    l2_population: \"{{ neutron_l2_population }}\""},{"line_number":125,"context_line":"    mechanisms: \"openvswitch{% if neutron_l2_population | bool %},l2population{% endif %}\""},{"line_number":126,"context_line":"    l3_agent_mode: \"legacy\""},{"line_number":127,"context_line":"    router_distributed: False"},{"line_number":128,"context_line":"    plugin_conf_ini_overrides: \"{{ neutron_ml2_conf_ini_overrides }}\""},{"line_number":129,"context_line":"    plugin_core: neutron.plugins.ml2.plugin.Ml2Plugin"},{"line_number":130,"context_line":"    plugin_ini: plugins/ml2/ml2_conf.ini"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_387952fd","line":127,"in_reply_to":"1aa78d24_4288b122","updated":"2016-07-11 15:25:25.000000000","message":"Done","commit_id":"14aa51b438f3b45144d4251151c48e3bcb3fdc7a"}],"templates/l3_agent.ini.j2":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"efb01448b428cc26fe21831696009139088c4de3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Drivers"},{"line_number":14,"context_line":"interface_driver \u003d {{ neutron_plugins[neutron_plugin_type].driver_interface }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Agent mode (legacy only)"},{"line_number":17,"context_line":"agent_mode \u003d {{ neutron_plugins[neutron_plugin_type].l3_agent_mode }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Conventional failover"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1aa78d24_25d64f27","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":26},"updated":"2016-07-11 15:09:42.000000000","message":"Remove I think?","commit_id":"14aa51b438f3b45144d4251151c48e3bcb3fdc7a"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"f8e7bddd008756cb2cd6f379d9a41d05d89da943","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Drivers"},{"line_number":14,"context_line":"interface_driver \u003d {{ neutron_plugins[neutron_plugin_type].driver_interface }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Agent mode (legacy only)"},{"line_number":17,"context_line":"agent_mode \u003d {{ neutron_plugins[neutron_plugin_type].l3_agent_mode }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Conventional failover"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1aa78d24_f84eaabf","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":26},"in_reply_to":"1aa78d24_25d64f27","updated":"2016-07-11 15:25:25.000000000","message":"Done","commit_id":"14aa51b438f3b45144d4251151c48e3bcb3fdc7a"}],"templates/neutron.conf.j2":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"563b06c1a4a2404df453deab2dd4d88acadb3bb0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"router_auto_schedule \u003d True"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Distributed virtual routing"},{"line_number":44,"context_line":"router_distributed \u003d {{ neutron_plugins[neutron_plugin_type].router_distributed }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Agents"},{"line_number":47,"context_line":"agent_down_time \u003d {{ neutron_agent_down_time }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1aa78d24_88a59d05","line":44,"updated":"2016-07-11 14:14:40.000000000","message":"Should have a | default(\u0027False\u0027) probably as all plugins which do not specifically define router_distributed will fatal error in this template.","commit_id":"48c6fd7885d474bbc7c075f99944fbf29fa4ca44"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"75870cdfee1080d4ee272416995dc9bd6877714b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"router_auto_schedule \u003d True"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Distributed virtual routing"},{"line_number":44,"context_line":"router_distributed \u003d {{ neutron_plugins[neutron_plugin_type].router_distributed }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Agents"},{"line_number":47,"context_line":"agent_down_time \u003d {{ neutron_agent_down_time }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1aa78d24_0e91b599","line":44,"in_reply_to":"1aa78d24_88a59d05","updated":"2016-07-11 14:39:27.000000000","message":"Great catch Logan. Thanks for your review. I\u0027ve amended the patch.","commit_id":"48c6fd7885d474bbc7c075f99944fbf29fa4ca44"}],"templates/plugins/ml2/openvswitch_agent.ini.j2":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"efb01448b428cc26fe21831696009139088c4de3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"l2_population \u003d {{ neutron_plugins[neutron_plugin_type].l2_population }}"},{"line_number":14,"context_line":"tunnel_types \u003d {{ neutron_tunnel_types }}"},{"line_number":15,"context_line":"enable_distributed_routing \u003d {{ neutron_plugins[neutron_plugin_type].router_distributed }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Security groups"},{"line_number":18,"context_line":"[securitygroup]"},{"line_number":19,"context_line":"firewall_driver \u003d {{ neutron_plugins[neutron_plugin_type].driver_firewall }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1aa78d24_a546bf1e","line":16,"updated":"2016-07-11 15:09:42.000000000","message":"I don\u0027t know if this matters, but the DVR guide in your commit message says you should have\narp_responder \u003d True\n\nI did verify that the default value for arp_responder is False as of Mitaka.\nhttp://docs.openstack.org/mitaka/config-reference/networking/sample-configuration-files.html#openvswitch-agent-ini\n\nBased on the comment in the config reference, it looks like arp_responder should be set here and True conditionally if l2_population is enabled.","commit_id":"14aa51b438f3b45144d4251151c48e3bcb3fdc7a"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"f8e7bddd008756cb2cd6f379d9a41d05d89da943","unresolved":false,"context_lines":[{"line_number":13,"context_line":"l2_population \u003d {{ neutron_plugins[neutron_plugin_type].l2_population }}"},{"line_number":14,"context_line":"tunnel_types \u003d {{ neutron_tunnel_types }}"},{"line_number":15,"context_line":"enable_distributed_routing \u003d {{ neutron_plugins[neutron_plugin_type].router_distributed }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Security groups"},{"line_number":18,"context_line":"[securitygroup]"},{"line_number":19,"context_line":"firewall_driver \u003d {{ neutron_plugins[neutron_plugin_type].driver_firewall }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1aa78d24_981b261c","line":16,"in_reply_to":"1aa78d24_a546bf1e","updated":"2016-07-11 15:25:25.000000000","message":"Agreed on the arp_responder being set to true when l2pop is enabled. That is somewhat orthogonal to DVR however, so I\u0027ll submit in a separate patch. It also only really applies when GRE or VxLan tunnels are used.","commit_id":"14aa51b438f3b45144d4251151c48e3bcb3fdc7a"}]}
