)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"c8433ae5d20e58bc5e94eadb6442f512231a3c09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Qing Wu Wang \u003cwangqwsh@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-12 03:26:44 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable higher performance I/O through"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable higher performance I/O through using conntrack"},{"line_number":10,"context_line":"and remove the need to use hybrid vif plugging which slows"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_dae4463d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"updated":"2016-07-12 15:44:04.000000000","message":"Maybe just \u0027Enable use of OvS firewall driver?\u0027 or similar? Message is a bit generic right now.","commit_id":"95946b4c9e7231bce4575422b06cc4f804af2f54"}],"defaults/main.yml":[{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"c8433ae5d20e58bc5e94eadb6442f512231a3c09","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    plugin_core: neutron.plugins.ml2.plugin.Ml2Plugin"},{"line_number":106,"context_line":"    plugin_ini: plugins/ml2/ml2_conf.ini"},{"line_number":107,"context_line":"  ml2.ovs:"},{"line_number":108,"context_line":"    driver_firewall: \"{% if neutron_os_type is defined and neutron_os_type \u003d\u003d \u0027powervm\u0027 %}neutron.agent.linux.openvswitch_firewall.OVSFirewallDriver"},{"line_number":109,"context_line":"                     {% else %}neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver{% endif %}\""},{"line_number":110,"context_line":"    driver_interface: neutron.agent.linux.interface.OVSInterfaceDriver"},{"line_number":111,"context_line":"    drivers_type: \"{{ neutron_ml2_drivers_type }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_9d5f5840","line":108,"range":{"start_line":108,"start_character":79,"end_line":108,"end_character":86},"updated":"2016-07-12 15:44:04.000000000","message":"We want this to be the default for powervm since it\u0027s the firewall option we\u0027re choosing to support, but no reason this should be specific to powervm as it works for kvm as well.","commit_id":"95946b4c9e7231bce4575422b06cc4f804af2f54"}],"releasenotes/notes/neutron-ovs-powervm-116662f169e17175.yaml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"41f1e86ad1d50e769964d031fd205a207e47940c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    In Ubuntu 16.04 the updated kernel that is shipped has"},{"line_number":4,"context_line":"    conntrack support. The inclusion of conntrack led to a"},{"line_number":5,"context_line":"    new firewall driver that removed the need for hybrid vif"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_8fa6c7a8","line":2,"updated":"2016-07-13 13:54:03.000000000","message":"Remove the prelude block entirely. The text in other, should be in features. Please consult other release notes in the role for reference on how best to structure this note.","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"3f792f87df63aef0c98ced5b95b98e1d3984d498","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    In Ubuntu 16.04 the updated kernel that is shipped has"},{"line_number":4,"context_line":"    conntrack support. The inclusion of conntrack led to a"},{"line_number":5,"context_line":"    new firewall driver that removed the need for hybrid vif"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_d77682a2","line":2,"in_reply_to":"1aa78d24_8fa6c7a8","updated":"2016-07-14 02:24:04.000000000","message":"Done","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"d4400069c0be40d38f85a4936de7ae80a0ebb67d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``os_neutron`` role will now default to the OVS firewall driver when"},{"line_number":5,"context_line":"    ``neutron_plugin_type`` is ``ml2.ovs`` and the host is running Ubuntu"},{"line_number":6,"context_line":"    16.04 on PowerVM. To override this default behavior, deployers should"},{"line_number":7,"context_line":"    define ``neutron_ml2_conf_ini_overrides`` and"},{"line_number":8,"context_line":"    \u0027neutron_openvswitch_agent_ini_overrides\u0027 in \u0027user_variables.yml\u0027. Example"},{"line_number":9,"context_line":"    below"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dada55a8_4cea5dad","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":56},"updated":"2016-07-20 21:35:25.000000000","message":"Do we want to mention that this override can also be set for non-PowerVM (e.g. KVM) hypervisors here, or is that more appropriate for the install guide?","commit_id":"461788fdf9a65cae167d0896e6ca07ad11313516"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"db26995940ceb612f1da380e57c1c5a2883201b8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``os_neutron`` role will now default to the OVS firewall driver when"},{"line_number":5,"context_line":"    ``neutron_plugin_type`` is ``ml2.ovs`` and the host is running Ubuntu"},{"line_number":6,"context_line":"    16.04 on PowerVM. To override this default behavior, deployers should"},{"line_number":7,"context_line":"    define ``neutron_ml2_conf_ini_overrides`` and"},{"line_number":8,"context_line":"    \u0027neutron_openvswitch_agent_ini_overrides\u0027 in \u0027user_variables.yml\u0027. Example"},{"line_number":9,"context_line":"    below"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dada55a8_220f2d89","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":56},"in_reply_to":"dada55a8_4cea5dad","updated":"2016-07-21 01:59:38.000000000","message":"If deployers wanted to change the OVS firewall driver, they can refer to the example to customize it.\nFor this review, we want it to be under PowerVM situation. But for the non-PowerVM, it should not be involved here.\nThis release note helps deployers to set the non-OVS firewall driver when the neutron_plugin_type is ml2.ovs on Power platform.","commit_id":"461788fdf9a65cae167d0896e6ca07ad11313516"}],"tasks/main.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"3410183821a1f38750891452e5d50851f6bc96d2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  when:"},{"line_number":51,"context_line":"    - cpuinfo_contents.stdout.find(\u0027pSeries\u0027) !\u003d -1"},{"line_number":52,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":53,"context_line":"    - neutron_plugin_type \u003d\u003d \u0027ml2.ovs\u0027"},{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - always"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_3ab74fd9","line":53,"updated":"2016-07-12 13:58:17.000000000","message":"This condition should not be used in the fact. It may apply to later logic based on the fact, but shouldn\u0027t directly impact whether or not the fact is defined.","commit_id":"95946b4c9e7231bce4575422b06cc4f804af2f54"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"c8433ae5d20e58bc5e94eadb6442f512231a3c09","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  when:"},{"line_number":51,"context_line":"    - cpuinfo_contents.stdout.find(\u0027pSeries\u0027) !\u003d -1"},{"line_number":52,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":53,"context_line":"    - neutron_plugin_type \u003d\u003d \u0027ml2.ovs\u0027"},{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - always"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_d031c7ee","line":53,"in_reply_to":"1aa78d24_3ab74fd9","updated":"2016-07-12 15:44:04.000000000","message":"+1","commit_id":"95946b4c9e7231bce4575422b06cc4f804af2f54"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"0b11f52565f317d0a8d31c0658e7961d3c416233","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - neutron_plugin_type \u003d\u003d \u0027ml2.ovs\u0027"},{"line_number":61,"context_line":"    - \"{{ ansible_distribution_version | version_compare(\u002716.04\u0027,\u0027\u003e\u003d\u0027) }}\""},{"line_number":62,"context_line":"  tags:"},{"line_number":63,"context_line":"    - neutron-ovs-driver-firewall-powervm"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- include: neutron_check.yml"},{"line_number":66,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dada55a8_cb504e0d","line":63,"updated":"2016-07-19 12:43:05.000000000","message":"This tag should be one or both of the values: \"neutron-install\" and/or \"neutron-config\" Those are the only two tags the role should support.","commit_id":"239902f8208d8ba2544eff5385b4bc14e2ff00a8"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"11a35057fe01376c89efffe7315aa162cc92ca9f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - neutron_plugin_type \u003d\u003d \u0027ml2.ovs\u0027"},{"line_number":61,"context_line":"    - \"{{ ansible_distribution_version | version_compare(\u002716.04\u0027,\u0027\u003e\u003d\u0027) }}\""},{"line_number":62,"context_line":"  tags:"},{"line_number":63,"context_line":"    - neutron-ovs-driver-firewall-powervm"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- include: neutron_check.yml"},{"line_number":66,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dada55a8_532a352d","line":63,"in_reply_to":"dada55a8_cb504e0d","updated":"2016-07-20 02:17:36.000000000","message":"Done","commit_id":"239902f8208d8ba2544eff5385b4bc14e2ff00a8"}],"tasks/neutron_ml2_ovs_powervm.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4617c6b47a8a7e64383000e071b9238940fe3724","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Set neutron ovs driver firewall"},{"line_number":17,"context_line":"  shell: echo \"neutron.agent.linux.openvswitch_firewall.OVSFirewallDriver\""},{"line_number":18,"context_line":"  register: powervm_driver_firewall_ovs"},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - neutron-ovs-driver-firewall-powervm"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_af53c3e0","line":17,"updated":"2016-07-13 13:53:21.000000000","message":"Why are you using shell here? It appears this task is completely unnecessary","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"3f792f87df63aef0c98ced5b95b98e1d3984d498","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Set neutron ovs driver firewall"},{"line_number":17,"context_line":"  shell: echo \"neutron.agent.linux.openvswitch_firewall.OVSFirewallDriver\""},{"line_number":18,"context_line":"  register: powervm_driver_firewall_ovs"},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - neutron-ovs-driver-firewall-powervm"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_b7b77639","line":17,"in_reply_to":"1aa78d24_af53c3e0","updated":"2016-07-14 02:24:04.000000000","message":"refine it in next path set","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4617c6b47a8a7e64383000e071b9238940fe3724","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - neutron-ovs-driver-firewall-powervm"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Set neutron ovs driver firewall type"},{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    ovs_type: \"openvswitch\""},{"line_number":25,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_cf30cfa0","line":22,"updated":"2016-07-13 13:53:21.000000000","message":"This task also appears to be unnecessary","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"3f792f87df63aef0c98ced5b95b98e1d3984d498","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - neutron-ovs-driver-firewall-powervm"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Set neutron ovs driver firewall type"},{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    ovs_type: \"openvswitch\""},{"line_number":25,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_d784c25e","line":22,"in_reply_to":"1aa78d24_cf30cfa0","updated":"2016-07-14 02:24:04.000000000","message":"Done","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4617c6b47a8a7e64383000e071b9238940fe3724","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        firewall_driver: \"neutron.agent.linux.openvswitch_firewall.OVSFirewallDriver\""},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - ovs_type is defined"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - neutron-ovs-driver-firewall-powervm"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_af18e31e","line":37,"updated":"2016-07-13 13:53:21.000000000","message":"Remove this tag","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"3f792f87df63aef0c98ced5b95b98e1d3984d498","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        firewall_driver: \"neutron.agent.linux.openvswitch_firewall.OVSFirewallDriver\""},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - ovs_type is defined"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - neutron-ovs-driver-firewall-powervm"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_7794ee8b","line":37,"in_reply_to":"1aa78d24_af18e31e","updated":"2016-07-14 02:24:04.000000000","message":"Done","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"}],"templates/plugins/ml2/ml2_conf.ini.j2":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4617c6b47a8a7e64383000e071b9238940fe3724","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{% if ovs_type is defined %}"},{"line_number":38,"context_line":"firewall_driver \u003d {{ ovs_type }}"},{"line_number":39,"context_line":"{% elif neutron_plugin_type \u003d\u003d \u0027ml2.ovs\u0027 %}"},{"line_number":40,"context_line":"firewall_driver \u003d iptables_hybrid"},{"line_number":41,"context_line":"{% endif %}"},{"line_number":42,"context_line":"enable_security_group \u003d True"},{"line_number":43,"context_line":"enable_ipset \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1aa78d24_efa2ebac","line":40,"updated":"2016-07-13 13:53:21.000000000","message":"I\u0027d rather see a neutron_ml2_conf_firewall_driver var or similar introduced, and the powervm task include can set it to the specified value.","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"3f792f87df63aef0c98ced5b95b98e1d3984d498","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{% if ovs_type is defined %}"},{"line_number":38,"context_line":"firewall_driver \u003d {{ ovs_type }}"},{"line_number":39,"context_line":"{% elif neutron_plugin_type \u003d\u003d \u0027ml2.ovs\u0027 %}"},{"line_number":40,"context_line":"firewall_driver \u003d iptables_hybrid"},{"line_number":41,"context_line":"{% endif %}"},{"line_number":42,"context_line":"enable_security_group \u003d True"},{"line_number":43,"context_line":"enable_ipset \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1aa78d24_b76016d1","line":40,"in_reply_to":"1aa78d24_efa2ebac","updated":"2016-07-14 02:24:04.000000000","message":"Done","commit_id":"d998cf63ce0f11e6be97b45a16007c1b7d80e6d3"}]}