)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"432e280596cd7a63058e387446450e535cb31a73","unresolved":false,"context_lines":[{"line_number":111,"context_line":"# Other plugins can be added to the system by simply extending the list `neutron_plugin_base`."},{"line_number":112,"context_line":"# neutron_plugin_base:"},{"line_number":113,"context_line":"#   - router"},{"line_number":114,"context_line":"#   - firewall"},{"line_number":115,"context_line":"#   - firewall_v2"},{"line_number":116,"context_line":"#   - lbaas"},{"line_number":117,"context_line":"#   - neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2"},{"line_number":118,"context_line":"#   - neutron_dynamic_routing.services.bgp.bgp_plugin.BgpPlugin"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_9fcfa9b2","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":17},"updated":"2016-10-19 08:51:46.000000000","message":"I\u0027m guessing that both can\u0027t be implemented at the same time? If so, then rather do something like this:\n\n#   - firewall / firewall_v2 # either one or the other, not both\n\nIf they are mutually exclusive then there should be a check, something like https://github.com/openstack/openstack-ansible-os_neutron/blob/stable/mitaka/tasks/neutron_check.yml#L16 which validates the settings and causes a failure if both are enabled.","commit_id":"ab1999a84ad6d8405f44af13413d65656689ac48"}],"doc/source/configure-network-services.rst":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"4f52e86f855437a28e95f61ed9ce004ea8f3fe58","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Deploying FWaaS v2"},{"line_number":70,"context_line":"------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"FWaaS v2 is the next gen Neutron firewall service and will provide"},{"line_number":73,"context_line":"rich set of APIs for securing OpenStack networks. It is still under"},{"line_number":74,"context_line":"active development."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_479c26c0","line":72,"updated":"2016-10-20 15:12:32.000000000","message":"Spell out \u0027next generation\u0027","commit_id":"299491330dda0d709fb6c184db837358decc6f0f"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"4f52e86f855437a28e95f61ed9ce004ea8f3fe58","unresolved":false,"context_lines":[{"line_number":70,"context_line":"------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"FWaaS v2 is the next gen Neutron firewall service and will provide"},{"line_number":73,"context_line":"rich set of APIs for securing OpenStack networks. It is still under"},{"line_number":74,"context_line":"active development."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Refer to `FWaaS 2.0 API specification"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_67a12af8","line":73,"updated":"2016-10-20 15:12:32.000000000","message":"\"provide a rich set of APIs\"","commit_id":"299491330dda0d709fb6c184db837358decc6f0f"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"4f52e86f855437a28e95f61ed9ce004ea8f3fe58","unresolved":false,"context_lines":[{"line_number":73,"context_line":"rich set of APIs for securing OpenStack networks. It is still under"},{"line_number":74,"context_line":"active development."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Refer to `FWaaS 2.0 API specification"},{"line_number":77,"context_line":"\u003chttps://specs.openstack.org/openstack/neutron-specs/specs/newton/fwaas-api-2.0.html\u003e`_"},{"line_number":78,"context_line":"for more information on these FWaaS v2 features"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_87a2befa","line":76,"updated":"2016-10-20 15:12:32.000000000","message":"Should we add a \u0027the\u0027 after the \u0027to\u0027 ?","commit_id":"299491330dda0d709fb6c184db837358decc6f0f"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"4f52e86f855437a28e95f61ed9ce004ea8f3fe58","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\u003chttps://specs.openstack.org/openstack/neutron-specs/specs/newton/fwaas-api-2.0.html\u003e`_"},{"line_number":78,"context_line":"for more information on these FWaaS v2 features"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"To deploy FWaaS v2 follow the steps detailed below."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. note::"},{"line_number":83,"context_line":"    FWaaS v1 and v2 cannot be deployed simultaneously."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_a7a7c209","line":80,"updated":"2016-10-20 15:12:32.000000000","message":"Follow the steps below to deploy FWaaS v2:","commit_id":"299491330dda0d709fb6c184db837358decc6f0f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"76bbb9710f75ce0f78484ddb6005112474a5c33f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"da6895a0_55360804","updated":"2016-10-21 13:24:04.000000000","message":"I think it would be good to call out the migration path from FWaaSv1\u003e2, f there is one. Should there be no migration path from v1\u003e2 maybe we should simply state that as well.","commit_id":"395b64416a921285d9e4b7c31ba7b13d20985276"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4ee84dc2a9f134cd8edabdb7686998bbdd15f26c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"FWaaS v2 is the next generation Neutron firewall service and will provide"},{"line_number":73,"context_line":"a rich set of APIs for securing OpenStack networks. It is still under"},{"line_number":74,"context_line":"active development."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Refer to the `FWaaS 2.0 API specification"},{"line_number":77,"context_line":"\u003chttps://specs.openstack.org/openstack/neutron-specs/specs/newton/fwaas-api-2.0.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da6895a0_29c142e5","line":74,"range":{"start_line":73,"start_character":52,"end_line":74,"end_character":19},"updated":"2016-10-21 11:33:40.000000000","message":"Should FWaaSv2 be used in production environments today, or is it still alpha/beta software?","commit_id":"395b64416a921285d9e4b7c31ba7b13d20985276"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"76bbb9710f75ce0f78484ddb6005112474a5c33f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"FWaaS v2 is the next generation Neutron firewall service and will provide"},{"line_number":73,"context_line":"a rich set of APIs for securing OpenStack networks. It is still under"},{"line_number":74,"context_line":"active development."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Refer to the `FWaaS 2.0 API specification"},{"line_number":77,"context_line":"\u003chttps://specs.openstack.org/openstack/neutron-specs/specs/newton/fwaas-api-2.0.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da6895a0_957260e4","line":74,"range":{"start_line":73,"start_character":52,"end_line":74,"end_character":19},"in_reply_to":"da6895a0_29c142e5","updated":"2016-10-21 13:24:04.000000000","message":"++ I think if this is still under development we should highlight that fact so folks getting started know what they\u0027re getting into.","commit_id":"395b64416a921285d9e4b7c31ba7b13d20985276"}],"templates/l3_agent.ini.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"432e280596cd7a63058e387446450e535cb31a73","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Metadata"},{"line_number":29,"context_line":"enable_metadata_proxy \u003d True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if neutron_fwaas | bool and neutron_plugin_type !\u003d \u0027plumgrid\u0027 %}"},{"line_number":32,"context_line":"[fwaas]"},{"line_number":33,"context_line":"enabled \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa6399be_1fe71913","line":30,"updated":"2016-10-19 08:51:46.000000000","message":"This could be simplified a bit:\n\n{% if neutron_plugin_type !\u003d \u0027plumgrid\u0027 %}\n  {% if neutron_fwaas | bool %}\n\n[fwaas]\nenabled \u003d true\ndriver \u003d neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver\nagent_version \u003d v1\n\n[AGENT]\nextensions \u003d neutron_fwaas.services.firewall.agents.l3reference.firewall_l3_agent:L3WithFWaaS\n\n  {% elif neutron_fwaas_v2 | bool %}\n\n[fwaas]\nenabled \u003d true\ndriver \u003d neutron.agent.linux.iptables_firewall_v2.IptablesFirewallDriverV2\nagent_version \u003d v2\n\n[AGENT]\nextensions \u003d neutron_fwaas.services.firewall.agents.l3reference.firewall_l3_agent_v2:L3WithFWaaS\n\n  {% endif %}\n{% endif %}","commit_id":"ab1999a84ad6d8405f44af13413d65656689ac48"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4ee84dc2a9f134cd8edabdb7686998bbdd15f26c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"enable_metadata_proxy \u003d True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if neutron_plugin_type !\u003d \u0027plumgrid\u0027 %}"},{"line_number":32,"context_line":"    {% if neutron_fwaas | bool %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[fwaas]"},{"line_number":35,"context_line":"enabled \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da6895a0_24040914","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":33},"updated":"2016-10-21 11:33:40.000000000","message":"It reads just a little easier (and doesn\u0027t leave whitespace in the resulting file) if you format it like this:\n\n{%     if neutron_fwaas | bool %}\n\nThat said, this is a total style nit.","commit_id":"395b64416a921285d9e4b7c31ba7b13d20985276"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4ee84dc2a9f134cd8edabdb7686998bbdd15f26c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[fwaas]"},{"line_number":35,"context_line":"enabled \u003d true"},{"line_number":36,"context_line":"driver \u003d neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":37,"context_line":"agent_version \u003d v1"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[AGENT]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da6895a0_64aa81d6","line":36,"range":{"start_line":36,"start_character":9,"end_line":36,"end_character":78},"updated":"2016-10-21 11:33:40.000000000","message":"As we need to cater for differences between the OVS and LinuxBridge use cases, the value here needs to be:\n\n{{ neutron_plugins[neutron_plugin_type].driver_firewall }}","commit_id":"395b64416a921285d9e4b7c31ba7b13d20985276"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4ee84dc2a9f134cd8edabdb7686998bbdd15f26c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[fwaas]"},{"line_number":45,"context_line":"enabled \u003d true"},{"line_number":46,"context_line":"driver \u003d neutron.agent.linux.iptables_firewall_v2.IptablesFirewallDriverV2"},{"line_number":47,"context_line":"agent_version \u003d v2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[AGENT]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da6895a0_649e0158","line":46,"range":{"start_line":46,"start_character":9,"end_line":46,"end_character":74},"updated":"2016-10-21 11:33:40.000000000","message":"It may be better to do something like this in the role defaults:\n\nneutron_plugins:\n  ml2.lxb:\n    driver_firewall_v1: neutron.agent.linux.iptables_firewall.IptablesFirewallDriver\n    driver_firewall_v2: neutron_fwaas.agent.linux.iptables_firewall_v2.IptablesFirewallDriverV2\n\nThen you can simply refer to:\n\n{{ neutron_plugins[neutron_plugin_type].driver_firewall_v1 }}\n\nor\n\n{{ neutron_plugins[neutron_plugin_type].driver_firewall_v2 }}\n\nAnd each neutron implementation (OVS, LXB, etc) can have the special drivers used.","commit_id":"395b64416a921285d9e4b7c31ba7b13d20985276"}]}