)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"286f2bce32808d269728a581867f13c05d5039f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"50e890a0_e1c9a274","updated":"2022-06-08 08:13:46.000000000","message":"I think it might be fine to land it. Hopefully ovn will be fixed quite soon with uwsgi usage.","commit_id":"bdd06c84488c7008c0dcb3eaca4effc8d38fcaeb"}],"defaults/main.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"bcacc549c569a22e2452f7ebbe37cf14962d133c","unresolved":true,"context_lines":[{"line_number":185,"context_line":"    exec_dirs: \"{{ neutron_bin }},/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin\""},{"line_number":186,"context_line":"neutron_rootwrap_conf_overrides: {}"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"neutron_rpc_server_init_overrides: {}"},{"line_number":189,"context_line":"neutron_server_init_overrides: {}"},{"line_number":190,"context_line":"neutron_sriov_nic_agent_ini_overrides: {}"},{"line_number":191,"context_line":"neutron_sriov_nic_agent_init_overrides: {}"},{"line_number":192,"context_line":"neutron_vpn_agent_init_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e2516fcb_06c413e9","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":33},"updated":"2021-03-13 12:44:04.000000000","message":"Shouldn\u0027t these two get merged?","commit_id":"f509594a0df66e57aee12fd614e6ada8262eee69"}],"vars/main.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"bcacc549c569a22e2452f7ebbe37cf14962d133c","unresolved":true,"context_lines":[{"line_number":465,"context_line":"    config_type: \"ini\""},{"line_number":466,"context_line":"    init_config_overrides: \"{{ neutron_vpn_agent_init_overrides }}\""},{"line_number":467,"context_line":"    start_order: 3"},{"line_number":468,"context_line":"  neutron-server:"},{"line_number":469,"context_line":"    group: neutron_server"},{"line_number":470,"context_line":"    service_name: neutron-server"},{"line_number":471,"context_line":"    service_en: True"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"fe2a63e8_b0c48b6a","line":468,"range":{"start_line":468,"start_character":2,"end_line":468,"end_character":17},"updated":"2021-03-13 12:44:04.000000000","message":"Maybe call this neutron-api?","commit_id":"f509594a0df66e57aee12fd614e6ada8262eee69"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"bcacc549c569a22e2452f7ebbe37cf14962d133c","unresolved":true,"context_lines":[{"line_number":467,"context_line":"    start_order: 3"},{"line_number":468,"context_line":"  neutron-server:"},{"line_number":469,"context_line":"    group: neutron_server"},{"line_number":470,"context_line":"    service_name: neutron-server"},{"line_number":471,"context_line":"    service_en: True"},{"line_number":472,"context_line":"    init_config_overrides: \"{{ neutron_server_init_overrides }}\""},{"line_number":473,"context_line":"    start_order: 1"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"10cf3913_c68eb83e","line":470,"range":{"start_line":470,"start_character":4,"end_line":470,"end_character":32},"updated":"2021-03-13 12:44:04.000000000","message":"And call this neutron-api, and fix whatever breaks around that name?","commit_id":"f509594a0df66e57aee12fd614e6ada8262eee69"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"bcacc549c569a22e2452f7ebbe37cf14962d133c","unresolved":true,"context_lines":[{"line_number":469,"context_line":"    group: neutron_server"},{"line_number":470,"context_line":"    service_name: neutron-server"},{"line_number":471,"context_line":"    service_en: True"},{"line_number":472,"context_line":"    init_config_overrides: \"{{ neutron_server_init_overrides }}\""},{"line_number":473,"context_line":"    start_order: 1"},{"line_number":474,"context_line":"    wsgi_app: \"{{ neutron_use_uwsgi }}\""},{"line_number":475,"context_line":"    wsgi_path: \"{{ neutron_bin ~ \u0027/neutron-api\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d8019f87_bfb0765a","line":472,"range":{"start_line":472,"start_character":4,"end_line":472,"end_character":64},"updated":"2021-03-13 12:44:04.000000000","message":"This is either not needed, go to neutron-rpc-server, or get renamed to neutron_api_init_overrides","commit_id":"f509594a0df66e57aee12fd614e6ada8262eee69"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"b663fff0f9b34e9e982cfa234252050f53925bd4","unresolved":true,"context_lines":[{"line_number":467,"context_line":"    config_type: \"ini\""},{"line_number":468,"context_line":"    init_config_overrides: \"{{ neutron_vpn_agent_init_overrides }}\""},{"line_number":469,"context_line":"    start_order: 3"},{"line_number":470,"context_line":"  neutron-server:"},{"line_number":471,"context_line":"    group: neutron_server"},{"line_number":472,"context_line":"    service_name: neutron-server"},{"line_number":473,"context_line":"    service_en: True"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"31376ca6_3c44501e","line":470,"updated":"2021-08-25 14:21:48.000000000","message":"I still think this deserves the name neutron-api. We\u0027re moving the api out to uwsgi.","commit_id":"5464c6b6057f2377d5b43c75875f084451216cec"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"b663fff0f9b34e9e982cfa234252050f53925bd4","unresolved":true,"context_lines":[{"line_number":479,"context_line":"    wsgi_name: \"neutron-api\""},{"line_number":480,"context_line":"    execstarts: \"{{ neutron_bin }}/neutron-server --config-file {{ neutron_conf_dir }}/neutron.conf --config-file {{ neutron_conf_dir }}/{{ neutron_plugins[neutron_plugin_type].plugin_ini }}{%- if (\u0027ml2.genericswitch\u0027 in neutron_plugin_types) %} --config-file {{ neutron_conf_dir }}/{{ neutron_plugins[\u0027ml2.genericswitch\u0027].plugin_ini }}{%- endif %}\""},{"line_number":481,"context_line":"    init_config_overrides: \"{{ neutron_server_init_overrides }}\""},{"line_number":482,"context_line":"  neutron-rpc-server:"},{"line_number":483,"context_line":"    group: neutron_server"},{"line_number":484,"context_line":"    service_name: neutron-rpc-server"},{"line_number":485,"context_line":"    service_en: \"{{ neutron_use_uwsgi }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"a33d13e8_492f76bb","line":482,"updated":"2021-08-25 14:21:48.000000000","message":"And this could remain neutron-server","commit_id":"5464c6b6057f2377d5b43c75875f084451216cec"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"b663fff0f9b34e9e982cfa234252050f53925bd4","unresolved":true,"context_lines":[{"line_number":481,"context_line":"    init_config_overrides: \"{{ neutron_server_init_overrides }}\""},{"line_number":482,"context_line":"  neutron-rpc-server:"},{"line_number":483,"context_line":"    group: neutron_server"},{"line_number":484,"context_line":"    service_name: neutron-rpc-server"},{"line_number":485,"context_line":"    service_en: \"{{ neutron_use_uwsgi }}\""},{"line_number":486,"context_line":"    init_config_overrides: \"{{ neutron_rpc_server_init_overrides | combine(neutron_server_init_overrides) }}\""},{"line_number":487,"context_line":"    start_order: 2"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"8e61a15d_3cb643e9","line":484,"updated":"2021-08-25 14:21:48.000000000","message":"This could then be neutron_use_uwsgi | ternary(\u0027neutron-rpc-server\u0027, \u0027neutron-server\u0027)\nWhereby we launch neutron-rpc-server if we\u0027re moving the api out, or launch the neutron-server with built-in api as normal.","commit_id":"5464c6b6057f2377d5b43c75875f084451216cec"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7a6c51a495f143770a607c53b1d14274f895e7c4","unresolved":true,"context_lines":[{"line_number":481,"context_line":"    init_config_overrides: \"{{ neutron_server_init_overrides }}\""},{"line_number":482,"context_line":"  neutron-rpc-server:"},{"line_number":483,"context_line":"    group: neutron_server"},{"line_number":484,"context_line":"    service_name: neutron-rpc-server"},{"line_number":485,"context_line":"    service_en: \"{{ neutron_use_uwsgi }}\""},{"line_number":486,"context_line":"    init_config_overrides: \"{{ neutron_rpc_server_init_overrides | combine(neutron_server_init_overrides) }}\""},{"line_number":487,"context_line":"    start_order: 2"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"09d8223a_09da47e5","line":484,"in_reply_to":"8e61a15d_3cb643e9","updated":"2021-08-26 11:07:20.000000000","message":"We added `service_en: \"{{ neutron_use_uwsgi }}\"` so when it\u0027s not uwsgi - this service would be just disabled.\n\nAlso name service differently with the same execstarts is kind of weird imo.","commit_id":"5464c6b6057f2377d5b43c75875f084451216cec"}]}