)]}'
{"defaults/main.yml":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"bafc37e9d45ee53d3600e22a2a415abc130d2067","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# for anything supported by the service. See the section"},{"line_number":133,"context_line":"# \u0027Overriding OpenStack configuration defaults\u0027 in the"},{"line_number":134,"context_line":"# \u0027Advanced configuration\u0027 appendix of the Deploy Guide."},{"line_number":135,"context_line":"neutron_api_paste_ini_overrides:"},{"line_number":136,"context_line":"  \"composite:neutronapi_v2_0\":"},{"line_number":137,"context_line":"    noauth: \"cors http_proxy_to_wsgi request_id catch_errors osprofiler extensions neutronapiapp_v2_0\""},{"line_number":138,"context_line":"    keystone: \"cors http_proxy_to_wsgi request_id catch_errors osprofiler authtoken keystonecontext extensions neutronapiapp_v2_0\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"neutron_bgp_dragent_ini_overrides: {}"},{"line_number":141,"context_line":"neutron_bgp_dragent_init_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_5d4ccf75","line":138,"range":{"start_line":135,"start_character":0,"end_line":138,"end_character":130},"updated":"2018-08-03 19:51:46.000000000","message":"Do we want to leave this as `{}` but then merge it into the task later, that way if a user overrides `neutron_api_paste_ini_overrides` for some reason, they don\u0027t end up with a broken install?","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99f3b01882a7ff59dd9d45ff73a4906325745f19","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# for anything supported by the service. See the section"},{"line_number":133,"context_line":"# \u0027Overriding OpenStack configuration defaults\u0027 in the"},{"line_number":134,"context_line":"# \u0027Advanced configuration\u0027 appendix of the Deploy Guide."},{"line_number":135,"context_line":"neutron_api_paste_ini_overrides:"},{"line_number":136,"context_line":"  \"composite:neutronapi_v2_0\":"},{"line_number":137,"context_line":"    noauth: \"cors http_proxy_to_wsgi request_id catch_errors osprofiler extensions neutronapiapp_v2_0\""},{"line_number":138,"context_line":"    keystone: \"cors http_proxy_to_wsgi request_id catch_errors osprofiler authtoken keystonecontext extensions neutronapiapp_v2_0\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"neutron_bgp_dragent_ini_overrides: {}"},{"line_number":141,"context_line":"neutron_bgp_dragent_init_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_7d642bba","line":138,"range":{"start_line":135,"start_character":0,"end_line":138,"end_character":130},"in_reply_to":"3f79a3b5_5d4ccf75","updated":"2018-08-03 20:03:58.000000000","message":"Done","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"bafc37e9d45ee53d3600e22a2a415abc130d2067","unresolved":false,"context_lines":[{"line_number":172,"context_line":"#  \"create_subnet\": \"rule:admin_or_network_owner\""},{"line_number":173,"context_line":"#  \"get_subnet\": \"rule:admin_or_owner or rule:shared\""},{"line_number":174,"context_line":"neutron_policy_overrides: {}"},{"line_number":175,"context_line":"neutron_rootwrap_conf_overrides:"},{"line_number":176,"context_line":"  DEFAULT:"},{"line_number":177,"context_line":"    filters_path: \"{{ neutron_conf_dir }}/rootwrap.d,/usr/share/neutron/rootwrap\""},{"line_number":178,"context_line":"    exec_dirs: \"{{ neutron_bin }},/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"neutron_server_init_overrides: {}"},{"line_number":181,"context_line":"neutron_sriov_nic_agent_ini_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_3d5b132f","line":178,"range":{"start_line":175,"start_character":0,"end_line":178,"end_character":95},"updated":"2018-08-03 19:51:46.000000000","message":"Ditto for this too, so maybe _neutron_rootwrap_conf + neutron_rootwrap_conf_overrides ?","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99f3b01882a7ff59dd9d45ff73a4906325745f19","unresolved":false,"context_lines":[{"line_number":172,"context_line":"#  \"create_subnet\": \"rule:admin_or_network_owner\""},{"line_number":173,"context_line":"#  \"get_subnet\": \"rule:admin_or_owner or rule:shared\""},{"line_number":174,"context_line":"neutron_policy_overrides: {}"},{"line_number":175,"context_line":"neutron_rootwrap_conf_overrides:"},{"line_number":176,"context_line":"  DEFAULT:"},{"line_number":177,"context_line":"    filters_path: \"{{ neutron_conf_dir }}/rootwrap.d,/usr/share/neutron/rootwrap\""},{"line_number":178,"context_line":"    exec_dirs: \"{{ neutron_bin }},/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"neutron_server_init_overrides: {}"},{"line_number":181,"context_line":"neutron_sriov_nic_agent_ini_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_3d5eb3e6","line":178,"range":{"start_line":175,"start_character":0,"end_line":178,"end_character":95},"in_reply_to":"3f79a3b5_3d5b132f","updated":"2018-08-03 20:03:58.000000000","message":"Done","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"}],"tasks/neutron_post_install.yml":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"bafc37e9d45ee53d3600e22a2a415abc130d2067","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    src: \"{{ item.src }}\""},{"line_number":40,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":41,"context_line":"    flat: yes"},{"line_number":42,"context_line":"  when:"},{"line_number":43,"context_line":"    - item.config_overrides"},{"line_number":44,"context_line":"  with_items:"},{"line_number":45,"context_line":"    - dest: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":46,"context_line":"      src: \"{{ neutron_conf_dir }}/api-paste.ini\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_7d88ab70","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":27},"updated":"2018-08-03 19:51:46.000000000","message":"I think we will have to remove this, because technically, it is possible that the user goes from {bunch of settings} to {}, and then running this will mean that it won\u0027t actually run this task cause the value of config_overrides is empty.","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99f3b01882a7ff59dd9d45ff73a4906325745f19","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    src: \"{{ item.src }}\""},{"line_number":40,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":41,"context_line":"    flat: yes"},{"line_number":42,"context_line":"  when:"},{"line_number":43,"context_line":"    - item.config_overrides"},{"line_number":44,"context_line":"  with_items:"},{"line_number":45,"context_line":"    - dest: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":46,"context_line":"      src: \"{{ neutron_conf_dir }}/api-paste.ini\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_ddf77fd4","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":27},"in_reply_to":"3f79a3b5_7d88ab70","updated":"2018-08-03 20:03:58.000000000","message":"If the user has overrides it should fire the item containing the overrides. That way we\u0027re not needlessly copying files back to the deployment host.","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"bafc37e9d45ee53d3600e22a2a415abc130d2067","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  notify:"},{"line_number":35,"context_line":"    - Restart neutron services"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Fetch override files"},{"line_number":38,"context_line":"  fetch:"},{"line_number":39,"context_line":"    src: \"{{ item.src }}\""},{"line_number":40,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":41,"context_line":"    flat: yes"},{"line_number":42,"context_line":"  when:"},{"line_number":43,"context_line":"    - item.config_overrides"},{"line_number":44,"context_line":"  with_items:"},{"line_number":45,"context_line":"    - dest: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":46,"context_line":"      src: \"{{ neutron_conf_dir }}/api-paste.ini\""},{"line_number":47,"context_line":"      config_overrides: \"{{ neutron_api_paste_ini_overrides }}\""},{"line_number":48,"context_line":"    - dest: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":49,"context_line":"      src: \"{{ neutron_conf_dir }}/rootwrap.conf\""},{"line_number":50,"context_line":"      config_overrides: \"{{ neutron_rootwrap_conf_overrides }}\""},{"line_number":51,"context_line":"    - dest: \"/tmp/policy.json-{{ inventory_hostname }}\""},{"line_number":52,"context_line":"      src: \"{{ neutron_conf_dir }}/policy.json\""},{"line_number":53,"context_line":"      config_overrides: \"{{ neutron_policy_overrides }}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Copy common neutron config"},{"line_number":56,"context_line":"  config_template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_3da9d3de","line":53,"range":{"start_line":37,"start_character":0,"end_line":53,"end_character":56},"updated":"2018-08-03 19:51:46.000000000","message":"It would be really nice to have remote_src inside config_template to avoid this step.  I wouldn\u0027t block this change on this but it would be nice and reduce the # of tasks and polluting the deploy host.","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99f3b01882a7ff59dd9d45ff73a4906325745f19","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  notify:"},{"line_number":35,"context_line":"    - Restart neutron services"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Fetch override files"},{"line_number":38,"context_line":"  fetch:"},{"line_number":39,"context_line":"    src: \"{{ item.src }}\""},{"line_number":40,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":41,"context_line":"    flat: yes"},{"line_number":42,"context_line":"  when:"},{"line_number":43,"context_line":"    - item.config_overrides"},{"line_number":44,"context_line":"  with_items:"},{"line_number":45,"context_line":"    - dest: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":46,"context_line":"      src: \"{{ neutron_conf_dir }}/api-paste.ini\""},{"line_number":47,"context_line":"      config_overrides: \"{{ neutron_api_paste_ini_overrides }}\""},{"line_number":48,"context_line":"    - dest: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":49,"context_line":"      src: \"{{ neutron_conf_dir }}/rootwrap.conf\""},{"line_number":50,"context_line":"      config_overrides: \"{{ neutron_rootwrap_conf_overrides }}\""},{"line_number":51,"context_line":"    - dest: \"/tmp/policy.json-{{ inventory_hostname }}\""},{"line_number":52,"context_line":"      src: \"{{ neutron_conf_dir }}/policy.json\""},{"line_number":53,"context_line":"      config_overrides: \"{{ neutron_policy_overrides }}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Copy common neutron config"},{"line_number":56,"context_line":"  config_template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_bd69638c","line":53,"range":{"start_line":37,"start_character":0,"end_line":53,"end_character":56},"in_reply_to":"3f79a3b5_3da9d3de","updated":"2018-08-03 20:03:58.000000000","message":"Totally agree. That might be a good item to add to the backlog.","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"bafc37e9d45ee53d3600e22a2a415abc130d2067","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    mode: \"0640\""},{"line_number":62,"context_line":"    config_overrides: \"{{ item.config_overrides }}\""},{"line_number":63,"context_line":"    config_type: \"{{ item.config_type }}\""},{"line_number":64,"context_line":"  when:"},{"line_number":65,"context_line":"    - item.config_overrides"},{"line_number":66,"context_line":"  with_items:"},{"line_number":67,"context_line":"    - src: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":68,"context_line":"      dest: \"{{ neutron_conf_dir }}/api-paste.ini\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_1d7df76d","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":27},"updated":"2018-08-03 19:51:46.000000000","message":"Same comment as the fetch above","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"d9f29bd4f1397187f69cc8ced26ea9db38802102","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  with_items:"},{"line_number":67,"context_line":"    - src: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":68,"context_line":"      dest: \"{{ neutron_conf_dir }}/api-paste.ini\""},{"line_number":69,"context_line":"      config_overrides: \"{{ _neutron_api_paste_ini_overrides | combine(neutron_api_paste_ini_overrides) }}\""},{"line_number":70,"context_line":"      config_type: \"ini\""},{"line_number":71,"context_line":"    - src: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":72,"context_line":"      dest: \"{{ neutron_conf_dir }}/rootwrap.conf\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_dd93ff5b","line":69,"range":{"start_line":69,"start_character":63,"end_line":69,"end_character":103},"updated":"2018-08-03 20:15:46.000000000","message":"combine(neutron_api_paste_ini_overrides, recursive\u003dTrue)","commit_id":"78f339810880f7d1b5a018b45bc56639759bdd9e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"47698d3ca9e018d5dda7c983ea441605d1a66bf7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  with_items:"},{"line_number":67,"context_line":"    - src: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":68,"context_line":"      dest: \"{{ neutron_conf_dir }}/api-paste.ini\""},{"line_number":69,"context_line":"      config_overrides: \"{{ _neutron_api_paste_ini_overrides | combine(neutron_api_paste_ini_overrides) }}\""},{"line_number":70,"context_line":"      config_type: \"ini\""},{"line_number":71,"context_line":"    - src: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":72,"context_line":"      dest: \"{{ neutron_conf_dir }}/rootwrap.conf\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_fdffdb31","line":69,"range":{"start_line":69,"start_character":63,"end_line":69,"end_character":103},"in_reply_to":"3f79a3b5_dd93ff5b","updated":"2018-08-03 20:41:40.000000000","message":"Done","commit_id":"78f339810880f7d1b5a018b45bc56639759bdd9e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"d9f29bd4f1397187f69cc8ced26ea9db38802102","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      config_type: \"ini\""},{"line_number":71,"context_line":"    - src: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":72,"context_line":"      dest: \"{{ neutron_conf_dir }}/rootwrap.conf\""},{"line_number":73,"context_line":"      config_overrides: \"{{ _neutron_rootwrap_conf_overrides | combine(neutron_rootwrap_conf_overrides) }}\""},{"line_number":74,"context_line":"      config_type: \"ini\""},{"line_number":75,"context_line":"    - src: \"/tmp/policy.json-{{ inventory_hostname }}\""},{"line_number":76,"context_line":"      dest: \"{{ neutron_conf_dir }}/policy.json-{{ neutron_venv_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_fd903b51","line":73,"range":{"start_line":73,"start_character":63,"end_line":73,"end_character":103},"updated":"2018-08-03 20:15:46.000000000","message":"Ditto","commit_id":"78f339810880f7d1b5a018b45bc56639759bdd9e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"d9f29bd4f1397187f69cc8ced26ea9db38802102","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    - item.config_overrides"},{"line_number":88,"context_line":"  with_items:"},{"line_number":89,"context_line":"    - path: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":90,"context_line":"      config_overrides: \"{{ _neutron_api_paste_ini_overrides | combine(neutron_api_paste_ini_overrides) }}\""},{"line_number":91,"context_line":"    - path: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":92,"context_line":"      config_overrides: \"{{ _neutron_rootwrap_conf_overrides | combine(neutron_rootwrap_conf_overrides) }}\""},{"line_number":93,"context_line":"    - path: \"/tmp/policy.json-{{ inventory_hostname }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_3d88f31d","line":90,"range":{"start_line":90,"start_character":63,"end_line":90,"end_character":103},"updated":"2018-08-03 20:15:46.000000000","message":"Ditto","commit_id":"78f339810880f7d1b5a018b45bc56639759bdd9e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"d9f29bd4f1397187f69cc8ced26ea9db38802102","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    - path: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":90,"context_line":"      config_overrides: \"{{ _neutron_api_paste_ini_overrides | combine(neutron_api_paste_ini_overrides) }}\""},{"line_number":91,"context_line":"    - path: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":92,"context_line":"      config_overrides: \"{{ _neutron_rootwrap_conf_overrides | combine(neutron_rootwrap_conf_overrides) }}\""},{"line_number":93,"context_line":"    - path: \"/tmp/policy.json-{{ inventory_hostname }}\""},{"line_number":94,"context_line":"      config_overrides: \"{{ neutron_policy_overrides }}\""},{"line_number":95,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_fd791b2f","line":92,"range":{"start_line":92,"start_character":63,"end_line":92,"end_character":103},"updated":"2018-08-03 20:15:46.000000000","message":"Ditto","commit_id":"78f339810880f7d1b5a018b45bc56639759bdd9e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"a7ddbd9386120c897fb4d0d7bf40ccf0a416d6fe","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Set core config files"},{"line_number":67,"context_line":"  set_fact:"},{"line_number":68,"context_line":"    neutron_core_files:"},{"line_number":69,"context_line":"      - tmp_f: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":70,"context_line":"        target_f: \"{{ neutron_conf_dir }}/api-paste.ini\""},{"line_number":71,"context_line":"        config_overrides: \"{{ _neutron_api_paste_ini_overrides | combine(neutron_api_paste_ini_overrides, recursive\u003dTrue) }}\""},{"line_number":72,"context_line":"        config_type: \"ini\""},{"line_number":73,"context_line":"      - tmp_f: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":74,"context_line":"        target_f: \"{{ neutron_conf_dir }}/rootwrap.conf\""},{"line_number":75,"context_line":"        config_overrides: \"{{ _neutron_rootwrap_conf_overrides | combine(neutron_rootwrap_conf_overrides, recursive\u003dTrue) }}\""},{"line_number":76,"context_line":"        config_type: \"ini\""},{"line_number":77,"context_line":"      - tmp_f: \"/tmp/policy.json-{{ inventory_hostname }}\""},{"line_number":78,"context_line":"        target_f: \"{{ neutron_conf_dir }}/policy.json\""},{"line_number":79,"context_line":"        config_overrides: \"{{ neutron_policy_overrides }}\""},{"line_number":80,"context_line":"        config_type: \"json\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: Preserve original configuration file(s)"},{"line_number":83,"context_line":"  command: \"cp {{ item.target_f }} {{ item.target_f }}.original\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_61d78fc1","line":80,"range":{"start_line":68,"start_character":0,"end_line":80,"end_character":27},"updated":"2018-08-06 13:53:06.000000000","message":"Small nit but I guess we could save ourselves a task by placing this in vars/main.yml","commit_id":"f63789261692181e0ddba4bcab9e8ab294e03742"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bfedea2221f3b68e3a60ce0683c4dfa7d7afca3f","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Set core config files"},{"line_number":67,"context_line":"  set_fact:"},{"line_number":68,"context_line":"    neutron_core_files:"},{"line_number":69,"context_line":"      - tmp_f: \"/tmp/api-paste.ini-{{ inventory_hostname }}\""},{"line_number":70,"context_line":"        target_f: \"{{ neutron_conf_dir }}/api-paste.ini\""},{"line_number":71,"context_line":"        config_overrides: \"{{ _neutron_api_paste_ini_overrides | combine(neutron_api_paste_ini_overrides, recursive\u003dTrue) }}\""},{"line_number":72,"context_line":"        config_type: \"ini\""},{"line_number":73,"context_line":"      - tmp_f: \"/tmp/rootwrap.conf-{{ inventory_hostname }}\""},{"line_number":74,"context_line":"        target_f: \"{{ neutron_conf_dir }}/rootwrap.conf\""},{"line_number":75,"context_line":"        config_overrides: \"{{ _neutron_rootwrap_conf_overrides | combine(neutron_rootwrap_conf_overrides, recursive\u003dTrue) }}\""},{"line_number":76,"context_line":"        config_type: \"ini\""},{"line_number":77,"context_line":"      - tmp_f: \"/tmp/policy.json-{{ inventory_hostname }}\""},{"line_number":78,"context_line":"        target_f: \"{{ neutron_conf_dir }}/policy.json\""},{"line_number":79,"context_line":"        config_overrides: \"{{ neutron_policy_overrides }}\""},{"line_number":80,"context_line":"        config_type: \"json\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: Preserve original configuration file(s)"},{"line_number":83,"context_line":"  command: \"cp {{ item.target_f }} {{ item.target_f }}.original\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_0d8a851a","line":80,"range":{"start_line":68,"start_character":0,"end_line":80,"end_character":27},"in_reply_to":"3f79a3b5_61d78fc1","updated":"2018-08-07 00:54:33.000000000","message":"Done","commit_id":"f63789261692181e0ddba4bcab9e8ab294e03742"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"a7ddbd9386120c897fb4d0d7bf40ccf0a416d6fe","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- name: Fetch override files"},{"line_number":89,"context_line":"  fetch:"},{"line_number":90,"context_line":"    src: \"{{ item.target_f }}\""},{"line_number":91,"context_line":"    dest: \"{{ item.tmp_f }}\""},{"line_number":92,"context_line":"    flat: yes"},{"line_number":93,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_819e6b05","line":90,"range":{"start_line":90,"start_character":10,"end_line":90,"end_character":29},"updated":"2018-08-06 13:53:06.000000000","message":"For idempotency with this task and the next task I wonder if you should fetch \"{{ item.target_f }}.original\" instead?\n\nIf you do that, you could potentially get rid of the conditional on this task and remove the \"Re-enable original configuration file(s)\" task I think?\n\nAlso maybe this should have a conditional like\n- inventory_hostname \u003d\u003d ansible_play_hosts[0]\n\nTo make it only run on the 1st neutron host.","commit_id":"f63789261692181e0ddba4bcab9e8ab294e03742"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bfedea2221f3b68e3a60ce0683c4dfa7d7afca3f","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- name: Fetch override files"},{"line_number":89,"context_line":"  fetch:"},{"line_number":90,"context_line":"    src: \"{{ item.target_f }}\""},{"line_number":91,"context_line":"    dest: \"{{ item.tmp_f }}\""},{"line_number":92,"context_line":"    flat: yes"},{"line_number":93,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_6d9bf971","line":90,"range":{"start_line":90,"start_character":10,"end_line":90,"end_character":29},"in_reply_to":"3f79a3b5_819e6b05","updated":"2018-08-07 00:54:33.000000000","message":"Done","commit_id":"f63789261692181e0ddba4bcab9e8ab294e03742"}],"tasks/neutron_pre_install.yml":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"bafc37e9d45ee53d3600e22a2a415abc130d2067","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    - path: \"/openstack\""},{"line_number":63,"context_line":"      owner: \"root\""},{"line_number":64,"context_line":"      group: \"root\""},{"line_number":65,"context_line":"    - path: \"{{ neutron_conf_dir }}\""},{"line_number":66,"context_line":"      mode: \"0750\""},{"line_number":67,"context_line":"      condition: \"{{ neutron_install_method !\u003d \u0027source\u0027 }}\""},{"line_number":68,"context_line":"    - dest: \"{{ neutron_conf_dir }}\""},{"line_number":69,"context_line":"      src: \"{{ neutron_bin | dirname }}/etc/neutron\""},{"line_number":70,"context_line":"      state: link"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_bd8de37c","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":59},"updated":"2018-08-03 19:51:46.000000000","message":"We can even drop this (I think?) because in distro installs, the package creates folders automatically.\n\nHowever, it would be nice for it to say \u003d\u003d \u0027distro\u0027 rather than !\u003d \u0027source\u0027 just cause it\u0027s cleaner.","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99f3b01882a7ff59dd9d45ff73a4906325745f19","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    - path: \"/openstack\""},{"line_number":63,"context_line":"      owner: \"root\""},{"line_number":64,"context_line":"      group: \"root\""},{"line_number":65,"context_line":"    - path: \"{{ neutron_conf_dir }}\""},{"line_number":66,"context_line":"      mode: \"0750\""},{"line_number":67,"context_line":"      condition: \"{{ neutron_install_method !\u003d \u0027source\u0027 }}\""},{"line_number":68,"context_line":"    - dest: \"{{ neutron_conf_dir }}\""},{"line_number":69,"context_line":"      src: \"{{ neutron_bin | dirname }}/etc/neutron\""},{"line_number":70,"context_line":"      state: link"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_bd1723ee","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":59},"in_reply_to":"3f79a3b5_bd8de37c","updated":"2018-08-03 20:03:58.000000000","message":"Done","commit_id":"a23ea02151aded8b7b05336ab97417fb900d058f"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"d9f29bd4f1397187f69cc8ced26ea9db38802102","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    createhome: \"yes\""},{"line_number":30,"context_line":"    home: \"/var/lib/{{ neutron_system_user_name }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Source config block"},{"line_number":33,"context_line":"  block:"},{"line_number":34,"context_line":"    - name: stat directories if they exist"},{"line_number":35,"context_line":"      stat:"},{"line_number":36,"context_line":"        path: \"{{ neutron_conf_dir }}\""},{"line_number":37,"context_line":"      register: neutron_conf_dir_stat"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Remove the neutron config directory"},{"line_number":40,"context_line":"      file:"},{"line_number":41,"context_line":"        path: \"{{ neutron_conf_dir }}\""},{"line_number":42,"context_line":"        state: absent"},{"line_number":43,"context_line":"      when:"},{"line_number":44,"context_line":"        - neutron_conf_dir_stat.stat.isdir is defined and"},{"line_number":45,"context_line":"          neutron_conf_dir_stat.stat.isdir"},{"line_number":46,"context_line":"  when:"},{"line_number":47,"context_line":"    - neutron_install_method \u003d\u003d \u0027source\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Create neutron dir"},{"line_number":50,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_7dbc2bbb","line":47,"range":{"start_line":32,"start_character":0,"end_line":47,"end_character":40},"updated":"2018-08-03 20:15:46.000000000","message":"I\u0027m confused about this. Doesn\u0027t this remove all idempotence for configs?","commit_id":"78f339810880f7d1b5a018b45bc56639759bdd9e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"3b43460eb8e070c182088ab8ba9b7e9b48d2767b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    createhome: \"yes\""},{"line_number":30,"context_line":"    home: \"/var/lib/{{ neutron_system_user_name }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Source config block"},{"line_number":33,"context_line":"  block:"},{"line_number":34,"context_line":"    - name: stat directories if they exist"},{"line_number":35,"context_line":"      stat:"},{"line_number":36,"context_line":"        path: \"{{ neutron_conf_dir }}\""},{"line_number":37,"context_line":"      register: neutron_conf_dir_stat"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Remove the neutron config directory"},{"line_number":40,"context_line":"      file:"},{"line_number":41,"context_line":"        path: \"{{ neutron_conf_dir }}\""},{"line_number":42,"context_line":"        state: absent"},{"line_number":43,"context_line":"      when:"},{"line_number":44,"context_line":"        - neutron_conf_dir_stat.stat.isdir is defined and"},{"line_number":45,"context_line":"          neutron_conf_dir_stat.stat.isdir"},{"line_number":46,"context_line":"  when:"},{"line_number":47,"context_line":"    - neutron_install_method \u003d\u003d \u0027source\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Create neutron dir"},{"line_number":50,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_81e66be8","line":47,"range":{"start_line":32,"start_character":0,"end_line":47,"end_character":40},"in_reply_to":"3f79a3b5_1de9777f","updated":"2018-08-06 13:38:23.000000000","message":"Ahh ok that makes sense, thanks.","commit_id":"78f339810880f7d1b5a018b45bc56639759bdd9e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"47698d3ca9e018d5dda7c983ea441605d1a66bf7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    createhome: \"yes\""},{"line_number":30,"context_line":"    home: \"/var/lib/{{ neutron_system_user_name }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Source config block"},{"line_number":33,"context_line":"  block:"},{"line_number":34,"context_line":"    - name: stat directories if they exist"},{"line_number":35,"context_line":"      stat:"},{"line_number":36,"context_line":"        path: \"{{ neutron_conf_dir }}\""},{"line_number":37,"context_line":"      register: neutron_conf_dir_stat"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Remove the neutron config directory"},{"line_number":40,"context_line":"      file:"},{"line_number":41,"context_line":"        path: \"{{ neutron_conf_dir }}\""},{"line_number":42,"context_line":"        state: absent"},{"line_number":43,"context_line":"      when:"},{"line_number":44,"context_line":"        - neutron_conf_dir_stat.stat.isdir is defined and"},{"line_number":45,"context_line":"          neutron_conf_dir_stat.stat.isdir"},{"line_number":46,"context_line":"  when:"},{"line_number":47,"context_line":"    - neutron_install_method \u003d\u003d \u0027source\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Create neutron dir"},{"line_number":50,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_1de9777f","line":47,"range":{"start_line":32,"start_character":0,"end_line":47,"end_character":40},"in_reply_to":"3f79a3b5_7dbc2bbb","updated":"2018-08-03 20:41:40.000000000","message":"in the case of an upgrade on a source install the directory is now a link so we need to remove the old directory and replace it with a link. Once this has completed it should never run again.","commit_id":"78f339810880f7d1b5a018b45bc56639759bdd9e"}]}
