)]}'
{"templates/plugins/ml2/ml2_conf.ini.j2":[{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"37d990091cffa6a803a8467271cd2fa42f86ed06","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# Security groups"},{"line_number":59,"context_line":"[securitygroup]"},{"line_number":60,"context_line":"{% if neutron_plugin_type \u003d\u003d \u0027ml2.ovs\u0027 or neutron_plugin_type \u003d\u003d \u0027ml2.ovs.dvr\u0027 %}"},{"line_number":61,"context_line":"firewall_driver \u003d {{ neutron_plugins[neutron_plugin_type].driver_firewall }}"},{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":"enable_security_group \u003d True"},{"line_number":64,"context_line":"enable_ipset \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f621f24_a9d8d71d","line":61,"updated":"2020-11-09 14:46:37.000000000","message":"LGTM. However, I\u0027m not entirely sure firewall_driver needs to be defined in both ml2_conf.ini *and* the agent ini file. Given both config files are passed in the service definition file, I would imagine the latter value overrides the former. It might be worth checking to see if we can remove firewall_driver from ml2_conf.ini snd *only* define in the agent config file, where it currently looks OK. See https://opendev.org/openstack/openstack-ansible-os_neutron/src/branch/master/templates/plugins/ml2/openvswitch_agent.ini.j2#L36","commit_id":"3c5a26cca9d125a927d9707119a6ce6be7c72eab"}]}