)]}'
{"tasks/providers/setup_ovs_dpdk.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9520056ba71f868ed9b4d6713e93b5497bbca289","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    path: /var/lib/vhost_socket"},{"line_number":90,"context_line":"    state: directory"},{"line_number":91,"context_line":"    owner: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027libvirt-qemu\u0027, \u0027qemu\u0027) }}\""},{"line_number":92,"context_line":"    group: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027{{ vhost_socket_directory_group }}\u0027, \u0027hugetlbfs\u0027) }}\""},{"line_number":93,"context_line":"    mode: \"0755\""},{"line_number":94,"context_line":"  when:"},{"line_number":95,"context_line":"    - neutron_services[\u0027neutron-openvswitch-agent\u0027][\u0027group\u0027] in group_names"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_982350a7","line":92,"range":{"start_line":92,"start_character":15,"end_line":92,"end_character":70},"updated":"2020-11-16 14:32:47.000000000","message":"I don\u0027t think we need to take into consideration centos7 since we\u0027ve already dropped it\u0027s support. It will be needed for backport though. So we can merge it and do cleanup as a follow-up patch","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"b4157be184439a6b3e53bac669b88170a3a9576d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    path: /var/lib/vhost_socket"},{"line_number":90,"context_line":"    state: directory"},{"line_number":91,"context_line":"    owner: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027libvirt-qemu\u0027, \u0027qemu\u0027) }}\""},{"line_number":92,"context_line":"    group: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027{{ vhost_socket_directory_group }}\u0027, \u0027hugetlbfs\u0027) }}\""},{"line_number":93,"context_line":"    mode: \"0755\""},{"line_number":94,"context_line":"  when:"},{"line_number":95,"context_line":"    - neutron_services[\u0027neutron-openvswitch-agent\u0027][\u0027group\u0027] in group_names"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_e412a461","line":92,"range":{"start_line":92,"start_character":120,"end_line":92,"end_character":129},"updated":"2020-11-16 14:30:36.000000000","message":"Is this group created automatically?","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9520056ba71f868ed9b4d6713e93b5497bbca289","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    path: /var/lib/vhost_socket"},{"line_number":90,"context_line":"    state: directory"},{"line_number":91,"context_line":"    owner: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027libvirt-qemu\u0027, \u0027qemu\u0027) }}\""},{"line_number":92,"context_line":"    group: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027{{ vhost_socket_directory_group }}\u0027, \u0027hugetlbfs\u0027) }}\""},{"line_number":93,"context_line":"    mode: \"0755\""},{"line_number":94,"context_line":"  when:"},{"line_number":95,"context_line":"    - neutron_services[\u0027neutron-openvswitch-agent\u0027][\u0027group\u0027] in group_names"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_b8072c18","line":92,"range":{"start_line":92,"start_character":113,"end_line":92,"end_character":117},"updated":"2020-11-16 14:32:47.000000000","message":"ditto","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9520056ba71f868ed9b4d6713e93b5497bbca289","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    path: /var/lib/vhost_socket"},{"line_number":90,"context_line":"    state: directory"},{"line_number":91,"context_line":"    owner: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027libvirt-qemu\u0027, \u0027qemu\u0027) }}\""},{"line_number":92,"context_line":"    group: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027{{ vhost_socket_directory_group }}\u0027, \u0027hugetlbfs\u0027) }}\""},{"line_number":93,"context_line":"    mode: \"0755\""},{"line_number":94,"context_line":"  when:"},{"line_number":95,"context_line":"    - neutron_services[\u0027neutron-openvswitch-agent\u0027][\u0027group\u0027] in group_names"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_58041815","line":92,"range":{"start_line":92,"start_character":81,"end_line":92,"end_character":85},"updated":"2020-11-16 14:32:47.000000000","message":"not needed","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"f158189b1033f22d23d22add46e980d3f3e3128d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    path: /var/lib/vhost_socket"},{"line_number":90,"context_line":"    state: directory"},{"line_number":91,"context_line":"    owner: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027libvirt-qemu\u0027, \u0027qemu\u0027) }}\""},{"line_number":92,"context_line":"    group: \"{{ ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027) | ternary(\u0027{{ vhost_socket_directory_group }}\u0027, \u0027hugetlbfs\u0027) }}\""},{"line_number":93,"context_line":"    mode: \"0755\""},{"line_number":94,"context_line":"  when:"},{"line_number":95,"context_line":"    - neutron_services[\u0027neutron-openvswitch-agent\u0027][\u0027group\u0027] in group_names"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_b8260c67","line":92,"range":{"start_line":92,"start_character":120,"end_line":92,"end_character":129},"in_reply_to":"1f621f24_e412a461","updated":"2020-11-16 14:52:52.000000000","message":"Yes \"hugetlbfs\" group created by openvswitch and openvswitch use that group name to bind socket etc.","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"}],"vars/redhat.yml":[{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"b4157be184439a6b3e53bac669b88170a3a9576d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"neutron_ovs_distro_packages:"},{"line_number":17,"context_line":"  - openvswitch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"dpdk_service_name: openvswitch"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"neutron_ovs_service_name: openvswitch"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_647fb4aa","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":17},"updated":"2020-11-16 14:30:36.000000000","message":"is this referenced anywhere?","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"74ec8fdb61a9393f48cca57dfdc04fae5c42deb0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"neutron_ovs_distro_packages:"},{"line_number":17,"context_line":"  - openvswitch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"dpdk_service_name: openvswitch"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"neutron_ovs_service_name: openvswitch"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_3be316a6","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":17},"in_reply_to":"1f621f24_3b9dd665","updated":"2020-11-16 16:14:42.000000000","message":"Ubuntu use service name \"dpdk\" but CentOS use \"openvswitch\"","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0e31e08f7d519caf0512cc83b7c02f774f8fc2a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"neutron_ovs_distro_packages:"},{"line_number":17,"context_line":"  - openvswitch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"dpdk_service_name: openvswitch"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"neutron_ovs_service_name: openvswitch"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_d83dc8bb","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":17},"in_reply_to":"1f621f24_647fb4aa","updated":"2020-11-16 14:34:39.000000000","message":"yeah https://opendev.org/openstack/openstack-ansible-os_neutron/src/branch/master/tasks/providers/setup_ovs_dpdk.yml#L47","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"c02d27ff1011a4933063c9412a99f0b646198e7f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"neutron_ovs_distro_packages:"},{"line_number":17,"context_line":"  - openvswitch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"dpdk_service_name: openvswitch"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"neutron_ovs_service_name: openvswitch"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_3b9dd665","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":17},"in_reply_to":"1f621f24_d83dc8bb","updated":"2020-11-16 16:02:53.000000000","message":"IIRC, this is a specific service named \u0027dpdk\u0027 (in Ubuntu) that is a sort of.. helper service. Different from the openvswitch service/binary. I don\u0027t think there\u0027s an equiv on the CentOS side. But it may be worth verifying what this service does (again) to see if it\u0027s necessary","commit_id":"9169c1ff26dd910d01ddae464a3b03e00d71b612"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"31f0d9f614b02b4c707e14f3da9307a1226043cf","unresolved":true,"context_lines":[{"line_number":19,"context_line":"neutron_ovs_distro_packages:"},{"line_number":20,"context_line":"  - openvswitch"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"dpdk_service_name: openvswitch"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"neutron_ovs_service_name: openvswitch"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d26a20f9_c69e17bf","line":22,"updated":"2020-11-25 03:25:48.000000000","message":"Having recently deployed OVS+DPDK on Ubuntu, there is a service named \u0027dpdk\u0027 that is responsible for binding the NIC to the appropriate DPDK drive (i.e. vfio-pci, igb_uio, etc). I don\u0027t know if this service exists for CentOS, but we may want to rework this to be correct cross-platform.","commit_id":"d6b36635598cc0b0c4473836c744fa2e138107e8"}]}