)]}'
{"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2ab78f5faec522531230af54c16e3da123cb9a02","unresolved":true,"context_lines":[{"line_number":443,"context_line":"neutron_ovn_northd_service_name: ovn-northd"},{"line_number":444,"context_line":"neutron_ovn_controller_service_name: ovn-controller"},{"line_number":445,"context_line":"neutron_ovn_l3_scheduler: leastloaded"},{"line_number":446,"context_line":"neutron_ovn_nb_connection: \"tcp:{{ groups[\u0027neutron_ovn_northd\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:6641,tcp:\u0027) }}:6641\""},{"line_number":447,"context_line":"neutron_ovn_sb_connection: \"tcp:{{ groups[\u0027neutron_ovn_northd\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:6642,tcp:\u0027) }}:6642\""},{"line_number":448,"context_line":"neutron_ovsdb_manager: ptcp:6640:127.0.0.1"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"###"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c64f2b93_d81374d5","line":447,"range":{"start_line":446,"start_character":0,"end_line":447,"end_character":138},"updated":"2021-08-16 10:22:07.000000000","message":"I\u0027d rather just set there list of hosts, and joined them later on inside the template. That would be cleaner way if ppl would like to override things I guess?\n\nAlso worth renaming var to smth like neutron_ovn_nb_addresses and add neutron_ovn_nb_port","commit_id":"454866176f6444c60471ab2c34dc53203a7dbb95"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"607a3d710dd98b3a0d3c123148ed005964b10de3","unresolved":false,"context_lines":[{"line_number":443,"context_line":"neutron_ovn_northd_service_name: ovn-northd"},{"line_number":444,"context_line":"neutron_ovn_controller_service_name: ovn-controller"},{"line_number":445,"context_line":"neutron_ovn_l3_scheduler: leastloaded"},{"line_number":446,"context_line":"neutron_ovn_nb_connection: \"tcp:{{ groups[\u0027neutron_ovn_northd\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:6641,tcp:\u0027) }}:6641\""},{"line_number":447,"context_line":"neutron_ovn_sb_connection: \"tcp:{{ groups[\u0027neutron_ovn_northd\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:6642,tcp:\u0027) }}:6642\""},{"line_number":448,"context_line":"neutron_ovsdb_manager: ptcp:6640:127.0.0.1"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"###"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c7bacd55_836012b7","line":447,"range":{"start_line":446,"start_character":0,"end_line":447,"end_character":138},"in_reply_to":"8dbf6310_2697ae66","updated":"2021-08-17 08:30:56.000000000","message":"It would be super hard to change that later because of upgrades and need to keep compatability for several releases.\n\nAlso since we add new variables - would be great to write some release notes. Eventually, this can be done with follow up patch and cover all valuable changes regarding OVN that has been done recently.","commit_id":"454866176f6444c60471ab2c34dc53203a7dbb95"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"9c5b84221ccddc6357a4fc04960901374ea98f6c","unresolved":false,"context_lines":[{"line_number":443,"context_line":"neutron_ovn_northd_service_name: ovn-northd"},{"line_number":444,"context_line":"neutron_ovn_controller_service_name: ovn-controller"},{"line_number":445,"context_line":"neutron_ovn_l3_scheduler: leastloaded"},{"line_number":446,"context_line":"neutron_ovn_nb_connection: \"tcp:{{ groups[\u0027neutron_ovn_northd\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:6641,tcp:\u0027) }}:6641\""},{"line_number":447,"context_line":"neutron_ovn_sb_connection: \"tcp:{{ groups[\u0027neutron_ovn_northd\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:6642,tcp:\u0027) }}:6642\""},{"line_number":448,"context_line":"neutron_ovsdb_manager: ptcp:6640:127.0.0.1"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"###"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8dbf6310_2697ae66","line":447,"range":{"start_line":446,"start_character":0,"end_line":447,"end_character":138},"in_reply_to":"c64f2b93_d81374d5","updated":"2021-08-17 02:52:10.000000000","message":"We can go with this approach at present and later improve as more and more people deploy it and found issue. If people still can override using neutron_ovn_sb_connection: \"tcp:a.a.a.a:6642,tcp:b.b.b.b:6642,tcp:c.c.c.c:6642\" \n\nReson i used variable name neutron_ovn_nb_connection because real option name is \"ovn_nb_connection\" https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803990/6/templates/plugins/ml2/ml2_conf.ini.j2#51","commit_id":"454866176f6444c60471ab2c34dc53203a7dbb95"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4fdc3597ec30ed719821a1be4ceacd4a6a5c89eb","unresolved":false,"context_lines":[{"line_number":443,"context_line":"neutron_ovn_northd_service_name: ovn-northd"},{"line_number":444,"context_line":"neutron_ovn_controller_service_name: ovn-controller"},{"line_number":445,"context_line":"neutron_ovn_l3_scheduler: leastloaded"},{"line_number":446,"context_line":"neutron_ovn_nb_connection: \"tcp:{{ groups[\u0027neutron_ovn_northd\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:6641,tcp:\u0027) }}:6641\""},{"line_number":447,"context_line":"neutron_ovn_sb_connection: \"tcp:{{ groups[\u0027neutron_ovn_northd\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:6642,tcp:\u0027) }}:6642\""},{"line_number":448,"context_line":"neutron_ovsdb_manager: ptcp:6640:127.0.0.1"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"###"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b3d4e9ff_87f5ac81","line":447,"range":{"start_line":446,"start_character":0,"end_line":447,"end_character":138},"in_reply_to":"c7bacd55_836012b7","updated":"2021-08-20 14:31:55.000000000","message":"Thinking about this again, we can leave neutron_ovn_nb_connection to be more flexible, but then do like:\n\nneutron_ovn_nb_addresses: \"{{ groups[\u0027neutron_ovn_northd\u0027] }}\"\nneutron_ovn_nb_port: 6641\nneutron_ovn_nb_connection: \"tcp:{{ (neutron_ovn_nb_addresses | map(\u0027extract\u0027, hostvars, [\u0027ansible_host\u0027]) | join(\u0027:\u0027 ~ neutron_ovn_nb_port ~ \u0027,tcp:\u0027)) ~ \u0027:\u0027 ~ neutron_ovn_nb_port }}\"","commit_id":"454866176f6444c60471ab2c34dc53203a7dbb95"}]}