)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"211363721bc443757c0336773dd11cacedb05be1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2a71e7f_576e8c4e","updated":"2022-06-08 11:15:10.000000000","message":"can you please describe more what you\u0027re doing here in commit message for the history? Otherwise it looks good except really small nits. Thanks!","commit_id":"150bcce6192ee7235e70f517bc8b1fb1fb318752"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cae9a164f4112d4f13c0b8534d6d1169d397588b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ea8cf208_1aa6bff2","in_reply_to":"3527aac5_22709a79","updated":"2022-06-17 06:50:09.000000000","message":"Looking more into patch, I realized there\u0027s no reason to define neutron_vpnaas_custom_config as dictionary, as you never use key anywhere. Which means it can be simply a list.","commit_id":"150bcce6192ee7235e70f517bc8b1fb1fb318752"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5e574295a88a07307d2af59c66fa6f61e03668a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3527aac5_22709a79","in_reply_to":"38989d69_0ed93dbb","updated":"2022-06-16 13:47:29.000000000","message":"Can you update commit message or do you mind if I update it to reflect what you\u0027re saying?","commit_id":"150bcce6192ee7235e70f517bc8b1fb1fb318752"},{"author":{"_account_id":34933,"name":"shahab taee","display_name":"shahab taee","email":"shahab.taee67@gmail.com","username":"shahabtaee"},"change_message_id":"e0749ac4f46722e3d18f9ade340dfedcbd934060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"38989d69_0ed93dbb","in_reply_to":"f2a71e7f_576e8c4e","updated":"2022-06-11 06:41:31.000000000","message":"as we need to monitor vpn connection detailes, try to find a way to config vpnaas to log states and connections of vpn , then decided to make this solution globally for any costumization or configuration may need in vpnaas. at the end by adding these configuration file for using with any vpn drivers  (stronswan/openswan) we accomplished our goal.","commit_id":"150bcce6192ee7235e70f517bc8b1fb1fb318752"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"a95d80defc6f7572217adcc59c32c45a65c45a8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"300d6d80_17d80edf","updated":"2022-06-11 09:50:30.000000000","message":"The commit message needs sufficient detail that someone who is not completely familiar with the internal workings of neutron vpnaas can understand what this patch is achieving. It may be appropriate to explain why the current code is not good enough, the specifically what this patch does, and then the outcome that is obtained through this patch.\n\nCommits to openstack-ansible need to be supportable by the maintainers, there needs to be a sufficient audit trail and way to understand why particular changes have been made when we look back through the git history or use \u0027git blame\u0027.","commit_id":"adcff723e7aac20944a82bf098b9cfbbb4506a49"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"30a6faf5f4cee73259930f1b02c131302cb1058a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"afceec36_e1f8f97f","updated":"2022-06-20 10:31:44.000000000","message":"recheck post failure","commit_id":"26b768ea5bcbe90c10e6ff8f47a64e0559fbd34d"}],"releasenotes/notes/neutron-vpnaas-custom-config-ad991bb02b9ed655.yaml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"211363721bc443757c0336773dd11cacedb05be1","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        ipsec_secret_template:"},{"line_number":21,"context_line":"          source: \"/etc/openstack_deploy/{{ neutron_vpnaas_distro_packages }}/ipsec.secret.template\""},{"line_number":22,"context_line":"          destination: \"{{ neutron_conf_dir }}/ipsec.secret.template\""},{"line_number":23,"context_line":"          "},{"line_number":24,"context_line":"    We should be also define ``neutron_l3_agent_ini_overrides`` in \u0027user_variables.yml\u0027"},{"line_number":25,"context_line":"    to tel ``l3_agent`` use new config file."},{"line_number":26,"context_line":"    Example:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2ff7301f_5dd16e16","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":10},"updated":"2022-06-08 11:15:10.000000000","message":"trailing whitespace","commit_id":"150bcce6192ee7235e70f517bc8b1fb1fb318752"},{"author":{"_account_id":34933,"name":"shahab taee","display_name":"shahab taee","email":"shahab.taee67@gmail.com","username":"shahabtaee"},"change_message_id":"e0749ac4f46722e3d18f9ade340dfedcbd934060","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        ipsec_secret_template:"},{"line_number":21,"context_line":"          source: \"/etc/openstack_deploy/{{ neutron_vpnaas_distro_packages }}/ipsec.secret.template\""},{"line_number":22,"context_line":"          destination: \"{{ neutron_conf_dir }}/ipsec.secret.template\""},{"line_number":23,"context_line":"          "},{"line_number":24,"context_line":"    We should be also define ``neutron_l3_agent_ini_overrides`` in \u0027user_variables.yml\u0027"},{"line_number":25,"context_line":"    to tel ``l3_agent`` use new config file."},{"line_number":26,"context_line":"    Example:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c6ebb69a_50a355ed","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":10},"in_reply_to":"2ff7301f_5dd16e16","updated":"2022-06-11 06:41:31.000000000","message":"Done","commit_id":"150bcce6192ee7235e70f517bc8b1fb1fb318752"}],"tasks/neutron_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"211363721bc443757c0336773dd11cacedb05be1","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    mode: \"0640\""},{"line_number":199,"context_line":"  loop: \"{{ q(\u0027dict\u0027, neutron_vpnaas_custom_config) }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - neutron_vpnaas_custom_config | length\u003e0"},{"line_number":202,"context_line":"    - neutron_services[\u0027neutron-l3-agent\u0027][\u0027group\u0027] in group_name"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"- name: Stop haproxy service on debian derivatives with standalone network nodes"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b3a01cf5_17620012","line":201,"range":{"start_line":201,"start_character":43,"end_line":201,"end_character":44},"updated":"2022-06-08 11:15:10.000000000","message":"would be great to add whitespaces around for better readability","commit_id":"150bcce6192ee7235e70f517bc8b1fb1fb318752"},{"author":{"_account_id":34933,"name":"shahab taee","display_name":"shahab taee","email":"shahab.taee67@gmail.com","username":"shahabtaee"},"change_message_id":"e0749ac4f46722e3d18f9ade340dfedcbd934060","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    mode: \"0640\""},{"line_number":199,"context_line":"  loop: \"{{ q(\u0027dict\u0027, neutron_vpnaas_custom_config) }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - neutron_vpnaas_custom_config | length\u003e0"},{"line_number":202,"context_line":"    - neutron_services[\u0027neutron-l3-agent\u0027][\u0027group\u0027] in group_name"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"- name: Stop haproxy service on debian derivatives with standalone network nodes"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8efb7c16_74b16c8b","line":201,"range":{"start_line":201,"start_character":43,"end_line":201,"end_character":44},"in_reply_to":"b3a01cf5_17620012","updated":"2022-06-11 06:41:31.000000000","message":"Done","commit_id":"150bcce6192ee7235e70f517bc8b1fb1fb318752"}]}