)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f7d5be660f351c96102b68134795c879e31f47c5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow overriding computed maximums"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Without this patch, the maximum agents for dhcp/l3 is computed,"},{"line_number":10,"context_line":"not user provided."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is a problem, as it is solely computed based on the number"},{"line_number":13,"context_line":"of agents. If you have plenty of agents, for example in the case"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"66032d20_d65ecdcc","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":18},"updated":"2022-09-02 11:01:36.000000000","message":"That is wrong statement. User cen provide number of agents using variables `neutron_l3_agents_max` and `neutron_dhcp_agents_max` and documented here:\nhttps://opendev.org/openstack/openstack-ansible-os_neutron/src/branch/master/defaults/main.yml#L411-L412","commit_id":"c58f7eecfd06e0680ecfb4744dbb81580ac17488"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f7d5be660f351c96102b68134795c879e31f47c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45ea6e8a_47ef8f41","updated":"2022-09-02 11:01:36.000000000","message":"I don\u0027t think this patch is correct, since tries to implement already existing variables.","commit_id":"c58f7eecfd06e0680ecfb4744dbb81580ac17488"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ba58d7b1a3ae0f1196b73ec746746ee239cdfae3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6949e09f_cd72daca","updated":"2022-08-25 13:21:47.000000000","message":"I literally just added an optional var, and this fails in many jobs... ","commit_id":"c58f7eecfd06e0680ecfb4744dbb81580ac17488"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1e05b746499c7f7151204f2c075cd9caf09a037e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5653fe7_2ae4c863","updated":"2022-09-02 11:24:04.000000000","message":"This has been implemented with https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/833769 in Yoga","commit_id":"c58f7eecfd06e0680ecfb4744dbb81580ac17488"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"8dd524ca5044dfbef47d65baed24ae2ef3c1363f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b947afd7_8639432f","updated":"2022-08-25 13:22:03.000000000","message":"recheck -- sorry didn\u0027t get the chance to read at all the issues.","commit_id":"c58f7eecfd06e0680ecfb4744dbb81580ac17488"}],"templates/neutron.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f7d5be660f351c96102b68134795c879e31f47c5","unresolved":true,"context_lines":[{"line_number":56,"context_line":"# Agents"},{"line_number":57,"context_line":"agent_down_time \u003d {{ neutron_agent_down_time }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{% set num_l3_agent \u003d (neutron_l3_agents_max | int) if neutron_l3_agents_max is defined else groups[neutron_services[\u0027neutron-l3-agent\u0027][\u0027group\u0027]] | length %}"},{"line_number":60,"context_line":"{% if neutron_plugin_type.split(\u0027.\u0027)[0] \u003d\u003d \u0027ml2\u0027 and num_l3_agent \u003e\u003d 2 %}"},{"line_number":61,"context_line":"{% if neutron_services[\u0027neutron-linuxbridge-agent\u0027][\u0027service_en\u0027] | bool or neutron_services[\u0027neutron-openvswitch-agent\u0027][\u0027service_en\u0027] | bool %}"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c26bcf82_7b7e07de","line":59,"range":{"start_line":59,"start_character":23,"end_line":59,"end_character":44},"updated":"2022-09-02 11:01:36.000000000","message":"This is user-provided variable that is being used instead of computed one when defined.","commit_id":"c58f7eecfd06e0680ecfb4744dbb81580ac17488"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f7d5be660f351c96102b68134795c879e31f47c5","unresolved":true,"context_lines":[{"line_number":82,"context_line":"api_workers \u003d {{ neutron_api_workers | default(neutron_api_threads) }}"},{"line_number":83,"context_line":"rpc_workers \u003d {{ neutron_rpc_workers }}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% set num_dhcp_agent \u003d (neutron_dhcp_agents_max | int) if neutron_dhcp_agents_max is defined else groups[neutron_services[\u0027neutron-dhcp-agent\u0027][\u0027group\u0027]] | length %}"},{"line_number":86,"context_line":"{% set dhcp_agents_max \u003d num_dhcp_agent if num_dhcp_agent \u003e 2 else 2 %}"},{"line_number":87,"context_line":"# DHCP"},{"line_number":88,"context_line":"{% if neutron_plugin_type \u003d\u003d \u0027vmware.nsx\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"83c49f26_2642e217","line":85,"range":{"start_line":85,"start_character":25,"end_line":85,"end_character":48},"updated":"2022-09-02 11:01:36.000000000","message":"same here","commit_id":"c58f7eecfd06e0680ecfb4744dbb81580ac17488"}]}