)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"214f74f00037a4bae3d7f7c46b81c8d6a1bfadf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90950211_e3563de8","updated":"2022-09-05 07:29:35.000000000","message":"Can you kindly explain in commit message why it should be this way?","commit_id":"4341f97e872aa873379e70426de572f8b95e5827"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"76769b5d31e2500804790df48545f6d33c7591e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"630c29d2_71b42fbf","updated":"2022-09-05 08:49:15.000000000","message":"recheck centos rdo mirror issue","commit_id":"4341f97e872aa873379e70426de572f8b95e5827"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"d5baa484eb8c1071b1ee9ebbbe5f85ac6fa79caa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79b3ca7b_125ba367","updated":"2022-09-09 12:49:19.000000000","message":"LGTM. Validated on an Ubuntu MNAIO. ","commit_id":"805dee297890e07dd7c9c653ff98772d1f05fcde"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"8ce68f42efefe97780f56a4b45b9c94b129e36cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79a02598_67064c50","updated":"2022-09-19 14:20:00.000000000","message":"Looks good, we don\u0027t need service running and enable on control plane. ","commit_id":"805dee297890e07dd7c9c653ff98772d1f05fcde"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"733af7cf52e1168dcecc731ad3d2f80cd0fe2f47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4234ac02_2b5ae97f","updated":"2022-09-20 11:25:40.000000000","message":"I think, that for centos we need to add centos-release-nfv-openvswitch even for nothbridge, as ovn supposedly come from this repo.\nAnd we brake repo installation logic:\n\nhttps://opendev.org/openstack/openstack-ansible-os_neutron/src/commit/37b11c5b118504732da43ddbe0844fd112955f7f/tasks/neutron_pre_install.yml#L84\n","commit_id":"a0a5e2d5e5a2a31a6cd12903e15c4675e6e44364"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"04f9357c8b6a42e55ddcae93aeb7d06bb32ecc12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0c866a3_f6df2c32","in_reply_to":"2cbabb5e_3be69690","updated":"2022-10-27 22:18:03.000000000","message":"Done","commit_id":"a0a5e2d5e5a2a31a6cd12903e15c4675e6e44364"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"48c6749690da460add2db45a532b21a1ffb9a4db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2cbabb5e_3be69690","in_reply_to":"4234ac02_2b5ae97f","updated":"2022-10-06 09:11:52.000000000","message":"The most straight approach would be:\n\ndiff --git a/vars/main.yml b/vars/main.yml\nindex 2e2ef32..8eb8805 100644\n--- a/vars/main.yml\n+++ b/vars/main.yml\n@@ -20,7 +20,7 @@ _neutron_is_first_play_host: \"{{ (neutron_services[\u0027neutron-server\u0027][\u0027group\u0027] in\n ###\n neutron_needs_openvswitch: \u003e-\n   {{ (neutron_services[\u0027neutron-openvswitch-agent\u0027][\u0027group\u0027] in group_names and neutron_services[\u0027neutron-openvswitch-agent\u0027].service_en | bool)\n-  or (neutron_services[\u0027neutron-ovn-northd\u0027][\u0027group\u0027] in group_names and (neutron_plugin_type \u003d\u003d \u0027ml2.ovn\u0027) | bool)\n+  or (neutron_services[\u0027neutron-ovn-northd\u0027][\u0027group\u0027] in group_names and (neutron_plugin_type \u003d\u003d \u0027ml2.ovn\u0027) and (ansible_facts[\u0027pkg_mgr\u0027] \u003d\u003d \u0027dnf\u0027) | bool)\n   or (neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names and (neutron_plugin_type \u003d\u003d \u0027ml2.ovn\u0027) | bool)\n   or ((neutron_services[\u0027neutron-server\u0027][\u0027group\u0027] not in group_names) and neutron_plugin_type \u003d\u003d \u0027ml2.opendaylight\u0027) }}\n \nAnother one would be moving https://opendev.org/openstack/openstack-ansible-os_neutron/src/commit/37b11c5b118504732da43ddbe0844fd112955f7f/tasks/neutron_pre_install.yml#L76-L84 into appropriate `tasks/providers/*_config.yml`:\n* tasks/providers/opendaylight_config.yml\n* tasks/providers/ovn_config.yml\n* tasks/providers/ovs_config.yml\n\nAnd the last one could be something like this, effectively copying `neutron_needs_openvswitch` calculation (could be shorten a little bit, by reusing `neutron_needs_openvswitch` value with ORing `pkg_mgr` \u003d\u003d \u0027dnf\u0027 and checking node inclusion in `neutron_services[\u0027neutron-ovn-northd\u0027][\u0027group\u0027]`):\n\ndiff --git a/tasks/neutron_pre_install.yml b/tasks/neutron_pre_install.yml\nindex 6065b32..1c06aab 100644\n--- a/tasks/neutron_pre_install.yml\n+++ b/tasks/neutron_pre_install.yml\n@@ -80,8 +80,7 @@\n   retries: 5\n   delay: 2\n   when:\n-    - ansible_facts[\u0027pkg_mgr\u0027] \u003d\u003d \u0027dnf\u0027\n-    - neutron_needs_openvswitch | bool\n+    - neutron_needs_openvswitch_repos | bool\n\n - name: Create ovs tempfiles directory\n   block:\ndiff --git a/vars/main.yml b/vars/main.yml\nindex 50dc4e4..da91e61 100644\n--- a/vars/main.yml\n+++ b/vars/main.yml\n@@ -23,6 +23,13 @@ neutron_needs_openvswitch: \u003e-\n   or (neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names and (neutron_plugin_type \u003d\u003d \u0027ml2.ovn\u0027) | bool)\n   or ((neutron_services[\u0027neutron-server\u0027][\u0027group\u0027] not in group_names) and neutron_plugin_type \u003d\u003d \u0027ml2.opendaylight\u0027) }}\n\n+neutron_needs_openvswitch_repos: \u003e-\n+  {{ (ansible_facts[\u0027pkg_mgr\u0027] \u003d\u003d \u0027dnf\u0027) and\n+  ((neutron_services[\u0027neutron-openvswitch-agent\u0027][\u0027group\u0027] in group_names and neutron_services[\u0027neutron-openvswitch-agent\u0027].service_en | bool)\n+  or (neutron_services[\u0027neutron-ovn-northd\u0027][\u0027group\u0027] in group_names and (neutron_plugin_type \u003d\u003d \u0027ml2.ovn\u0027) | bool)\n+  or (neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names and (neutron_plugin_type \u003d\u003d \u0027ml2.ovn\u0027) | bool)\n+  or ((neutron_services[\u0027neutron-server\u0027][\u0027group\u0027] not in group_names) and neutron_plugin_type \u003d\u003d \u0027ml2.opendaylight\u0027)) }}\n+\n # Set the Calico Felix agent executable destination path\n calico_felix_bin: /usr/local/bin/calico-felix","commit_id":"a0a5e2d5e5a2a31a6cd12903e15c4675e6e44364"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c47b3d7814f484cc8e877870f391dbe38fe7aba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4281dd74_792da2d1","updated":"2022-10-28 07:27:52.000000000","message":"Ugh. Now we fail because northd and controller are exact same groups for aio scenario. So I think we should check more conditions then just if it\u0027s in northd... I will push patch to fix that","commit_id":"585c0aeb743ff1c16b5d637358428d6f1467262a"}],"tasks/providers/ovn_config.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"abeaac0f46906a01538e4f85f878089046202444","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Ensure Open vSwitch service is started and enabled"},{"line_number":44,"context_line":"  systemd:"},{"line_number":45,"context_line":"    name: \"{{ neutron_ovs_service_name }}\""},{"line_number":46,"context_line":"    state: started"},{"line_number":47,"context_line":"    enabled: yes"},{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Ensure ovn-northd service is started and enabled"},{"line_number":52,"context_line":"  systemd:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9e7023e7_b4596da5","line":49,"range":{"start_line":43,"start_character":0,"end_line":49,"end_character":72},"updated":"2022-10-18 11:33:33.000000000","message":"I\u0027m thinking maybe we can install ovs packages with current conditions, but here decide if it should be started/enabled or disabled/masked depending if it\u0027s nrothd or not? Should be quite straightforward ternary withing same task","commit_id":"a0a5e2d5e5a2a31a6cd12903e15c4675e6e44364"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"04f9357c8b6a42e55ddcae93aeb7d06bb32ecc12","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Ensure Open vSwitch service is started and enabled"},{"line_number":44,"context_line":"  systemd:"},{"line_number":45,"context_line":"    name: \"{{ neutron_ovs_service_name }}\""},{"line_number":46,"context_line":"    state: started"},{"line_number":47,"context_line":"    enabled: yes"},{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Ensure ovn-northd service is started and enabled"},{"line_number":52,"context_line":"  systemd:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f23fc1f0_3f9f5dc4","line":49,"range":{"start_line":43,"start_character":0,"end_line":49,"end_character":72},"in_reply_to":"9e7023e7_b4596da5","updated":"2022-10-27 22:18:03.000000000","message":"Done","commit_id":"a0a5e2d5e5a2a31a6cd12903e15c4675e6e44364"}]}