)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8f99aaefa5c3adfc560c33cd23ffb44029503f6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"26178356_e29ff7fe","updated":"2022-11-29 08:39:49.000000000","message":"But looks good to me overall. I\u0027m fine with switching to +2 if you confirm comments.","commit_id":"88d79ae94801a64e409db409b0bd69382134bdc0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7fdde66e94be3cbe3f3fc288e85f4d1c8d65f4e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3d66d0a0_6b4f1faf","updated":"2022-11-24 15:43:22.000000000","message":"recheck - retry limit has been solved now","commit_id":"88d79ae94801a64e409db409b0bd69382134bdc0"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"4252b18dbcaf40b4baff65955397655119a74cd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ddaabb6c_4f7e3ab6","updated":"2022-11-30 03:51:41.000000000","message":"recheck - strange failures in one job: oslo_config.cfg.ConfigFilesNotFoundError: Failed to find some config files: /etc/neutron/neutron.conf,/etc/neutron/plugins/ml2/ml2_conf.ini","commit_id":"c559ed7ca2900bf1157e6fd02853292aeaedef05"}],"defaults/main.yml":[{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"da51ef038358c6af0bfb30e23faddcfa776ff77e","unresolved":true,"context_lines":[{"line_number":508,"context_line":"    signed_by: \"{{ neutron_ovn_pki_intermediate_cert_name }}\""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# OVN destination files for SSL certificates"},{"line_number":511,"context_line":"neutron_ovn_ssl_cert: /etc/openvswitch/neutron_ovn.pem"},{"line_number":512,"context_line":"neutron_ovn_ssl_key: /etc/openvswitch/neutron_ovn.key"},{"line_number":513,"context_line":"neutron_ovn_ssl_ca_cert: /etc/openvswitch/neutron_ovn-ca.pem"},{"line_number":514,"context_line":"# Installation details for SSL certificates"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa2d4397_8b0f5f17","line":511,"range":{"start_line":511,"start_character":0,"end_line":511,"end_character":54},"updated":"2022-10-28 20:28:10.000000000","message":"probably need to put it somewhere else for neutron-server containers. like in /etc/neutron/ or something. and also override the user/group to allow neutron to use it.","commit_id":"4a3238080cfbfc4de24d05c48fa7014154cccd7a"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"6cf473b52849d08452b3beb106f81a240160ad19","unresolved":false,"context_lines":[{"line_number":508,"context_line":"    signed_by: \"{{ neutron_ovn_pki_intermediate_cert_name }}\""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# OVN destination files for SSL certificates"},{"line_number":511,"context_line":"neutron_ovn_ssl_cert: /etc/openvswitch/neutron_ovn.pem"},{"line_number":512,"context_line":"neutron_ovn_ssl_key: /etc/openvswitch/neutron_ovn.key"},{"line_number":513,"context_line":"neutron_ovn_ssl_ca_cert: /etc/openvswitch/neutron_ovn-ca.pem"},{"line_number":514,"context_line":"# Installation details for SSL certificates"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df3b9db8_03d801f9","line":511,"range":{"start_line":511,"start_character":0,"end_line":511,"end_character":54},"in_reply_to":"fa2d4397_8b0f5f17","updated":"2022-11-11 18:23:52.000000000","message":"Done","commit_id":"4a3238080cfbfc4de24d05c48fa7014154cccd7a"}],"tasks/main.yml":[{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"c81e9bbc79985a033213a9cc44982f043bc05810","unresolved":true,"context_lines":[{"line_number":137,"context_line":"    pki_install_certificates: \"{{ neutron_ovn_pki_install_certificates }}\""},{"line_number":138,"context_line":"  when:"},{"line_number":139,"context_line":"    - neutron_ovn_ssl"},{"line_number":140,"context_line":"    - \"\u0027network_all\u0027 in group_names\""},{"line_number":141,"context_line":"  tags:"},{"line_number":142,"context_line":"    - neutron_ovn-config"},{"line_number":143,"context_line":"    - pki"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"153f2e0e_a5f5cdb3","line":140,"updated":"2022-11-29 20:06:57.000000000","message":"This task doesn\u0027t appear to run on compute nodes, since they are not in the network group, so the certs/keys are missing.\n\nChanging this:\n\n\"\u0027network_all\u0027 in group_names\"\n\nto:\n\n(neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names) or (neutron_services[\u0027neutron-ovn-northd\u0027][\u0027group\u0027] in group_names)\n  \nseems to resolve that issue. Without the certs and keys, deployments fail as own-controller can\u0027t hit NB/SB DB. With the certs/keys in place, looks good so far.","commit_id":"88d79ae94801a64e409db409b0bd69382134bdc0"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"e1178b174a51420b6416a5306fe082f7953dbf20","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    pki_install_certificates: \"{{ neutron_ovn_pki_install_certificates }}\""},{"line_number":138,"context_line":"  when:"},{"line_number":139,"context_line":"    - neutron_ovn_ssl"},{"line_number":140,"context_line":"    - \"\u0027network_all\u0027 in group_names\""},{"line_number":141,"context_line":"  tags:"},{"line_number":142,"context_line":"    - neutron_ovn-config"},{"line_number":143,"context_line":"    - pki"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"6f30a0c3_e080c580","line":140,"in_reply_to":"153f2e0e_a5f5cdb3","updated":"2022-11-29 21:20:49.000000000","message":"Done","commit_id":"88d79ae94801a64e409db409b0bd69382134bdc0"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"750d55fffc6f9d7db5a506baf38fc8f856c77df0","unresolved":true,"context_lines":[{"line_number":137,"context_line":"    pki_install_certificates: \"{{ neutron_ovn_pki_install_certificates }}\""},{"line_number":138,"context_line":"  when:"},{"line_number":139,"context_line":"    - neutron_ovn_ssl"},{"line_number":140,"context_line":"    - (neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names) or (neutron_services[\u0027neutron-ovn-northd\u0027][\u0027group\u0027] in group_names) or (neutron_services[\u0027neutron-server\u0027][\u0027group\u0027] in group_names)"},{"line_number":141,"context_line":"  tags:"},{"line_number":142,"context_line":"    - neutron_ovn-config"},{"line_number":143,"context_line":"    - pki"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"4230b1d9_42272ab6","line":140,"range":{"start_line":140,"start_character":142,"end_line":140,"end_character":206},"updated":"2022-11-30 16:03:54.000000000","message":"Local testing confirms this is needed.","commit_id":"49f2c21ac274e16e04ae39ef1ff0e7f5152b12f9"}],"tasks/providers/ovn_cluster_setup.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1cb21e2fdd95e6ac700f67cc73998e0acf46125e","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    - not leader_node"},{"line_number":82,"context_line":"    - ovn_northd_opts.changed"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- name: set ssl for ovn-?b"},{"line_number":85,"context_line":"  command: \"{{ cmd }}\""},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - \"ovn-nbctl set-connection pssl:6641\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ba133031_52628125","line":84,"range":{"start_line":84,"start_character":24,"end_line":84,"end_character":26},"updated":"2022-11-29 08:39:00.000000000","message":"Is it intentional? As reads in output a bit weirdly, but not critical","commit_id":"88d79ae94801a64e409db409b0bd69382134bdc0"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"e1178b174a51420b6416a5306fe082f7953dbf20","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    - not leader_node"},{"line_number":82,"context_line":"    - ovn_northd_opts.changed"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- name: set ssl for ovn-?b"},{"line_number":85,"context_line":"  command: \"{{ cmd }}\""},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - \"ovn-nbctl set-connection pssl:6641\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"6ad2d7d8_c0e787ff","line":84,"range":{"start_line":84,"start_character":24,"end_line":84,"end_character":26},"in_reply_to":"ba133031_52628125","updated":"2022-11-29 21:20:49.000000000","message":"changed the name a bit","commit_id":"88d79ae94801a64e409db409b0bd69382134bdc0"}],"tasks/providers/ovn_config.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1cb21e2fdd95e6ac700f67cc73998e0acf46125e","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    - neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names"},{"line_number":50,"context_line":"    - neutron_ovn_ssl"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Ensure ovn-northd service is started and enabled"},{"line_number":53,"context_line":"  systemd:"},{"line_number":54,"context_line":"    name: \"{{ neutron_ovn_northd_service_name }}\""},{"line_number":55,"context_line":"    state: started"},{"line_number":56,"context_line":"    enabled: yes"},{"line_number":57,"context_line":"  when:"},{"line_number":58,"context_line":"    - neutron_services[\u0027neutron-ovn-northd\u0027][\u0027group\u0027] in group_names"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Ensure ovn-controller service is started and enabled"},{"line_number":61,"context_line":"  systemd:"},{"line_number":62,"context_line":"    name: \"{{ neutron_ovn_controller_service_name }}\""},{"line_number":63,"context_line":"    state: \"{{ (ovn_controller_config.changed) | ternary(\u0027restarted\u0027,\u0027started\u0027) }}\""},{"line_number":64,"context_line":"    enabled: yes"},{"line_number":65,"context_line":"  when:"},{"line_number":66,"context_line":"    - neutron_services[\u0027neutron-ovn-controller\u0027][\u0027group\u0027] in group_names"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- ansible.builtin.include_tasks: setup_ovs_ovn.yml"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"240adc70_5aa9d59f","line":67,"range":{"start_line":52,"start_character":0,"end_line":67,"end_character":0},"updated":"2022-11-29 08:39:00.000000000","message":"tbh I don\u0027t like both of these tasks. Maybe we should flush handlers instead? Not sure we can though as I can imagine some misbehaviour if we do so in other places. So hard to judge for me if it\u0027s best we can do or not.","commit_id":"88d79ae94801a64e409db409b0bd69382134bdc0"}]}