)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"0b4d695a6b79dd86e0c2f5c31df48ecc70ffb355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54b7883a_07eef1df","updated":"2023-07-08 12:48:30.000000000","message":"Just to confirm, is the \u0027neutron_ovn_ssl\u003dfalse\u0027 case still handled properly?","commit_id":"df393c21108deb13beb88cccce572b3335f98203"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4d35752bdf540e85c4d4232d83ffbd95c3863a36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb522d9a_b1b24241","updated":"2023-07-06 13:11:35.000000000","message":"recheck timeout","commit_id":"df393c21108deb13beb88cccce572b3335f98203"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"5de911416f81d7dfbc69bca6a1dd3e713999c2f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fedeae65_ac272b16","in_reply_to":"54b7883a_07eef1df","updated":"2023-07-11 14:44:08.000000000","message":"Yes, I\u0027ve verified this in AIO, with `neutron_ovn_ssl: False` sets up OVN like this:\n```\nroot@aio1-neutron-ovn-northd-container-f1886800:/# ovn-nbctl list conn\n_uuid               : a1dacf13-4953-40df-94d0-fe2353fa1e1a\nexternal_ids        : {}\ninactivity_probe    : 60000\nis_connected        : false\nmax_backoff         : []\nother_config        : {}\nstatus              : {}\ntarget              : \"ptcp:6641\"\nroot@aio1-neutron-ovn-northd-container-f1886800:/# ovn-sbctl list conn\n_uuid               : 470ead98-065b-474b-bdcf-436f30b892b0\nexternal_ids        : {}\ninactivity_probe    : 60000\nis_connected        : false\nmax_backoff         : []\nother_config        : {}\nread_only           : false\nrole                : \"\"\nstatus              : {}\ntarget              : \"ptcp:6642\"\n```\n```\n2297 ovsdb-server -vconsole:off -vfile:info --log-file\u003d/var/log/ovn/ovsdb-server-nb.log --remote\u003dpunix:/var/run/ovn/ovnnb_db.sock --pidfile\u003d/var/run/ovn/ovnnb_db.pid --unixctl\u003d/var/run/ovn/ovnnb_db.ctl --remote\u003ddb:OVN_Northbound,NB_Global,connections --private-key\u003ddb:OVN_Northbound,SSL,private_key --certificate\u003ddb:OVN_Northbound,SSL,certificate --ca-cert\u003ddb:OVN_Northbound,SSL,ca_cert --ssl-protocols\u003ddb:OVN_Northbound,SSL,ssl_protocols --ssl-ciphers\u003ddb:OVN_Northbound,SSL,ssl_ciphers /var/lib/ovn/ovnnb_db.db\n2321 ovsdb-server -vconsole:off -vfile:info --log-file\u003d/var/log/ovn/ovsdb-server-sb.log --remote\u003dpunix:/var/run/ovn/ovnsb_db.sock --pidfile\u003d/var/run/ovn/ovnsb_db.pid --unixctl\u003d/var/run/ovn/ovnsb_db.ctl --remote\u003ddb:OVN_Southbound,SB_Global,connections --private-key\u003ddb:OVN_Southbound,SSL,private_key --certificate\u003ddb:OVN_Southbound,SSL,certificate --ca-cert\u003ddb:OVN_Southbound,SSL,ca_cert --ssl-protocols\u003ddb:OVN_Southbound,SSL,ssl_protocols --ssl-ciphers\u003ddb:OVN_Southbound,SSL,ssl_ciphers /var/lib/ovn/ovnsb_db.db\n```\n```\nroot@aio1-neutron-ovn-northd-container-f1886800:/# ss -ntpl \u0027( sport \u003d :6641 )\u0027\nState                                 Recv-Q                                 Send-Q                                                                 Local Address:Port                                                                 Peer Address:Port                                Process\nLISTEN                                0                                      10                                                                           0.0.0.0:6641                                                                      0.0.0.0:*                                    users:((\"ovsdb-server\",pid\u003d2297,fd\u003d23))\nroot@aio1-neutron-ovn-northd-container-f1886800:/# ss -ntpl \u0027( sport \u003d :6642 )\u0027\nState                                 Recv-Q                                 Send-Q                                                                 Local Address:Port                                                                 Peer Address:Port                                Process\nLISTEN                                0                                      10                                                                           0.0.0.0:6642                                                                      0.0.0.0:*                                    users:((\"ovsdb-server\",pid\u003d2321,fd\u003d20))\n```\n\nDoes this answer your question?","commit_id":"df393c21108deb13beb88cccce572b3335f98203"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"920c522c70674ec3cc1de37db824b0bb89168aa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"290b9c64_f7a3d0a2","updated":"2023-07-17 14:20:52.000000000","message":"I guess it\u0027s worth backporting at least to antelope","commit_id":"d35c27bf718be54aa0c73eee8ecdd9cf0f8ef98f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4628292b849bcc54fd685fd3ea3e78b4e725c650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76dfca41_8f111ad3","updated":"2023-07-20 09:21:12.000000000","message":"recehck timeout","commit_id":"d35c27bf718be54aa0c73eee8ecdd9cf0f8ef98f"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"ef2a99d1f9d85c49d4d684978b70840c4a515bc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a2bf31c_57c98f90","updated":"2023-07-26 11:02:11.000000000","message":"recheck fixed pyargv value rendering in ansible-role-uwsgi role.","commit_id":"d35c27bf718be54aa0c73eee8ecdd9cf0f8ef98f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7841611cbbcf8fd9bcba29aa9f614eb631e5b43c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc8dd43e_f6adb148","updated":"2023-07-18 11:38:23.000000000","message":"recheck jammy failed on \"Perform a cell_v2 discover\"","commit_id":"d35c27bf718be54aa0c73eee8ecdd9cf0f8ef98f"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"04a1f891c5b711796523a35658d1371a39ed6ef8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7327ba5b_c3366e34","updated":"2023-07-25 10:18:57.000000000","message":"recheck timeout","commit_id":"d35c27bf718be54aa0c73eee8ecdd9cf0f8ef98f"}],"tasks/providers/ovn_cluster_setup.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7666e3aa2d9be707d1f420696c428ea52c20291e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"- name: Configure connection settings for ovn-nb and ovn-sb"},{"line_number":85,"context_line":"  command: \"{{ cmd }}\""},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - \"ovn-nbctl --inactivity-probe\u003d{{ neutron_ovn_nb_inactivity_probe }} set-connection p{{ ovn_proto }}:6641\""},{"line_number":88,"context_line":"    - \"ovn-sbctl --inactivity-probe\u003d{{ neutron_ovn_sb_inactivity_probe }} set-connection p{{ ovn_proto }}:6642\""},{"line_number":89,"context_line":"  when:"},{"line_number":90,"context_line":"    - \"inventory_hostname \u003d\u003d neutron_ovn_primary_cluster_node\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fd27fe5d_d13e997c","line":87,"range":{"start_line":87,"start_character":89,"end_line":87,"end_character":110},"updated":"2023-07-06 13:19:58.000000000","message":"that is really good catch","commit_id":"df393c21108deb13beb88cccce572b3335f98203"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"5de911416f81d7dfbc69bca6a1dd3e713999c2f2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"- name: Configure connection settings for ovn-nb and ovn-sb"},{"line_number":85,"context_line":"  command: \"{{ cmd }}\""},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - \"ovn-nbctl --inactivity-probe\u003d{{ neutron_ovn_nb_inactivity_probe }} set-connection p{{ ovn_proto }}:6641\""},{"line_number":88,"context_line":"    - \"ovn-sbctl --inactivity-probe\u003d{{ neutron_ovn_sb_inactivity_probe }} set-connection p{{ ovn_proto }}:6642\""},{"line_number":89,"context_line":"  when:"},{"line_number":90,"context_line":"    - \"inventory_hostname \u003d\u003d neutron_ovn_primary_cluster_node\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dbfe160e_eb9f913c","line":87,"range":{"start_line":87,"start_character":89,"end_line":87,"end_character":110},"in_reply_to":"fd27fe5d_d13e997c","updated":"2023-07-11 14:44:08.000000000","message":"Nah, it was already properly handled with:\n```\nwhen:\n - neutron_ovn_ssl\n```","commit_id":"df393c21108deb13beb88cccce572b3335f98203"}],"templates/ovn-northd-opts.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f64bdcd711f0d0ac74409372f46ee43f1c23d364","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# OVN cluster parameters"},{"line_number":4,"context_line":"{{ neutron_ovn_northd_opts }}\u003d\" \\"},{"line_number":5,"context_line":"  --db-nb-create-insecure-remote\u003d{{ (neutron_ovn_ssl) | ternary(\u0027no\u0027,\u0027yes\u0027) }} \\"},{"line_number":6,"context_line":"  --db-sb-create-insecure-remote\u003d{{ (neutron_ovn_ssl) | ternary(\u0027no\u0027,\u0027yes\u0027) }} \\"},{"line_number":7,"context_line":"  --db-nb-addr\u003d{{ ansible_host }} \\"},{"line_number":8,"context_line":"  --db-sb-addr\u003d{{ ansible_host }} \\"},{"line_number":9,"context_line":"  --db-nb-cluster-local-addr\u003d{{ ansible_host }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6e2c807c_a9d9bd20","side":"PARENT","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":80},"updated":"2023-06-28 15:01:13.000000000","message":"not sure why this is dropped? How it\u0027s related to the commit topic?","commit_id":"d0c37ede9fde4a25724fbe6ec4e57426bfe7416e"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"ed74edfdd49e2952924a314b9233f1f2e18a1b05","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# OVN cluster parameters"},{"line_number":4,"context_line":"{{ neutron_ovn_northd_opts }}\u003d\" \\"},{"line_number":5,"context_line":"  --db-nb-create-insecure-remote\u003d{{ (neutron_ovn_ssl) | ternary(\u0027no\u0027,\u0027yes\u0027) }} \\"},{"line_number":6,"context_line":"  --db-sb-create-insecure-remote\u003d{{ (neutron_ovn_ssl) | ternary(\u0027no\u0027,\u0027yes\u0027) }} \\"},{"line_number":7,"context_line":"  --db-nb-addr\u003d{{ ansible_host }} \\"},{"line_number":8,"context_line":"  --db-sb-addr\u003d{{ ansible_host }} \\"},{"line_number":9,"context_line":"  --db-nb-cluster-local-addr\u003d{{ ansible_host }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"38085300_a0f6220b","side":"PARENT","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":80},"in_reply_to":"36067e6f_1a4fba8d","updated":"2023-07-12 10:58:20.000000000","message":"Done. One thing I forgot to mention: this change would only affect new installations.","commit_id":"d0c37ede9fde4a25724fbe6ec4e57426bfe7416e"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"9bb88a96249ee8ba343540e2a57813d8713e981b","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# OVN cluster parameters"},{"line_number":4,"context_line":"{{ neutron_ovn_northd_opts }}\u003d\" \\"},{"line_number":5,"context_line":"  --db-nb-create-insecure-remote\u003d{{ (neutron_ovn_ssl) | ternary(\u0027no\u0027,\u0027yes\u0027) }} \\"},{"line_number":6,"context_line":"  --db-sb-create-insecure-remote\u003d{{ (neutron_ovn_ssl) | ternary(\u0027no\u0027,\u0027yes\u0027) }} \\"},{"line_number":7,"context_line":"  --db-nb-addr\u003d{{ ansible_host }} \\"},{"line_number":8,"context_line":"  --db-sb-addr\u003d{{ ansible_host }} \\"},{"line_number":9,"context_line":"  --db-nb-cluster-local-addr\u003d{{ ansible_host }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6e40a293_a18c7eb6","side":"PARENT","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":80},"in_reply_to":"6e2c807c_a9d9bd20","updated":"2023-06-29 12:56:10.000000000","message":"When `--db-nb-create-insecure-remote` (or the same option for SB) is set to `yes`, `ovn-ctl` starts ovsdb-server with `--remote` option set to `ptcp:6641:\u003cIP\u003e`. But, at the same time, it adds `--remote\u003ddb:OVN_Northbound,NB_Global,connections`, which is set by `--db-nb-use-remote-in-db` option (or `DB_NB_USE_REMOTE_IN_DB` variable), which default is `yes`. \n\nWhen `--db-nb-create-insecure-remote` is set to `no`, `ovn-ctl` doesn\u0027t add `--remote ptcp:6641:\u003cIP\u003e`.\n\nIn a freshly created OVN database, `Connection` table is empty, but we populate it with `ovn-nbctl set-connection pssl:6641`, which says that (in this example) NB DB ovsdb-server should listen on 0.0.0.0:6641, which would lead to `Address already in use` errors IF `neutron_ovn_ssl` is False and subsequently `--db-nb-create-insecure-remote` is `no`. \n\nIf all of this sounds like inconsistent behaviour to you -- it totally is, there is even a bug about it [1] O_o.\n\nFrom what I can tell from the ML, specifically this part [2], there is no other way to set `inactivity-probe` other than using `Connection` table.\n\nWith [3] and `neutron_ovn_ssl` set to True OVN SB and NB databases are listening on 0.0.0.0 now.\n\n[1] https://github.com/ovn-org/ovn/issues/83\n[2] https://www.mail-archive.com/ovs-discuss@openvswitch.org/msg07476.html\n[3] https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/862403","commit_id":"d0c37ede9fde4a25724fbe6ec4e57426bfe7416e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7666e3aa2d9be707d1f420696c428ea52c20291e","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# OVN cluster parameters"},{"line_number":4,"context_line":"{{ neutron_ovn_northd_opts }}\u003d\" \\"},{"line_number":5,"context_line":"  --db-nb-create-insecure-remote\u003d{{ (neutron_ovn_ssl) | ternary(\u0027no\u0027,\u0027yes\u0027) }} \\"},{"line_number":6,"context_line":"  --db-sb-create-insecure-remote\u003d{{ (neutron_ovn_ssl) | ternary(\u0027no\u0027,\u0027yes\u0027) }} \\"},{"line_number":7,"context_line":"  --db-nb-addr\u003d{{ ansible_host }} \\"},{"line_number":8,"context_line":"  --db-sb-addr\u003d{{ ansible_host }} \\"},{"line_number":9,"context_line":"  --db-nb-cluster-local-addr\u003d{{ ansible_host }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"36067e6f_1a4fba8d","side":"PARENT","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":80},"in_reply_to":"6e40a293_a18c7eb6","updated":"2023-07-06 13:19:58.000000000","message":"It\u0027s sounds quite /o\\ and patch makes way more sense now overall.\n\nCan you kindly move some part of this text to the commit message so that it was more clear what this patch does for the history?","commit_id":"d0c37ede9fde4a25724fbe6ec4e57426bfe7416e"}]}