)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0edabae9d6b038342c1e8c4ed9a7a182b14f49b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d966703_d9cbaa22","updated":"2024-06-11 16:16:48.000000000","message":"Hey!\n\nI think this patch is probably not needed, as you should be able to have support of these features for years.\n\nWe usually encourage to use config overrides for such cases. So to get this functionality, it should be enough to do:\n\n```\nneutron_l3_agent_ini_overrides:\n  DEFAULT:\n    ovs_use_veth: True\n    extensions:\n      - fip_qos\n      - gateway_ip_qos\n```\n\nAlternative valid patch would be to have a variable in defaults to nicely extend `l3_agent_plugins` list","commit_id":"fd9068d070df04992d18328b714127b1a06f0d30"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"19c88a1d9789b3a131070f17a5247186638e49dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"112dde8e_9ba90cc3","updated":"2024-07-23 17:53:21.000000000","message":"I went on and proposed a patch that I think makes sense and will allow to keep dynamically generated list of extensions while allow users to extend it whenever needed:\nhttps://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/924769\n\nCan you check if it works for you?\n\nThen, this patch needs to be transformed just to alter l3_agent in a following way:\n```\n{% if \u0027gateway_ip_qos\u0027 in neutron_l3_agent_extensions %}\novs_use_veth \u003d True\n{% endif %}\n```","commit_id":"fd9068d070df04992d18328b714127b1a06f0d30"},{"author":{"_account_id":37065,"name":"Mohammadreza Barkhordari","display_name":"Mreza Barkhordari","email":"mrz.barkhordari@gmail.com","username":"mreza-barkhordari"},"change_message_id":"fdb03afdc6c38a881fa58e93f155182e22db2046","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"249824cc_ea4a2ba6","updated":"2024-06-12 13:51:13.000000000","message":"accourding to l3_agent.ini.j2 file: vpnaas, port_forwarding,fwaas_v2 will add dynamically, but with using this override , dynamic nature of this list would be affected.\nthis way we can prevent manual change of override and also have dynamic nature of extensions list (l3_agent_plugins)","commit_id":"fd9068d070df04992d18328b714127b1a06f0d30"},{"author":{"_account_id":37065,"name":"Mohammadreza Barkhordari","display_name":"Mreza Barkhordari","email":"mrz.barkhordari@gmail.com","username":"mreza-barkhordari"},"change_message_id":"8a21434b9d48a7dfa07cceceb4a0d1677e04c2f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d0cfd525_260e2131","in_reply_to":"112dde8e_9ba90cc3","updated":"2024-08-19 05:39:28.000000000","message":"It seems working with this patch but as you told it is required to set some other options for some extions like \"gateway ip qos\" which it needs the \"ovs_use_veth \u003d True\" to be included in l3_agent.ini.j2","commit_id":"fd9068d070df04992d18328b714127b1a06f0d30"},{"author":{"_account_id":37065,"name":"Mohammadreza Barkhordari","display_name":"Mreza Barkhordari","email":"mrz.barkhordari@gmail.com","username":"mreza-barkhordari"},"change_message_id":"7033c8ece488e16d4885ea0bc888243229f52eb7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bbdd9f1a_5e105186","in_reply_to":"249824cc_ea4a2ba6","updated":"2024-07-20 07:16:02.000000000","message":"Done","commit_id":"fd9068d070df04992d18328b714127b1a06f0d30"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"490a177732dcd99b3fa14945e8de3b23feefa7dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5351fa0_f25ee369","in_reply_to":"2d966703_d9cbaa22","updated":"2024-06-11 16:18:05.000000000","message":"Sorry, was slightly wrong. that\u0027s the valid paste:\n\n```\nneutron_l3_agent_ini_overrides:\n  DEFAULT:\n    ovs_use_veth: True\n    extensions: fip_qos,gateway_ip_qos\n```","commit_id":"fd9068d070df04992d18328b714127b1a06f0d30"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4f7a94707d5aab40b6c7c3b168c06dee3078acb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"473d0219_4edae1e5","in_reply_to":"a5351fa0_f25ee369","updated":"2024-06-11 16:19:07.000000000","message":"Ugh...... I should take time before posting things 😄\n\n```\nneutron_l3_agent_ini_overrides:\n  DEFAULT:\n    ovs_use_veth: True\n  AGENT:\n    extensions: fip_qos,gateway_ip_qos\n```","commit_id":"fd9068d070df04992d18328b714127b1a06f0d30"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5fd0ec18c333ebf44eb12bc31d2d8e5341afbe63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"158c46c1_d813f4b4","in_reply_to":"d0cfd525_260e2131","updated":"2024-11-26 17:30:26.000000000","message":"Frankly I was expecting this patch to be updated, but as this didn\u0027t happen, I\u0027ve proposed a new one:\nhttps://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/936288\n\nYou still can use overrides to add required setting until it\u0027s merged, ie:\n```\nneutron_l3_agent_ini_overrides:\n  DEFAULT:\n    ovs_use_veth: True\n```","commit_id":"fd9068d070df04992d18328b714127b1a06f0d30"}]}