)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"01e06b587163df52d37e23c6a9962784ea6aed55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"caf63fcb_04a279a5","updated":"2024-10-14 19:08:20.000000000","message":"we need to backport that to 2023.1","commit_id":"96fb295bbc5c77c8ea139f523d1cc4e8b506f165"}],"handlers/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"25d9c3c802aa1a2ae37629161004ee3ab2e49d77","unresolved":true,"context_lines":[{"line_number":102,"context_line":"- name: Start services"},{"line_number":103,"context_line":"  service:"},{"line_number":104,"context_line":"    name: \"{{ item.service_name }}\""},{"line_number":105,"context_line":"    enabled: \"{{ item.enabled | default(True) }}\""},{"line_number":106,"context_line":"    state: \"{{ item.state | default(\u0027started\u0027) }}\""},{"line_number":107,"context_line":"    daemon_reload: yes"},{"line_number":108,"context_line":"  with_items: \"{{ filtered_neutron_services }}\""},{"line_number":109,"context_line":"  register: _start"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4e91148c_d97dfee9","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":50},"updated":"2024-10-15 08:23:11.000000000","message":"I actually thinking, if we should drop `enabled` here and rely on systemd_service to do the thing\n\nAnd then instead of state - just run this handler conditionally.","commit_id":"96fb295bbc5c77c8ea139f523d1cc4e8b506f165"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"c1b1c4f344505687a576938a78059b67d3a25f68","unresolved":true,"context_lines":[{"line_number":102,"context_line":"- name: Start services"},{"line_number":103,"context_line":"  service:"},{"line_number":104,"context_line":"    name: \"{{ item.service_name }}\""},{"line_number":105,"context_line":"    enabled: \"{{ item.enabled | default(True) }}\""},{"line_number":106,"context_line":"    state: \"{{ item.state | default(\u0027started\u0027) }}\""},{"line_number":107,"context_line":"    daemon_reload: yes"},{"line_number":108,"context_line":"  with_items: \"{{ filtered_neutron_services }}\""},{"line_number":109,"context_line":"  register: _start"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"46115c78_2eb3e269","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":50},"in_reply_to":"4e91148c_d97dfee9","updated":"2024-10-15 09:23:43.000000000","message":"If we have similar setting of \u0027enabled\u0027 in the other roles (which I think we do), then perhaps any changes to move that our of the handler should be a follow up across all roles instead?","commit_id":"96fb295bbc5c77c8ea139f523d1cc4e8b506f165"}]}
