)]}'
{"templates/nova.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"793349f64af10a2cba081aa9bf63ef01f49b9d7e","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# Glance"},{"line_number":157,"context_line":"[glance]"},{"line_number":158,"context_line":"{% if glance_api_servers is defined %}"},{"line_number":159,"context_line":"api_servers \u003d {{ glance_api_servers }}"},{"line_number":160,"context_line":"{% else %}"},{"line_number":161,"context_line":"host \u003d {{ glance_host }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5aef4532_e69cd45f","side":"PARENT","line":158,"updated":"2016-03-11 06:57:01.000000000","message":"I think this case statement should remain as there are several cases where this role might be deployed without having this option set. In the case where the glance-api servers variable is unset the role would fail to run. Maybe we need to change the option to use a more nova_ specific variable which we can set a default for?","commit_id":"3cac45ee6c372f7b65ee8a3cc483fb5153b87aae"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8b201c44bf81c921c6c3f39014c178800a9b8d31","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# Glance"},{"line_number":157,"context_line":"[glance]"},{"line_number":158,"context_line":"{% if glance_api_servers is defined %}"},{"line_number":159,"context_line":"api_servers \u003d {{ glance_api_servers }}"},{"line_number":160,"context_line":"{% else %}"},{"line_number":161,"context_line":"host \u003d {{ glance_host }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1af94dfe_17023a0b","side":"PARENT","line":158,"in_reply_to":"1af94dfe_17eebab3","updated":"2016-03-17 17:02:56.000000000","message":"while a deployer can add anything they like, the nova.conf template should be able to pick up on things it needs based on its usage which is why I think this conditional should remain.","commit_id":"3cac45ee6c372f7b65ee8a3cc483fb5153b87aae"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2402f694d4e2638b6130d160e7a02072845038d3","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# Glance"},{"line_number":157,"context_line":"[glance]"},{"line_number":158,"context_line":"{% if glance_api_servers is defined %}"},{"line_number":159,"context_line":"api_servers \u003d {{ glance_api_servers }}"},{"line_number":160,"context_line":"{% else %}"},{"line_number":161,"context_line":"host \u003d {{ glance_host }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1af94dfe_17eebab3","side":"PARENT","line":158,"in_reply_to":"3afc51ec_78d16ccd","updated":"2016-03-17 16:57:03.000000000","message":"Do we really need to care? With config overrides a deployer is able to add anything they like!","commit_id":"3cac45ee6c372f7b65ee8a3cc483fb5153b87aae"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"11fcb5eacb8f78c98ee2973a945a73f3574cc6ff","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# Glance"},{"line_number":157,"context_line":"[glance]"},{"line_number":158,"context_line":"{% if glance_api_servers is defined %}"},{"line_number":159,"context_line":"api_servers \u003d {{ glance_api_servers }}"},{"line_number":160,"context_line":"{% else %}"},{"line_number":161,"context_line":"host \u003d {{ glance_host }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3afc51ec_78d16ccd","side":"PARENT","line":158,"in_reply_to":"5aef4532_e69cd45f","updated":"2016-03-11 18:41:58.000000000","message":"Good point.\n\nMaybe instead of using the host / port pair we can provide a default equivalent to something like {{ internal_lb_vip_address + \u0027:\u0027 + glance_service_port }} to preserve the current behavior without relying on deprecated nova config options?","commit_id":"3cac45ee6c372f7b65ee8a3cc483fb5153b87aae"}]}
