)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"29348897c74617783fa7b6e6e1675096a5a537f2","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"nova_network_services:"},{"line_number":215,"context_line":"  linuxbridge:"},{"line_number":216,"context_line":"    firewall_driver: nova.virt.firewall.NoopFirewallDriver"},{"line_number":217,"context_line":"    use_forwarded_for: False"},{"line_number":218,"context_line":"    service_metadata_proxy: True"},{"line_number":219,"context_line":"  nuage:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_2a5cc1ec","line":216,"range":{"start_line":216,"start_character":4,"end_line":216,"end_character":58},"updated":"2016-04-02 11:25:44.000000000","message":"As this is the same for both, it seems unnecessary to include this setting?","commit_id":"4d5f4052307bbd4dadacaa1483e652f0250aa46f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"29348897c74617783fa7b6e6e1675096a5a537f2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"  linuxbridge:"},{"line_number":216,"context_line":"    firewall_driver: nova.virt.firewall.NoopFirewallDriver"},{"line_number":217,"context_line":"    use_forwarded_for: False"},{"line_number":218,"context_line":"    service_metadata_proxy: True"},{"line_number":219,"context_line":"  nuage:"},{"line_number":220,"context_line":"    firewall_driver:  nova.virt.firewall.NoopFirewallDriver"},{"line_number":221,"context_line":"    use_forwarded_for: True"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_ca6b8584","line":218,"range":{"start_line":218,"start_character":4,"end_line":218,"end_character":32},"updated":"2016-04-02 11:25:44.000000000","message":"As this is the same for both, it seems unnecessary to include this setting?","commit_id":"4d5f4052307bbd4dadacaa1483e652f0250aa46f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"75d781b3e0fecd9e13c0df5e7a84fe997c6bb13f","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"nova_network_services:"},{"line_number":250,"context_line":"  linuxbridge:"},{"line_number":251,"context_line":"    use_forwarded_for: False"},{"line_number":252,"context_line":"  nuage:"},{"line_number":253,"context_line":"    use_forwarded_for: True"},{"line_number":254,"context_line":"    ovs_bridge: alubr0"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_bb210ffe","line":251,"range":{"start_line":251,"start_character":4,"end_line":251,"end_character":21},"updated":"2016-04-18 09:02:33.000000000","message":"See my other comment.","commit_id":"9d6a2122707708b4bdad41ebf176b83e57540cbd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"75d781b3e0fecd9e13c0df5e7a84fe997c6bb13f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"  linuxbridge:"},{"line_number":251,"context_line":"    use_forwarded_for: False"},{"line_number":252,"context_line":"  nuage:"},{"line_number":253,"context_line":"    use_forwarded_for: True"},{"line_number":254,"context_line":"    ovs_bridge: alubr0"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# Nova quota"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_db7ccbed","line":253,"range":{"start_line":253,"start_character":4,"end_line":253,"end_character":21},"updated":"2016-04-18 09:02:33.000000000","message":"See my other comment","commit_id":"9d6a2122707708b4bdad41ebf176b83e57540cbd"}],"tasks/nova_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c35277fd110f0399d8c3c9c498318a4617cce443","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Setup Nuage nova config"},{"line_number":67,"context_line":"  include: nuage_nova_config.yml"},{"line_number":68,"context_line":"  when: neutron_plugin_type \u003d\u003d \u0027nuage\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Get nova command path"},{"line_number":71,"context_line":"  command: which nova"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_ef2f0286","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":27},"updated":"2016-03-30 17:05:05.000000000","message":"This var is not known to this role, so this should also evaluate whether this var exists.","commit_id":"573ff1aba64f3141e71e346289a0d6bf5a605301"},{"author":{"_account_id":20090,"name":"Rohan Parulekar","email":"2k.rohan@gmail.com","username":"rparulek"},"change_message_id":"66b6a0d2ccc6195c62a4e0c3cca11fc67977bbd6","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Setup Nuage nova config"},{"line_number":67,"context_line":"  include: nuage_nova_config.yml"},{"line_number":68,"context_line":"  when: neutron_plugin_type \u003d\u003d \u0027nuage\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Get nova command path"},{"line_number":71,"context_line":"  command: which nova"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_091ce7bf","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":27},"in_reply_to":"ba0121b8_ef2f0286","updated":"2016-03-30 22:29:38.000000000","message":"I have a question on this comment; I am re-defining/overriding \"neutron_plugin_type \u003d\u003d nuage\" in my user_nuage_neutron.yml user variable file to override the default \"ml2\" value. I think the variable overriden or re-defined like this in user variables file should be accessible to nova right? When I ran this playbook using AIO; it did not error out and populated the correct values in /etc/nova/nova.conf as expected.","commit_id":"573ff1aba64f3141e71e346289a0d6bf5a605301"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a6247370a2630e057c6391fc9fb29f5a42dfb8ea","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Setup Nuage nova config"},{"line_number":67,"context_line":"  include: nuage_nova_config.yml"},{"line_number":68,"context_line":"  when: neutron_plugin_type \u003d\u003d \u0027nuage\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Get nova command path"},{"line_number":71,"context_line":"  command: which nova"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_f2a88579","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":27},"in_reply_to":"ba0121b8_ef2f0286","updated":"2016-03-30 17:34:26.000000000","message":"ie\n\n  when:\n    - neutron_plugin_type is defined\n    - neutron_plugin_type \u003d\u003d \u0027nuage\u0027","commit_id":"573ff1aba64f3141e71e346289a0d6bf5a605301"}],"tasks/nuage_nova_config.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c35277fd110f0399d8c3c9c498318a4617cce443","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba0121b8_8fc806aa","updated":"2016-03-30 17:05:05.000000000","message":"These changes will cause the nova.conf file to be rewritten on every single playbook execution. These should rather be applied as conditionals in the template, or simply as config overrides in documentation. Also, there is work underway to make OVS work which will conflict with this so it\u0027d be better to have this dove-tail with https://review.openstack.org/298765 and the follow on work that will come.","commit_id":"573ff1aba64f3141e71e346289a0d6bf5a605301"}],"templates/nova.conf.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"129cfd8763e7efd56c22dfee2a9de2abc780bf0a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"libvirt_vif_driver \u003d  {{ nuage_nova_libvirt_vif_driver }}"},{"line_number":95,"context_line":"use_forwarded_for \u003d {{ nuage_nova_use_forwarded_for }}"},{"line_number":96,"context_line":"metadata_listen_port \u003d {{ nuage_nova_metadata_port }}"},{"line_number":97,"context_line":"{% else %}"},{"line_number":98,"context_line":"firewall_driver \u003d {{ nova_firewall_driver }}"},{"line_number":99,"context_line":"{% endif %}"},{"line_number":100,"context_line":"my_ip \u003d {{ nova_management_address }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba0121b8_53795ac7","line":97,"updated":"2016-03-31 08:53:31.000000000","message":"It seems we have had a misunderstanding here.\n\nMy suggestion was that \u0027nova_network_type\u0027 be used as a key for other settings. So in a way similar to neutron_services in the os_neutron role there can be a dict called something like \u0027nova_network_services\u0027 with each nova_network_type as a key. Each key then contains values for firewall_driver, libvirt_vif_driver and whatever other drivers need to be set for it. Then these values are simply something like {{ nova_network_services[nova_network_type][firewall_driver] }}.\n\nDoes that make sense?","commit_id":"2ef3d97d24640f4c3b6008100d90d7e621ad8e4a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"75d781b3e0fecd9e13c0df5e7a84fe997c6bb13f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"force_dhcp_release \u003d True"},{"line_number":94,"context_line":"dhcpbridge_flagfile \u003d /etc/nova/nova.conf"},{"line_number":95,"context_line":"firewall_driver \u003d {{ nova_firewall_driver }}"},{"line_number":96,"context_line":"use_forwarded_for \u003d {{ nova_network_services[nova_network_type][\u0027use_forwarded_for\u0027] | bool }}"},{"line_number":97,"context_line":"my_ip \u003d {{ nova_management_address }}"},{"line_number":98,"context_line":"default_floating_pool \u003d public"},{"line_number":99,"context_line":"security_group_api \u003d neutron"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1a122d0e_3b0dff90","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":17},"updated":"2016-04-18 09:02:33.000000000","message":"Is the use_forwarded_for linked to nova_network_services?\nI thought use_forwarded_for was for working with a proxy, so I don\u0027t see the immediate link. \n\nTherefore, I\u0027d rather have this removed (and configured by the config_template) OR have it documented (explaining the why is a minimum).","commit_id":"9d6a2122707708b4bdad41ebf176b83e57540cbd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dcafdce2c57a70325ff66893e207b8530c2a4ab6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"force_dhcp_release \u003d True"},{"line_number":94,"context_line":"dhcpbridge_flagfile \u003d /etc/nova/nova.conf"},{"line_number":95,"context_line":"firewall_driver \u003d {{ nova_firewall_driver }}"},{"line_number":96,"context_line":"use_forwarded_for \u003d {{ nova_network_services[nova_network_type][\u0027use_forwarded_for\u0027] | bool }}"},{"line_number":97,"context_line":"my_ip \u003d {{ nova_management_address }}"},{"line_number":98,"context_line":"default_floating_pool \u003d public"},{"line_number":99,"context_line":"security_group_api \u003d neutron"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1a122d0e_aa025709","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":17},"in_reply_to":"1a122d0e_3b0dff90","updated":"2016-04-18 10:26:59.000000000","message":"When using linuxbridge as the nova_network_type, this maintains the current default behaviour. It only changes behaviour when setting the nova_network_type to \u0027nuage\u0027 and this setting is required for nuage.","commit_id":"9d6a2122707708b4bdad41ebf176b83e57540cbd"}]}
