)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"969812671020439e58e8283816a50f36ff8da2ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Implement Nova PowerVM Virt Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add powervm playbooks to enable PowerVM platform as Openstack"},{"line_number":10,"context_line":"compute node."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic6197ea8940a7958d8b422b2627e6e96fd6deb21"},{"line_number":13,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_0f501a0a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":13},"updated":"2016-05-23 13:35:10.000000000","message":"What are the next steps on this one?","commit_id":"7076e734b018f8f0421dda7e3a9716ae8d0162fb"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"7842d3b3961ab1fd0fa37556d401ed58f970c2d2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Implement Nova PowerVM Virt Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add powervm playbooks to enable PowerVM platform as Openstack"},{"line_number":10,"context_line":"compute node."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic6197ea8940a7958d8b422b2627e6e96fd6deb21"},{"line_number":13,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_00d3c760","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":13},"in_reply_to":"bab6814e_0f501a0a","updated":"2016-05-23 14:28:11.000000000","message":"Investigating the configure of powervm driver and testing is the next step.\nI saw there are some configures under [powervm] tag. I will try to generate it in nova.conf","commit_id":"7076e734b018f8f0421dda7e3a9716ae8d0162fb"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"5ae747a98f38016149d5c4d756df0ad309fa7049","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implement Nova PowerVM Virt Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add powervm playbooks to enable PowerVM platform as Openstack"},{"line_number":10,"context_line":"compute node."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic6197ea8940a7958d8b422b2627e6e96fd6deb21"},{"line_number":13,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9abb7d3a_7ef5e6c9","line":10,"updated":"2016-06-02 15:11:49.000000000","message":"I wonder if we should add a note in here about \"novalink\".  Its a term used in this change set.\n\nMaybe just: \"This adds support to configure the PowerVM NovaLink feature (required for OpenStack integration) as well as the PowerVM OpenStack drivers.\"?","commit_id":"9757c0851a7040e090accae906ff7c8b3c4988ff"}],"defaults/main.yml":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"78ff4c7d668790939d54146d0fe9d31a7f9ec53d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  powervm:"},{"line_number":127,"context_line":"    nova_compute_driver: nova_powervm.virt.powervm.driver.PowerVMDriver"},{"line_number":128,"context_line":"    nova_scheduler_host_manager: host_manager"},{"line_number":129,"context_line":"    nova_reserved_host_memory_mb: 2048"},{"line_number":130,"context_line":"    nova_compute_manager: nova.compute.manager.ComputeManager"},{"line_number":131,"context_line":"    nova_firewall_driver: nova.virt.firewall.NoopFirewallDriver"},{"line_number":132,"context_line":"    nova_scheduler_use_baremetal_filters: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_6b748167","line":129,"range":{"start_line":129,"start_character":35,"end_line":129,"end_character":38},"updated":"2016-05-20 16:46:50.000000000","message":"This is a bit higher actually I think.\n\nCurious what adreznec thinks.  But I\u0027m thinking we should have this around 8192?\n\nThere is the firmware + Novalink here.  And with OVS running through it..","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  powervm:"},{"line_number":127,"context_line":"    nova_compute_driver: nova_powervm.virt.powervm.driver.PowerVMDriver"},{"line_number":128,"context_line":"    nova_scheduler_host_manager: host_manager"},{"line_number":129,"context_line":"    nova_reserved_host_memory_mb: 2048"},{"line_number":130,"context_line":"    nova_compute_manager: nova.compute.manager.ComputeManager"},{"line_number":131,"context_line":"    nova_firewall_driver: nova.virt.firewall.NoopFirewallDriver"},{"line_number":132,"context_line":"    nova_scheduler_use_baremetal_filters: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_6443e013","line":129,"range":{"start_line":129,"start_character":35,"end_line":129,"end_character":38},"in_reply_to":"bab6814e_6b748167","updated":"2016-05-23 10:16:24.000000000","message":"Done","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"7bd342b39731f639b83b46387ab92c61e5822c79","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  powervm:"},{"line_number":127,"context_line":"    nova_compute_driver: nova_powervm.virt.powervm.driver.PowerVMDriver"},{"line_number":128,"context_line":"    nova_scheduler_host_manager: host_manager"},{"line_number":129,"context_line":"    nova_reserved_host_memory_mb: 2048"},{"line_number":130,"context_line":"    nova_compute_manager: nova.compute.manager.ComputeManager"},{"line_number":131,"context_line":"    nova_firewall_driver: nova.virt.firewall.NoopFirewallDriver"},{"line_number":132,"context_line":"    nova_scheduler_use_baremetal_filters: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_a3df9e67","line":129,"range":{"start_line":129,"start_character":35,"end_line":129,"end_character":38},"in_reply_to":"bab6814e_6b748167","updated":"2016-05-20 22:06:49.000000000","message":"Yeah, we\u0027ll want this a bit higher to account for HPT/API memory usage.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  powervm:"},{"line_number":127,"context_line":"    nova_compute_driver: nova_powervm.virt.powervm.driver.PowerVMDriver"},{"line_number":128,"context_line":"    nova_scheduler_host_manager: host_manager"},{"line_number":129,"context_line":"    nova_reserved_host_memory_mb: 2048"},{"line_number":130,"context_line":"    nova_compute_manager: nova.compute.manager.ComputeManager"},{"line_number":131,"context_line":"    nova_firewall_driver: nova.virt.firewall.NoopFirewallDriver"},{"line_number":132,"context_line":"    nova_scheduler_use_baremetal_filters: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_84408408","line":129,"range":{"start_line":129,"start_character":35,"end_line":129,"end_character":38},"in_reply_to":"bab6814e_a3df9e67","updated":"2016-05-23 10:16:24.000000000","message":"Done","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"7bd342b39731f639b83b46387ab92c61e5822c79","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":133,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Current supported choice: qemu or kvm or ironic"},{"line_number":136,"context_line":"# If this is not set, then the playbook will try to guess it."},{"line_number":137,"context_line":"#nova_virt_type: kvm"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_c3e2a22e","line":135,"range":{"start_line":135,"start_character":28,"end_line":135,"end_character":49},"updated":"2016-05-20 22:06:49.000000000","message":"Need to add \u0027powervm\u0027 to this list.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":133,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Current supported choice: qemu or kvm or ironic"},{"line_number":136,"context_line":"# If this is not set, then the playbook will try to guess it."},{"line_number":137,"context_line":"#nova_virt_type: kvm"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_c44e0c3a","line":135,"range":{"start_line":135,"start_character":28,"end_line":135,"end_character":49},"in_reply_to":"bab6814e_c3e2a22e","updated":"2016-05-23 10:16:24.000000000","message":"Done","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"78ff4c7d668790939d54146d0fe9d31a7f9ec53d","unresolved":false,"context_lines":[{"line_number":424,"context_line":"  - nfs-common"},{"line_number":425,"context_line":"  - dosfstools"},{"line_number":426,"context_line":"  - dosfstools-dbg"},{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":430,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_eb907145","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":19},"updated":"2016-05-20 16:46:50.000000000","message":"I think we\u0027d want the pvm-novalink\n\nThat is the package that provides the PowerVM hypervisor support.\n\nIt is pretty much guaranteed to be there on a PowerVM system.  But is needed for the driver.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"5c0424ec6126163dca737c94cccc907d70b04c8d","unresolved":false,"context_lines":[{"line_number":424,"context_line":"  - nfs-common"},{"line_number":425,"context_line":"  - dosfstools"},{"line_number":426,"context_line":"  - dosfstools-dbg"},{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":430,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_65d41b47","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":19},"in_reply_to":"bab6814e_94f6dd5a","updated":"2016-05-24 16:32:01.000000000","message":"I have added it in apt repo. but failed to install it.\nWhat is the package name? I have tried \u0027nova-link\u0027,\u0027novalink\u0027 and \u0027pvm-novalink\u0027, however all of these names are failed.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"ba792ef6dbff089803cfa14dc1d626edf634eb68","unresolved":false,"context_lines":[{"line_number":424,"context_line":"  - nfs-common"},{"line_number":425,"context_line":"  - dosfstools"},{"line_number":426,"context_line":"  - dosfstools-dbg"},{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":430,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_94f6dd5a","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":19},"in_reply_to":"bab6814e_b1afc57b","updated":"2016-05-23 13:33:26.000000000","message":"pvm-novalink is not opensource.  But the repos are here:\nftp://public.dhe.ibm.com/systems/virtualization/Novalink/\n\nftp://public.dhe.ibm.com/systems/virtualization/Novalink/debian/","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":424,"context_line":"  - nfs-common"},{"line_number":425,"context_line":"  - dosfstools"},{"line_number":426,"context_line":"  - dosfstools-dbg"},{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":430,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_b1afc57b","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":19},"in_reply_to":"bab6814e_c36742b5","updated":"2016-05-23 10:16:24.000000000","message":"sorry, could you help to provide the pvm-novalink source repo?\nI can not find it in github.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"7bd342b39731f639b83b46387ab92c61e5822c79","unresolved":false,"context_lines":[{"line_number":424,"context_line":"  - nfs-common"},{"line_number":425,"context_line":"  - dosfstools"},{"line_number":426,"context_line":"  - dosfstools-dbg"},{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":430,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_c36742b5","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":19},"in_reply_to":"bab6814e_eb907145","updated":"2016-05-20 22:06:49.000000000","message":"Yep, pvm-novalink should be a package requirement here. We\u0027ll have to deal with adding the repo in the install step.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"78ff4c7d668790939d54146d0fe9d31a7f9ec53d","unresolved":false,"context_lines":[{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":430,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_cbbc8dbd","line":430,"range":{"start_line":430,"start_character":2,"end_line":430,"end_character":16},"updated":"2016-05-20 16:46:50.000000000","message":"If we install from git, do we need to call this out/","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":430,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_b1aa2583","line":430,"range":{"start_line":430,"start_character":2,"end_line":430,"end_character":16},"in_reply_to":"bab6814e_c3b90217","updated":"2016-05-23 10:16:24.000000000","message":"I use github as the nova-powervm source repo to install it","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"7bd342b39731f639b83b46387ab92c61e5822c79","unresolved":false,"context_lines":[{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":430,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_c3b90217","line":430,"range":{"start_line":430,"start_character":2,"end_line":430,"end_character":16},"in_reply_to":"bab6814e_cbbc8dbd","updated":"2016-05-20 22:06:49.000000000","message":"I believe we do, yes.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3a62d8df15aa44813e5c3e1ed786545d90ad17d3","unresolved":false,"context_lines":[{"line_number":425,"context_line":"  - dosfstools"},{"line_number":426,"context_line":"  - dosfstools-dbg"},{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":"  - pvm-novalink"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":431,"context_line":"  - pypowervm"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_04ba9ae1","line":428,"range":{"start_line":428,"start_character":2,"end_line":428,"end_character":16},"updated":"2016-05-27 12:33:40.000000000","message":"Adam and I were talking about this yesterday.  One thing to remember is that a PowerVM system out of the box should have the pvm-novalink package installed on the mgmt VM.  So ideally this won\u0027t actually install anything.\n\nI don\u0027t know that it hurts to have it here, but it is one thing to note.","commit_id":"72b029b5ef2a21e047ade44f0caa12b882972df1"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"57280381cf5aaf88e93ae0ffffd4bc11d7f8b6e7","unresolved":false,"context_lines":[{"line_number":425,"context_line":"  - dosfstools"},{"line_number":426,"context_line":"  - dosfstools-dbg"},{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":"  - pvm-novalink"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":431,"context_line":"  - pypowervm"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_968cca80","line":428,"range":{"start_line":428,"start_character":2,"end_line":428,"end_character":16},"in_reply_to":"9abb7d3a_04ba9ae1","updated":"2016-05-30 03:39:37.000000000","message":"If pvm-novalink is unnecessary here, the apt repo process for novalink should be removed as well in playbooks.","commit_id":"72b029b5ef2a21e047ade44f0caa12b882972df1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fb7d0d3546c73821a819d63e54dfc19b993887e0","unresolved":false,"context_lines":[{"line_number":425,"context_line":"  - dosfstools"},{"line_number":426,"context_line":"  - dosfstools-dbg"},{"line_number":427,"context_line":"  - multipath-tools"},{"line_number":428,"context_line":"  - pvm-novalink"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":431,"context_line":"  - pypowervm"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_676a881c","line":428,"range":{"start_line":428,"start_character":2,"end_line":428,"end_character":16},"in_reply_to":"9abb7d3a_04ba9ae1","updated":"2016-05-27 12:49:52.000000000","message":"This will result in the package being updated. If that\u0027s not the desired effect then you may wish to change \u0027latest\u0027 to \u0027present\u0027 in the package install task. This would then require the system admin to use another mechanism to update the package.","commit_id":"72b029b5ef2a21e047ade44f0caa12b882972df1"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3a62d8df15aa44813e5c3e1ed786545d90ad17d3","unresolved":false,"context_lines":[{"line_number":428,"context_line":"  - pvm-novalink"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":431,"context_line":"  - pypowervm"},{"line_number":432,"context_line":"  - nova-powervm"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"novalink_apt_repo:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_2487de10","line":431,"range":{"start_line":431,"start_character":0,"end_line":431,"end_character":13},"updated":"2016-05-27 12:33:40.000000000","message":"I\u0027m thinking that the pypowervm pip package could be removed.\n\nThe pvm-novalink that is installed via apt is actually a marker package of things like pvm-rest, pvm-core, etc...  One of the elements in it is pypowervm.\n\nLets get Adam\u0027s view on this...but this may be one to remove.","commit_id":"72b029b5ef2a21e047ade44f0caa12b882972df1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fb7d0d3546c73821a819d63e54dfc19b993887e0","unresolved":false,"context_lines":[{"line_number":428,"context_line":"  - pvm-novalink"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":431,"context_line":"  - pypowervm"},{"line_number":432,"context_line":"  - nova-powervm"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"novalink_apt_repo:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_a7d8f01e","line":431,"range":{"start_line":431,"start_character":0,"end_line":431,"end_character":13},"in_reply_to":"9abb7d3a_2487de10","updated":"2016-05-27 12:49:52.000000000","message":"This package gets installed into the nova venv, so it won\u0027t have access to any site package on the host. If you need the host and venv package contents to match then you should probably consider taking the approach set out in https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/ceph_client/tasks/ceph_install_python_libs.yml which solves that problem without giving the venv direct access to all system python packages.","commit_id":"72b029b5ef2a21e047ade44f0caa12b882972df1"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"3a85728d830a3c2ccd1540d7a3df8fc60aec5963","unresolved":false,"context_lines":[{"line_number":428,"context_line":"  - pvm-novalink"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":431,"context_line":"  - pypowervm"},{"line_number":432,"context_line":"  - nova-powervm"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"novalink_apt_repo:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_b0ff51a9","line":431,"range":{"start_line":431,"start_character":0,"end_line":431,"end_character":13},"in_reply_to":"9abb7d3a_a7d8f01e","updated":"2016-05-30 08:12:04.000000000","message":"Done","commit_id":"72b029b5ef2a21e047ade44f0caa12b882972df1"}],"releasenotes/notes/nova-powervm-b4eddae30abbd08e.yaml":[{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"b0289409938a516e4075c0e51f2a022137e212ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - PowerVM Virt Driver support had been added to allow deployment of PowerVM system"},{"line_number":4,"context_line":"    as Openstack compute nodes on ppc64le architecture using the Ubuntu."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_11739b16","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":71},"updated":"2016-06-03 18:48:54.000000000","message":"This release note could use a bit of cleaning up. Maybe:\n\n- The os_nova role can now detect and support basic deployment of a PowerVM environment. This sets the virtualization type to \u0027powervm\u0027 and installs/updates the PowerVM NovaLink package and nova-powervm driver.","commit_id":"9757c0851a7040e090accae906ff7c8b3c4988ff"}],"tasks/nova_compute.yml":[{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"d9e69d77c32fca40e528c7b844829b33b74eab24","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  when: nova_virt_type \u003d\u003d \u0027kvm\u0027 or nova_virt_type \u003d\u003d \u0027qemu\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- include: nova_compute_powervm.yml"},{"line_number":20,"context_line":"  when: nova_virt_type \u003d\u003d \u0027powervm\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include: nova_compute_key_populate.yml"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_a3415eab","line":20,"updated":"2016-05-20 21:54:24.000000000","message":"The question that this line raises is: How is the nova_virt_type getting set to \u0027powervm\u0027?   The user can certainly set it in the user variables file, but there is also logic to set the value for KVM/QEMU if it\u0027s not set.  If the user does not set the value, the nova_virt_dect.yml is surely not going to do the right thing for PowerVM. \n\nI think you can add logic to the virt detection tasks to look for Power processors and when PowerNV is not found, assume it\u0027s \u0027powervm\u0027?\n\n??  I\u0027m not sure of a better way.  I plan to put up a change to look for PowerNV and set it to \u0027kvm\u0027 for KVM on Power.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  when: nova_virt_type \u003d\u003d \u0027kvm\u0027 or nova_virt_type \u003d\u003d \u0027qemu\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- include: nova_compute_powervm.yml"},{"line_number":20,"context_line":"  when: nova_virt_type \u003d\u003d \u0027powervm\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include: nova_compute_key_populate.yml"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_44e05ccd","line":20,"in_reply_to":"bab6814e_03514a36","updated":"2016-05-23 10:16:24.000000000","message":"yes, I am trying to refine this.\nI found the /proc/cpuinfo can prompt which processor is in \u0027cpu\u0027 line. Such as POWER6, POWER7, or POWER8 processor","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"7bd342b39731f639b83b46387ab92c61e5822c79","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  when: nova_virt_type \u003d\u003d \u0027kvm\u0027 or nova_virt_type \u003d\u003d \u0027qemu\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- include: nova_compute_powervm.yml"},{"line_number":20,"context_line":"  when: nova_virt_type \u003d\u003d \u0027powervm\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include: nova_compute_key_populate.yml"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_03514a36","line":20,"in_reply_to":"bab6814e_a3415eab","updated":"2016-05-20 22:06:49.000000000","message":"Yeah, I\u0027ve thought about this as well. It seems we have a few options:\n- Do nothing (e.g. Ironic) and leave it to the user to set.\n- Look for the pvm-novalink package (not a great solution imo)\n- Run lscpu and check for \u0027Hypervisor vendor: pHyp\u0027\n- Check for the ibmvmc kernel module\n\nBut I haven\u0027t decided fits best for this use case.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"}],"tasks/nova_compute_powervm.yml":[{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"a758304180ce7f3749b2027fae390f48614eaf96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, IBM Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_3554b2fd","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":26},"updated":"2016-05-20 02:25:26.000000000","message":"I am not sure it this copyright is set correctly.\nWhich one is set right? \u0027Rackspace US, Inc.\u0027 or \u0027IBM\u0027\nI temporarily set it as \u0027IBM\u0027","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"78ff4c7d668790939d54146d0fe9d31a7f9ec53d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, IBM Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_4bc9bd58","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"updated":"2016-05-20 16:46:50.000000000","message":"Yeah, need to fix this year.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"4ece4e04e1a3f8d5238f14d2fc23c37858f6f043","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, IBM Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_67d5f11a","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":26},"in_reply_to":"bab6814e_3554b2fd","updated":"2016-05-20 03:10:20.000000000","message":"IBM is correct since this is a new file you\u0027re contributing.\nThe year is off though.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, IBM Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_a4cf8854","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"bab6814e_4bc9bd58","updated":"2016-05-23 10:16:24.000000000","message":"Done","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"78ff4c7d668790939d54146d0fe9d31a7f9ec53d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: nova_compute_powervm_install.yml"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Create a pvm_admin group"},{"line_number":19,"context_line":"  group:"},{"line_number":20,"context_line":"    name: \"pvm_admin\""},{"line_number":21,"context_line":"    state: present"},{"line_number":22,"context_line":"    system: yes"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add nova user to pvm_admin group"},{"line_number":25,"context_line":"  user:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_abd94924","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":15},"updated":"2016-05-20 16:46:50.000000000","message":"Should check with adreznec...but the existence of the pvm-novalink package will ensure that the pvm_admin group is there.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: nova_compute_powervm_install.yml"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Create a pvm_admin group"},{"line_number":19,"context_line":"  group:"},{"line_number":20,"context_line":"    name: \"pvm_admin\""},{"line_number":21,"context_line":"    state: present"},{"line_number":22,"context_line":"    system: yes"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add nova user to pvm_admin group"},{"line_number":25,"context_line":"  user:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_84fd2470","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":15},"in_reply_to":"bab6814e_03330aac","updated":"2016-05-23 10:16:24.000000000","message":"Done","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"7bd342b39731f639b83b46387ab92c61e5822c79","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: nova_compute_powervm_install.yml"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Create a pvm_admin group"},{"line_number":19,"context_line":"  group:"},{"line_number":20,"context_line":"    name: \"pvm_admin\""},{"line_number":21,"context_line":"    state: present"},{"line_number":22,"context_line":"    system: yes"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add nova user to pvm_admin group"},{"line_number":25,"context_line":"  user:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_03330aac","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":15},"in_reply_to":"bab6814e_abd94924","updated":"2016-05-20 22:06:49.000000000","message":"This will get automatically created as part of the pvm-core package installation, which will get pulled in on pvm-novalink install. Without that package installed the driver cannot function to begin with.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"}],"tasks/nova_compute_powervm_install.yml":[{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"7bd342b39731f639b83b46387ab92c61e5822c79","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    name: \"{{ item }}\""},{"line_number":51,"context_line":"    state: latest"},{"line_number":52,"context_line":"    virtualenv: \"{{ nova_venv_bin | dirname }}\""},{"line_number":53,"context_line":"    virtualenv_site_packages: \"no\""},{"line_number":54,"context_line":"    extra_args: \"{{ pip_install_options|default(\u0027\u0027) }}\""},{"line_number":55,"context_line":"  register: install_packages"},{"line_number":56,"context_line":"  until: install_packages|success"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_430fd287","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":33},"updated":"2016-05-20 22:06:49.000000000","message":"I believe in this scenario since we\u0027re installing nova/nova-powervm into a venv without site packages access, we would also have to independently install pypowervm into this venv as well or it wouldn\u0027t be available.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    name: \"{{ item }}\""},{"line_number":51,"context_line":"    state: latest"},{"line_number":52,"context_line":"    virtualenv: \"{{ nova_venv_bin | dirname }}\""},{"line_number":53,"context_line":"    virtualenv_site_packages: \"no\""},{"line_number":54,"context_line":"    extra_args: \"{{ pip_install_options|default(\u0027\u0027) }}\""},{"line_number":55,"context_line":"  register: install_packages"},{"line_number":56,"context_line":"  until: install_packages|success"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_e07fb512","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":33},"in_reply_to":"bab6814e_430fd287","updated":"2016-05-23 10:16:24.000000000","message":"I will add pypowervm in nova_compute_powervm_pip_packages","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"d9e69d77c32fca40e528c7b844829b33b74eab24","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#  There is a change in the works to upload the guestfs package to pypi in the"},{"line_number":69,"context_line":"#  future however that\u0027s not been done as of yet."},{"line_number":70,"context_line":"#  related thread http://lists.openstack.org/pipermail/openstack-dev/2015-July/070927.html"},{"line_number":71,"context_line":"- name: Link guestfs into the venv"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    src: \"{{ item.name }}\""},{"line_number":74,"context_line":"    dest: \"{{ nova_venv_bin | dirname }}/lib/python2.7/{{ item.name | basename }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_03c14a54","line":71,"updated":"2016-05-20 21:54:24.000000000","message":"nova-powervm doesn\u0027t support injecting files, so this is unnecessary.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"29c7f54064ef9074076b295a713f40dfd6b92479","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#  There is a change in the works to upload the guestfs package to pypi in the"},{"line_number":69,"context_line":"#  future however that\u0027s not been done as of yet."},{"line_number":70,"context_line":"#  related thread http://lists.openstack.org/pipermail/openstack-dev/2015-July/070927.html"},{"line_number":71,"context_line":"- name: Link guestfs into the venv"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    src: \"{{ item.name }}\""},{"line_number":74,"context_line":"    dest: \"{{ nova_venv_bin | dirname }}/lib/python2.7/{{ item.name | basename }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_c4428cad","line":71,"in_reply_to":"bab6814e_03c14a54","updated":"2016-05-23 10:16:24.000000000","message":"Done","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"7bd342b39731f639b83b46387ab92c61e5822c79","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#  There is a change in the works to upload the guestfs package to pypi in the"},{"line_number":69,"context_line":"#  future however that\u0027s not been done as of yet."},{"line_number":70,"context_line":"#  related thread http://lists.openstack.org/pipermail/openstack-dev/2015-July/070927.html"},{"line_number":71,"context_line":"- name: Link guestfs into the venv"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    src: \"{{ item.name }}\""},{"line_number":74,"context_line":"    dest: \"{{ nova_venv_bin | dirname }}/lib/python2.7/{{ item.name | basename }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_835d3a49","line":71,"in_reply_to":"bab6814e_03c14a54","updated":"2016-05-20 22:06:49.000000000","message":"Yep.","commit_id":"3d9fceac86a0b63c23f26de89bcbf6129bcc1584"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"03c5ab3553b8172c2f0a7c8d1ca452ff417affff","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#TODO(evrardjp): Replace the next 2 tasks by a standard apt with cache"},{"line_number":17,"context_line":"#when https://github.com/ansible/ansible-modules-core/pull/1517 is merged"},{"line_number":18,"context_line":"#in 1.9.x or we move to 2.0 (if tested working)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_9a06981e","line":15,"updated":"2016-05-25 09:39:32.000000000","message":"You\u0027re going to need to include tasks for adding the novalink repo and keys in order to get this working properly.\n\nAn example of how to do that is in https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/haproxy_server/tasks/haproxy_add_ppa_repo.yml#L45-L102 (although you can skip the pinning task as it shouldn\u0027t be necessary).","commit_id":"7e5eb92ae15f58accf0eaedcad0e05ed6c8552b2"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"2e0f78ff3b015c303c5dcee74d47f68559c57292","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#TODO(evrardjp): Replace the next 2 tasks by a standard apt with cache"},{"line_number":17,"context_line":"#when https://github.com/ansible/ansible-modules-core/pull/1517 is merged"},{"line_number":18,"context_line":"#in 1.9.x or we move to 2.0 (if tested working)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_70381a3e","line":15,"in_reply_to":"bab6814e_9a06981e","updated":"2016-05-25 16:22:02.000000000","message":"Done","commit_id":"7e5eb92ae15f58accf0eaedcad0e05ed6c8552b2"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"5189cb5456bf42efcac4bb780d13307b62d598f1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    url: \"{{ item.url }}\""},{"line_number":19,"context_line":"    state: \"{{ item.state }}\""},{"line_number":20,"context_line":"  register: add_nv_keys"},{"line_number":21,"context_line":"  until: add_nv_keys|success"},{"line_number":22,"context_line":"  ignore_errors: True"},{"line_number":23,"context_line":"  with_items: novalink_gpg_keys"},{"line_number":24,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_5175eac8","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":28},"updated":"2016-05-26 13:30:45.000000000","message":"You should probably add retries/delays here.","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"5b1886aac549b11dcdd3f47d9b6db43eac7d4433","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    url: \"{{ item.url }}\""},{"line_number":19,"context_line":"    state: \"{{ item.state }}\""},{"line_number":20,"context_line":"  register: add_nv_keys"},{"line_number":21,"context_line":"  until: add_nv_keys|success"},{"line_number":22,"context_line":"  ignore_errors: True"},{"line_number":23,"context_line":"  with_items: novalink_gpg_keys"},{"line_number":24,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_155bf455","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":28},"in_reply_to":"bab6814e_5175eac8","updated":"2016-05-27 06:50:30.000000000","message":"Done","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"5189cb5456bf42efcac4bb780d13307b62d598f1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    repo: \"{{ novalink_apt_repo.repo }}\""},{"line_number":30,"context_line":"    state: \"{{ novalink_apt_repo.state }}\""},{"line_number":31,"context_line":"  register: add_nv_repos"},{"line_number":32,"context_line":"  until: add_nv_repos|success"},{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    - novalink-repo"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_1146c27a","line":32,"updated":"2016-05-26 13:30:45.000000000","message":"Same here.","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"5b1886aac549b11dcdd3f47d9b6db43eac7d4433","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    repo: \"{{ novalink_apt_repo.repo }}\""},{"line_number":30,"context_line":"    state: \"{{ novalink_apt_repo.state }}\""},{"line_number":31,"context_line":"  register: add_nv_repos"},{"line_number":32,"context_line":"  until: add_nv_repos|success"},{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    - novalink-repo"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_75588057","line":32,"in_reply_to":"bab6814e_1146c27a","updated":"2016-05-27 06:50:30.000000000","message":"Done","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2da769b3261c21ad49f53c0452ba891d333507b6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- name: Update apt if needed"},{"line_number":52,"context_line":"  apt:"},{"line_number":53,"context_line":"    update_cache: yes"},{"line_number":54,"context_line":"  when: \"ansible_date_time.epoch|float - apt_cache_stat.stat.mtime \u003e {{cache_timeout}}\""},{"line_number":55,"context_line":"  tags:"},{"line_number":56,"context_line":"    - nova-apt-packages"},{"line_number":57,"context_line":"    - nova-compute-powervm-apt-packages"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7aa08908_47328211","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":87},"updated":"2016-06-07 12:53:46.000000000","message":"This also needs to happen if \u0027add_nv_repos | changed\u0027, otherwise the new repo addition will not have the cache updated afterwards. :/","commit_id":"bc0ac6125bba498050e18c9c97369688f37630ac"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"dc3787c0340b327155fb5ab1ab62d505e0da6417","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  apt:"},{"line_number":53,"context_line":"    update_cache: yes"},{"line_number":54,"context_line":"  when: \"ansible_date_time.epoch|float - apt_cache_stat.stat.mtime \u003e {{cache_timeout}}\""},{"line_number":55,"context_line":"        or add_nv_repos|changed"},{"line_number":56,"context_line":"  tags:"},{"line_number":57,"context_line":"    - nova-apt-packages"},{"line_number":58,"context_line":"    - nova-compute-powervm-apt-packages"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7aa08908_e6e6f013","line":55,"updated":"2016-06-07 20:59:26.000000000","message":"It\u0027s not possible to have a newline here unless you use a pipe (|). It will need to be on one line or:\n\nwhen: |\n    \"ansible_date_time.epoch|float - apt_cache_stat.stat.mtime \u003e {{cache_timeout}}\"\n    or add_nv_repos|changed","commit_id":"915a74aee891f23ba6459ea21c51948e44f651e4"}],"tasks/nova_virt_detect.yml":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"c76a78fa8fc2f47547cb604058b4c79293e26dc4","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Get powervm virt type value and store as var"},{"line_number":32,"context_line":"  shell: |"},{"line_number":33,"context_line":"    `which egrep` -c \u0027(POWER)\u0027 /proc/cpuinfo"},{"line_number":34,"context_line":"  register: virt_powervm_type_value"},{"line_number":35,"context_line":"  changed_when: false"},{"line_number":36,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_32572f59","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":44},"updated":"2016-05-23 18:53:49.000000000","message":"How does this react when ppc64le is running on a KVM type?","commit_id":"dbf01252095daefc7649427ab04560f9a0dd7f4f"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"1f4337afe711b56985912f4b83022e1411891778","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Get powervm virt type value and store as var"},{"line_number":32,"context_line":"  shell: |"},{"line_number":33,"context_line":"    `which egrep` -c \u0027(POWER)\u0027 /proc/cpuinfo"},{"line_number":34,"context_line":"  register: virt_powervm_type_value"},{"line_number":35,"context_line":"  changed_when: false"},{"line_number":36,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_a1f10198","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":44},"in_reply_to":"bab6814e_32572f59","updated":"2016-05-24 03:12:36.000000000","message":"Does the ppc64le can also run on qemu type?\nWhich kind of types can ppc64le run?","commit_id":"dbf01252095daefc7649427ab04560f9a0dd7f4f"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"4b9f89aabe22f1b3f5781c2e18284ca78e1f897b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  register: virt_powervm_type_value"},{"line_number":35,"context_line":"  changed_when: false"},{"line_number":36,"context_line":"  failed_when: false"},{"line_number":37,"context_line":"  when: (virt_type_value.stdout | int) \u003d\u003d 0"},{"line_number":38,"context_line":"  tags:"},{"line_number":39,"context_line":"    - nova-powervm-cpuinfo-read"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_db2ec941","line":37,"updated":"2016-05-23 16:36:24.000000000","message":"Should add the when condition of ansible-architecture \u003d\u003d ppc64le\n\nThere\u0027s no need to run it on non power hardware.","commit_id":"dbf01252095daefc7649427ab04560f9a0dd7f4f"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"f3679984cfc9584eec33db9840c3dfb3d8739959","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  register: virt_powervm_type_value"},{"line_number":35,"context_line":"  changed_when: false"},{"line_number":36,"context_line":"  failed_when: false"},{"line_number":37,"context_line":"  when: (virt_type_value.stdout | int) \u003d\u003d 0"},{"line_number":38,"context_line":"  tags:"},{"line_number":39,"context_line":"    - nova-powervm-cpuinfo-read"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_379ee807","line":37,"in_reply_to":"bab6814e_126b0b1f","updated":"2016-05-24 08:24:17.000000000","message":"if the ppc64le can run on kvm, does that mean I can only use the ansible-architecture to check the virt type and do not need to check the processor type?","commit_id":"dbf01252095daefc7649427ab04560f9a0dd7f4f"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"c76a78fa8fc2f47547cb604058b4c79293e26dc4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  register: virt_powervm_type_value"},{"line_number":35,"context_line":"  changed_when: false"},{"line_number":36,"context_line":"  failed_when: false"},{"line_number":37,"context_line":"  when: (virt_type_value.stdout | int) \u003d\u003d 0"},{"line_number":38,"context_line":"  tags:"},{"line_number":39,"context_line":"    - nova-powervm-cpuinfo-read"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_126b0b1f","line":37,"in_reply_to":"bab6814e_db2ec941","updated":"2016-05-23 18:53:49.000000000","message":"+1","commit_id":"dbf01252095daefc7649427ab04560f9a0dd7f4f"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"4b9f89aabe22f1b3f5781c2e18284ca78e1f897b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- name: Overwrite a fact for the nova virt type if it is powervm"},{"line_number":42,"context_line":"  set_fact:"},{"line_number":43,"context_line":"     nova_virt_type: \"{{ ((virt_powervm_type_value.stdout | int) \u003e 0) | ternary(\u0027powervm\u0027, nova_virt_type) }}\""},{"line_number":44,"context_line":"  when: (virt_type_value.stdout | int) \u003d\u003d 0"},{"line_number":45,"context_line":"  tags:"},{"line_number":46,"context_line":"    - nova-powervm-virt-type-set"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_7b14fde7","line":44,"updated":"2016-05-23 16:36:24.000000000","message":"Same as above.","commit_id":"dbf01252095daefc7649427ab04560f9a0dd7f4f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cfcfece2ff70ed4dcd2ad1e28c587f65137dd3fb","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Get powervm virt type value and store as var"},{"line_number":32,"context_line":"  shell: |"},{"line_number":33,"context_line":"    `which egrep` -c \u0027(POWER)\u0027 /proc/cpuinfo"},{"line_number":34,"context_line":"  register: virt_powervm_type_value"},{"line_number":35,"context_line":"  changed_when: false"},{"line_number":36,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_f7a1bd47","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":28},"updated":"2016-05-25 09:26:06.000000000","message":"Why not just add this to the egrep above in line 18? That way you wouldn\u0027t have to overwrite the fact. Is there any particular danger in doing this?\n\nAlternatively, do this check above line 25 then change the task at line 27 to check for the current conditional or the conditional in line 45.","commit_id":"7e5eb92ae15f58accf0eaedcad0e05ed6c8552b2"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"2e0f78ff3b015c303c5dcee74d47f68559c57292","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Get powervm virt type value and store as var"},{"line_number":32,"context_line":"  shell: |"},{"line_number":33,"context_line":"    `which egrep` -c \u0027(POWER)\u0027 /proc/cpuinfo"},{"line_number":34,"context_line":"  register: virt_powervm_type_value"},{"line_number":35,"context_line":"  changed_when: false"},{"line_number":36,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_7cebdb78","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":28},"in_reply_to":"bab6814e_7aa81478","updated":"2016-05-25 16:22:02.000000000","message":"Done","commit_id":"7e5eb92ae15f58accf0eaedcad0e05ed6c8552b2"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"56fee1783dd2738995162d1923278c1f8cf222d7","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Get powervm virt type value and store as var"},{"line_number":32,"context_line":"  shell: |"},{"line_number":33,"context_line":"    `which egrep` -c \u0027(POWER)\u0027 /proc/cpuinfo"},{"line_number":34,"context_line":"  register: virt_powervm_type_value"},{"line_number":35,"context_line":"  changed_when: false"},{"line_number":36,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_7aa81478","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":28},"in_reply_to":"bab6814e_f7a1bd47","updated":"2016-05-25 09:32:24.000000000","message":"Oh, never mind - I see that you\u0027re setting the nova_virt_type to \u0027powervm\u0027 and not \u0027kvm\u0027.\n\nIn that case I still think that the tests and nova_virt_type settings should happen in sequence rather than the override mechanism. Perhaps the detection should be based on the arch type, then the setting of the fact should be changed from a ternary to an if, then, else?","commit_id":"7e5eb92ae15f58accf0eaedcad0e05ed6c8552b2"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"5189cb5456bf42efcac4bb780d13307b62d598f1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Get CPU info content and store  as var"},{"line_number":17,"context_line":"  shell: cat /proc/cpuinfo"},{"line_number":18,"context_line":"  register: cpuinfo_contents"},{"line_number":19,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_2b06f91b","line":16,"range":{"start_line":16,"start_character":38,"end_line":16,"end_character":40},"updated":"2016-05-26 13:30:45.000000000","message":"Extra space added here","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"5b1886aac549b11dcdd3f47d9b6db43eac7d4433","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Get CPU info content and store  as var"},{"line_number":17,"context_line":"  shell: cat /proc/cpuinfo"},{"line_number":18,"context_line":"  register: cpuinfo_contents"},{"line_number":19,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_9567e424","line":16,"range":{"start_line":16,"start_character":38,"end_line":16,"end_character":40},"in_reply_to":"bab6814e_2b06f91b","updated":"2016-05-27 06:50:30.000000000","message":"Done","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"5189cb5456bf42efcac4bb780d13307b62d598f1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    nova_virt_type: \"kvm\""},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - cpuinfo_contents.stdout.find(\u0027vmx\u0027) !\u003d -1 or cpuinfo_contents.stdout.find(\u0027svm\u0027) !\u003d -1"},{"line_number":29,"context_line":"    - ansible_architecture \u003d\u003d \u0027x86_64\u0027"},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    - nova-virt-type-set"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_b6e40c3c","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":38},"updated":"2016-05-26 13:30:45.000000000","message":"This would break KVM running on POWER, and https://review.openstack.org/#/c/319480/","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"5b1886aac549b11dcdd3f47d9b6db43eac7d4433","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    nova_virt_type: \"kvm\""},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - cpuinfo_contents.stdout.find(\u0027vmx\u0027) !\u003d -1 or cpuinfo_contents.stdout.find(\u0027svm\u0027) !\u003d -1"},{"line_number":29,"context_line":"    - ansible_architecture \u003d\u003d \u0027x86_64\u0027"},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    - nova-virt-type-set"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_f56c700a","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":38},"in_reply_to":"bab6814e_b6e40c3c","updated":"2016-05-27 06:50:30.000000000","message":"Done","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"1290d1ae606dbcc3b6a9e236d67a750990010bee","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"    nova_virt_type: \"powervm\""},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - cpuinfo_contents.stdout.find(\u0027POWER\u0027) !\u003d -1"},{"line_number":38,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":39,"context_line":"  tags:"},{"line_number":40,"context_line":"    - nova-virt-type-set"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_5b536417","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":49},"updated":"2016-05-26 01:48:42.000000000","message":"Keep in mind that POWER supports either PowerVM or KVM.\n\nWe should ask kyle3h to look at this.  He is doing a similar change set for KVM on POWER.\n\nI worry that we assume here that POWER \u003d\u003d PowerVM, and I\u0027m not sure that\u0027s true.\n\nPing me in IRC and we can get you the cpuinfo output for a KVM based system versus a PowerVM based system.  We\u0027ll find a good value to check in there.","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"5b1886aac549b11dcdd3f47d9b6db43eac7d4433","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"    nova_virt_type: \"powervm\""},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - cpuinfo_contents.stdout.find(\u0027POWER\u0027) !\u003d -1"},{"line_number":38,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":39,"context_line":"  tags:"},{"line_number":40,"context_line":"    - nova-virt-type-set"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_7581a08f","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":49},"in_reply_to":"bab6814e_5b536417","updated":"2016-05-27 06:50:30.000000000","message":"Done","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"5189cb5456bf42efcac4bb780d13307b62d598f1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"    nova_virt_type: \"powervm\""},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - cpuinfo_contents.stdout.find(\u0027POWER\u0027) !\u003d -1"},{"line_number":38,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":39,"context_line":"  tags:"},{"line_number":40,"context_line":"    - nova-virt-type-set"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_b0e2549e","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":49},"in_reply_to":"bab6814e_5b536417","updated":"2016-05-26 13:30:45.000000000","message":"Yeah, this assumption is incorrect. I think instead we should be checking /proc/cpuinfo for \u0027platform: pSeries\u0027, which identifies phyp, rather than checking for POWER.","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"5b1886aac549b11dcdd3f47d9b6db43eac7d4433","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"    nova_virt_type: \"powervm\""},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - cpuinfo_contents.stdout.find(\u0027POWER\u0027) !\u003d -1"},{"line_number":38,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":39,"context_line":"  tags:"},{"line_number":40,"context_line":"    - nova-virt-type-set"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_157494cd","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":49},"in_reply_to":"bab6814e_b0e2549e","updated":"2016-05-27 06:50:30.000000000","message":"Done","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"5189cb5456bf42efcac4bb780d13307b62d598f1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  when:"},{"line_number":46,"context_line":"    - cpuinfo_contents.stdout.find(\u0027vmx\u0027) \u003d\u003d -1"},{"line_number":47,"context_line":"    - cpuinfo_contents.stdout.find(\u0027svm\u0027) \u003d\u003d -1"},{"line_number":48,"context_line":"    - cpuinfo_contents.stdout.find(\u0027POWER\u0027) \u003d\u003d -1"},{"line_number":49,"context_line":"    - ansible_architecture \u003d\u003d \u0027x86_64\u0027"},{"line_number":50,"context_line":"  tags:"},{"line_number":51,"context_line":"    - nova-virt-type-set"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_968aa862","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":38},"updated":"2016-05-26 13:30:45.000000000","message":"This would break QEMU running on POWER","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"5b1886aac549b11dcdd3f47d9b6db43eac7d4433","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  when:"},{"line_number":46,"context_line":"    - cpuinfo_contents.stdout.find(\u0027vmx\u0027) \u003d\u003d -1"},{"line_number":47,"context_line":"    - cpuinfo_contents.stdout.find(\u0027svm\u0027) \u003d\u003d -1"},{"line_number":48,"context_line":"    - cpuinfo_contents.stdout.find(\u0027POWER\u0027) \u003d\u003d -1"},{"line_number":49,"context_line":"    - ansible_architecture \u003d\u003d \u0027x86_64\u0027"},{"line_number":50,"context_line":"  tags:"},{"line_number":51,"context_line":"    - nova-virt-type-set"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_b5494891","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":38},"in_reply_to":"bab6814e_968aa862","updated":"2016-05-27 06:50:30.000000000","message":"Done","commit_id":"d535fa970637acc1e28e1aae8d224bd297f049a0"}],"templates/nova.conf.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cfcfece2ff70ed4dcd2ad1e28c587f65137dd3fb","unresolved":false,"context_lines":[{"line_number":276,"context_line":"hw_disk_discard \u003d {{ nova_libvirt_hw_disk_discard }}"},{"line_number":277,"context_line":"disk_cachemodes \u003d {{ nova_libvirt_disk_cachemodes }}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"{% if nova_virt_type \u003d\u003d \u0027powervm\u0027 and powervm_environment_variables is defined %}"},{"line_number":280,"context_line":"[powervm]"},{"line_number":281,"context_line":"{% for key, value in powervm_environment_variables.iteritems() %}"},{"line_number":282,"context_line":"{% if value %}"},{"line_number":283,"context_line":"{{ key }} \u003d {{ value }}"},{"line_number":284,"context_line":"{% endif %}"},{"line_number":285,"context_line":"{% endfor %}"},{"line_number":286,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bab6814e_fa7084a6","line":286,"range":{"start_line":279,"start_character":0,"end_line":286,"end_character":11},"updated":"2016-05-25 09:26:06.000000000","message":"Instead of adding a new var here, is there a specific reason why the deployer can\u0027t just use the nova_nova_conf_overrides as described in http://docs.openstack.org/developer/openstack-ansible/developer-docs/extending.html#setting-overrides-in-configuration-files","commit_id":"7e5eb92ae15f58accf0eaedcad0e05ed6c8552b2"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"2e0f78ff3b015c303c5dcee74d47f68559c57292","unresolved":false,"context_lines":[{"line_number":276,"context_line":"hw_disk_discard \u003d {{ nova_libvirt_hw_disk_discard }}"},{"line_number":277,"context_line":"disk_cachemodes \u003d {{ nova_libvirt_disk_cachemodes }}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"{% if nova_virt_type \u003d\u003d \u0027powervm\u0027 and powervm_environment_variables is defined %}"},{"line_number":280,"context_line":"[powervm]"},{"line_number":281,"context_line":"{% for key, value in powervm_environment_variables.iteritems() %}"},{"line_number":282,"context_line":"{% if value %}"},{"line_number":283,"context_line":"{{ key }} \u003d {{ value }}"},{"line_number":284,"context_line":"{% endif %}"},{"line_number":285,"context_line":"{% endfor %}"},{"line_number":286,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bab6814e_1fd728ee","line":286,"range":{"start_line":279,"start_character":0,"end_line":286,"end_character":11},"in_reply_to":"bab6814e_fa7084a6","updated":"2016-05-25 16:22:02.000000000","message":"Done","commit_id":"7e5eb92ae15f58accf0eaedcad0e05ed6c8552b2"}]}
