)]}'
{"releasenotes/notes/symlink_libvirt_save_dir_to_nova_dir-3b1b278cb7e5831f.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"21d8339a381434b5e6d649639ca63c89471be538","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Verify that /var/lib/libvirt/qemu/save is empty"},{"line_number":4,"context_line":"    before running an upgrade, as it will be replaced"},{"line_number":5,"context_line":"    with a symlink."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - /var/lib/libvirt/qemu/save is now a symlink to"},{"line_number":8,"context_line":"    {{ nova_system_home_folder }}/save as the previous"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_88c292e7","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":19},"updated":"2016-05-26 10:40:11.000000000","message":"If the tasks are done right, this check is not necessary as it will be done by the tasks.","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"21d8339a381434b5e6d649639ca63c89471be538","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    before running an upgrade, as it will be replaced"},{"line_number":5,"context_line":"    with a symlink."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - /var/lib/libvirt/qemu/save is now a symlink to"},{"line_number":8,"context_line":"    {{ nova_system_home_folder }}/save as the previous"},{"line_number":9,"context_line":"    location was filling root partitions on deployers"},{"line_number":10,"context_line":"    compute nodes when image-create was called on large"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_c8b81a78","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":30},"updated":"2016-05-26 10:40:11.000000000","message":"surround this with double backticks","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"21d8339a381434b5e6d649639ca63c89471be538","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    with a symlink."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - /var/lib/libvirt/qemu/save is now a symlink to"},{"line_number":8,"context_line":"    {{ nova_system_home_folder }}/save as the previous"},{"line_number":9,"context_line":"    location was filling root partitions on deployers"},{"line_number":10,"context_line":"    compute nodes when image-create was called on large"},{"line_number":11,"context_line":"    instances."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_68a80e21","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":38},"updated":"2016-05-26 10:40:11.000000000","message":"surround this with double backticks","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"21d8339a381434b5e6d649639ca63c89471be538","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    with a symlink."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - /var/lib/libvirt/qemu/save is now a symlink to"},{"line_number":8,"context_line":"    {{ nova_system_home_folder }}/save as the previous"},{"line_number":9,"context_line":"    location was filling root partitions on deployers"},{"line_number":10,"context_line":"    compute nodes when image-create was called on large"},{"line_number":11,"context_line":"    instances."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_832c339a","line":11,"range":{"start_line":8,"start_character":39,"end_line":11,"end_character":14},"updated":"2016-05-26 10:40:11.000000000","message":"Suggested change:\n\nto resolve an issue where the default location used by the libvirt managedsave command can result in the root partition on compute nodes being filled when ``nova image-create`` is issued on large instances.","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"}],"tasks/nova_compute_kvm_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e8a270356bc6c515b421d7351c6833030bbe9209","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    - nova-apt-packages"},{"line_number":46,"context_line":"    - nova-compute-kvm-apt-packages"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Remove qemu save dir"},{"line_number":49,"context_line":"  file:"},{"line_number":50,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":51,"context_line":"    state: absent"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":54,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_35c97d7a","line":51,"range":{"start_line":48,"start_character":0,"end_line":51,"end_character":17},"updated":"2016-05-25 09:47:11.000000000","message":"shouldn\u0027t we use stat to check if it\u0027s currently a folder instead of a link, and do the actions conditionally on the folder, instead of doing it everytime and break the idempotency?","commit_id":"dff23904b41c2c82d250c405aa8f2bd8edcf545b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"21d8339a381434b5e6d649639ca63c89471be538","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    - nova-apt-packages"},{"line_number":46,"context_line":"    - nova-compute-kvm-apt-packages"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Chaeck if qemu save directory is a directory"},{"line_number":49,"context_line":"  stat:"},{"line_number":50,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":51,"context_line":"  register: qemu_savedir_stat"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_c8849a0c","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":14},"updated":"2016-05-26 10:40:11.000000000","message":"nit:Check","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"21d8339a381434b5e6d649639ca63c89471be538","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  file:"},{"line_number":61,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":62,"context_line":"    state: absent"},{"line_number":63,"context_line":"  when:"},{"line_number":64,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":67,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_08a22299","line":64,"range":{"start_line":63,"start_character":7,"end_line":64,"end_character":6},"updated":"2016-05-26 10:40:11.000000000","message":"this should also be conditional on whether the directory is empty","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a6c9660ddbae8c5071e980191d651990c1e89820","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  file:"},{"line_number":61,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":62,"context_line":"    state: absent"},{"line_number":63,"context_line":"  when:"},{"line_number":64,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":67,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_74e572a2","line":64,"range":{"start_line":63,"start_character":7,"end_line":64,"end_character":6},"in_reply_to":"bab6814e_08a22299","updated":"2016-05-26 16:10:55.000000000","message":"I thought that was implicitly done by the previous task running successfully.  I\u0027ll include it as a specific check though on the next edit.","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"21d8339a381434b5e6d649639ca63c89471be538","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    state: link"},{"line_number":70,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":71,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":72,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- name: Install pip packages (venv)"},{"line_number":75,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_684c8ec8","line":72,"updated":"2016-05-26 10:40:11.000000000","message":"this should be conditional on whether the task \u0027Remove qemu save dir\u0027 changed","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"72664e4bfb9bfb99edd98e03a756eb26541dc7d1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    state: link"},{"line_number":70,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":71,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":72,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- name: Install pip packages (venv)"},{"line_number":75,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_0c5da6e9","line":72,"in_reply_to":"bab6814e_54a14e45","updated":"2016-05-27 10:37:23.000000000","message":"If you don\u0027t then it will simply make this change regardless of the previous tests.","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a6c9660ddbae8c5071e980191d651990c1e89820","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    state: link"},{"line_number":70,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":71,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":72,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- name: Install pip packages (venv)"},{"line_number":75,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_54a14e45","line":72,"in_reply_to":"bab6814e_684c8ec8","updated":"2016-05-26 16:10:55.000000000","message":"Does that need to be, is this not idempotent?","commit_id":"edd151668ec0485f6d42db38d031ca524c53b934"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"d8778ff2258c5d6aa5c7857c29e522381466a402","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"},{"line_number":57,"context_line":"    rc: 1"},{"line_number":58,"context_line":"  register: qemu_savedir_empty"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# it counterintuitively seems that we need to make sure the return code is 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_ee03e30d","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":9},"updated":"2016-05-27 17:48:30.000000000","message":"Seeing some weirdness from ansible when testing this\n\ncmd and rc are return codes, not parameters \nhttp://docs.ansible.com/ansible/shell_module.html\n\nThink this should just be\nshell: ls -A /var/lib/libvirt/qemu/save\n\ninclude a \u0027when: qemu_savedir_stat.stat.isdir\u0027 with this task, and it should always have a 0 return code","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"16942989337aba759dbaeb8d0b8163146fccb5e7","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"},{"line_number":57,"context_line":"    rc: 1"},{"line_number":58,"context_line":"  register: qemu_savedir_empty"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# it counterintuitively seems that we need to make sure the return code is 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_1a593d5b","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":9},"in_reply_to":"9abb7d3a_1f564fd2","updated":"2016-05-27 19:08:34.000000000","message":"ya, this sounds awesome.  I\u0027ve removed the rc and changed it to ignore errors.  That may work better.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"00c410cc278658a9d28f0ea7bac96796d3279f9e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"},{"line_number":57,"context_line":"    rc: 1"},{"line_number":58,"context_line":"  register: qemu_savedir_empty"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# it counterintuitively seems that we need to make sure the return code is 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_1f564fd2","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":9},"in_reply_to":"9abb7d3a_542c3e4a","updated":"2016-05-27 18:52:48.000000000","message":"ansible 2 is a lot more strict, but I\u0027m not even really sure what 1.9 is doing here\n\nit won\u0027t run as is under 2\n\"unsupported parameter for module: rc\"\n\nand after removing the rc line, I get a 0 return code in ansible1.9 and a 1 in ansible2 regardless of the directory put in for \u0027/var/lib/libvirt/qemu/save\u0027, it doesn\u0027t even have to exist","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"1d5cafc4ccf362fd93be10cf1389620b5ef0c5cc","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"},{"line_number":57,"context_line":"    rc: 1"},{"line_number":58,"context_line":"  register: qemu_savedir_empty"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# it counterintuitively seems that we need to make sure the return code is 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_542c3e4a","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":9},"in_reply_to":"9abb7d3a_ee03e30d","updated":"2016-05-27 18:01:00.000000000","message":"cmd is the command being run\nrc is the return code we expect for success\n\nthe \u0027success\u0027 in the case is exit code 1, though on second run this would return 0, which is fail...  so ya, this needs to be re-thought out.\n\nputting this behind a when statement would mean that the register may or may not actually be run.  This would cause the code further on to fail I think.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"d8778ff2258c5d6aa5c7857c29e522381466a402","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    state: absent"},{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_51e9f019","line":69,"range":{"start_line":69,"start_character":6,"end_line":69,"end_character":32},"updated":"2016-05-27 17:48:30.000000000","message":"check instead for\nqemu_savedir_empty.stdout_lines | length \u003d\u003d 0","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"6facc895ea3b4c49b974d63015e10fc6ed290504","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    state: absent"},{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_946d0607","line":69,"range":{"start_line":69,"start_character":6,"end_line":69,"end_character":32},"in_reply_to":"9abb7d3a_51e9f019","updated":"2016-05-27 18:16:49.000000000","message":"I think the return code is fine, if the path does not exist the return code is 2.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"00c410cc278658a9d28f0ea7bac96796d3279f9e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    state: absent"},{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_7fecbbc7","line":69,"range":{"start_line":69,"start_character":6,"end_line":69,"end_character":32},"in_reply_to":"9abb7d3a_946d0607","updated":"2016-05-27 18:52:48.000000000","message":"Can\u0027t seem to get anything other than a 0 with ansible 1.9.4\n\nchanged: [localhost] \u003d\u003e {\"changed\": true, \"cmd\": \"cmd\u003d\u0027[ \\\"$(ls -A /does/not/exist)\\\" ]\u0027\", \"delta\": \"0:00:00.005142\", \"end\": \"2016-05-27 11:28:53.905101\", \"rc\": 0, \"start\": \"2016-05-27 11:28:53.899959\", \"stderr\": \"\", \"stdout\": \"\", \"warnings\": []}","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2f093ba71a9e8161ec6af05b7ac4d918fb50a24d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_9d625ed7","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"updated":"2016-05-27 11:35:39.000000000","message":"This will always be actioned, regardless of whether the existing folder is empty or not. This should be conditional on whether the folder is empty.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"16942989337aba759dbaeb8d0b8163146fccb5e7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_a509f62e","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9abb7d3a_3f1d1374","updated":"2016-05-27 19:08:34.000000000","message":"I want it to fail.  Failure means the deployer needs to fix something (and this is something they should fix if this automated method doesn\u0027t work).","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"4402443db1c8ea9850f15cef0ecab33fdfadd297","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_45a00af5","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9abb7d3a_3f1d1374","updated":"2016-05-27 19:12:16.000000000","message":"more to the point though...  It WILL NOT attempt to create a symlink if the correct one already exists.  If it does then the file module is not being idempotent which would be a bug.  And again, I want it to fail if this part fails.  Otherwise it will be ignored.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"00c410cc278658a9d28f0ea7bac96796d3279f9e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_3f1d1374","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9abb7d3a_5f2617bb","updated":"2016-05-27 18:52:48.000000000","message":"My point was mainly just repeating what Jesse already said, this task will attempt to create the link regardless of whether a safe removal of the dir happened or not. \n\nIf the link is already created, that\u0027s perfectly fine for subsequent runs, but the run will fail if the dir exists and wasn\u0027t removed by either the previous task or possibly outside of the role.\n\nI could see this being an issue with any deployment attempting an upgrade, between even minor releases, if there are any files in /var/lib/libvirt/qemu/save.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"dc8dbf1d528175b20ed07d3243aa7a97d4a9c2b2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_fbdc4d1a","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9abb7d3a_9d625ed7","updated":"2016-05-27 14:03:53.000000000","message":"No, that\u0027s not the case, it\u0027ll try and fail if the path already exists, only removal is forced and recursive.  One of the test failures showed this.  As can be seen here.\n\nhttp://logs.openstack.org/24/320624/6/check/gate-openstack-ansible-os_nova-ansible-func-ubuntu-trusty/0394de3/console.html#_2016-05-26_17_51_16_207","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"d8778ff2258c5d6aa5c7857c29e522381466a402","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_d16de033","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9abb7d3a_b6c49c40","updated":"2016-05-27 17:48:30.000000000","message":"If this is attempted every time, it makes the checks for an empty dir kind of pointless.\n\nThink it should depend on either qemu_savedir_stat not existing in the first place, or the \u0027Remove qemu save dir\u0027 task being marked changed.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"6facc895ea3b4c49b974d63015e10fc6ed290504","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_5f2617bb","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9abb7d3a_d16de033","updated":"2016-05-27 18:16:49.000000000","message":"The check for empty dir is so we can do the removal of the dir safely.  Are we stating that the file operation in ansible is not idempotent?  That it will recreate the link even if it already exists?  If so, I wasn\u0027t aware I had to work around such a limitation.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"c100a1ec2bb5a512cc7c86bcc811c549a24f9289","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_b6c49c40","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9abb7d3a_f6b904ee","updated":"2016-05-27 14:12:19.000000000","message":"I thought we did, mainly because we want to ensure this happens.  Making it fail calls attention if it doesn\u0027t happen.","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7d3d22e5c1172f987e7f5614999417784b06e00f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":69,"context_line":"    - qemu_savedir_empty.rc \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":72,"context_line":"  file:"},{"line_number":73,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":74,"context_line":"    state: link"},{"line_number":75,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":76,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":77,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Install pip packages (venv)"},{"line_number":80,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_f6b904ee","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"9abb7d3a_fbdc4d1a","updated":"2016-05-27 14:09:47.000000000","message":"Hmm, I\u0027m not sure that we\u0027d want it to fail?","commit_id":"0e01a9869bd794ae1e55ebf4e6e3cbd5e524ab10"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"4045453f3f0ec52a3cf7478dd031fa66c94a9720","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":51,"context_line":"  register: qemu_savedir_stat"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_ea5586c6","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":46},"updated":"2016-05-27 22:17:10.000000000","message":"The ls command is returning 0 for me, empty directory or not.\n1 only when the directory doesn\u0027t exist.","commit_id":"507c3af533096e3efd1c8f81d79623e5266de1bd"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"18b24d77922f09dc36022ba1ea45e6f4c92bc5db","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":51,"context_line":"  register: qemu_savedir_stat"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_eafc6640","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":46},"in_reply_to":"9abb7d3a_ea5586c6","updated":"2016-05-27 23:03:04.000000000","message":"actully it\u0027s correct as shown below","commit_id":"507c3af533096e3efd1c8f81d79623e5266de1bd"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"4045453f3f0ec52a3cf7478dd031fa66c94a9720","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"},{"line_number":57,"context_line":"  register: qemu_savedir_empty"},{"line_number":58,"context_line":"  when: qemu_savedir_stat.stat.isdir"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_0ae28ad5","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":52},"updated":"2016-05-27 22:17:10.000000000","message":"What are the the wrapped brackets and parenthesis for?\n\nThis seems to work\nshell: ls -A /var/lib/libvirt/qemu/save\n\nand to determine it\u0027s empty\nqemu_savedir_empty.stdout_lines | length \u003d\u003d 0","commit_id":"507c3af533096e3efd1c8f81d79623e5266de1bd"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"18b24d77922f09dc36022ba1ea45e6f4c92bc5db","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"},{"line_number":57,"context_line":"  register: qemu_savedir_empty"},{"line_number":58,"context_line":"  when: qemu_savedir_stat.stat.isdir"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_0dbbc4c5","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":52},"in_reply_to":"9abb7d3a_0ae28ad5","updated":"2016-05-27 23:03:04.000000000","message":"exampledir is empty\n\n[ \"$(ls -A exampledir)\" ]\nexit code is 1\n\ntouch exampledir/foo\n[ \"$(ls -A exampledir)\" ]\nexit code is 0\n\nThe reason we can\u0027t use stdout_lines is because this the register for this task is not guaranteed to run (because this is behind a when statement).","commit_id":"507c3af533096e3efd1c8f81d79623e5266de1bd"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"e7c67a3b2d522ef83967320d93d902f47551601b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"},{"line_number":57,"context_line":"  register: qemu_savedir_empty"},{"line_number":58,"context_line":"  when: qemu_savedir_stat.stat.isdir"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Remove qemu save dir"},{"line_number":61,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_ad6d5834","line":58,"updated":"2016-05-27 23:15:58.000000000","message":"I\u0027m removing this when statement, we need to always know and register this check so we can use the variable later on.","commit_id":"507c3af533096e3efd1c8f81d79623e5266de1bd"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"4045453f3f0ec52a3cf7478dd031fa66c94a9720","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    state: absent"},{"line_number":64,"context_line":"  when:"},{"line_number":65,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":66,"context_line":"    - qemu_savedir_empty.changed \u003d\u003d True"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# We can just ensure the link exists here as ansible should be idempotent and"},{"line_number":69,"context_line":"#  the creation of a link in ansible will not occur if a file or directory"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_8a931aa3","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":40},"updated":"2016-05-27 22:17:10.000000000","message":"When will this not be true?","commit_id":"507c3af533096e3efd1c8f81d79623e5266de1bd"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"18b24d77922f09dc36022ba1ea45e6f4c92bc5db","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    state: absent"},{"line_number":64,"context_line":"  when:"},{"line_number":65,"context_line":"    - qemu_savedir_stat.stat.isdir"},{"line_number":66,"context_line":"    - qemu_savedir_empty.changed \u003d\u003d True"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# We can just ensure the link exists here as ansible should be idempotent and"},{"line_number":69,"context_line":"#  the creation of a link in ansible will not occur if a file or directory"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_4aedb28a","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":40},"in_reply_to":"9abb7d3a_8a931aa3","updated":"2016-05-27 23:03:04.000000000","message":"when qemu_savedir_stat.stat.isdir is false","commit_id":"507c3af533096e3efd1c8f81d79623e5266de1bd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"edae9a000605b472ea84634e253830420e3e8754","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":51,"context_line":"  register: qemu_savedir_stat"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9abb7d3a_9f3e6326","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":46},"updated":"2016-05-31 09:36:17.000000000","message":"If this is true, then the conditional in the task below is wrong.","commit_id":"27c41736957d240941a89b67ca9b397d18e30d2f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"edae9a000605b472ea84634e253830420e3e8754","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# this will return 1 if the directory is empty"},{"line_number":54,"context_line":"- name: Check if qemu save directory is empty"},{"line_number":55,"context_line":"  shell:"},{"line_number":56,"context_line":"    cmd: \u0027[ \"$(ls -A /var/lib/libvirt/qemu/save)\" ]\u0027"},{"line_number":57,"context_line":"  register: qemu_savedir_empty"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Remove qemu save dir"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9abb7d3a_7f10df59","line":56,"range":{"start_line":56,"start_character":9,"end_line":56,"end_character":52},"updated":"2016-05-31 09:36:17.000000000","message":"Thy not just simplify this to be:\n\nshell: ls -1A /var/lib/libvirt/qemu/save\nwhen: qemu_savedir_stat.isdir\n\nThis will only execute when that path is a directory, and will return the list of files in that directory which you can check the length of with qemu_savedir_empty.stdout_lines | length","commit_id":"27c41736957d240941a89b67ca9b397d18e30d2f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"edae9a000605b472ea84634e253830420e3e8754","unresolved":false,"context_lines":[{"line_number":67,"context_line":"# We can just ensure the link exists here as ansible should be idempotent and"},{"line_number":68,"context_line":"#  the creation of a link in ansible will not occur if a file or directory"},{"line_number":69,"context_line":"#  exists."},{"line_number":70,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":71,"context_line":"  file:"},{"line_number":72,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":73,"context_line":"    state: link"},{"line_number":74,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":75,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":76,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Install pip packages (venv)"},{"line_number":79,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9abb7d3a_22892076","line":76,"range":{"start_line":70,"start_character":0,"end_line":76,"end_character":39},"updated":"2016-05-31 09:36:17.000000000","message":"If you force this and make it conditional on when:\n - qemu_savedir_empty is defined\n - qemu_savedir_empty.stdout_lines | length \u003d\u003d 0\n\nThen the \u0027Remove qemu save dir\u0027 task can be removed and there will be no danger of this happening unexpectedly as far as I can tell.","commit_id":"27c41736957d240941a89b67ca9b397d18e30d2f"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d6a2297d1a1fd41825debe2569226da92bf4d18d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"# We can just ensure the link exists here as ansible should be idempotent and"},{"line_number":68,"context_line":"#  the creation of a link in ansible will not occur if a file or directory"},{"line_number":69,"context_line":"#  exists."},{"line_number":70,"context_line":"- name: Symlink qemu save dir to nova_libvirt_save_path"},{"line_number":71,"context_line":"  file:"},{"line_number":72,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":73,"context_line":"    state: link"},{"line_number":74,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":75,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":76,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Install pip packages (venv)"},{"line_number":79,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9abb7d3a_2b4d74c4","line":76,"range":{"start_line":70,"start_character":0,"end_line":76,"end_character":39},"in_reply_to":"9abb7d3a_22892076","updated":"2016-05-31 11:46:23.000000000","message":"ya, was actually going to do that in the next review.  However, I DO need \u0027Check if qemu save directory is empty\u0027 to always run if I am to use a variable it registers.  This is why I can\u0027t have a when on it.  And ya, just found a reason I need to change to stdout_lines, if the directory/file does not exist the test as it is now will still exit one.","commit_id":"27c41736957d240941a89b67ca9b397d18e30d2f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f0b987b08490fb04b24cb41fa09082879bf70d2b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":66,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":67,"context_line":"    force: True"},{"line_number":68,"context_line":"    when:"},{"line_number":69,"context_line":"      - qemu_savedir_stat.stat.isdir"},{"line_number":70,"context_line":"      - qemu_savedir_empty.stdout_lines \u003d\u003d 0"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Install pip packages (venv)"},{"line_number":73,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9abb7d3a_9ef13c04","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":44},"updated":"2016-05-31 11:45:31.000000000","message":"This needs to be in line with \u0027file:\u0027 and \u0027name:\u0027","commit_id":"a9ce722bb66eefdf77098b0e72e29e87e77708b3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f0b987b08490fb04b24cb41fa09082879bf70d2b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    force: True"},{"line_number":68,"context_line":"    when:"},{"line_number":69,"context_line":"      - qemu_savedir_stat.stat.isdir"},{"line_number":70,"context_line":"      - qemu_savedir_empty.stdout_lines \u003d\u003d 0"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Install pip packages (venv)"},{"line_number":73,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9abb7d3a_fe67a8b4","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":39},"updated":"2016-05-31 11:45:31.000000000","message":"qemu_savedir_empty.stdout_lines | length \u003d\u003d 0","commit_id":"a9ce722bb66eefdf77098b0e72e29e87e77708b3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cea7e15c0b0c61ae04cbca38cf15b33be96fb9c4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  file:"},{"line_number":62,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":63,"context_line":"    state: link"},{"line_number":64,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":65,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":66,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":67,"context_line":"    force: True"},{"line_number":68,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9abb7d3a_17708a0a","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":41},"updated":"2016-05-31 13:43:13.000000000","message":"This changes the user:group from libvirt-qemu:kvm to nova:nova on the link, while the /var/lib/nova/save folder stays as libvirt-qemu:kvm.\n\nDoes that cause any problems with the function that uses this folder?","commit_id":"7a3da5408126b3b73063fffcbaff36f6ceb17e04"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"c31a86f6f290b99fec353e1635a0822d7f24d0f5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  file:"},{"line_number":62,"context_line":"    path: \"/var/lib/libvirt/qemu/save\""},{"line_number":63,"context_line":"    state: link"},{"line_number":64,"context_line":"    owner: \"{{ nova_system_user_name }}\""},{"line_number":65,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":66,"context_line":"    src: \"{{ nova_libvirt_save_path }}\""},{"line_number":67,"context_line":"    force: True"},{"line_number":68,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9abb7d3a_dafc6774","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":41},"in_reply_to":"9abb7d3a_17708a0a","updated":"2016-05-31 13:53:45.000000000","message":"yes, made a tunable that\u0027s separate to fix it.","commit_id":"7a3da5408126b3b73063fffcbaff36f6ceb17e04"}],"tasks/nova_pre_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e8a270356bc6c515b421d7351c6833030bbe9209","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - { path: \"{{ nova_system_home_folder }}/.ssh\", mode: \"0700\" }"},{"line_number":69,"context_line":"    - { path: \"{{ nova_system_home_folder }}/cache/api\" }"},{"line_number":70,"context_line":"    - { path: \"{{ nova_system_home_folder }}/instances\" }"},{"line_number":71,"context_line":"    - { path: \"{{ nova_libvirt_save_path }}\" }"},{"line_number":72,"context_line":"    - { path: \"/var/lock/nova\" }"},{"line_number":73,"context_line":"    - { path: \"/var/run/nova\" }"},{"line_number":74,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_b58a8d18","line":71,"updated":"2016-05-25 09:47:11.000000000","message":"shouldn\u0027t be important to set the mode here, because of the sensitivity of this transient info?\nLike at least o-r.","commit_id":"dff23904b41c2c82d250c405aa8f2bd8edcf545b"}]}
