)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3177511eb978504ad13440080e2cc315b9c8e299","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is \u0027powervm\u0027. Otherwise it impacts nova serivce to start on"},{"line_number":11,"context_line":"ppc64le platform. Create nova_powervm symbolic link to"},{"line_number":12,"context_line":"nova.virt.nova_powervm module. Because nova adds \u0027nova.virt\u0027"},{"line_number":13,"context_line":"prefix to import compute dirver object. Thus nova_powervm module"},{"line_number":14,"context_line":"should be under nova.virt module."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I479ff18d15097738eb6671d3cdbe66e6ef66cd31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_9c951fe6","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":31},"updated":"2016-06-22 12:13:49.000000000","message":"*driver","commit_id":"e158d8317106e8face121c68e8247af89f27990d"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3177511eb978504ad13440080e2cc315b9c8e299","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Qing Wu Wang \u003cwangqwsh@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-22 04:05:34 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable Libvirt in nova.conf. Add nova_powervm module in nova.virt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Delete Libvirt configurations in nova.conf if the nova_virt_type"},{"line_number":10,"context_line":"is \u0027powervm\u0027. Otherwise it impacts nova serivce to start on"},{"line_number":11,"context_line":"ppc64le platform. Create nova_powervm symbolic link to"},{"line_number":12,"context_line":"nova.virt.nova_powervm module. Because nova adds \u0027nova.virt\u0027"},{"line_number":13,"context_line":"prefix to import compute dirver object. Thus nova_powervm module"},{"line_number":14,"context_line":"should be under nova.virt module."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I479ff18d15097738eb6671d3cdbe66e6ef66cd31"},{"line_number":17,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_fcff0332","line":14,"range":{"start_line":7,"start_character":0,"end_line":14,"end_character":33},"updated":"2016-06-22 12:13:49.000000000","message":"Personally not a huge fan of this message.  :-)\n\nI\u0027d say its more along the lines of \u0027omitting the libvirt configuration in the nova compute driver if you aren\u0027t using the libvirt driver\u0027.","commit_id":"e158d8317106e8face121c68e8247af89f27990d"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"7426ea06921bba23797c75d70a973dcf490d795d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Qing Wu Wang \u003cwangqwsh@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-22 04:05:34 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable Libvirt in nova.conf. Add nova_powervm module in nova.virt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Delete Libvirt configurations in nova.conf if the nova_virt_type"},{"line_number":10,"context_line":"is \u0027powervm\u0027. Otherwise it impacts nova serivce to start on"},{"line_number":11,"context_line":"ppc64le platform. Create nova_powervm symbolic link to"},{"line_number":12,"context_line":"nova.virt.nova_powervm module. Because nova adds \u0027nova.virt\u0027"},{"line_number":13,"context_line":"prefix to import compute dirver object. Thus nova_powervm module"},{"line_number":14,"context_line":"should be under nova.virt module."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I479ff18d15097738eb6671d3cdbe66e6ef66cd31"},{"line_number":17,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_988fddcb","line":14,"range":{"start_line":7,"start_character":0,"end_line":14,"end_character":33},"in_reply_to":"3aaa91ec_fcff0332","updated":"2016-06-22 16:04:17.000000000","message":"refine it in the next patchset","commit_id":"e158d8317106e8face121c68e8247af89f27990d"}],"tasks/nova_compute_powervm_install.yml":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3177511eb978504ad13440080e2cc315b9c8e299","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    - nova-install"},{"line_number":124,"context_line":"    - nova-pip-packages"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"- name: Register nova module path (no venv)"},{"line_number":127,"context_line":"  command: python -c \u0027import nova; print nova.__file__\u0027"},{"line_number":128,"context_line":"  register: nova_module_path"},{"line_number":129,"context_line":"  when:"},{"line_number":130,"context_line":"    - not nova_venv_enabled | bool"},{"line_number":131,"context_line":"  tags:"},{"line_number":132,"context_line":"    - nova-powervm-libs"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Register nova_powervm module path (no venv)"},{"line_number":135,"context_line":"  command: python -c \u0027import nova_powervm; print nova_powervm.__file__\u0027"},{"line_number":136,"context_line":"  register: nova_powervm_module_path"},{"line_number":137,"context_line":"  when:"},{"line_number":138,"context_line":"    - not nova_venv_enabled | bool"},{"line_number":139,"context_line":"  tags:"},{"line_number":140,"context_line":"    - nova-powervm-libs"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- name: Link nova_powervm module into the nova virt (no venv)"},{"line_number":143,"context_line":"  file:"},{"line_number":144,"context_line":"    src: \"{{ nova_powervm_module_path.stdout | dirname }}\""},{"line_number":145,"context_line":"    dest: \"{{ nova_module_path.stdout | dirname }}/virt/nova_powervm\""},{"line_number":146,"context_line":"    state: link"},{"line_number":147,"context_line":"    force: \"yes\""},{"line_number":148,"context_line":"  when:"},{"line_number":149,"context_line":"    - not nova_venv_enabled | bool"},{"line_number":150,"context_line":"  tags:"},{"line_number":151,"context_line":"    - nova-powervm-libs"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"- name: Link nova_powervm module into the nova virt (venv)"},{"line_number":154,"context_line":"  file:"},{"line_number":155,"context_line":"    src: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova_powervm\""},{"line_number":156,"context_line":"    dest: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova/virt/nova_powervm\""},{"line_number":157,"context_line":"    state: link"},{"line_number":158,"context_line":"    force: \"yes\""},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - nova_venv_enabled | bool"},{"line_number":161,"context_line":"  tags:"},{"line_number":162,"context_line":"    - nova-powervm-libs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3aaa91ec_5c59f759","line":162,"range":{"start_line":126,"start_character":0,"end_line":162,"end_character":23},"updated":"2016-06-22 12:13:49.000000000","message":"I\u0027m not sure why you need to do this?\n\nWe should have code in nova_powervm to do this.  Eric Fried worked on this.\n\nSpecifically these bits:  https://github.com/openstack/nova-powervm/blob/master/nova/virt/powervm/driver.py\n\n\nIs this something that perhaps we need to port back to Mitaka?","commit_id":"e158d8317106e8face121c68e8247af89f27990d"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"21a59a53ebc06a6965a247162fd88bf1dbea8faf","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    - nova-install"},{"line_number":124,"context_line":"    - nova-pip-packages"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"- name: Register nova module path (no venv)"},{"line_number":127,"context_line":"  command: python -c \u0027import nova; print nova.__file__\u0027"},{"line_number":128,"context_line":"  register: nova_module_path"},{"line_number":129,"context_line":"  when:"},{"line_number":130,"context_line":"    - not nova_venv_enabled | bool"},{"line_number":131,"context_line":"  tags:"},{"line_number":132,"context_line":"    - nova-powervm-libs"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Register nova_powervm module path (no venv)"},{"line_number":135,"context_line":"  command: python -c \u0027import nova_powervm; print nova_powervm.__file__\u0027"},{"line_number":136,"context_line":"  register: nova_powervm_module_path"},{"line_number":137,"context_line":"  when:"},{"line_number":138,"context_line":"    - not nova_venv_enabled | bool"},{"line_number":139,"context_line":"  tags:"},{"line_number":140,"context_line":"    - nova-powervm-libs"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- name: Link nova_powervm module into the nova virt (no venv)"},{"line_number":143,"context_line":"  file:"},{"line_number":144,"context_line":"    src: \"{{ nova_powervm_module_path.stdout | dirname }}\""},{"line_number":145,"context_line":"    dest: \"{{ nova_module_path.stdout | dirname }}/virt/nova_powervm\""},{"line_number":146,"context_line":"    state: link"},{"line_number":147,"context_line":"    force: \"yes\""},{"line_number":148,"context_line":"  when:"},{"line_number":149,"context_line":"    - not nova_venv_enabled | bool"},{"line_number":150,"context_line":"  tags:"},{"line_number":151,"context_line":"    - nova-powervm-libs"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"- name: Link nova_powervm module into the nova virt (venv)"},{"line_number":154,"context_line":"  file:"},{"line_number":155,"context_line":"    src: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova_powervm\""},{"line_number":156,"context_line":"    dest: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova/virt/nova_powervm\""},{"line_number":157,"context_line":"    state: link"},{"line_number":158,"context_line":"    force: \"yes\""},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - nova_venv_enabled | bool"},{"line_number":161,"context_line":"  tags:"},{"line_number":162,"context_line":"    - nova-powervm-libs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3aaa91ec_8f45b218","line":162,"range":{"start_line":126,"start_character":0,"end_line":162,"end_character":23},"in_reply_to":"3aaa91ec_5c59f759","updated":"2016-06-23 08:19:21.000000000","message":"As discussed in IRC, the nova-powervm change for this does not work.\nI use the latest nova-powervm for deployment.","commit_id":"e158d8317106e8face121c68e8247af89f27990d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"154fb5488d2051dd950777b0c3a006380132449b","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- name: Link nova_powervm module into the nova virt (no venv)"},{"line_number":143,"context_line":"  file:"},{"line_number":144,"context_line":"    src: \"{{ nova_powervm_module_path.stdout | dirname }}\""},{"line_number":145,"context_line":"    dest: \"{{ nova_module_path.stdout | dirname }}/virt/nova_powervm\""},{"line_number":146,"context_line":"    state: link"},{"line_number":147,"context_line":"    force: \"yes\""},{"line_number":148,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_180e82e5","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":69},"updated":"2016-06-27 15:45:29.000000000","message":"This doesn\u0027t seem right.\n\nI assume the idea is to wind up with a symlink like:\n\n .../nova/virt/powervm \u003d\u003e .../nova-powervm/nova/virt/powervm\n\nIn which case perhaps the above needs to look more like:\n\n    src: \"{{ nova_powervm_module_path.stdout | dirname }}/virt/powervm\"\n    dest: \"{{ nova_module_path.stdout | dirname }}/virt/powervm\"","commit_id":"96d10cd2e4076b7f2ab4acd2aee63a50b4aa22b9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"154fb5488d2051dd950777b0c3a006380132449b","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"- name: Link nova_powervm module into the nova virt (venv)"},{"line_number":154,"context_line":"  file:"},{"line_number":155,"context_line":"    src: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova_powervm\""},{"line_number":156,"context_line":"    dest: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova/virt/nova_powervm\""},{"line_number":157,"context_line":"    state: link"},{"line_number":158,"context_line":"    force: \"yes\""},{"line_number":159,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_78ffc6aa","line":156,"range":{"start_line":155,"start_character":0,"end_line":156,"end_character":92},"updated":"2016-06-27 15:45:29.000000000","message":"Same as above.  Also, is it site-packages or dist-packages?","commit_id":"96d10cd2e4076b7f2ab4acd2aee63a50b4aa22b9"},{"author":{"_account_id":9485,"name":"Jerry Cai","email":"caimin@cn.ibm.com","username":"jerrycai"},"change_message_id":"de46c10b3fdcd46ea1e5b99bc0ac8efc2e5babfb","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"- name: Link nova_powervm module into the nova virt (venv)"},{"line_number":154,"context_line":"  file:"},{"line_number":155,"context_line":"    src: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova_powervm\""},{"line_number":156,"context_line":"    dest: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova/virt/nova_powervm\""},{"line_number":157,"context_line":"    state: link"},{"line_number":158,"context_line":"    force: \"yes\""},{"line_number":159,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_6de611b1","line":156,"range":{"start_line":155,"start_character":0,"end_line":156,"end_character":92},"in_reply_to":"3aaa91ec_78ffc6aa","updated":"2016-07-01 04:29:40.000000000","message":"it might be site-packages, fixed in latest patch.","commit_id":"96d10cd2e4076b7f2ab4acd2aee63a50b4aa22b9"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3d42e36001e9f03f268154d2a3786b37760f5280","unresolved":false,"context_lines":[{"line_number":142,"context_line":"- name: Link nova_powervm module into the nova virt (no venv)"},{"line_number":143,"context_line":"  file:"},{"line_number":144,"context_line":"    src: \"{{ nova_powervm_module_path.stdout | dirname }}/virt/powervm\""},{"line_number":145,"context_line":"    dest: \"{{ nova_module_path.stdout | dirname }}/virt/nova_powervm\""},{"line_number":146,"context_line":"    state: link"},{"line_number":147,"context_line":"    force: \"yes\""},{"line_number":148,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_f0037540","line":145,"range":{"start_line":145,"start_character":56,"end_line":145,"end_character":68},"updated":"2016-07-05 14:45:56.000000000","message":"I think the dest is supposed to just be powervm.  Not nova_powervm.","commit_id":"0bb4fe7ed64c0bbebf2e765c9c3923e65242eb4c"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3d42e36001e9f03f268154d2a3786b37760f5280","unresolved":false,"context_lines":[{"line_number":153,"context_line":"- name: Link nova_powervm module into the nova virt (venv)"},{"line_number":154,"context_line":"  file:"},{"line_number":155,"context_line":"    src: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova_powervm/virt/powervm\""},{"line_number":156,"context_line":"    dest: \"{{ nova_venv_bin | dirname }}/lib/python2.7/site-packages/nova/virt/nova_powervm\""},{"line_number":157,"context_line":"    state: link"},{"line_number":158,"context_line":"    force: \"yes\""},{"line_number":159,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_70ef8587","line":156,"range":{"start_line":156,"start_character":79,"end_line":156,"end_character":91},"updated":"2016-07-05 14:45:56.000000000","message":"I think the dest is supposed to just be powervm.","commit_id":"0bb4fe7ed64c0bbebf2e765c9c3923e65242eb4c"}],"templates/nova.conf.j2":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3177511eb978504ad13440080e2cc315b9c8e299","unresolved":false,"context_lines":[{"line_number":253,"context_line":"api_endpoint \u003d {{ ironic_service_adminurl }}"},{"line_number":254,"context_line":"{% endif %}"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"{% if nova_virt_type !\u003d \u0027powervm\u0027 %}"},{"line_number":257,"context_line":"[libvirt]"},{"line_number":258,"context_line":"inject_partition \u003d {{ nova_libvirt_inject_partition }}"},{"line_number":259,"context_line":"inject_password \u003d {{ nova_libvirt_inject_password }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3aaa91ec_1cf92f81","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":36},"updated":"2016-06-22 12:13:49.000000000","message":"Rather than saying is not powervm....isn\u0027t this more specific to libvirt?  And therefore we could we say \"if nova_virt_type \u003d\u003d \u0027libvirt\u0027\"?","commit_id":"e158d8317106e8face121c68e8247af89f27990d"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"7426ea06921bba23797c75d70a973dcf490d795d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"api_endpoint \u003d {{ ironic_service_adminurl }}"},{"line_number":254,"context_line":"{% endif %}"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"{% if nova_virt_type !\u003d \u0027powervm\u0027 %}"},{"line_number":257,"context_line":"[libvirt]"},{"line_number":258,"context_line":"inject_partition \u003d {{ nova_libvirt_inject_partition }}"},{"line_number":259,"context_line":"inject_password \u003d {{ nova_libvirt_inject_password }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3aaa91ec_18e12dff","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":36},"in_reply_to":"3aaa91ec_1cf92f81","updated":"2016-06-22 16:04:17.000000000","message":"need to specify \u0027kvm\u0027, \u0027qeum\u0027 and \u0027xen\u0027 here for libvirt","commit_id":"e158d8317106e8face121c68e8247af89f27990d"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"297f21868ea534fa240e135db490a3e27a772abf","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"## Vif"},{"line_number":105,"context_line":"linuxnet_interface_driver \u003d {{ nova_linuxnet_interface_driver }}"},{"line_number":106,"context_line":"{% if nova_virt_type \u003d\u003d \u0027kvm\u0027 or nova_virt_type \u003d\u003d \u0027qemu\u0027 or nova_virt_type \u003d\u003d \u0027xen\u0027 %}"},{"line_number":107,"context_line":"libvirt_vif_type \u003d ethernet"},{"line_number":108,"context_line":"{% endif %}"},{"line_number":109,"context_line":"vif_plugging_timeout \u003d 10"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3aaa91ec_790ba22a","line":106,"updated":"2016-06-24 13:03:52.000000000","message":"You could simplify this: {% if nova_virt_type in [\u0027kvm, \u0027qemu\u0027, \u0027xen\u0027] %}","commit_id":"96d10cd2e4076b7f2ab4acd2aee63a50b4aa22b9"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"297f21868ea534fa240e135db490a3e27a772abf","unresolved":false,"context_lines":[{"line_number":253,"context_line":"api_endpoint \u003d {{ ironic_service_adminurl }}"},{"line_number":254,"context_line":"{% endif %}"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"{% if nova_virt_type \u003d\u003d \u0027kvm\u0027 or nova_virt_type \u003d\u003d \u0027qemu\u0027 or nova_virt_type \u003d\u003d \u0027xen\u0027 %}"},{"line_number":257,"context_line":"[libvirt]"},{"line_number":258,"context_line":"inject_partition \u003d {{ nova_libvirt_inject_partition }}"},{"line_number":259,"context_line":"inject_password \u003d {{ nova_libvirt_inject_password }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3aaa91ec_d9045619","line":256,"updated":"2016-06-24 13:03:52.000000000","message":"See the note above about simplifying.","commit_id":"96d10cd2e4076b7f2ab4acd2aee63a50b4aa22b9"}]}
