)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0fb6d981868781d8e555c2deaf800e5a88ba7668","unresolved":false,"context_lines":[{"line_number":377,"context_line":"  - nova"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"nova_compute_lxd_pip_packages:"},{"line_number":380,"context_line":"  - pyOpenSSL"},{"line_number":381,"context_line":"  - pylxd"},{"line_number":382,"context_line":"  - nova-lxd"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dada55a8_ea49b1b8","line":380,"range":{"start_line":380,"start_character":2,"end_line":380,"end_character":13},"updated":"2016-07-25 21:00:25.000000000","message":"It would seem that this is one of the requirements, so you shouldn\u0027t have to list this. https://github.com/openstack/nova-lxd/blob/master/requirements.txt#L14","commit_id":"b2da172f318db83fb195c1a1861cd522d3ed4e91"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":377,"context_line":"nova_api_paste_ini_overrides: {}"},{"line_number":378,"context_line":"nova_policy_overrides: {}"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":381,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_44e6a844","side":"PARENT","line":381,"range":{"start_line":380,"start_character":0,"end_line":381,"end_character":16},"updated":"2016-07-27 03:13:01.000000000","message":"Not sure what happend here.  Will readd.","commit_id":"601c49bdeb5bf74afb9c23c05ec6c8a51838d55d"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"0dc13cf00aa26f68a280862ad6c1ab97031d8133","unresolved":false,"context_lines":[{"line_number":377,"context_line":"nova_api_paste_ini_overrides: {}"},{"line_number":378,"context_line":"nova_policy_overrides: {}"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":381,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_121360b9","side":"PARENT","line":381,"range":{"start_line":380,"start_character":0,"end_line":381,"end_character":16},"updated":"2016-07-26 22:08:02.000000000","message":"Why was this removed? Did you mean to move it elsewhere?","commit_id":"601c49bdeb5bf74afb9c23c05ec6c8a51838d55d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8feeccf3ef5ff8995f6c1e7ef96e9f8b37de30d6","unresolved":false,"context_lines":[{"line_number":377,"context_line":"nova_api_paste_ini_overrides: {}"},{"line_number":378,"context_line":"nova_policy_overrides: {}"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"nova_compute_powervm_pip_packages:"},{"line_number":381,"context_line":"  - nova-powervm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_421d0161","side":"PARENT","line":381,"range":{"start_line":380,"start_character":0,"end_line":381,"end_character":16},"in_reply_to":"dada55a8_121360b9","updated":"2016-07-26 22:45:28.000000000","message":"I don\u0027t think this was intended to be removed.","commit_id":"601c49bdeb5bf74afb9c23c05ec6c8a51838d55d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    nova_firewall_driver: nova.virt.firewall.NoopFirewallDriver"},{"line_number":114,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":115,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":116,"context_line":"  lxc:"},{"line_number":117,"context_line":"    nova_compute_driver: lxd.LXDDriver"},{"line_number":118,"context_line":"    nova_scheduler_host_manager: host_manager"},{"line_number":119,"context_line":"    nova_reserved_host_memory_mb: 2048"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_2fb8b674","line":116,"range":{"start_line":116,"start_character":2,"end_line":116,"end_character":5},"updated":"2016-07-26 22:44:33.000000000","message":"should this be \"lxd\"?","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"0dc13cf00aa26f68a280862ad6c1ab97031d8133","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":139,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Current supported choice: qemu or kvm or lxc or ironic or powervm"},{"line_number":142,"context_line":"# If this is not set, then the playbook will try to guess it."},{"line_number":143,"context_line":"#nova_virt_type: kvm"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_9240f0a6","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":67},"updated":"2016-07-26 22:08:02.000000000","message":"Are we getting to the point where we should just make this a list? E.g. qemu, kvm, lxc, ironic, powervm","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":139,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Current supported choice: qemu or kvm or lxc or ironic or powervm"},{"line_number":142,"context_line":"# If this is not set, then the playbook will try to guess it."},{"line_number":143,"context_line":"#nova_virt_type: kvm"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_6fae2e2f","line":141,"range":{"start_line":141,"start_character":43,"end_line":141,"end_character":46},"updated":"2016-07-26 22:44:33.000000000","message":"Should this be \"lxd\"?","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":139,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Current supported choice: qemu or kvm or lxc or ironic or powervm"},{"line_number":142,"context_line":"# If this is not set, then the playbook will try to guess it."},{"line_number":143,"context_line":"#nova_virt_type: kvm"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_c4c8d8aa","line":141,"range":{"start_line":141,"start_character":43,"end_line":141,"end_character":46},"in_reply_to":"dada55a8_6fae2e2f","updated":"2016-07-27 03:13:01.000000000","message":"lxc is correct, see other comments.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":139,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Current supported choice: qemu or kvm or lxc or ironic or powervm"},{"line_number":142,"context_line":"# If this is not set, then the playbook will try to guess it."},{"line_number":143,"context_line":"#nova_virt_type: kvm"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_cf2c7aae","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":67},"in_reply_to":"dada55a8_9240f0a6","updated":"2016-07-26 22:44:33.000000000","message":"+1 I think it may be worth while to building this into a list or simply noting that that \"nova_virt_types\" are the supported options. We could then have a fail early task which checks if the virt type is actually being set correctly.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":139,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Current supported choice: qemu or kvm or lxc or ironic or powervm"},{"line_number":142,"context_line":"# If this is not set, then the playbook will try to guess it."},{"line_number":143,"context_line":"#nova_virt_type: kvm"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_e4c19c81","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":67},"in_reply_to":"dada55a8_9240f0a6","updated":"2016-07-27 03:13:01.000000000","message":"Good idea.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    nova_scheduler_use_baremetal_filters: False"},{"line_number":139,"context_line":"    nova_scheduler_tracks_instance_changes: True"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Current supported choice: qemu or kvm or lxc or ironic or powervm"},{"line_number":142,"context_line":"# If this is not set, then the playbook will try to guess it."},{"line_number":143,"context_line":"#nova_virt_type: kvm"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_64d5ac41","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":67},"in_reply_to":"dada55a8_cf2c7aae","updated":"2016-07-27 03:13:01.000000000","message":"I think that\u0027s a good suggestion.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"08a420426507c1d3f44cca60e744c7067354c783","unresolved":false,"context_lines":[{"line_number":29,"context_line":"nova_requirements_git_install_branch: master"},{"line_number":30,"context_line":"nova_developer_mode: false"},{"line_number":31,"context_line":"nova_developer_constraints:"},{"line_number":32,"context_line":"  - \"git+{{ nova_git_repo }}@{{ nova_git_install_branch }}#egg\u003dnova\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Name of the virtual env to deploy into"},{"line_number":35,"context_line":"nova_venv_tag: untagged"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9ad45d7e_4c030a74","line":32,"updated":"2016-08-08 21:58:23.000000000","message":"Please add the git repo bits from https://review.openstack.org/#/c/350226/16/defaults/main.yml to finalise this patch.","commit_id":"7bf20f0190e93a0d8c0a4bbd2a16789af125c32d"}],"releasenotes/notes/add-nova-lxd-f094438e4bf36d52.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7be57ce93250498f86d3a07dfd5eea6efe64c5a1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The os_nova role can now deploy the nova-lxd hypervisor."},{"line_number":4,"context_line":"    This can be achieved by setting ``nova_virt_type`` to"},{"line_number":5,"context_line":"    ``lxc`` in host_vars."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bacf61ea_cb9eb306","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":24},"updated":"2016-08-03 09:39:43.000000000","message":"on a per-host basis in ``openstack_user_config.yml`` or on a global basis in ``user_variables.yml``.","commit_id":"7d91c419699152d360e85e1355a57b101e9cc00d"}],"tasks/main.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"784d6f34ca957991f8d86043f129443cd8bc15c2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - always"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- fail: msg\u003d\"Supported Virt Type Provided: {{ nova_supported_virt_types }}\""},{"line_number":41,"context_line":"  when:"},{"line_number":42,"context_line":"    - nova_virt_type is defined"},{"line_number":43,"context_line":"    - nova_virt_type not in nova_supported_virt_types"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_8e698d8e","line":40,"updated":"2016-07-27 20:19:18.000000000","message":"This should be \"Unsupported\"","commit_id":"5d6c506b05fe6a02547afec96d81aeb100b830ab"}],"tasks/nova_compute.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  when: nova_virt_type \u003d\u003d \u0027powervm\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include: nova_compute_lxd.yml"},{"line_number":23,"context_line":"  when: nova_virt_type \u003d\u003d \u0027lxc\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- include: nova_compute_key_populate.yml"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_cf90faef","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":30},"updated":"2016-07-26 22:44:33.000000000","message":"should this be \"lxd\"?","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  when: nova_virt_type \u003d\u003d \u0027powervm\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include: nova_compute_lxd.yml"},{"line_number":23,"context_line":"  when: nova_virt_type \u003d\u003d \u0027lxc\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- include: nova_compute_key_populate.yml"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_643c8c93","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":30},"in_reply_to":"dada55a8_cf90faef","updated":"2016-07-27 03:13:01.000000000","message":"See other comments.  lxc is correct.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"}],"tasks/nova_compute_lxd.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"9f26e13779e72d1a10c2103148ecb62844be0ab8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - nova-lxd"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Configure lxd init"},{"line_number":27,"context_line":"  shell: \"/usr/bin/lxd init \\"},{"line_number":28,"context_line":"          --auto \\"},{"line_number":29,"context_line":"          --network-address\u003d{{ lxd_bind_address }} \\"},{"line_number":30,"context_line":"          --network-port\u003d{{ lxd_bind_port }} \\"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_06884670","line":27,"updated":"2016-07-26 19:02:21.000000000","message":"Should this only be run when one of the previous install tasks is changed? Would like this to be idempotent is possible and not report as a changed task if not absolutely necessary.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - nova-lxd"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Configure lxd init"},{"line_number":27,"context_line":"  shell: \"/usr/bin/lxd init \\"},{"line_number":28,"context_line":"          --auto \\"},{"line_number":29,"context_line":"          --network-address\u003d{{ lxd_bind_address }} \\"},{"line_number":30,"context_line":"          --network-port\u003d{{ lxd_bind_port }} \\"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_0475d062","line":27,"in_reply_to":"dada55a8_06884670","updated":"2016-07-27 03:13:01.000000000","message":"Good idea.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - nova-lxd"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Configure lxd init"},{"line_number":27,"context_line":"  shell: \"/usr/bin/lxd init \\"},{"line_number":28,"context_line":"          --auto \\"},{"line_number":29,"context_line":"          --network-address\u003d{{ lxd_bind_address }} \\"},{"line_number":30,"context_line":"          --network-port\u003d{{ lxd_bind_port }} \\"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_8f8a82bd","line":27,"in_reply_to":"dada55a8_06884670","updated":"2016-07-26 22:44:33.000000000","message":"Maybe this init task can be run when there\u0027s no detected running LXD process from the registered output from a previous task?","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - nova-lxd"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Configure lxd init"},{"line_number":27,"context_line":"  shell: \"/usr/bin/lxd init \\"},{"line_number":28,"context_line":"          --auto \\"},{"line_number":29,"context_line":"          --network-address\u003d{{ lxd_bind_address }} \\"},{"line_number":30,"context_line":"          --network-port\u003d{{ lxd_bind_port }} \\"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_640accd3","line":27,"in_reply_to":"dada55a8_8f8a82bd","updated":"2016-07-27 03:13:01.000000000","message":"This is not actually starting up the process like an init script.  This is how you set the configuration variables for this software instead of using a text file.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"784d6f34ca957991f8d86043f129443cd8bc15c2","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Configure lxd init"},{"line_number":38,"context_line":"  command: \"{{ nova_system_home_folder }}/lxd-init.sh\""},{"line_number":39,"context_line":"  when: lxd_init_script.changed"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    - nova-lxd"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_ee2be931","line":39,"updated":"2016-07-27 20:19:18.000000000","message":"De facto standard in the roles now is \u0027lxc_init_script | changed\u0027","commit_id":"5d6c506b05fe6a02547afec96d81aeb100b830ab"}],"tasks/nova_compute_lxd_install.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  delay: 2"},{"line_number":46,"context_line":"  with_items: \"{{ nova_compute_lxd_pip_packages }}\""},{"line_number":47,"context_line":"  when:"},{"line_number":48,"context_line":"    - nova_venv_enabled | bool"},{"line_number":49,"context_line":"    - nova_get_venv | failed or nova_developer_mode | bool"},{"line_number":50,"context_line":"  tags:"},{"line_number":51,"context_line":"    - nova-install"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_4fceca2d","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":30},"updated":"2016-07-26 22:44:33.000000000","message":"venv is the only option so i think this can be removed.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  delay: 2"},{"line_number":46,"context_line":"  with_items: \"{{ nova_compute_lxd_pip_packages }}\""},{"line_number":47,"context_line":"  when:"},{"line_number":48,"context_line":"    - nova_venv_enabled | bool"},{"line_number":49,"context_line":"    - nova_get_venv | failed or nova_developer_mode | bool"},{"line_number":50,"context_line":"  tags:"},{"line_number":51,"context_line":"    - nova-install"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_24fd74b1","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":30},"in_reply_to":"dada55a8_4fceca2d","updated":"2016-07-27 03:13:01.000000000","message":"Will do.  I just saw those changes elsewhere.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"9f26e13779e72d1a10c2103148ecb62844be0ab8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    - nova-install"},{"line_number":70,"context_line":"    - nova-pip-packages"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Install pip packages (no venv)"},{"line_number":73,"context_line":"  pip:"},{"line_number":74,"context_line":"    name: \"{{ item }}\""},{"line_number":75,"context_line":"    state: latest"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_06efa61e","line":72,"updated":"2016-07-26 19:02:21.000000000","message":"Should probably remove the non-venv install tasks","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    - nova-install"},{"line_number":70,"context_line":"    - nova-pip-packages"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Install pip packages (no venv)"},{"line_number":73,"context_line":"  pip:"},{"line_number":74,"context_line":"    name: \"{{ item }}\""},{"line_number":75,"context_line":"    state: latest"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_2f5c367c","line":72,"in_reply_to":"dada55a8_06efa61e","updated":"2016-07-26 22:44:33.000000000","message":"+1","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7be57ce93250498f86d3a07dfd5eea6efe64c5a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Install pip packages (venv)"},{"line_number":17,"context_line":"  pip:"},{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"    state: latest"},{"line_number":20,"context_line":"    virtualenv: \"{{ nova_bin | dirname }}\""},{"line_number":21,"context_line":"    virtualenv_site_packages: \"no\""},{"line_number":22,"context_line":"    extra_args: \"{{ pip_install_options|default(\u0027\u0027) }}\""},{"line_number":23,"context_line":"  register: install_packages"},{"line_number":24,"context_line":"  until: install_packages|success"},{"line_number":25,"context_line":"  retries: 5"},{"line_number":26,"context_line":"  delay: 2"},{"line_number":27,"context_line":"  with_items: \"{{ nova_compute_lxd_pip_packages }}\""},{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - nova-install"},{"line_number":30,"context_line":"    - nova-pip-packages"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bacf61ea_0b260b16","line":30,"range":{"start_line":16,"start_character":0,"end_line":30,"end_character":23},"updated":"2016-08-03 09:39:43.000000000","message":"Instead of using with_items here, please use the join filter as this installs all the packages at once and is therefore faster and takes all requirements into account\n\nAn example: https://github.com/openstack/openstack-ansible-os_nova/blob/106ca720d6ce956932cb5982ac2ba3d0f3d1c030/tasks/nova_compute_kvm_install.yml#L47","commit_id":"7d91c419699152d360e85e1355a57b101e9cc00d"}],"tasks/nova_install_apt.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7be57ce93250498f86d3a07dfd5eea6efe64c5a1","unresolved":false,"context_lines":[{"line_number":119,"context_line":"- name: Install apt packages (compute - LXD)"},{"line_number":120,"context_line":"  apt:"},{"line_number":121,"context_line":"    pkg: \"{{ item }}\""},{"line_number":122,"context_line":"    state: latest"},{"line_number":123,"context_line":"    default_release: \"{{ lxd_default_release | default(omit) }}\""},{"line_number":124,"context_line":"  register: install_packages"},{"line_number":125,"context_line":"  until: install_packages|success"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bacf61ea_2b74affb","line":122,"range":{"start_line":122,"start_character":11,"end_line":122,"end_character":17},"updated":"2016-08-03 09:39:43.000000000","message":"Please use \"{{ nova_package_state }}\" here, as per https://github.com/openstack/openstack-ansible-os_nova/blob/106ca720d6ce956932cb5982ac2ba3d0f3d1c030/tasks/nova_install_apt.yml#L19","commit_id":"7d91c419699152d360e85e1355a57b101e9cc00d"}],"templates/nova.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"## Vif"},{"line_number":105,"context_line":"linuxnet_interface_driver \u003d {{ nova_linuxnet_interface_driver }}"},{"line_number":106,"context_line":"{% if nova_virt_type in [\u0027kvm\u0027, \u0027lxc\u0027, \u0027qemu\u0027, \u0027xen\u0027] %}"},{"line_number":107,"context_line":"libvirt_vif_type \u003d ethernet"},{"line_number":108,"context_line":"{% endif %}"},{"line_number":109,"context_line":"vif_plugging_timeout \u003d 10"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dada55a8_4f09aa83","line":106,"range":{"start_line":106,"start_character":33,"end_line":106,"end_character":36},"updated":"2016-07-26 22:44:33.000000000","message":"is this \"lxc\" or \"lxd\" ?","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"## Vif"},{"line_number":105,"context_line":"linuxnet_interface_driver \u003d {{ nova_linuxnet_interface_driver }}"},{"line_number":106,"context_line":"{% if nova_virt_type in [\u0027kvm\u0027, \u0027lxc\u0027, \u0027qemu\u0027, \u0027xen\u0027] %}"},{"line_number":107,"context_line":"libvirt_vif_type \u003d ethernet"},{"line_number":108,"context_line":"{% endif %}"},{"line_number":109,"context_line":"vif_plugging_timeout \u003d 10"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dada55a8_e4da3c77","line":106,"range":{"start_line":106,"start_character":33,"end_line":106,"end_character":36},"in_reply_to":"dada55a8_4f09aa83","updated":"2016-07-27 03:13:01.000000000","message":"lxc is correct.  The virt type is lxc, lxd is just an alternate user space for the same underlying libraries.  So, we need to use lxc here, or implement some extra logic to convert lxc to lxd below.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":261,"context_line":"use_usb_tablet \u003d False"},{"line_number":262,"context_line":"use_virtio_for_bridges \u003d True"},{"line_number":263,"context_line":"cpu_mode \u003d {{ nova_cpu_mode }}"},{"line_number":264,"context_line":"virt_type \u003d {{ nova_virt_type }}"},{"line_number":265,"context_line":"remove_unused_resized_minimum_age_seconds \u003d {{ nova_remove_unused_resized_minimum_age_seconds }}"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"{% if cinder_backends_rbd_inuse|bool or nova_libvirt_images_rbd_pool is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dada55a8_c4f1f802","line":264,"range":{"start_line":264,"start_character":0,"end_line":264,"end_character":32},"updated":"2016-07-27 03:13:01.000000000","message":"For all the \u0027lxc\u0027 or \u0027lxd\u0027 comments, this line needs to be set to \u0027lxc\u0027 per docs from nova-lxd.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"}],"vars/ubuntu-14.04.yml":[{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"0dc13cf00aa26f68a280862ad6c1ab97031d8133","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  - multipath-tools"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"nova_compute_lxd_packages:"},{"line_number":56,"context_line":"  - lxd"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Ubuntu Cloud Archive variables"},{"line_number":59,"context_line":"nova_uca_enable: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_ac1af4c3","line":56,"range":{"start_line":56,"start_character":4,"end_line":56,"end_character":7},"updated":"2016-07-26 22:08:02.000000000","message":"Is lxd in the base 14.04 sufficient? Or do we need a version from backports or a PPA?","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"eb12fc4634cdb34b218053f652d5d6d02e247b69","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  - multipath-tools"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"nova_compute_lxd_packages:"},{"line_number":56,"context_line":"  - lxd"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Ubuntu Cloud Archive variables"},{"line_number":59,"context_line":"nova_uca_enable: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_cf463abf","line":56,"range":{"start_line":56,"start_character":4,"end_line":56,"end_character":7},"in_reply_to":"dada55a8_ac1af4c3","updated":"2016-07-26 22:44:33.000000000","message":"+1 I think it\u0027d be best to get this from the backports repo similar to here: [ https://github.com/openstack/openstack-ansible-lxc_hosts/blob/5606ea555b3698e542b816eda2e77eed059ef5ec/tasks/lxc_install_apt.yml#L37 ]","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"7297751f8cb9cca214c1fd19c97d4922a52f94f4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  - multipath-tools"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"nova_compute_lxd_packages:"},{"line_number":56,"context_line":"  - lxd"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Ubuntu Cloud Archive variables"},{"line_number":59,"context_line":"nova_uca_enable: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_e4935ca1","line":56,"range":{"start_line":56,"start_character":4,"end_line":56,"end_character":7},"in_reply_to":"dada55a8_cf463abf","updated":"2016-07-27 03:13:01.000000000","message":"I\u0027m getting it from backports.  I thought it was coming from the UCA, but it appears not.  I\u0027m unsure how backports are already being installed on my local host, but I think we can add it, good catch.","commit_id":"eaee792584ae360254d02f9a132c48a85cc531a6"}]}