)]}'
{"tasks/main.yml":[{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"bdd9a421c79d1b0c465044654bde5eea6b1f43ee","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    - always"},{"line_number":52,"context_line":"    - nova-virt-detect"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- include: nova_disable_smt.yml"},{"line_number":55,"context_line":"  when:"},{"line_number":56,"context_line":"    - nova_virt_type \u003d\u003d \"kvm\""},{"line_number":57,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Set default nova console for ppc64le"},{"line_number":60,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_7d274812","line":57,"range":{"start_line":54,"start_character":2,"end_line":57,"end_character":38},"updated":"2016-10-28 18:47:54.000000000","message":"This seems like it should be done in nova_compute_kvm.yml rather than here. Is there any reason it\u0027s not there?  We only need to turn off SMT for compute nodes.","commit_id":"c0fa97c976b12f5bb654320b163cffe1d34010f8"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"6488b7c1f4490ba72491bf17e00d663e4c888c61","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    - always"},{"line_number":52,"context_line":"    - nova-virt-detect"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- include: nova_disable_smt.yml"},{"line_number":55,"context_line":"  when:"},{"line_number":56,"context_line":"    - nova_virt_type \u003d\u003d \"kvm\""},{"line_number":57,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Set default nova console for ppc64le"},{"line_number":60,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_15ba9c6e","line":57,"range":{"start_line":54,"start_character":2,"end_line":57,"end_character":38},"in_reply_to":"ba5da102_7d274812","updated":"2016-10-29 12:59:49.000000000","message":"yeah, nova_compute_kvm is the better place.","commit_id":"c0fa97c976b12f5bb654320b163cffe1d34010f8"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"bdd9a421c79d1b0c465044654bde5eea6b1f43ee","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    - nova_virt_type \u003d\u003d \"kvm\""},{"line_number":57,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Set default nova console for ppc64le"},{"line_number":60,"context_line":"  set_fact:"},{"line_number":61,"context_line":"    nova_console_type: \"novnc\""},{"line_number":62,"context_line":"  when: ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- include: nova_pre_install.yml"},{"line_number":65,"context_line":"- include: nova_install.yml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_3de95081","line":62,"range":{"start_line":59,"start_character":0,"end_line":62,"end_character":41},"updated":"2016-10-28 18:47:54.000000000","message":"It seems like this should be done in the nova_pre_install.yml....just to keep this file uncluttered.  We just need to set the fact before nova_install.yml happens.","commit_id":"c0fa97c976b12f5bb654320b163cffe1d34010f8"}],"tasks/nova_compute_kvm.yml":[{"author":{"_account_id":22111,"name":"Ravi Gummadi","email":"ravigumm@in.ibm.com","username":"ravigumm"},"change_message_id":"c8a63455166b0147128c5ca3bd09ab46591c5ac8","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- include: nova_disable_smt.yml"},{"line_number":83,"context_line":"  when:"},{"line_number":84,"context_line":"    - nova_virt_type \u003d\u003d \"kvm\""},{"line_number":85,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- include: nova_compute_kvm_virsh_net_remove.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_cf2b2cea","line":84,"updated":"2016-10-31 08:28:26.000000000","message":"Is this nova_virt_type condition helping us in any case/scenario ?","commit_id":"d8b0d34d6f1acef2e3a0610d74415f344b5b531d"}],"tasks/nova_disable_smt.yml":[{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"bdd9a421c79d1b0c465044654bde5eea6b1f43ee","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    - pid1_name \u003d\u003d \"systemd\""},{"line_number":33,"context_line":"  register: systemd_init"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Reload the systemd daemon"},{"line_number":36,"context_line":"  command: \"systemctl daemon-reload\""},{"line_number":37,"context_line":"  when: systemd_init | changed"},{"line_number":38,"context_line":" "},{"line_number":39,"context_line":"- name: Upstart script to disable SMT"},{"line_number":40,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_dd721449","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":30},"updated":"2016-10-28 18:47:54.000000000","message":"Notify the \u0027Reload systemd daemon\u0027 instead of manually doing it.","commit_id":"c0fa97c976b12f5bb654320b163cffe1d34010f8"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"bdd9a421c79d1b0c465044654bde5eea6b1f43ee","unresolved":false,"context_lines":[{"line_number":35,"context_line":"- name: Reload the systemd daemon"},{"line_number":36,"context_line":"  command: \"systemctl daemon-reload\""},{"line_number":37,"context_line":"  when: systemd_init | changed"},{"line_number":38,"context_line":" "},{"line_number":39,"context_line":"- name: Upstart script to disable SMT"},{"line_number":40,"context_line":"  copy:"},{"line_number":41,"context_line":"    src: \"smt.conf\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_1dd72c24","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":1},"updated":"2016-10-28 18:47:54.000000000","message":"Get rid of white space.","commit_id":"c0fa97c976b12f5bb654320b163cffe1d34010f8"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"70427bf5954a47ed64d9ce40e91ef3ec493a93db","unresolved":false,"context_lines":[{"line_number":35,"context_line":"- name: Reload the systemd daemon"},{"line_number":36,"context_line":"  command: \"systemctl daemon-reload\""},{"line_number":37,"context_line":"  when: systemd_init | changed"},{"line_number":38,"context_line":"  notify:"},{"line_number":39,"context_line":"    - Reload systemd daemon"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Upstart script to disable SMT"},{"line_number":42,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_d534a4fc","line":39,"range":{"start_line":38,"start_character":2,"end_line":39,"end_character":27},"updated":"2016-10-29 13:28:11.000000000","message":"This notify goes on the task that changes the smt.service (line 23 above), once that\u0027s done you don\u0027t need this task nor the systemd_init var.  \n\nSee the nova_init_systemd.yml file for a proper example (task Place the systemd init script).","commit_id":"35ec23917592819bdd1dd981e45fcb811bea64e9"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"70427bf5954a47ed64d9ce40e91ef3ec493a93db","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  when:"},{"line_number":46,"context_line":"    - ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":47,"context_line":"    - pid1_name !\u003d \"systemd\""},{"line_number":48,"context_line":"  tags:"},{"line_number":49,"context_line":"    - kvm-disable-smt"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_3526c0ce","line":48,"updated":"2016-10-29 13:28:11.000000000","message":"We should add a notify here also.  See nova_init_upstart.yml for an example.","commit_id":"35ec23917592819bdd1dd981e45fcb811bea64e9"},{"author":{"_account_id":22111,"name":"Ravi Gummadi","email":"ravigumm@in.ibm.com","username":"ravigumm"},"change_message_id":"40013f536468348396b1254cd7a8a5545856f4ba","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Disable SMT"},{"line_number":17,"context_line":"  command: /usr/sbin/ppc64_cpu --smt\u003doff"},{"line_number":18,"context_line":"  when: ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":19,"context_line":"  failed_when: false"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    - kvm-disable-smt"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba5da102_8b8004c2","line":18,"updated":"2016-11-02 05:15:28.000000000","message":"This condition ansible_architecture \u003d\u003d \u0027ppc64le\u0027 for each task inside this file is not required when ansible version is \u003e\u003d 2.0. Because include statement for this file in the caller nova_compute_kvm.yml already has this condition.","commit_id":"3d45892d898c9c5624d5029d3e334b8524a17caa"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2988f6f74cb44b3d765d9a9463167549717e1505","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Disable SMT"},{"line_number":17,"context_line":"  command: /usr/sbin/ppc64_cpu --smt\u003doff"},{"line_number":18,"context_line":"  when: ansible_architecture \u003d\u003d \u0027ppc64le\u0027"},{"line_number":19,"context_line":"  failed_when: false"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    - kvm-disable-smt"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba5da102_534a1a27","line":18,"in_reply_to":"ba5da102_8b8004c2","updated":"2016-11-02 09:45:24.000000000","message":"Agreed, the include already has this condition - so none of the \u0027when: ansible_architecture \u003d\u003d \u0027ppc64le\u0027\u0027 statements are required in this file.","commit_id":"3d45892d898c9c5624d5029d3e334b8524a17caa"}]}