)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7a3719c1dada03639bffd3772395721b30ae3a92","unresolved":false,"context_lines":[{"line_number":82,"context_line":"nova_db_max_pool_size: 120"},{"line_number":83,"context_line":"nova_db_pool_timeout: 30"},{"line_number":84,"context_line":"nova_galera_use_ssl: False"},{"line_number":85,"context_line":"nova_galera_ssl_ca_cert: \"{{ galera_ssl_client_ca_cert | default(\u0027/etc/ssl/certs/galera-ca.crt\u0027) }}\" "},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"## DB API"},{"line_number":88,"context_line":"nova_api_galera_user: nova_api"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba2be162_0ec34439","line":85,"range":{"start_line":85,"start_character":66,"end_line":85,"end_character":94},"updated":"2017-03-02 20:48:32.000000000","message":"Just provide a default here, don\u0027t try the var value first. Also get rid of the trailing whitespace.\n\nMaybe it\u0027s better if the name of the var is nova_db_use_ssl and nova_db_ssl_ca_cert to keep consistency here. Not sure - up to you.","commit_id":"08c188672eb98247a37dadeb102569e343b8fc38"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"f760dd5bb45814f25c221d7ef2576421eb0ca85e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"nova_db_max_pool_size: 120"},{"line_number":83,"context_line":"nova_db_pool_timeout: 30"},{"line_number":84,"context_line":"nova_galera_use_ssl: False"},{"line_number":85,"context_line":"nova_galera_ssl_ca_cert: \"{{ galera_ssl_client_ca_cert | default(\u0027/etc/ssl/certs/galera-ca.crt\u0027) }}\" "},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"## DB API"},{"line_number":88,"context_line":"nova_api_galera_user: nova_api"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba2be162_e47b6f26","line":85,"range":{"start_line":85,"start_character":66,"end_line":85,"end_character":94},"in_reply_to":"ba2be162_0ec34439","updated":"2017-03-02 21:39:47.000000000","message":"well... it\u0027s using galera_address, galera_database and galera user already. I\u0027d say ssl is about galera also","commit_id":"08c188672eb98247a37dadeb102569e343b8fc38"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d68950d7592f1e519a4adba5a308600451c1a401","unresolved":false,"context_lines":[{"line_number":81,"context_line":"nova_db_max_overflow: 10"},{"line_number":82,"context_line":"nova_db_max_pool_size: 120"},{"line_number":83,"context_line":"nova_db_pool_timeout: 30"},{"line_number":84,"context_line":"nova_galera_use_ssl: False"},{"line_number":85,"context_line":"nova_galera_ssl_ca_cert: /etc/ssl/certs/galera-ca.crt"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"## DB API"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba2be162_e93251a6","line":84,"updated":"2017-03-03 10:42:57.000000000","message":"While I understand that the above lines have no comments documenting their purpose, that\u0027s a legacy thing. We want to change that. Please add comments for the purpose of these new variables.\n\nFor example:\n\n# Toggle whether nova connects via an encrypted connection\nnova_galera_use_ssl: False\n\n# The path to where the database server CA certificate is stored\nnova_galera_ssl_ca_cert: /etc/ssl/certs/galera-ca.crt\n\n# The path to a user-provided CA certificate file on the deployment host\n#galera_user_ssl_ca_cert: /etc/openstack_deploy/files/galera-ca.crt","commit_id":"97e6af1d8d276d7b438c82c173874083cc525479"}],"releasenotes/notes/nova_galera_ssl-24c2ca2a8ab6fec4.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"da7a8420ccc2d552fc7d96032e5abbb9dd60a757","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: It is recommended to set up as many services as possible "},{"line_number":3,"context_line":"  with SSL connectivity to any other service in the production"},{"line_number":4,"context_line":"  environment. One of the critical thing is to enforce SSL between the"},{"line_number":5,"context_line":"  database and any OpenStack API service. The change allows to set up Nova"},{"line_number":6,"context_line":"  to encrypt the connection to MySQL in case the DB is set up accordingly"},{"line_number":7,"context_line":"  and proper CA certificate is provided."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - Nova is able to connect to MySQL DB using encryption"},{"line_number":10,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_8a7b9d8b","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":40},"updated":"2017-03-02 21:53:10.000000000","message":"Remove this part.\n\nSee https://docs.openstack.org/developer/openstack-ansible/developer-docs/contribute.html#documentation-and-release-note-guidelines","commit_id":"d1c0680d0cb4af03d270ab3c1c4794ffa53128af"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d68950d7592f1e519a4adba5a308600451c1a401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ba2be162_e96411ba","updated":"2017-03-03 10:42:57.000000000","message":"For the sake of moving things forward, I\u0027ve edited the release note on your behalf. I think this covers enough and can be read out of context, which is important for release notes.","commit_id":"97e6af1d8d276d7b438c82c173874083cc525479"}],"tasks/nova_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d68950d7592f1e519a4adba5a308600451c1a401","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    mode: \"0640\""},{"line_number":49,"context_line":"  when:"},{"line_number":50,"context_line":"    - nova_galera_use_ssl | bool"},{"line_number":51,"context_line":"    - galera_user_ssl_ca_cert is defined"},{"line_number":52,"context_line":"  tags:"},{"line_number":53,"context_line":"    - nova-config"},{"line_number":54,"context_line":"    - nova-post-install"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba2be162_69710176","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":29},"updated":"2017-03-03 10:42:57.000000000","message":"Can you add this commented out in defaults with an explanation of what it is as a comment above it.","commit_id":"97e6af1d8d276d7b438c82c173874083cc525479"}],"templates/nova.conf.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d3a4e69accc2e69af58c73dfeedbf83a0891babb","unresolved":false,"context_lines":[{"line_number":213,"context_line":"{% if inventory_hostname in (groups[\u0027nova_conductor\u0027] + groups[\u0027nova_scheduler\u0027] + groups[\u0027nova_api_os_compute\u0027] + groups[\u0027nova_api_metadata\u0027] + groups[\u0027nova_console\u0027] + groups[\u0027nova_api_placement\u0027])%}"},{"line_number":214,"context_line":"[database]"},{"line_number":215,"context_line":"{% if nova_galera_use_ssl | bool %}"},{"line_number":216,"context_line":"connection \u003d mysql+pymysql://{{ nova_galera_user }}:{{ nova_container_mysql_password }}@{{ nova_galera_address }}/{{ nova_galera_database }}?charset\u003dutf8?ssl_ca\u003d{{ nova_galera_ssl_ca_cert }}"},{"line_number":217,"context_line":"{% else %)"},{"line_number":218,"context_line":"connection \u003d mysql+pymysql://{{ nova_galera_user }}:{{ nova_container_mysql_password }}@{{ nova_galera_address }}/{{ nova_galera_database }}?charset\u003dutf8"},{"line_number":219,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ba2be162_cefa0c75","line":216,"range":{"start_line":216,"start_character":153,"end_line":216,"end_character":154},"updated":"2017-03-02 20:49:38.000000000","message":"shouldn\u0027t this be an ampersand? ie \u0026\n\nI\u0027m not sure - that\u0027s just a URL norm","commit_id":"08c188672eb98247a37dadeb102569e343b8fc38"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"f760dd5bb45814f25c221d7ef2576421eb0ca85e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"{% if inventory_hostname in (groups[\u0027nova_conductor\u0027] + groups[\u0027nova_scheduler\u0027] + groups[\u0027nova_api_os_compute\u0027] + groups[\u0027nova_api_metadata\u0027] + groups[\u0027nova_console\u0027] + groups[\u0027nova_api_placement\u0027])%}"},{"line_number":214,"context_line":"[database]"},{"line_number":215,"context_line":"{% if nova_galera_use_ssl | bool %}"},{"line_number":216,"context_line":"connection \u003d mysql+pymysql://{{ nova_galera_user }}:{{ nova_container_mysql_password }}@{{ nova_galera_address }}/{{ nova_galera_database }}?charset\u003dutf8?ssl_ca\u003d{{ nova_galera_ssl_ca_cert }}"},{"line_number":217,"context_line":"{% else %)"},{"line_number":218,"context_line":"connection \u003d mysql+pymysql://{{ nova_galera_user }}:{{ nova_container_mysql_password }}@{{ nova_galera_address }}/{{ nova_galera_database }}?charset\u003dutf8"},{"line_number":219,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ba2be162_a4e097fb","line":216,"range":{"start_line":216,"start_character":153,"end_line":216,"end_character":154},"in_reply_to":"ba2be162_cefa0c75","updated":"2017-03-02 21:39:47.000000000","message":"You are absolutely right :/\nI was confused by some bad reference.... fixed","commit_id":"08c188672eb98247a37dadeb102569e343b8fc38"}]}