)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7d533b33f55dfbb16b70fdeb8589195eadc4b73c","unresolved":false,"context_lines":[{"line_number":547,"context_line":"#     nova_pci_passthrough_whitelist: \u0027{ \"physical_network\": \"physnet1\", \"devname\": \"p1p1\" }\u0027"},{"line_number":548,"context_line":"nova_pci_passthrough_whitelist: {}"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"nova_nginx_placement_sites:"},{"line_number":551,"context_line":"  nova_placement:"},{"line_number":552,"context_line":"    - listen {{ nova_placement_service_port }}"},{"line_number":553,"context_line":"    - keepalive_timeout 70"},{"line_number":554,"context_line":"    - access_log /var/log/nova/nova-placement-api-access.log custom"},{"line_number":555,"context_line":"    - error_log /var/log/nova/nova-placement-api-error.log info"},{"line_number":556,"context_line":"    - location /placement/ {"},{"line_number":557,"context_line":"        try_files $uri @nova-placement-api;"},{"line_number":558,"context_line":"      }"},{"line_number":559,"context_line":"    - location @nova-placement-api {"},{"line_number":560,"context_line":"        include uwsgi_params;"},{"line_number":561,"context_line":"        uwsgi_pass 127.0.0.1:{{ nova_placement_uwsgi_socket_port }};"},{"line_number":562,"context_line":"        uwsgi_param SCRIPT_NAME \u0027/placement\u0027;"},{"line_number":563,"context_line":"        uwsgi_modifier1 30;"},{"line_number":564,"context_line":"      }"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"nova_nginx_http_params:"},{"line_number":567,"context_line":"  - log_format custom \u0027{{ nova_placement_nginx_access_log_format_combined }} {{ nova_placement_nginx_access_log_format_extras }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_ffa938dd","line":567,"range":{"start_line":550,"start_character":0,"end_line":567,"end_character":129},"updated":"2017-03-30 12:23:31.000000000","message":"Do we actually want people to change these, or they essential to be left alone as they are for the running of the services?\n\nIf we put this content into vars/main.yml then it is harder to override (extra vars can still do it) and it is not exposed in the documentation. My vote is to move this stuff there.","commit_id":"e9a43821d7f8c1ba732a3e8fc95fdaabb1c654b5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b46988f0aca4b7073e5dd0bbbfa70e9c697bebc7","unresolved":false,"context_lines":[{"line_number":547,"context_line":"#     nova_pci_passthrough_whitelist: \u0027{ \"physical_network\": \"physnet1\", \"devname\": \"p1p1\" }\u0027"},{"line_number":548,"context_line":"nova_pci_passthrough_whitelist: {}"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"nova_nginx_placement_sites:"},{"line_number":551,"context_line":"  nova_placement:"},{"line_number":552,"context_line":"    - listen {{ nova_placement_service_port }}"},{"line_number":553,"context_line":"    - keepalive_timeout 70"},{"line_number":554,"context_line":"    - access_log /var/log/nova/nova-placement-api-access.log custom"},{"line_number":555,"context_line":"    - error_log /var/log/nova/nova-placement-api-error.log info"},{"line_number":556,"context_line":"    - location /placement/ {"},{"line_number":557,"context_line":"        try_files $uri @nova-placement-api;"},{"line_number":558,"context_line":"      }"},{"line_number":559,"context_line":"    - location @nova-placement-api {"},{"line_number":560,"context_line":"        include uwsgi_params;"},{"line_number":561,"context_line":"        uwsgi_pass 127.0.0.1:{{ nova_placement_uwsgi_socket_port }};"},{"line_number":562,"context_line":"        uwsgi_param SCRIPT_NAME \u0027/placement\u0027;"},{"line_number":563,"context_line":"        uwsgi_modifier1 30;"},{"line_number":564,"context_line":"      }"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"nova_nginx_http_params:"},{"line_number":567,"context_line":"  - log_format custom \u0027{{ nova_placement_nginx_access_log_format_combined }} {{ nova_placement_nginx_access_log_format_extras }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_df1f94b5","line":567,"range":{"start_line":550,"start_character":0,"end_line":567,"end_character":129},"updated":"2017-03-30 12:36:25.000000000","message":"See my comment in PS1.","commit_id":"e5e542136eb996420ec79beeb71210ac437fe885"}],"meta/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c20d37d6ae2ee96a69eb75263781706bceee8bc6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    keep_only_specified: False"},{"line_number":39,"context_line":"    nginx_http_params: \"{{ nginx_http_default_params + nova_nginx_http_params }}\""},{"line_number":40,"context_line":"    when:"},{"line_number":41,"context_line":"      - inventory_hostname in groups[\u0027nova_api_os_compute\u0027]"},{"line_number":42,"context_line":"      - inventory_hostname in groups[\u0027nova_api_metadata\u0027]"},{"line_number":43,"context_line":"      - inventory_hostname in groups[\u0027nova_api_placement\u0027]"},{"line_number":44,"context_line":"      - inventory_hostname in groups[\u0027nova_scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_09803bf4","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":54},"updated":"2017-03-30 03:05:28.000000000","message":"I think this all needs to be changed to a set of \"or\" conditions:\n  ...\n    when: \u003e\n      inventory_hostname in groups[\u0027nova_api_os_compute\u0027] or\n      inventory_hostname in groups[\u0027nova_api_metadata\u0027] or\n      inventory_hostname in groups[\u0027nova_api_placement\u0027] or\n      inventory_hostname in groups[\u0027nova_scheduler\u0027]","commit_id":"e9a43821d7f8c1ba732a3e8fc95fdaabb1c654b5"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"ca8f911c54b17c3feffa8781ebd86dd254183014","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    keep_only_specified: False"},{"line_number":39,"context_line":"    nginx_http_params: \"{{ nginx_http_default_params + nova_nginx_http_params }}\""},{"line_number":40,"context_line":"    when:"},{"line_number":41,"context_line":"      - inventory_hostname in groups[\u0027nova_api_os_compute\u0027]"},{"line_number":42,"context_line":"      - inventory_hostname in groups[\u0027nova_api_metadata\u0027]"},{"line_number":43,"context_line":"      - inventory_hostname in groups[\u0027nova_api_placement\u0027]"},{"line_number":44,"context_line":"      - inventory_hostname in groups[\u0027nova_scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_a21cbec1","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":54},"in_reply_to":"ffe62b97_09803bf4","updated":"2017-03-30 09:07:29.000000000","message":"Hahaha you are correct - logic fail.","commit_id":"e9a43821d7f8c1ba732a3e8fc95fdaabb1c654b5"}],"tasks/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b46988f0aca4b7073e5dd0bbbfa70e9c697bebc7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  when:"},{"line_number":30,"context_line":"    - nova_virt_type is defined"},{"line_number":31,"context_line":"    - nova_virt_type not in nova_supported_virt_types"},{"line_number":32,"context_line":"    - inventory_hostname in groups[\u0027nova_all\u0027]"},{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    - always"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_ff501861","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":46},"updated":"2017-03-30 12:36:25.000000000","message":"When would this role be executed against a host that is not in nova_all?","commit_id":"e5e542136eb996420ec79beeb71210ac437fe885"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"db2cff58367d32358f609243051a1a1311c0ee1d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  when:"},{"line_number":30,"context_line":"    - nova_virt_type is defined"},{"line_number":31,"context_line":"    - nova_virt_type not in nova_supported_virt_types"},{"line_number":32,"context_line":"    - inventory_hostname in groups[\u0027nova_all\u0027]"},{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    - always"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_1d79842e","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":46},"in_reply_to":"ffe62b97_ff501861","updated":"2017-03-30 13:02:51.000000000","message":"In order to allow nginx to colocate or not colocate with the nova hosts, i\u0027ve created some subgroups - nova_all being a subgroup of \"nova_nginx_all\" which also containers \"nova_nginx\" group.\n\nThe idea is, if the host is in nova_all do these things, but if it\u0027s just an nginx host (i.e. nginx is on it\u0027s own host, we don\u0027t want to install the nova bits so don\u0027t run against that host).\n\nThere may well be a better way to do that - but I wanted to mess around with the idea of having separate nginx hosts and seeing what we can do there.","commit_id":"e5e542136eb996420ec79beeb71210ac437fe885"}],"tasks/nova_nginx.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b46988f0aca4b7073e5dd0bbbfa70e9c697bebc7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: nova_placement_nginx.yml"},{"line_number":17,"context_line":"  when: inventory_hostname in groups[\u0027nova_api_placement_nginx\u0027]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Once we add the extra services it\u0027ll look like this:"},{"line_number":20,"context_line":"# - include: nova_api_os_compute_nginx.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_7f3408fc","line":17,"range":{"start_line":17,"start_character":38,"end_line":17,"end_character":62},"updated":"2017-03-30 12:36:25.000000000","message":"Instead of creating a new group for this, why not use set theory filters to target appropriately. For example, this would be the intersection of the nginx group and the nova_api_placement group. It perhaps feels a little silly though because surely all placement containers have nginx implemented?","commit_id":"e5e542136eb996420ec79beeb71210ac437fe885"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"db2cff58367d32358f609243051a1a1311c0ee1d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: nova_placement_nginx.yml"},{"line_number":17,"context_line":"  when: inventory_hostname in groups[\u0027nova_api_placement_nginx\u0027]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Once we add the extra services it\u0027ll look like this:"},{"line_number":20,"context_line":"# - include: nova_api_os_compute_nginx.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_9dbfd4cf","line":17,"range":{"start_line":17,"start_character":38,"end_line":17,"end_character":62},"in_reply_to":"ffe62b97_7f3408fc","updated":"2017-03-30 13:02:51.000000000","message":"This actually allows the exact opposite - you could run nginx on \"infra1_nginx_container-abc12345\" which runs all the nginx vhosts for all services, and placement being one of them.\n\nOR you could have nova_api_placement_nginx be the same as nova_api_placement in which case it\u0027ll set it up in the right place there too.\n\nI\u0027m not stuck on one or the other, but this does provide the flexibility to do either. There are a few special cases though:\n* If nginx co-locates with nova, we need to add nginx to the nova group to allow it to write logs properly.\n* If nginx does not co-locate with nova we need to create the /var/log/nova directory\n\nMy main aim is to fly the idea up the flag pole and see who salutes it - if we can come to a consensus on best practices given a few options, that\u0027d be ideal.","commit_id":"e5e542136eb996420ec79beeb71210ac437fe885"}],"tasks/nova_placement_nginx.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"6d00fec71a6251ae88d7245612cb95b2e398f8ad","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Add nginx user to nova group for log writing"},{"line_number":17,"context_line":"  user:"},{"line_number":18,"context_line":"    name: \"{{ nova_nginx_user_name }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bff0334d_092238a5","line":15,"updated":"2017-04-06 16:13:45.000000000","message":"Think this may be a better fit as a common taskfile, similar to rabbit/mysql configs since it\u0027ll have to be done within each os_ role and sometimes multiple times within those roles","commit_id":"e5e542136eb996420ec79beeb71210ac437fe885"}],"tests/ansible-role-requirements.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7d533b33f55dfbb16b70fdeb8589195eadc4b73c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"- name: nginx"},{"line_number":66,"context_line":"  src: https://github.com/jdauphant/ansible-role-nginx"},{"line_number":67,"context_line":"  scm: git"},{"line_number":68,"context_line":"  version: v2.7.7"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_7f63e8b2","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":17},"updated":"2017-03-30 12:23:31.000000000","message":"Should we be using master here instead or a versioned role?","commit_id":"e9a43821d7f8c1ba732a3e8fc95fdaabb1c654b5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b46988f0aca4b7073e5dd0bbbfa70e9c697bebc7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-os_nova"},{"line_number":63,"context_line":"  scm: git"},{"line_number":64,"context_line":"  version: stable/ocata"},{"line_number":65,"context_line":"- name: nginx"},{"line_number":66,"context_line":"  src: https://github.com/jdauphant/ansible-role-nginx"},{"line_number":67,"context_line":"  scm: git"},{"line_number":68,"context_line":"  version: v2.7.7"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_3fbb2073","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":17},"updated":"2017-03-30 12:36:25.000000000","message":"See comment in PS1.","commit_id":"e5e542136eb996420ec79beeb71210ac437fe885"}],"tests/inventory":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d745718168269b9b82dd16aa67202d7d63040a45","unresolved":false,"context_lines":[{"line_number":116,"context_line":"nova_scheduler"},{"line_number":117,"context_line":"nova_api_placement"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"[nova_nginx_all:children]"},{"line_number":120,"context_line":"nova_all"},{"line_number":121,"context_line":"nova_nginx"},{"line_number":122,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"dfeb2761_b8093132","line":119,"updated":"2017-04-03 16:56:04.000000000","message":"this group feels like it is named oddly, for what it contains. with the name not being very self-describing we likely need to consider adding docs/guide content (in the nova role or centrally) for using these groups properly in the different deploy models.","commit_id":"e5e542136eb996420ec79beeb71210ac437fe885"}]}
