)]}'
{"id":"openstack%2Fopenstack-ansible-os_nova~461705","triplet_id":"openstack%2Fopenstack-ansible-os_nova~master~I1bda4c1a787dee3376476fcc2a313f69a3f1d22e","project":"openstack/openstack-ansible-os_nova","branch":"master","topic":"libvirtd","hashtags":[],"change_id":"I1bda4c1a787dee3376476fcc2a313f69a3f1d22e","subject":"Add more parameters to the libvirtd template.","status":"NEW","created":"2017-05-02 09:56:29.000000000","updated":"2025-06-10 22:06:54.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4d0402cdec0757af9696cc64865729243491a1ef","_number":461705,"virtual_id_number":461705,"owner":{"_account_id":589,"name":"Syed Armani","email":"syed.armani@citynetwork.eu","username":"dce3062"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":1,"date":"2017-05-02 11:05:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":-1,"date":"2017-05-05 11:02:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2017-05-02 11:13:01.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2017-05-03 12:39:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"date":"2017-07-17 10:08:55.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"CC":[{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-02 11:05:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-05-02 11:13:01.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2017-05-03 12:39:25.000000000","updated_by":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"reviewer":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"state":"REVIEWER"},{"updated":"2017-05-05 11:02:57.000000000","updated_by":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"reviewer":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"state":"REVIEWER"},{"updated":"2017-07-17 10:08:55.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2025-06-10 22:06:54.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"state":"CC"},{"updated":"2025-06-10 22:06:54.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"CC"}],"messages":[{"id":"22177f1db698d01217445d89fd4349b194bd3ea9","author":{"_account_id":589,"name":"Syed Armani","email":"syed.armani@citynetwork.eu","username":"dce3062"},"date":"2017-05-02 09:56:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9858f02c1c20054b07c306c6ded40eaae0d0bce","author":{"_account_id":589,"name":"Syed Armani","email":"syed.armani@citynetwork.eu","username":"dce3062"},"date":"2017-05-02 09:59:08.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a0afe19f5323961a44048056d106c5237ac20b8c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-02 11:05:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-os_nova-docs-ubuntu-xenial http://docs-draft.openstack.org/05/461705/2/check/gate-openstack-ansible-os_nova-docs-ubuntu-xenial/d9be5f5//doc/build/html/ : SUCCESS in 1m 52s\n- gate-openstack-ansible-os_nova-linters-ubuntu-xenial http://logs.openstack.org/05/461705/2/check/gate-openstack-ansible-os_nova-linters-ubuntu-xenial/9b45047/ : SUCCESS in 2m 19s\n- gate-openstack-ansible-os_nova-ansible-func-centos-7-nv http://logs.openstack.org/05/461705/2/check/gate-openstack-ansible-os_nova-ansible-func-centos-7-nv/dc4f85b/ : FAILURE in 1h 05m 59s (non-voting)\n- gate-openstack-ansible-os_nova-ansible-func-ubuntu-xenial http://logs.openstack.org/05/461705/2/check/gate-openstack-ansible-os_nova-ansible-func-ubuntu-xenial/af14421/ : SUCCESS in 35m 50s\n- gate-openstack-ansible-os_nova-ansible-func_lxd-ubuntu-xenial http://logs.openstack.org/05/461705/2/check/gate-openstack-ansible-os_nova-ansible-func_lxd-ubuntu-xenial/acbaf90/ : SUCCESS in 36m 16s\n- gate-openstack-ansible-os_nova-ansible-upgrade-ubuntu-xenial http://logs.openstack.org/05/461705/2/check/gate-openstack-ansible-os_nova-ansible-upgrade-ubuntu-xenial/8e25079/ : SUCCESS in 41m 16s","accounts_in_message":[],"_revision_number":2},{"id":"a331d972c329043cce6815bb754dc96f8d852ed8","author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"date":"2017-05-05 11:02:57.000000000","message":"Patch Set 2: Code-Review-1\n\n2 minor things:\n\n1. Those don\u0027t appear to be the default for libvirtd.conf - that means it\u0027s a change in functionality.\n\nIt might be better to do either of the following:\n* conditionally include those values if they are set - this preserves the default and only sets the value if it\u0027s provided.\n* set them to match the default of libvirtd.conf so there is no change - although this is less good since the default could change and we wouldn\u0027t copy it.\n\n2. We\u0027ll need a releasenote to indicate the new options that have been added.","accounts_in_message":[],"_revision_number":2},{"id":"35c4968a1c8c01eac179649a543ea1c5a2a2981e","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-07-17 10:08:55.000000000","message":"Patch Set 2:\n\n\u003e 2 minor things:\n \u003e \n \u003e 1. Those don\u0027t appear to be the default for libvirtd.conf - that\n \u003e means it\u0027s a change in functionality.\n \u003e \n \u003e It might be better to do either of the following:\n \u003e * conditionally include those values if they are set - this\n \u003e preserves the default and only sets the value if it\u0027s provided.\n \u003e * set them to match the default of libvirtd.conf so there is no\n \u003e change - although this is less good since the default could change\n \u003e and we wouldn\u0027t copy it.\n \u003e \n \u003e 2. We\u0027ll need a releasenote to indicate the new options that have\n \u003e been added.\n\n100% agreed there.","accounts_in_message":[],"_revision_number":2},{"id":"4d0402cdec0757af9696cc64865729243491a1ef","author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"date":"2025-06-10 22:06:54.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"837f975ea0a70272f762bd588997447378ef1c1b","revisions":{"eaa03982505fde7974617ceac395fc898a516e15":{"kind":"REWORK","_number":1,"created":"2017-05-02 09:56:29.000000000","uploader":{"_account_id":589,"name":"Syed Armani","email":"syed.armani@citynetwork.eu","username":"dce3062"},"ref":"refs/changes/05/461705/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/05/461705/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/05/461705/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/05/461705/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/05/461705/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/05/461705/1"}}},"commit":{"parents":[{"commit":"6a219128b7de75c366b9dada44e5defef5e84866","subject":"Update paste, policy and rootwrap configurations 2017-04-28","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/6a219128b7de75c366b9dada44e5defef5e84866"}]}],"author":{"name":"Syed Armani","email":"syed.armani@hastexo.com","date":"2017-05-02 09:24:43.000000000","tz":330},"committer":{"name":"Syed Armani","email":"syed.armani@hastexo.com","date":"2017-05-02 09:56:21.000000000","tz":330},"subject":"Add more parameters to the libvirtd template to boost parallel performance.","message":"Add more parameters to the libvirtd template to boost parallel performance.\n\nWith default libvirtd settings, parallel suspend or resume of more\nthan 20 heat stacks results in suspend/resume failure. This can be\nfixed by tweaking the `max_clients`, `max_client_requests`,\n`max_workers` and `max_requests` values in libvirtd configuration file.\n\nAdding these parameters to the template will allow operators to configure\nlibvirtd for better parallel performance.\n\nChange-Id: I1bda4c1a787dee3376476fcc2a313f69a3f1d22e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/eaa03982505fde7974617ceac395fc898a516e15"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/eaa03982505fde7974617ceac395fc898a516e15"}]},"branch":"refs/heads/master"},"837f975ea0a70272f762bd588997447378ef1c1b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-05-02 09:59:08.000000000","uploader":{"_account_id":589,"name":"Syed Armani","email":"syed.armani@citynetwork.eu","username":"dce3062"},"ref":"refs/changes/05/461705/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/05/461705/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/05/461705/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/05/461705/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/05/461705/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/05/461705/2"}}},"commit":{"parents":[{"commit":"6a219128b7de75c366b9dada44e5defef5e84866","subject":"Update paste, policy and rootwrap configurations 2017-04-28","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/6a219128b7de75c366b9dada44e5defef5e84866"}]}],"author":{"name":"Syed Armani","email":"syed.armani@hastexo.com","date":"2017-05-02 09:24:43.000000000","tz":330},"committer":{"name":"Syed Armani","email":"syed.armani@hastexo.com","date":"2017-05-02 09:58:29.000000000","tz":330},"subject":"Add more parameters to the libvirtd template.","message":"Add more parameters to the libvirtd template.\n\nWith default libvirtd settings, parallel suspend or resume of more\nthan 20 heat stacks results in suspend/resume failure. This can be\nfixed by tweaking the `max_clients`, `max_client_requests`,\n`max_workers` and `max_requests` values in libvirtd configuration file.\n\nAdding these parameters to the template will allow operators to configure\nlibvirtd for better parallel performance.\n\nChange-Id: I1bda4c1a787dee3376476fcc2a313f69a3f1d22e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/837f975ea0a70272f762bd588997447378ef1c1b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/837f975ea0a70272f762bd588997447378ef1c1b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"}},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}