)]}'
{"tasks/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7d7380d03a54592e70ede6f1717ca04403860a09","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# Also, we delegate this to a random host in the"},{"line_number":106,"context_line":"# conductor group in order to spread the load of"},{"line_number":107,"context_line":"# multiple forks across the group members."},{"line_number":108,"context_line":"- include: nova_db_post_setup.yml"},{"line_number":109,"context_line":"  static: no"},{"line_number":110,"context_line":"  delegate_to: \"{{ groups[\u0027nova_conductor\u0027] | random }}\""},{"line_number":111,"context_line":"  when:"},{"line_number":112,"context_line":"    - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":113,"context_line":"  tags:"},{"line_number":114,"context_line":"    - nova-config"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_f8bd49d8","line":114,"range":{"start_line":108,"start_character":0,"end_line":114,"end_character":17},"updated":"2017-07-04 11:56:15.000000000","message":"- include: nova_db_post_setup.yml\n  delegate_to: \"{{ conductor_host }}\"\n  with_random_choice: \"{{ groups[\u0027nova_conductor\u0027] }}\"\n  loop_control:\n    loop_var: conductor_host\n  when:\n    - \"\u0027nova_compute\u0027 in group_names\"\n  tags:\n    - nova-config","commit_id":"1c9677f94ebeb2b5cda6313b138ca7cd73988776"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"83b434aea0f05b559fb46a5ccc111d8ae9f994a2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  loop_control:"},{"line_number":112,"context_line":"    loop_var: conductor_host"},{"line_number":113,"context_line":"  when:"},{"line_number":114,"context_line":"    - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":115,"context_line":"  tags:"},{"line_number":116,"context_line":"    - nova-config"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_a28bfe1c","line":114,"updated":"2017-07-05 12:07:41.000000000","message":"is this supposed to be nova_compute here? If maybe mention this in the comment that it\u0027d only run when the compute group is present?","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4d9ff1994bf1d5d5e9dcb1d1a29ba3acd8a8388c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  loop_control:"},{"line_number":112,"context_line":"    loop_var: conductor_host"},{"line_number":113,"context_line":"  when:"},{"line_number":114,"context_line":"    - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":115,"context_line":"  tags:"},{"line_number":116,"context_line":"    - nova-config"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_ef3c3ec9","line":114,"in_reply_to":"3f1d235d_a263fe41","updated":"2017-07-05 12:50:28.000000000","message":"I guess my confusion is that we\u0027re requiring a node out of the \"nova_conductor\" group while only depending on the nova_compute group. maybe we just need to add a second conditional for \n\n  \"\u0027nova_conductor\u0027 in group_names\"","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"659e2fc9861031c89785a3bba276b55b76970f5f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  loop_control:"},{"line_number":112,"context_line":"    loop_var: conductor_host"},{"line_number":113,"context_line":"  when:"},{"line_number":114,"context_line":"    - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":115,"context_line":"  tags:"},{"line_number":116,"context_line":"    - nova-config"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_a263fe41","line":114,"in_reply_to":"3f1d235d_a28bfe1c","updated":"2017-07-05 12:13:11.000000000","message":"Yep, see the comment above the task.\n\nThe compute agent to cell mapping can only happen once the respective compute node has actually registered as an agent, so we can only run it for each compute node, but we have to delegate back to conductor because it\u0027s the one that has DB access.\n\nIs the comment not clear enough? How do you suggest I change it to make it clearer?","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9e30971a2c1ee990641633d3df9f38dbc650893c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  loop_control:"},{"line_number":112,"context_line":"    loop_var: conductor_host"},{"line_number":113,"context_line":"  when:"},{"line_number":114,"context_line":"    - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":115,"context_line":"  tags:"},{"line_number":116,"context_line":"    - nova-config"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_e35d7547","line":114,"in_reply_to":"3f1d235d_d2a00593","updated":"2017-07-05 14:48:32.000000000","message":"ok. sounds good.","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4624ccf2d8c9d52b740e3d40732f38d5a7becd5d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  loop_control:"},{"line_number":112,"context_line":"    loop_var: conductor_host"},{"line_number":113,"context_line":"  when:"},{"line_number":114,"context_line":"    - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":115,"context_line":"  tags:"},{"line_number":116,"context_line":"    - nova-config"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_d2a00593","line":114,"in_reply_to":"3f1d235d_ef3c3ec9","updated":"2017-07-05 13:24:56.000000000","message":"Oh no, that wouldn\u0027t work.\n\nThe task can only run once the compute node is ready, so we tie it to that group for activation. However we *delegate* it to the conductor so that it executes there (where the right config is).\n\nIf we do some sort of group membership check for compute OR conductor, these tasks will fail for conductor because there are no compute nodes yet. The playbook works through the various groups in order, with compute being last as per the upgrade process recommended by nova.","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"}],"tasks/nova_db_post_setup.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"83b434aea0f05b559fb46a5ccc111d8ae9f994a2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# When upgrading we need to map existing instances to the new cell1"},{"line_number":24,"context_line":"# To do this we need the cell UUID."},{"line_number":25,"context_line":"- name: Get UUID of new Nova Cell"},{"line_number":26,"context_line":"  shell: \"{{ nova_bin }}/nova-manage cell_v2 list_cells | awk \u0027/{{ nova_cell1_name }}/ {print $4}\u0027\""},{"line_number":27,"context_line":"  become: yes"},{"line_number":28,"context_line":"  become_user: \"{{ nova_system_user_name }}\""},{"line_number":29,"context_line":"  register: cell1_uuid"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_42e9cab4","line":26,"range":{"start_line":26,"start_character":58,"end_line":26,"end_character":99},"updated":"2017-07-05 12:07:41.000000000","message":"We might want to use grep here, awk will always return 0 even if there\u0027s nothing to match.","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"659e2fc9861031c89785a3bba276b55b76970f5f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# When upgrading we need to map existing instances to the new cell1"},{"line_number":24,"context_line":"# To do this we need the cell UUID."},{"line_number":25,"context_line":"- name: Get UUID of new Nova Cell"},{"line_number":26,"context_line":"  shell: \"{{ nova_bin }}/nova-manage cell_v2 list_cells | awk \u0027/{{ nova_cell1_name }}/ {print $4}\u0027\""},{"line_number":27,"context_line":"  become: yes"},{"line_number":28,"context_line":"  become_user: \"{{ nova_system_user_name }}\""},{"line_number":29,"context_line":"  register: cell1_uuid"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_a2c89e21","line":26,"range":{"start_line":26,"start_character":58,"end_line":26,"end_character":99},"in_reply_to":"3f1d235d_42e9cab4","updated":"2017-07-05 12:13:11.000000000","message":"Yeah, can do.","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"}],"templates/nova.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"83b434aea0f05b559fb46a5ccc111d8ae9f994a2","unresolved":false,"context_lines":[{"line_number":323,"context_line":"server_groups \u003d {{ nova_quota_server_groups }}"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"[upgrade_levels]"},{"line_number":326,"context_line":"compute\u003dauto"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f1d235d_22fb6e79","line":326,"updated":"2017-07-05 12:07:41.000000000","message":"Does this generally work these days? before it\u0027d crash Nova-on first run?","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"659e2fc9861031c89785a3bba276b55b76970f5f","unresolved":false,"context_lines":[{"line_number":323,"context_line":"server_groups \u003d {{ nova_quota_server_groups }}"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"[upgrade_levels]"},{"line_number":326,"context_line":"compute\u003dauto"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f1d235d_02d992f1","line":326,"in_reply_to":"3f1d235d_22fb6e79","updated":"2017-07-05 12:13:11.000000000","message":"Yep, now that we have the services starting in the right order it works just fine.","commit_id":"40a34ee28e0184f7b4724e90de012e05b042c369"}]}
