)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"44f526b33a626676d6cee88c48fba89f67799876","unresolved":false,"context_lines":[{"line_number":13,"context_line":"/templates/nova.conf.j2 template has been changed so new variables can be imported"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"the file nova_install.yml has been changed: added conditional to ensure no new console playbooks are loaded."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I02dc48a8d562d20f37b21e03207e91a220b6dbaf"},{"line_number":18,"context_line":"Partial-Bug: #1696701"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_1d937051","line":16,"updated":"2017-07-03 15:38:02.000000000","message":"It\u0027d be super nice if you could wrap the commit message at 79 chars.\n\nA commit message should not just contain a short summary of what is being done, but also why.","commit_id":"a5e3d41938e1c3ca22bf092e94bb4ed28bb4e898"}],"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"44f526b33a626676d6cee88c48fba89f67799876","unresolved":false,"context_lines":[{"line_number":434,"context_line":"nova_scheduler_init_overrides: {}"},{"line_number":435,"context_line":"nova_spicehtml5proxy_init_overrides: {}"},{"line_number":436,"context_line":"nova_placement_api_init_overrides: {}"},{"line_number":437,"context_line":"nova_nova-serialproxy_init_overrides: {}"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"## Service Name-Group Mapping"},{"line_number":440,"context_line":"nova_services:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_3db98ccb","line":437,"updated":"2017-07-03 15:38:02.000000000","message":"A var name cannot include a dash (\u0027-\u0027)","commit_id":"a5e3d41938e1c3ca22bf092e94bb4ed28bb4e898"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"bc87cb8e3ccc130666db1ff69615ec65b8194466","unresolved":false,"context_lines":[{"line_number":240,"context_line":"nova_serialconsoleproxy_proto: \"ws\""},{"line_number":241,"context_line":"nova_serialconsoleproxy_port: 6083"},{"line_number":242,"context_line":"nova_serialconsoleproxy_port_range: 10000:20000"},{"line_number":243,"context_line":"nova_serialconsoleproxy_base_uri: \"{{ nova_serialconsoleproxy_proto }}://{{ external_lb_vip_address }}:{{ nova_serialconsoleproxy_port }}\""},{"line_number":244,"context_line":"nova_serialconsoleproxy_base_url: \"{{ nova_serialconsoleproxy_base_uri }}\""},{"line_number":245,"context_line":"nova_serialconsoleproxy_serialconsole-proxyserver_proxyclient_address: \"{{ ansible_host }}\""},{"line_number":246,"context_line":"nova_serialconsoleproxy_serialconsole-proxyserver_listen: \"{{ ansible_host }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_ff1501e6","line":243,"updated":"2017-07-18 08:16:21.000000000","message":"What\u0027s the purpose of the base_uri? It\u0027s only used below in line 244. So what is the use case of having both variables?","commit_id":"7fe257649860a3d369993f1502cba2e421039c91"}],"tasks/nova_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"44f526b33a626676d6cee88c48fba89f67799876","unresolved":false,"context_lines":[{"line_number":160,"context_line":"- include: \"consoles/nova_console_{{ nova_console_type }}_install.yml\""},{"line_number":161,"context_line":"  when:"},{"line_number":162,"context_line":"    - \"\u0027nova_console\u0027 in group_names\""},{"line_number":163,"context_line":"    - nova_console_type !\u003d \"serialconsole\""},{"line_number":164,"context_line":"  tags:"},{"line_number":165,"context_line":"    - nova-install"},{"line_number":166,"context_line":"    - nova-novnc-console"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_3dde2c11","line":163,"range":{"start_line":163,"start_character":6,"end_line":163,"end_character":42},"updated":"2017-07-03 15:38:02.000000000","message":"Better to quote properly:\n\n\"nova_console_type !\u003d \u0027serialconsole\u0027\"","commit_id":"a5e3d41938e1c3ca22bf092e94bb4ed28bb4e898"}],"templates/nova.conf.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"44f526b33a626676d6cee88c48fba89f67799876","unresolved":false,"context_lines":[{"line_number":215,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":216,"context_line":"memcache_secret_key \u003d {{ memcached_encryption_key }}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"{% if inventory_hostname in (groups[\u0027nova_console\u0027]) %}"},{"line_number":219,"context_line":"{% if nova_console_type \u003d\u003d \u0027serialconsole\u0027 %}"},{"line_number":220,"context_line":"[serial_console]"},{"line_number":221,"context_line":"serialproxy_host\u003d {{ external_lb_vip_address }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f1d235d_fd0e748b","line":218,"range":{"start_line":218,"start_character":0,"end_line":218,"end_character":55},"updated":"2017-07-03 15:38:02.000000000","message":"This is better expressed as:\n\n{% if \u0027nova_console\u0027 in group_names %}","commit_id":"a5e3d41938e1c3ca22bf092e94bb4ed28bb4e898"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"44f526b33a626676d6cee88c48fba89f67799876","unresolved":false,"context_lines":[{"line_number":216,"context_line":"memcache_secret_key \u003d {{ memcached_encryption_key }}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"{% if inventory_hostname in (groups[\u0027nova_console\u0027]) %}"},{"line_number":219,"context_line":"{% if nova_console_type \u003d\u003d \u0027serialconsole\u0027 %}"},{"line_number":220,"context_line":"[serial_console]"},{"line_number":221,"context_line":"serialproxy_host\u003d {{ external_lb_vip_address }}"},{"line_number":222,"context_line":"serialproxy_port\u003d {{ nova_serialconsoleproxy_port }}"},{"line_number":223,"context_line":"{% endif %}"},{"line_number":224,"context_line":"{% endif %}"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"{% if inventory_hostname in (groups[\u0027nova_conductor\u0027] + groups[\u0027nova_scheduler\u0027] + groups[\u0027nova_api_os_compute\u0027] + groups[\u0027nova_api_metadata\u0027] + groups[\u0027nova_console\u0027] + groups[\u0027nova_api_placement\u0027])%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f1d235d_bd3fdc23","line":223,"range":{"start_line":219,"start_character":0,"end_line":223,"end_character":11},"updated":"2017-07-03 15:38:02.000000000","message":"This section creates a duplicate \u0027serial_console\u0027 section in the conf. Better to include these with the section above.","commit_id":"a5e3d41938e1c3ca22bf092e94bb4ed28bb4e898"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8b250dd663d587e087d8a98edf9a847cd020b883","unresolved":false,"context_lines":[{"line_number":112,"context_line":"cross_az_attach \u003d {{ nova_cross_az_attach }}"},{"line_number":113,"context_line":"os_region_name \u003d {{ nova_service_region }}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"{% if \u0027nova_compute\u0027 in group_names %}"},{"line_number":116,"context_line":"{% if nova_console_type \u003d\u003d \u0027spice\u0027 %}"},{"line_number":117,"context_line":"[spice]"},{"line_number":118,"context_line":"agent_enabled \u003d {{ nova_console_agent_enabled }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1f1a1f67_ab3b4636","line":115,"updated":"2017-07-13 14:51:51.000000000","message":"So this config is not required for any other nova service? not api, consoleauth, etc? I honestly have no idea personally so I\u0027m curious.","commit_id":"7fe257649860a3d369993f1502cba2e421039c91"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1b7730714a77a5a3d8d3fdb3335fbafc5e192b0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"cross_az_attach \u003d {{ nova_cross_az_attach }}"},{"line_number":113,"context_line":"os_region_name \u003d {{ nova_service_region }}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"{% if \u0027nova_compute\u0027 in group_names %}"},{"line_number":116,"context_line":"{% if nova_console_type \u003d\u003d \u0027spice\u0027 %}"},{"line_number":117,"context_line":"[spice]"},{"line_number":118,"context_line":"agent_enabled \u003d {{ nova_console_agent_enabled }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1f1a1f67_53de2e6d","line":115,"in_reply_to":"1f1a1f67_1c90cbec","updated":"2017-07-18 09:57:15.000000000","message":"Great suggestion. +1","commit_id":"7fe257649860a3d369993f1502cba2e421039c91"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"bc87cb8e3ccc130666db1ff69615ec65b8194466","unresolved":false,"context_lines":[{"line_number":112,"context_line":"cross_az_attach \u003d {{ nova_cross_az_attach }}"},{"line_number":113,"context_line":"os_region_name \u003d {{ nova_service_region }}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"{% if \u0027nova_compute\u0027 in group_names %}"},{"line_number":116,"context_line":"{% if nova_console_type \u003d\u003d \u0027spice\u0027 %}"},{"line_number":117,"context_line":"[spice]"},{"line_number":118,"context_line":"agent_enabled \u003d {{ nova_console_agent_enabled }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1f1a1f67_1c90cbec","line":115,"in_reply_to":"1f1a1f67_ab3b4636","updated":"2017-07-18 08:16:21.000000000","message":"I strongly suggest making this a separate patch. You might have overseen something - then it\u0027s easy to just revert this patch. But if you have everything in that single patch, also the serial console support is removed if somebody does a revert of this patch...","commit_id":"7fe257649860a3d369993f1502cba2e421039c91"}]}