)]}'
{"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7f1b42273f2e111544c5874a4d469076514d0e6f","unresolved":false,"context_lines":[{"line_number":371,"context_line":"nova_scheduler_driver_task_period: 60"},{"line_number":372,"context_line":"nova_scheduler_host_subset_size: 10"},{"line_number":373,"context_line":"nova_scheduler_max_attempts: 5"},{"line_number":374,"context_line":"nova_scheduler_default_filters: \u003e-"},{"line_number":375,"context_line":"  RetryFilter,"},{"line_number":376,"context_line":"  AvailabilityZoneFilter,"},{"line_number":377,"context_line":"  AggregateRamFilter,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_2396fd3f","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":30},"updated":"2019-05-14 09:30:27.000000000","message":"Why don\u0027t we convert this to regular list?","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"26d5b7e543ce86de25cf755257297f06e5c56e9e","unresolved":false,"context_lines":[{"line_number":371,"context_line":"nova_scheduler_driver_task_period: 60"},{"line_number":372,"context_line":"nova_scheduler_host_subset_size: 10"},{"line_number":373,"context_line":"nova_scheduler_max_attempts: 5"},{"line_number":374,"context_line":"nova_scheduler_default_filters: \u003e-"},{"line_number":375,"context_line":"  RetryFilter,"},{"line_number":376,"context_line":"  AvailabilityZoneFilter,"},{"line_number":377,"context_line":"  AggregateRamFilter,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_d6bc7307","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":30},"in_reply_to":"dfbec78f_2396fd3f","updated":"2019-05-14 23:14:59.000000000","message":"I agree that it should be a list, but it is also a very environment specific setting that is often overridden afaik, so I opted not to break backward compat. Thoughts?","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f0f61191705ce7d9f487cae83d70f4a72374f760","unresolved":false,"context_lines":[{"line_number":371,"context_line":"nova_scheduler_driver_task_period: 60"},{"line_number":372,"context_line":"nova_scheduler_host_subset_size: 10"},{"line_number":373,"context_line":"nova_scheduler_max_attempts: 5"},{"line_number":374,"context_line":"nova_scheduler_default_filters: \u003e-"},{"line_number":375,"context_line":"  RetryFilter,"},{"line_number":376,"context_line":"  AvailabilityZoneFilter,"},{"line_number":377,"context_line":"  AggregateRamFilter,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_e4269c68","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":30},"in_reply_to":"dfbec78f_d6bc7307","updated":"2019-05-15 06:16:42.000000000","message":"So why can\u0027t we just cover it with release note and place an update for our upgrade script, where convert variable from string to list, by splitting on \",\"?","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7f1b42273f2e111544c5874a4d469076514d0e6f","unresolved":false,"context_lines":[{"line_number":385,"context_line":"  ServerGroupAntiAffinityFilter,"},{"line_number":386,"context_line":"  ServerGroupAffinityFilter,"},{"line_number":387,"context_line":"  NUMATopologyFilter"},{"line_number":388,"context_line":"nova_scheduler_extra_filters: null"},{"line_number":389,"context_line":"nova_scheduler_driver: filter_scheduler"},{"line_number":390,"context_line":"nova_scheduler_available_filters: nova.scheduler.filters.all_filters"},{"line_number":391,"context_line":"nova_scheduler_weight_classes: nova.scheduler.weights.all_weighers"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_63907544","line":388,"range":{"start_line":388,"start_character":30,"end_line":388,"end_character":34},"updated":"2019-05-14 09:30:27.000000000","message":"null generates warnings in log files, iirc. We may use \"[]\" instead","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"26d5b7e543ce86de25cf755257297f06e5c56e9e","unresolved":false,"context_lines":[{"line_number":385,"context_line":"  ServerGroupAntiAffinityFilter,"},{"line_number":386,"context_line":"  ServerGroupAffinityFilter,"},{"line_number":387,"context_line":"  NUMATopologyFilter"},{"line_number":388,"context_line":"nova_scheduler_extra_filters: null"},{"line_number":389,"context_line":"nova_scheduler_driver: filter_scheduler"},{"line_number":390,"context_line":"nova_scheduler_available_filters: nova.scheduler.filters.all_filters"},{"line_number":391,"context_line":"nova_scheduler_weight_classes: nova.scheduler.weights.all_weighers"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_f6b97714","line":388,"range":{"start_line":388,"start_character":30,"end_line":388,"end_character":34},"in_reply_to":"dfbec78f_63907544","updated":"2019-05-14 23:14:59.000000000","message":"Can you point me to this please? null is perfectly valid and regularly used so I don\u0027t think this is the case.","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f0f61191705ce7d9f487cae83d70f4a72374f760","unresolved":false,"context_lines":[{"line_number":385,"context_line":"  ServerGroupAntiAffinityFilter,"},{"line_number":386,"context_line":"  ServerGroupAffinityFilter,"},{"line_number":387,"context_line":"  NUMATopologyFilter"},{"line_number":388,"context_line":"nova_scheduler_extra_filters: null"},{"line_number":389,"context_line":"nova_scheduler_driver: filter_scheduler"},{"line_number":390,"context_line":"nova_scheduler_available_filters: nova.scheduler.filters.all_filters"},{"line_number":391,"context_line":"nova_scheduler_weight_classes: nova.scheduler.weights.all_weighers"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_44344893","line":388,"range":{"start_line":388,"start_character":30,"end_line":388,"end_character":34},"in_reply_to":"dfbec78f_f6b97714","updated":"2019-05-15 06:16:42.000000000","message":"Probably I\u0027ve mixed up things with https://review.opendev.org/#/c/657084/","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"}],"templates/nova.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7f1b42273f2e111544c5874a4d469076514d0e6f","unresolved":false,"context_lines":[{"line_number":326,"context_line":"max_io_ops_per_host \u003d {{ nova_max_io_ops_per_host }}"},{"line_number":327,"context_line":"ram_weight_multiplier \u003d {{ nova_ram_weight_multiplier }}"},{"line_number":328,"context_line":"available_filters \u003d {{ nova_scheduler_available_filters }}"},{"line_number":329,"context_line":"enabled_filters \u003d {{ _nova_scheduler_filters }}"},{"line_number":330,"context_line":"host_subset_size \u003d {{ nova_scheduler_host_subset_size }}"},{"line_number":331,"context_line":"weight_classes \u003d {{ nova_scheduler_weight_classes }}"},{"line_number":332,"context_line":"tracks_instance_changes \u003d {{ nova_scheduler_tracks_instance_changes }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dfbec78f_03a17994","line":329,"range":{"start_line":329,"start_character":21,"end_line":329,"end_character":44},"updated":"2019-05-14 09:30:27.000000000","message":"than this can be \"{{ (nova_scheduler_default_filters + nova_scheduler_extra_filters) | join(\u0027,\u0027) }}\"","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"}],"vars/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7f1b42273f2e111544c5874a4d469076514d0e6f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":76,"context_line":"    mode: \"0640\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"_nova_scheduler_filters: \"{{ [ nova_scheduler_default_filters,"},{"line_number":79,"context_line":"                               nova_scheduler_extra_filters ] |"},{"line_number":80,"context_line":"                              reject(\u0027none\u0027) |"},{"line_number":81,"context_line":"                              join(\u0027,\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_632cf501","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":43},"updated":"2019-05-14 09:30:27.000000000","message":"Than we don\u0027t need this at all","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"792c6927898a19766db07791a0fd4889a588e19b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    group: \"{{ nova_system_group_name }}\""},{"line_number":76,"context_line":"    mode: \"0640\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"_nova_scheduler_filters: \"{{ [ nova_scheduler_default_filters,"},{"line_number":79,"context_line":"                               nova_scheduler_extra_filters ] |"},{"line_number":80,"context_line":"                              reject(\u0027none\u0027) |"},{"line_number":81,"context_line":"                              join(\u0027,\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_fd44a1b9","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":43},"in_reply_to":"dfbec78f_632cf501","updated":"2019-05-17 15:51:05.000000000","message":"Does it hurt to end enabled_filters value with a \u0027,\u0027? \n\nIf it doesn\u0027t hurt, we can end the default value with \u0027,\u0027, and then we can simply concat the nova_scheduler_default_filters with the nova_scheduler_extra_filters (and define nova_scheduler_extra_filters by default to \"\").\n\nHowever, I am concerned about duplicates. Neither the current code or my proposal will detect duplicates. So it means you need to know what\u0027s by default to override stuff.\n\nThat could be solved by having the default as a list, and the extra as a list too, and then we select unique values, and join.","commit_id":"362fc1ecff142fe70c1e1fc1847d9f28ef32bd1f"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"78924d1c97b7210a8957ccda204ccafca4432469","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  {% else %}"},{"line_number":102,"context_line":"  {%   set filters \u003d default_filters %}"},{"line_number":103,"context_line":"  {% endif %}"},{"line_number":104,"context_line":"  {{ default_filters + nova_scheduler_extra_filters }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_bed44620","line":104,"range":{"start_line":104,"start_character":5,"end_line":104,"end_character":20},"updated":"2020-10-13 11:32:56.000000000","message":"This should be `filters` right? The one we set above?","commit_id":"4f993fdd8e226f730378cc7ad25e09a3cb8d9c18"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"66ed9a9a3ad3384008e4aadb69648f7c33ece671","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  {% else %}"},{"line_number":102,"context_line":"  {%   set filters \u003d default_filters %}"},{"line_number":103,"context_line":"  {% endif %}"},{"line_number":104,"context_line":"  {{ default_filters + nova_scheduler_extra_filters }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f6b1bfe_90402c0a","line":104,"range":{"start_line":104,"start_character":5,"end_line":104,"end_character":20},"in_reply_to":"7f6b1bfe_1091bc9a","updated":"2020-10-13 16:27:57.000000000","message":"Follow up fix in https://review.opendev.org/757909\n\nI see your backport already incorporates that fix so it should be good to go already.","commit_id":"4f993fdd8e226f730378cc7ad25e09a3cb8d9c18"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"4d1dc2945194738e0c6028100cab606bd5bfb176","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  {% else %}"},{"line_number":102,"context_line":"  {%   set filters \u003d default_filters %}"},{"line_number":103,"context_line":"  {% endif %}"},{"line_number":104,"context_line":"  {{ default_filters + nova_scheduler_extra_filters }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f6b1bfe_1091bc9a","line":104,"range":{"start_line":104,"start_character":5,"end_line":104,"end_character":20},"in_reply_to":"9f560f44_bed44620","updated":"2020-10-13 16:22:47.000000000","message":"Good catch! Yes you are correct it should be filters.","commit_id":"4f993fdd8e226f730378cc7ad25e09a3cb8d9c18"}]}