)]}'
{"id":"openstack%2Fopenstack-ansible-os_nova~673316","triplet_id":"openstack%2Fopenstack-ansible-os_nova~master~Ic5548f08d200402538a0334f801834ee7ef8a39b","project":"openstack/openstack-ansible-os_nova","branch":"master","topic":"fix-ironic","hashtags":[],"change_id":"Ic5548f08d200402538a0334f801834ee7ef8a39b","subject":"tasks: add conditionals for ironic","status":"MERGED","created":"2019-07-29 15:48:13.000000000","updated":"2019-07-31 17:12:28.000000000","submitted":"2019-07-29 21:30:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673316-1564435838843-c33df9d0","meta_rev_id":"58a43345140013ada531827601e3d8bcbe822542","_number":673316,"virtual_id_number":673316,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},{"value":0,"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":2,"date":"2019-07-29 21:30:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"recommended":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"all":[{"value":1,"date":"2019-07-29 18:41:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},{"value":2,"date":"2019-07-29 15:55:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":2,"date":"2019-07-29 15:58:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},{"value":0,"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-29 19:40:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},{"value":0,"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-29 15:55:28.000000000","updated_by":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"reviewer":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"state":"REVIEWER"},{"updated":"2019-07-29 15:58:54.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2019-07-29 18:41:37.000000000","updated_by":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"reviewer":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"state":"REVIEWER"},{"updated":"2019-07-29 19:40:10.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-07-29 21:30:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a47daa6b4077ecb907acaf7a7845e797b35a96a5","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-29 15:48:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d7dca57f43d69fb03066adf398d95acb4f629655","author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"date":"2019-07-29 15:55:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4698181fd69fd79b43027ed1954ea2d550cbb59a","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-07-29 15:58:54.000000000","message":"Patch Set 1: Code-Review+2\n\nIt looks good to me, but I won\u0027t set +W so that we need one more approval to merge that","accounts_in_message":[],"_revision_number":1},{"id":"5e0b3b9ed184a6645c085a4a87753bffc086d792","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-29 18:08:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/16/673316/1/check/openstack-ansible-linters/ce21c39/ : SUCCESS in 6m 51s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/16/673316/1/check/openstack-ansible-deploy-aio_metal-debian-stable/ba136dd/ : SUCCESS in 1h 06m 39s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/16/673316/1/check/openstack-ansible-deploy-aio_metal-centos-7/e14d422/ : SUCCESS in 1h 28m 04s\n- openstack-ansible-deploy-aio_metal-opensuse-15 http://logs.openstack.org/16/673316/1/check/openstack-ansible-deploy-aio_metal-opensuse-15/a7efa69/ : SUCCESS in 1h 15m 58s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/16/673316/1/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/06377ac/ : SUCCESS in 59m 53s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/16/673316/1/check/openstack-ansible-deploy-aio_distro_metal-centos-7/267f9ec/ : SUCCESS in 52m 28s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 http://logs.openstack.org/16/673316/1/check/openstack-ansible-deploy-aio_distro_metal-opensuse-15/2f7e9c3/ : FAILURE in 50m 51s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic http://logs.openstack.org/16/673316/1/check/openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic/8b1cea2/ : SUCCESS in 53m 41s\n- openstack-tox-docs http://logs.openstack.org/16/673316/1/check/openstack-tox-docs/c7e9918/html/ : SUCCESS in 4m 32s\n- openstack-ansible-deploy-aio_metal_lxd-ubuntu-bionic http://logs.openstack.org/16/673316/1/check/openstack-ansible-deploy-aio_metal_lxd-ubuntu-bionic/a7df518/ : SUCCESS in 1h 02m 19s","accounts_in_message":[],"_revision_number":1},{"id":"aeb6206a2e8ddea152840288192ca79df258f44f","author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"date":"2019-07-29 18:41:37.000000000","message":"Patch Set 1: Code-Review+1\n\n+1 looks good!","accounts_in_message":[],"_revision_number":1},{"id":"e16e799505854a06348afa87c4f5d29c60a704be","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-07-29 19:40:10.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"97e73f34578c0997ab5d422452b70f94ac849ce8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-29 19:40:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"58787500b37a139f038bf4155ae5c69b9dd134e6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-29 21:30:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/16/673316/1/gate/openstack-ansible-linters/3dbc87d/ : SUCCESS in 8m 09s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/16/673316/1/gate/openstack-ansible-deploy-aio_metal-debian-stable/2825cce/ : SUCCESS in 1h 21m 00s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/16/673316/1/gate/openstack-ansible-deploy-aio_metal-centos-7/8153a57/ : SUCCESS in 1h 29m 30s\n- openstack-ansible-deploy-aio_metal-opensuse-15 http://logs.openstack.org/16/673316/1/gate/openstack-ansible-deploy-aio_metal-opensuse-15/28d4424/ : SUCCESS in 1h 19m 25s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/16/673316/1/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/c2e7ae1/ : SUCCESS in 1h 07m 39s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/16/673316/1/gate/openstack-ansible-deploy-aio_distro_metal-centos-7/3a34bb1/ : SUCCESS in 1h 00m 54s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic http://logs.openstack.org/16/673316/1/gate/openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic/8fc01ea/ : SUCCESS in 49m 31s\n- openstack-tox-docs http://logs.openstack.org/16/673316/1/gate/openstack-tox-docs/fd7a719/html/ : SUCCESS in 2m 46s\n- openstack-ansible-deploy-aio_metal_lxd-ubuntu-bionic http://logs.openstack.org/16/673316/1/gate/openstack-ansible-deploy-aio_metal_lxd-ubuntu-bionic/f132d01/ : SUCCESS in 59m 31s","accounts_in_message":[],"_revision_number":1},{"id":"4fbef02a1ef91380540cc1f16bd51e7b28e4b127","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-29 21:30:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"2ed7ff4b48328cb4545248bb408a8edac14f4e4e","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-31 17:12:28.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit ec412310afa74b5da444d5ca35d2533d69a3ad39","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"efe094aa674c1444473e55a178dfc98ea80e59ad","revisions":{"efe094aa674c1444473e55a178dfc98ea80e59ad":{"kind":"REWORK","_number":1,"created":"2019-07-29 15:48:13.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/16/673316/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/16/673316/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/16/673316/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/16/673316/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/16/673316/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/16/673316/1"}}},"commit":{"parents":[{"commit":"80aef4671d030601cd73c19c952a5073748ccafc","subject":"Updated from OpenStack Ansible Tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/80aef4671d030601cd73c19c952a5073748ccafc"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-07-29 15:47:57.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-07-29 15:48:11.000000000","tz":-240},"subject":"tasks: add conditionals for ironic","message":"tasks: add conditionals for ironic\n\nThis patch avoids running the nova_compute.yml playbook\nentirely because we already skip the setup portion and we\ndon\u0027t need to setup SSH keys (as there\u0027s no live migration)\nnor setting up NFS.\n\nIt also gets rid of the set_fact inside nova_virt_detect.yml\nbecause it was non-functional in the first place.  This is\nbecause the nova_virt_type was set to \u0027ironic\u0027 in the\ngroup_vars which meant that the autodetect code was\nskipped and therefore that portion never ran.\n\nChange-Id: Ic5548f08d200402538a0334f801834ee7ef8a39b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/efe094aa674c1444473e55a178dfc98ea80e59ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/efe094aa674c1444473e55a178dfc98ea80e59ad"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}