)]}'
{"id":"openstack%2Fopenstack-ansible-os_nova~685071","triplet_id":"openstack%2Fopenstack-ansible-os_nova~master~Ia0227886bd2cc59aab6d2861ef4aa9358d160925","project":"openstack/openstack-ansible-os_nova","branch":"master","topic":"bug/1845497","hashtags":[],"change_id":"Ia0227886bd2cc59aab6d2861ef4aa9358d160925","subject":"Partially revert \"Convert dynamic includes to static imports\"","status":"MERGED","created":"2019-09-26 13:29:17.000000000","updated":"2019-09-28 16:54:27.000000000","submitted":"2019-09-28 16:53:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"685071-1569689603789-af8bbaff","meta_rev_id":"7b1c602002ea277d6f1c9526ce98ec6d94e48f5b","_number":685071,"virtual_id_number":685071,"owner":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},{"value":0,"_account_id":29881,"name":"Jonathan Rosser","email":"jonathan.rosser@gmail.com"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-28 16:53:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"recommended":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"all":[{"value":1,"date":"2019-09-26 21:29:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},{"value":0,"_account_id":29881,"name":"Jonathan Rosser","email":"jonathan.rosser@gmail.com"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":2,"date":"2019-09-28 15:06:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":2,"date":"2019-09-26 20:16:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"all":[{"value":0,"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},{"value":0,"_account_id":29881,"name":"Jonathan Rosser","email":"jonathan.rosser@gmail.com"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":1,"date":"2019-09-28 15:06:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},{"value":0,"_account_id":29881,"name":"Jonathan Rosser","email":"jonathan.rosser@gmail.com"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":29881,"name":"Jonathan Rosser","email":"jonathan.rosser@gmail.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-26 13:30:52.000000000","updated_by":{"_account_id":29881,"name":"Jonathan Rosser","email":"jonathan.rosser@gmail.com"},"reviewer":{"_account_id":29881,"name":"Jonathan Rosser","email":"jonathan.rosser@gmail.com"},"state":"REVIEWER"},{"updated":"2019-09-26 14:18:22.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2019-09-26 20:16:55.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-09-26 21:29:13.000000000","updated_by":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"reviewer":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"state":"REVIEWER"},{"updated":"2019-09-28 15:06:00.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2019-09-28 16:53:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"18f1fbc26b984437fddf502148bc85fdf25e0a94","author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"date":"2019-09-26 13:29:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ea3056cf619dccb636da505a80551bee702a1e52","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-09-26 14:18:22.000000000","message":"Patch Set 1: Code-Review-1\n\nWe need to do partial revert instead, as tasks/nova_compute don\u0027t need reverting and is ok to go.","accounts_in_message":[],"_revision_number":1},{"id":"db3e474d1dec008501d849bb43fb87c7ae336430","author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"date":"2019-09-26 14:50:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c4a2afbd9d8b3254a364981acc6711c472c16966","author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"date":"2019-09-26 14:51:01.000000000","message":"Patch Set 1:\n\n\u003e We need to do partial revert instead, as tasks/nova_compute don\u0027t need reverting and is ok to go.\n\nHm, true. I adjusted that in the lastest patch set.","accounts_in_message":[],"_revision_number":1},{"id":"110243b476067a947f5f5c5553bb92a02477885f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-26 17:10:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/0e5ac2fa7f9a4029a668646db5b08515 : SUCCESS in 8m 54s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/c20ae03d75e6432aa603a4f730dff3e9 : SUCCESS in 1h 42m 12s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/0a4cf71223c346628d137933d9286b48 : SUCCESS in 1h 45m 02s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/8bd5263332834300baec03216d76157d : SUCCESS in 1h 26m 11s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b630b95e43a04e59963eae4324180492 : SUCCESS in 1h 11m 16s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/51af96a74ad741e9a2407870717f6c58 : SUCCESS in 1h 16m 25s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/363db011c70546d8a2e1545e274402ac : FAILURE in 51m 35s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/99992f647a7f4e0fa38e2e3d08b9ad14 : SUCCESS in 49m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/692b54a84c974e6bb3bceec0c5bd62c2 : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":2},{"id":"ce4c66acfcba7c0e26d01be1cc123078d9518ea3","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-09-26 20:16:55.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5113bb95eab99a116231ecc45bb655c05a3110e1","author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"date":"2019-09-26 21:29:13.000000000","message":"Patch Set 2: Code-Review+1\n\nRan into this bug on stein and this fixed the issue for me.","accounts_in_message":[],"_revision_number":2},{"id":"d3a520a4fd2dc6631d9aef115f2ef17e2798777e","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-09-28 15:06:00.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f3d07bec043f2fe45bb49cef8311b5f3a14e0c7e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-28 15:06:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0abdbe711b67db69d8508c41871732c63c7210d0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-28 16:53:23.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/38ff2de5e60243fea33a34abe13d5377 : SUCCESS in 5m 43s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/7cd24508b4c84d9fae75e2a907ff6871 : SUCCESS in 1h 18m 43s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/d368e415ae5c49cfb95301120a4014a6 : SUCCESS in 1h 25m 22s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/e3a6710b97f34775a2fd2c3fc900b935 : SUCCESS in 1h 17m 21s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/08dfb6e8b9454bb7a00831a4da202ed4 : SUCCESS in 1h 29m 15s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/0e40471c50294cb8adacf8124dc414c4 : SUCCESS in 1h 10m 39s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/feafab39e1d94cdfa27654ff186cacca : SUCCESS in 52m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5692596f3f184972932d875fc8827c30 : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":2},{"id":"efe128141e3eb9e8def84d27827eb4aa98810713","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-28 16:53:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"55bbe7aa6811355e2704e8adbf27076813b3174b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-28 16:54:27.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e7f233e3a0be49c6be7e97372fa9749f : SUCCESS in 49s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"417ec1a2961d0da9dea92b8d36d0df7f60c59dbe","revisions":{"3ab5d969b4b21484b02a3a84d2ba97545ab4dfd6":{"kind":"REWORK","_number":1,"created":"2019-09-26 13:29:17.000000000","uploader":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"ref":"refs/changes/71/685071/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/71/685071/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/71/685071/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/71/685071/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/71/685071/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/71/685071/1"}}},"commit":{"parents":[{"commit":"6a7a4bd6a6736f35fb47e852cad97288b52fb499","subject":"Merge \"Convert dynamic includes to static imports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/6a7a4bd6a6736f35fb47e852cad97288b52fb499"}]}],"author":{"name":"Ralf Haferkamp","email":"rhafer@suse.com","date":"2019-09-26 13:12:31.000000000","tz":120},"committer":{"name":"Ralf Haferkamp","email":"rhafer@suse.com","date":"2019-09-26 13:29:15.000000000","tz":120},"subject":"Revert \"Convert dynamic includes to static imports\"","message":"Revert \"Convert dynamic includes to static imports\"\n\nThis reverts commit 68d2839e1825d942f9afc76a6ee4329b9b031e26.\n\nChange-Id: Ia0227886bd2cc59aab6d2861ef4aa9358d160925\nCloses-Bug: 1845497\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/3ab5d969b4b21484b02a3a84d2ba97545ab4dfd6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/3ab5d969b4b21484b02a3a84d2ba97545ab4dfd6"}]},"branch":"refs/heads/master"},"417ec1a2961d0da9dea92b8d36d0df7f60c59dbe":{"kind":"REWORK","_number":2,"created":"2019-09-26 14:50:20.000000000","uploader":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"ref":"refs/changes/71/685071/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/71/685071/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/71/685071/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/71/685071/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/71/685071/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/71/685071/2"}}},"commit":{"parents":[{"commit":"6a7a4bd6a6736f35fb47e852cad97288b52fb499","subject":"Merge \"Convert dynamic includes to static imports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/6a7a4bd6a6736f35fb47e852cad97288b52fb499"}]}],"author":{"name":"Ralf Haferkamp","email":"rhafer@suse.com","date":"2019-09-26 13:12:31.000000000","tz":120},"committer":{"name":"Ralf Haferkamp","email":"rhafer@suse.com","date":"2019-09-26 14:50:00.000000000","tz":120},"subject":"Partially revert \"Convert dynamic includes to static imports\"","message":"Partially revert \"Convert dynamic includes to static imports\"\n\nThis reverts parts of commit 68d2839e1825d942f9afc76a6ee4329b9b031e26.\n\nWhen running the nova playbooks without having \"nova_virt_type\" set. It\nfailed with:\n\n\"Error when evaluating variable in dynamic parent include path:\n drivers/{{ nova_virt_type }}/nova_compute_{{ nova_virt_type }}.yml.\n When using static imports, the parent dynamic include cannot utilize\n host facts or variables from inventory\"\n\nsince the above commit. In ansible it\u0027s not allowed to call import_tasks\nfrom a playbook which was included via include_tasks using a dynamic\ninclude path. So we\u0027re switching back to \"include_tasks\" for the\naffected playbook.\n\nChange-Id: Ia0227886bd2cc59aab6d2861ef4aa9358d160925\nCloses-Bug: 1845497\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/417ec1a2961d0da9dea92b8d36d0df7f60c59dbe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/417ec1a2961d0da9dea92b8d36d0df7f60c59dbe"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}