)]}'
{"id":"openstack%2Fopenstack-ansible-os_nova~693652","triplet_id":"openstack%2Fopenstack-ansible-os_nova~master~Iecb74fd1e5a92e883152ac1e44d22b4a228372fd","project":"openstack/openstack-ansible-os_nova","branch":"master","topic":"nova-compute-pip-packages","hashtags":[],"change_id":"Iecb74fd1e5a92e883152ac1e44d22b4a228372fd","subject":"Undepricate the nova_compute_pip_packages in queens","status":"ABANDONED","created":"2019-11-11 06:20:39.000000000","updated":"2019-11-11 14:05:34.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d922703e408e33a23c04a591a6e9e9cafa2edadd","_number":693652,"virtual_id_number":693652,"owner":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-11-11 10:30:36.000000000","_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-11-11 13:13:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-11-11 09:32:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-11 09:32:30.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-11-11 13:13:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"904b497cbf478b71e32aaaf1668881f5c0fe0a6f","author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"date":"2019-11-11 06:20:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cc6448df26a1862624bc94fe1438507bc6327ca7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-11 09:04:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/19ae5c51cca941829351dcdd46028e19 : SUCCESS in 5m 43s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/af2eff6099864c5fb994cd908daff67c : SUCCESS in 1h 22m 05s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/8b496e3cb9f44ff5932b813680d77276 : SUCCESS in 1h 34m 31s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/8e79920430bf4ab48d02bfc6e532a444 : SUCCESS in 1h 31m 08s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2c7d0f370a8048838cb109365ad8cf82 : SUCCESS in 1h 12m 51s\n- openstack-ansible-upgrade-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/494006b7fd534bb6b11df7e2594dbf38 : SUCCESS in 2h 37m 54s\n- openstack-ansible-upgrade-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7520b6bcbd2e46409197e562488692a8 : SUCCESS in 1h 30m 32s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/2fd96654b62f4a69a274148cba76880d : POST_FAILURE in 2h 15m 28s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/d7ded6dfae27480bb3230875832428b7 : POST_FAILURE in 2h 01m 42s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5db929e15e0447bebb5a56bdecc7ca54 : SUCCESS in 50m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f5a0982fab44e5293a49cd657b129e3 : SUCCESS in 7m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ed61192d3d7d46459f8f3c23e8fdd45b : SUCCESS in 5m 37s","accounts_in_message":[],"_revision_number":1},{"id":"9105dc131567d3f186c200802b57bc91aea3134b","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-11-11 09:32:30.000000000","message":"Patch Set 1: Code-Review-1\n\nIn master nova_user_pip_packages will do what you want, there is no need for an extra variable?\n\nTry overriding nova_pip_packages in group_vars on your queens deployment to add extra packages to the compute nodes.","accounts_in_message":[],"_revision_number":1},{"id":"74e8fca2eb2ca87f2061761492c022a901e01e9b","author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"date":"2019-11-11 10:29:04.000000000","message":"Patch Set 1:\n\n\u003e In master nova_user_pip_packages will do what you want, there is no\n \u003e need for an extra variable?\n \u003e \n \u003e Try overriding nova_pip_packages in group_vars on your queens\n \u003e deployment to add extra packages to the compute nodes.\n\nIndeed, as I said in the commit message. So how we can fix the BUG in the QUEENS https://review.opendev.org/#/c/693504/ ? without commit in the master? (facepalm)","accounts_in_message":[],"_revision_number":1},{"id":"2839a84d671d625cd3dd35548fa64d9dc4b10bb6","author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"date":"2019-11-11 10:30:36.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"fc107d38c7b6d3fe8e177d9f93f24d4fe7a229d4","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-11-11 11:08:59.000000000","message":"Patch Set 1:\n\n\u003e Indeed, as I said in the commit message. So how we can fix the BUG\n \u003e in the QUEENS https://review.opendev.org/#/c/693504/ ? without\n \u003e commit in the master? (facepalm)\n\nMy suggestion to you on queens both in this patch and the previous one you made is to try overriding pip_install_packages in the group_vars for your compute nodes. If this works it is not necessary to make any changes to the code. Could you please try this and see if it works?","accounts_in_message":[],"_revision_number":1},{"id":"b310f9b19d72adfe67c1e68f6d42f23ddb614f2a","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-11-11 11:09:51.000000000","message":"Patch Set 1:\n\n\u003e \u003e Indeed, as I said in the commit message. So how we can fix the\n \u003e BUG\n \u003e \u003e in the QUEENS https://review.opendev.org/#/c/693504/ ? without\n \u003e \u003e commit in the master? (facepalm)\n \nOf course I mean try overriding nova_pip_packages for your compute nodes.\n \u003e My suggestion to you on queens both in this patch and the previous\n \u003e one you made is to try overriding pip_install_packages in the\n \u003e group_vars for your compute nodes. If this works it is not\n \u003e necessary to make any changes to the code. Could you please try\n \u003e this and see if it works?","accounts_in_message":[],"_revision_number":1},{"id":"3f611c00d34046a801a5f88a97789b5cefd04d75","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-11 13:13:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/c7deafed0eaa44d98d9377ccd3a46fb1 : SUCCESS in 6m 10s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/a3c0fe309a0c4d4293fe7bb01671342b : SUCCESS in 1h 11m 06s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/dd09303289c74bf0ab369f771568f9b7 : SUCCESS in 1h 58m 21s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/e0dd75bc742e410ea4f0354a32ac0586 : SUCCESS in 1h 26m 16s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/812e446b6f374b5cbec8db033159a15c : SUCCESS in 1h 08m 07s\n- openstack-ansible-upgrade-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/0c028c1a8a184df2b9cfe41bccd775ee : SUCCESS in 2h 40m 09s\n- openstack-ansible-upgrade-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0517a494ec1d4946935dba42ec94dd86 : SUCCESS in 1h 45m 08s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/2e94bc54134b4920a64ee7d027bca0d8 : SUCCESS in 1h 04m 41s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/6cbac6ec829a49d59793dfbd9f8eec63 : SUCCESS in 1h 00m 27s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/16d22f837d664636a90b9fa176080044 : SUCCESS in 51m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c788b1f3ee7645e0bf10dbd39336521b : SUCCESS in 5m 36s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7ff921092ed74ecb9e3853002a6a2a13 : SUCCESS in 3m 33s","accounts_in_message":[],"_revision_number":1},{"id":"cf877a20d020f770ce13da73abef688baab5876d","author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"date":"2019-11-11 14:05:34.000000000","message":"Abandoned\n\nhttps://docs.openstack.org/openstack-ansible/latest/reference/configuration/using-overrides.html#group-vars-and-host-vars","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2f7588caade10b7cc9be089f00e1da49cf54d4da","revisions":{"2f7588caade10b7cc9be089f00e1da49cf54d4da":{"kind":"REWORK","_number":1,"created":"2019-11-11 06:20:39.000000000","uploader":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"ref":"refs/changes/52/693652/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/52/693652/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/52/693652/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/52/693652/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/52/693652/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/52/693652/1"}}},"commit":{"parents":[{"commit":"c0f95b09ac3ed9a0ca41d4efae5b9491707ef432","subject":"Add auth_type to the ironic section of nova.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/c0f95b09ac3ed9a0ca41d4efae5b9491707ef432"}]}],"author":{"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","date":"2019-11-11 06:17:19.000000000","tz":180},"committer":{"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","date":"2019-11-11 06:17:19.000000000","tz":180},"subject":"Undepricate the nova_compute_pip_packages in queens","message":"Undepricate the nova_compute_pip_packages in queens\n\nWith the change Id962efe16c425424715409f071c4a304f8416001 we lost the\nability to install the pip packages on the compute nodes only. In upstream\nwe have the many changes and \u0027nova_user_pip_packages\u0027 option, but for\nqueens we partialy revert the Id962efe16c425424715409f071c4a304f8416001.\n\nChange-Id: Iecb74fd1e5a92e883152ac1e44d22b4a228372fd\nSigned-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/2f7588caade10b7cc9be089f00e1da49cf54d4da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/2f7588caade10b7cc9be089f00e1da49cf54d4da"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}