)]}'
{"id":"openstack%2Fopenstack-ansible-os_nova~695045","triplet_id":"openstack%2Fopenstack-ansible-os_nova~master~Id37718c287813fe182d8305485fcf2eb8a993eab","project":"openstack/openstack-ansible-os_nova","branch":"master","topic":"695045","hashtags":[],"change_id":"Id37718c287813fe182d8305485fcf2eb8a993eab","subject":"Disable spicehtml5proxy and serialproxy when installing novnc","status":"ABANDONED","created":"2019-11-19 17:26:02.000000000","updated":"2019-11-20 11:03:39.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f0c5eccd13ee4f2fb2795bf03c572308d35006db","_number":695045,"virtual_id_number":695045,"owner":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-11-19 21:14:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-19 17:42:39.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-11-19 18:10:04.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2019-11-19 21:14:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3738e8efbf2c431ac887bc173f5b40049d92403d","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2019-11-19 17:26:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"948da8149c78b0ecff5a9e9869a03bd33acca108","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-11-19 17:42:39.000000000","message":"Patch Set 1:\n\nI think we should make this more universal and cover the three different console types equally.","accounts_in_message":[],"_revision_number":1},{"id":"bcae0c0bc0202df94404acf463764076470735ea","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-11-19 18:10:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"228710737c365de197f0fd2fb7c8353f34a83a55","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2019-11-19 18:22:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6ebb5765f93a6e407c05559c0b3054980316f299","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2019-11-19 18:28:01.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"2416169ff8816dd1803462e3c560e75f1b6bc7a3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-19 21:14:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/bdc705202e8b4096ac5bcb6706e18bfe : SUCCESS in 5m 52s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/6a66e7d0358b4cd6a0b21f69368d6fc8 : SUCCESS in 1h 25m 12s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/2137aa20a209413aa62d59cbcf3d0ee9 : SUCCESS in 1h 47m 07s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/265ae0ae741542b4ae5f5dae257fae23 : SUCCESS in 1h 31m 32s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/64602678b43d42ef8a807455abe55f7f : SUCCESS in 1h 15m 19s\n- openstack-ansible-upgrade-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/e09a301d17254d55add9b17b9d7551f8 : SUCCESS in 2h 43m 47s\n- openstack-ansible-upgrade-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9e1502cb0fcf4ec99b69d1362cb30393 : SUCCESS in 1h 52m 24s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/5dd63818f7fc410ea20a1ef821c86afe : SUCCESS in 1h 21m 06s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/872bba018c324ab6a6881ab4991ba0c6 : FAILURE in 38m 45s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/284e86c6507041809fbcd98f741865fb : SUCCESS in 58m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f23540021c240c388ed972999e6e4e0 : SUCCESS in 5m 02s","accounts_in_message":[],"_revision_number":3},{"id":"e8caf0cc54f64fb4cf5fb528f1ea619f9c440db7","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2019-11-20 11:03:39.000000000","message":"Abandoned\n\nSee https://review.opendev.org/#/c/695169/","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"989d11ef724edea1ef55735d76b775b1b3a18e6e","revisions":{"7d34508245c939d12daab4b19b0310c6a6147a72":{"kind":"REWORK","_number":1,"created":"2019-11-19 17:26:02.000000000","uploader":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"ref":"refs/changes/45/695045/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/45/695045/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/1"}}},"commit":{"parents":[{"commit":"c0f95b09ac3ed9a0ca41d4efae5b9491707ef432","subject":"Add auth_type to the ironic section of nova.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/c0f95b09ac3ed9a0ca41d4efae5b9491707ef432"}]}],"author":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-11-19 16:57:58.000000000","tz":0},"committer":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-11-19 16:57:58.000000000","tz":0},"subject":"Disable nova-spicehtml5proxy service when installing novnc","message":"Disable nova-spicehtml5proxy service when installing novnc\n\nWhen installing novnc, nova-spicehtml5proxy should be disabled.\nThis is within the best practises to only deploy one remote access method.\n\nNow that novnc has become the default previous installations of\nnova-spicehtml5proxy should be disabled.\n\nUpgraders from stein to train who use the default will otherwise see the\nnova-spicehtml5proxy continually fail and restart.\nThe nova config option use_journal is now set to true, nova-spicehtml5proxy\nservice consumes this config and tries to now use journal and this fails due\nthe systemd-python package not being available in the venv as it will be one\nfrom stein. The dependency on this pip package was only added in train.\n\nChange-Id: Id37718c287813fe182d8305485fcf2eb8a993eab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/7d34508245c939d12daab4b19b0310c6a6147a72"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/7d34508245c939d12daab4b19b0310c6a6147a72"}]},"branch":"refs/heads/master"},"781e97468214ed528c3670cbcbe5571b7b2b70d3":{"kind":"REWORK","_number":2,"created":"2019-11-19 18:22:16.000000000","uploader":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"ref":"refs/changes/45/695045/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/45/695045/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/2"}}},"commit":{"parents":[{"commit":"c0f95b09ac3ed9a0ca41d4efae5b9491707ef432","subject":"Add auth_type to the ironic section of nova.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/c0f95b09ac3ed9a0ca41d4efae5b9491707ef432"}]}],"author":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-11-19 16:57:58.000000000","tz":0},"committer":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-11-19 18:20:06.000000000","tz":0},"subject":"Disable spicehtml5proxy and serialproxy when installing novnc","message":"Disable spicehtml5proxy and serialproxy when installing novnc\n\nWhen installing novnc, nova-spicehtml5proxy and nova-serialproxy\nshould be disabled. This is within the best practises to only deploy one\nremote access method at a time.\n\nNow that novnc has become the default previous installations of\nnova-spicehtml5proxy should be disabled.\n\nUpgraders from stein to train who use the default will otherwise see the\nnova-spicehtml5proxy continually fail and restart.\nThe nova config option use_journal is now set to true, nova-spicehtml5proxy\nservice consumes this config and tries to now use journal and this fails due\nthe systemd-python package not being available in the venv as it will be one\nfrom stein. The dependency on this pip package was only added in train.\n\nChange-Id: Id37718c287813fe182d8305485fcf2eb8a993eab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/781e97468214ed528c3670cbcbe5571b7b2b70d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/781e97468214ed528c3670cbcbe5571b7b2b70d3"}]},"branch":"refs/heads/master"},"989d11ef724edea1ef55735d76b775b1b3a18e6e":{"kind":"REWORK","_number":3,"created":"2019-11-19 18:28:01.000000000","uploader":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"ref":"refs/changes/45/695045/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/45/695045/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/45/695045/3"}}},"commit":{"parents":[{"commit":"c0f95b09ac3ed9a0ca41d4efae5b9491707ef432","subject":"Add auth_type to the ironic section of nova.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/c0f95b09ac3ed9a0ca41d4efae5b9491707ef432"}]}],"author":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-11-19 16:57:58.000000000","tz":0},"committer":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-11-19 18:27:56.000000000","tz":0},"subject":"Disable spicehtml5proxy and serialproxy when installing novnc","message":"Disable spicehtml5proxy and serialproxy when installing novnc\n\nWhen installing novnc, nova-spicehtml5proxy and nova-serialproxy\nshould be disabled. This is within the best practises to only deploy one\nremote access method at a time.\n\nNow that novnc has become the default previous installations of\nnova-spicehtml5proxy should be disabled.\n\nUpgraders from stein to train who use the default will otherwise see the\nnova-spicehtml5proxy continually fail and restart.\nThe nova config option use_journal is now set to true, nova-spicehtml5proxy\nservice consumes this config and tries to now use journal and this fails due\nthe systemd-python package not being available in the venv as it will be one\nfrom stein. The dependency on this pip package was only added in train.\n\nChange-Id: Id37718c287813fe182d8305485fcf2eb8a993eab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/989d11ef724edea1ef55735d76b775b1b3a18e6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/989d11ef724edea1ef55735d76b775b1b3a18e6e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}