)]}'
{"id":"openstack%2Fopenstack-ansible-os_nova~754147","triplet_id":"openstack%2Fopenstack-ansible-os_nova~master~Id7c03399bd54ac790dcfc28ad1dcd7f6d48979db","project":"openstack/openstack-ansible-os_nova","branch":"master","hashtags":[],"change_id":"Id7c03399bd54ac790dcfc28ad1dcd7f6d48979db","subject":"Make possible to set nova_libvirt_images_rbd_pool to empty string","status":"MERGED","created":"2020-09-24 16:45:03.000000000","updated":"2020-10-06 08:59:15.000000000","submitted":"2020-10-06 08:57:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"754147-1601974673307-b16f2ed3","meta_rev_id":"b84b05b4012e5fd8e906fb8f068bf2a4246d7322","_number":754147,"virtual_id_number":754147,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-06 08:57:53.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"all":[{"value":2,"date":"2020-10-06 07:27:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-09-25 21:24:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"all":[{"value":1,"date":"2020-10-06 07:27:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-25 21:24:14.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2020-10-06 07:27:58.000000000","updated_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"reviewer":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"state":"REVIEWER"},{"updated":"2020-10-06 08:57:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5c842239c788771bf752ed488ffe58520c2aa540","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-09-24 16:45:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0396f5b3f90f7bb9602f14b260a62d925bca3e0b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 18:39:43.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/a572732f5ef54c6ba420a275b97ef294 : SUCCESS in 8m 40s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/454a331e195347499511a8bbe100863e : FAILURE in 50m 28s\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/5b66496fa044420ca7eb01075dab6623 : FAILURE in 53m 26s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/11c4b3ab803943c0a73b8dae0c103865 : FAILURE in 49m 49s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/66c7e6be17e64e3ca7ece62a8b8135ed : FAILURE in 48m 54s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/f3c6991b5cbb470999e72fe71d88c7df : FAILURE in 1h 40m 16s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/de312b1d6d3f43eb858f0898eff02f17 : FAILURE in 1h 23m 53s\n- openstack-ansible-deploy-aio_distro_metal-centos-8 https://zuul.opendev.org/t/openstack/build/3e5f7eb0735140b6a1fbe4cda99a333e : FAILURE in 42m 51s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c378eef982b547fc847ab64bb12f9323 : FAILURE in 36m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f5bed917876f469296555b41a4d53449 : SUCCESS in 5m 31s","accounts_in_message":[],"_revision_number":1},{"id":"8fc87dce59133b962aee4fe764141c3c65f2f375","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-09-25 09:51:29.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"39200c710484a135f01c7fc63ddcd05874e322ee","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-25 12:04:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/881d8beed5964418b4fca41a28458f78 : SUCCESS in 10m 02s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/21d24bdee0984f5fa5a8b51844c1622d : SUCCESS in 1h 08m 39s\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/f52bc7d3dbb749b0aeced3b23704bda9 : SUCCESS in 1h 41m 36s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f50f5b69a39e470db3e7b163b1a6a1ce : SUCCESS in 1h 18m 02s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/37cccae67d3d450283c0a888746427e6 : SUCCESS in 1h 07m 12s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/444cc6d953b04a72b3c7b5a07db4cb35 : SUCCESS in 2h 01m 02s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3bcd8eb2ffff405cb563f4d8ef3d7e9b : SUCCESS in 1h 25m 42s\n- openstack-ansible-deploy-aio_distro_metal-centos-8 https://zuul.opendev.org/t/openstack/build/2e06127e82054eaba2a1747e2c711cf3 : SUCCESS in 58m 09s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e6aaf445d21445d8b202b2c594599947 : SUCCESS in 1h 01m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/158c62808be04fa9883c9dce4b94dc05 : SUCCESS in 10m 21s","accounts_in_message":[],"_revision_number":2},{"id":"435956221023f0e8789dd12609cebca08a5f0f29","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-09-25 21:24:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d6388418758613456fe28fedfe3bd52e55cfd1d2","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2020-10-06 07:27:58.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"09cbd8e69a3d8a0dc05816e45e974255cf447ae0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-06 07:28:10.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a3d6231482a7ed37200d569295dc7e616a62a200","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-06 08:57:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"fbea55299fcea0b6810c7dbc7983cac2f97677a3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-06 08:57:53.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/e5127d2bee27402bb7650a9d847b2a28 : SUCCESS in 8m 33s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/8c9f7398c50c46b0b53d03a969b01f9e : SUCCESS in 1h 11m 37s\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/31964dd265fd46fd8e701fe784ce97a5 : SUCCESS in 1h 20m 46s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e3026e9efdea46b58eff3f14d2729fce : SUCCESS in 1h 15m 48s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/679423ed60f34d47bd38fdeb964d6dc4 : SUCCESS in 1h 09m 27s\n- openstack-ansible-deploy-aio_distro_metal-centos-8 https://zuul.opendev.org/t/openstack/build/980804cccb8f48198d992aa689c4aaee : SUCCESS in 1h 02m 54s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/daba96c105874789bc776a091cccd215 : SUCCESS in 56m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9a096f5b488446d29dc936b28ff9759a : SUCCESS in 6m 16s","accounts_in_message":[],"_revision_number":2},{"id":"b84b05b4012e5fd8e906fb8f068bf2a4246d7322","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-06 08:59:15.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9aab9abbae684f36b75890c3794fff0c : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"661ee04abd741be8aa27b75f7474855890bffa51","revisions":{"de2d6d5d5993da43bb77c68382deae9aea0eb8e0":{"kind":"REWORK","_number":1,"created":"2020-09-24 16:45:03.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/47/754147/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/47/754147/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/47/754147/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/47/754147/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/47/754147/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/47/754147/1"}}},"commit":{"parents":[{"commit":"bcbc2099d27e2843ad59e08ea1aaa042083809e6","subject":"Bump libvirt version to prevent compute failure","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/bcbc2099d27e2843ad59e08ea1aaa042083809e6"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@ya.ru","date":"2020-09-24 16:44:48.000000000","tz":180},"committer":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@ya.ru","date":"2020-09-24 16:44:48.000000000","tz":180},"subject":"Make possible to set nova_libvirt_images_rbd_pool to empty string","message":"Make possible to set nova_libvirt_images_rbd_pool to empty string\n\nChecking if nova_libvirt_images_rbd_pool is defined leaves us without\nan opportunity to disable ceph usage for specific node.\nInstead of that we will use bool filter, which will be true if line\nis not empty, and false if it is. That way by setting variable to empty\nstring in host_vars we can disable all relevant options for specific node\n\nChange-Id: Id7c03399bd54ac790dcfc28ad1dcd7f6d48979db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/de2d6d5d5993da43bb77c68382deae9aea0eb8e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/de2d6d5d5993da43bb77c68382deae9aea0eb8e0"}]},"branch":"refs/heads/master"},"661ee04abd741be8aa27b75f7474855890bffa51":{"kind":"REWORK","_number":2,"created":"2020-09-25 09:51:29.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/47/754147/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/47/754147/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/47/754147/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/47/754147/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/47/754147/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/47/754147/2"}}},"commit":{"parents":[{"commit":"bcbc2099d27e2843ad59e08ea1aaa042083809e6","subject":"Bump libvirt version to prevent compute failure","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/bcbc2099d27e2843ad59e08ea1aaa042083809e6"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@ya.ru","date":"2020-09-24 16:44:48.000000000","tz":180},"committer":{"name":"Dmitriy Rabotyagov (noonedeadpunk)","email":"noonedeadpunk@ya.ru","date":"2020-09-25 09:51:26.000000000","tz":0},"subject":"Make possible to set nova_libvirt_images_rbd_pool to empty string","message":"Make possible to set nova_libvirt_images_rbd_pool to empty string\n\nChecking if nova_libvirt_images_rbd_pool is defined leaves us without\nan opportunity to disable ceph usage for specific node.\nInstead of that we will use bool filter, which will be true if line\nis not empty, and false if it is. That way by setting variable to empty\nstring in host_vars we can disable all relevant options for specific node\n\nChange-Id: Id7c03399bd54ac790dcfc28ad1dcd7f6d48979db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/661ee04abd741be8aa27b75f7474855890bffa51"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/661ee04abd741be8aa27b75f7474855890bffa51"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}