)]}'
{"id":"openstack%2Fopenstack-ansible-os_nova~786592","triplet_id":"openstack%2Fopenstack-ansible-os_nova~master~I7410576bd0d28be12b8838c6e2a853b7b8dc950c","project":"openstack/openstack-ansible-os_nova","branch":"master","topic":"bug/1478071","hashtags":[],"change_id":"I7410576bd0d28be12b8838c6e2a853b7b8dc950c","subject":"WIP: Add definitions for database pool sizes in global parameters","status":"ABANDONED","created":"2021-04-16 07:51:31.000000000","updated":"2021-12-06 16:09:06.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ca4e5422b9a9f063d5bc089e3da2ae1b765393cd","_number":786592,"virtual_id_number":786592,"owner":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-04-16 09:52:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-16 07:52:11.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"CC"},{"updated":"2021-04-16 07:53:12.000000000","updated_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2021-04-16 09:52:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a510ca68a860b322cc3bb8d20927cce56d823cde","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2021-04-16 07:51:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"118e54c58bbd95c2f2161c092771a3415bed2333","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-16 07:52:11.000000000","message":"Patch Set 1:\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"a51ce8c595645cfa7036924cb111c066eb237885","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2021-04-16 07:53:12.000000000","message":"Patch Set 1:\n\nAs-per the related bug, I suspect this will either need a release note instructing larger deployments to increase these values, or we might want to have slightly larger defaults for core services like keystone/neutron/nova","accounts_in_message":[],"_revision_number":1},{"id":"51a9a76f35427af73229298d79848c031ae41f6e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2021-04-16 07:58:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"511171e196143b7d37024bc8c9b701ab372b6caf","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2021-04-16 08:10:37.000000000","message":"Patch Set 2:\n\nAn alternative approach for the defaults would be to set the max_pool_size to ~10, but have a larger default max_overflow. As those connections are not persistent there is less chance of them contributing to the database hitting max_connections.","accounts_in_message":[],"_revision_number":2},{"id":"87742dd7dc0e1232f70402ca10dcf923e89c310b","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-16 08:24:51.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e An alternative approach for the defaults would be to set the max_pool_size to ~10, but have a larger default max_overflow. As those connections are not persistent there is less chance of them contributing to the database hitting max_connections.\n\nWell.. I think that max_pool_size for core services is pretty fair. But not sure why to exceed max_overflow? To allow the current amount of connections when required? As total connections will be max_pool_size+max_overflow\n\n\n\nSo I agree that having max_pool_size is probably more wise. We need to create a reno indeed anyway since we\u0027re changing defaults.\n\nAnd regarding max_overflow - dunno... What I saw recently was galera become unrespinsible when user tried to create 150 instances at once. So for sure we should not increase it to the point where we were by default (120). What is wise number is a good question...","accounts_in_message":[],"_revision_number":2},{"id":"496d0b1cb0c41f7bd95d5f232ccd1b4618128a34","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2021-04-16 08:28:51.000000000","message":"Patch Set 2:\n\nIt looks like Keystone uses a default max_overflow of 50, so I was considering max_pool_size of 10 (intended to cover base load), and max_overflow of 50 (intended to cover peak load such as a 150 instance create). In some cases a deployment may still benefit from increasing galera max_connections too, but hopefully that\u0027s a fair compromise as a default.","accounts_in_message":[],"_revision_number":2},{"id":"5c9821a77bd0112c2ef71101f1fb6e56bb54bb6c","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-16 08:33:12.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e It looks like Keystone uses a default max_overflow of 50, so I was considering max_pool_size of 10 (intended to cover base load), and max_overflow of 50 (intended to cover peak load such as a 150 instance create). In some cases a deployment may still benefit from increasing galera max_connections too, but hopefully that\u0027s a fair compromise as a default.\n\nSounds good","accounts_in_message":[],"_revision_number":2},{"id":"68256c9c65b19b7aa67e2651c0f7fc091df6021f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-16 09:52:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/a46add207844449a9b84ef8537954629 : SUCCESS in 10m 00s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/2d987036a29c4ea6b181cc108f8dbc49 : SUCCESS in 1h 19m 59s (non-voting)\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/53c39dbdb55a48cb82128976e1658ce6 : SUCCESS in 1h 21m 18s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f9ee23279a5246e996acc97d410c4ab3 : SUCCESS in 1h 15m 58s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/131fbd981f774279a31241a01eeb41e7 : SUCCESS in 1h 08m 03s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/be1083874c5243019902046d46b271fe : SUCCESS in 1h 19m 17s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/126eb0cd9dcc4e32845d911f4dbb0792 : SUCCESS in 1h 45m 28s\n- openstack-ansible-deploy-aio_distro_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/d70184bfe4034a80894dc27d74f61578 : SUCCESS in 58m 31s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/4110415dca2f4e61b2a94ccc04ad3255 : SUCCESS in 57m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/43edd0d9afbc4a438bbe5bdc9c37f791 : SUCCESS in 5m 26s","accounts_in_message":[],"_revision_number":2},{"id":"ab79bd75e6d9fa260071f7879b1eecc6c5c10d05","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2021-04-16 12:52:22.000000000","message":"Patch Set 2:\n\nAfter some trials and calculations these values still seem a little high. Added notes to https://etherpad.opendev.org/p/db_pool_calculations","accounts_in_message":[],"_revision_number":2},{"id":"48d54540d0ba1f3e6d241a2389b217b826811d10","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-16 16:52:59.000000000","message":"Patch Set 2:\n\nWill have some play with numbers on monday as well","accounts_in_message":[],"_revision_number":2},{"id":"ca4e5422b9a9f063d5bc089e3da2ae1b765393cd","tag":"autogenerated:gerrit:abandon","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2021-12-06 16:09:06.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3818f4eb82106418879c21a0208077a4536b50c1","revisions":{"67cd21c75c2f8ab5bc4260434cea03ece670114b":{"kind":"REWORK","_number":1,"created":"2021-04-16 07:51:31.000000000","uploader":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"ref":"refs/changes/92/786592/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/92/786592/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/92/786592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/92/786592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/92/786592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/92/786592/1"}}},"commit":{"parents":[{"commit":"f7858e9440d515ba5d5a3beb4496e24c55c19d25","subject":"Merge \"Set default qemu settings for RBD\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/f7858e9440d515ba5d5a3beb4496e24c55c19d25"}]}],"author":{"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","date":"2021-04-16 07:43:14.000000000","tz":60},"committer":{"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","date":"2021-04-16 07:51:13.000000000","tz":60},"subject":"WIP: Add definitions for database pool sizes in global parameters","message":"WIP: Add definitions for database pool sizes in global parameters\n\nValues are matched to the SQLAlchemy defaults and should work\nwell with the way \u0027galera_max_connections\u0027 is defined. Larger\ndeployments need to adjust that value significantly when increasing\nthese.\n\nChange-Id: I7410576bd0d28be12b8838c6e2a853b7b8dc950c\nRelated-Bug: #1478071\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/67cd21c75c2f8ab5bc4260434cea03ece670114b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/67cd21c75c2f8ab5bc4260434cea03ece670114b"}]},"branch":"refs/heads/master"},"3818f4eb82106418879c21a0208077a4536b50c1":{"kind":"REWORK","_number":2,"created":"2021-04-16 07:58:43.000000000","uploader":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"ref":"refs/changes/92/786592/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/92/786592/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/92/786592/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/92/786592/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/92/786592/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/92/786592/2"}}},"commit":{"parents":[{"commit":"f7858e9440d515ba5d5a3beb4496e24c55c19d25","subject":"Merge \"Set default qemu settings for RBD\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/f7858e9440d515ba5d5a3beb4496e24c55c19d25"}]}],"author":{"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","date":"2021-04-16 07:43:14.000000000","tz":60},"committer":{"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","date":"2021-04-16 07:58:20.000000000","tz":60},"subject":"WIP: Add definitions for database pool sizes in global parameters","message":"WIP: Add definitions for database pool sizes in global parameters\n\nValues are matched to the SQLAlchemy defaults and should work\nwell with the way \u0027galera_max_connections\u0027 is defined. Larger\ndeployments need to adjust that value significantly when increasing\nthese.\n\nChange-Id: I7410576bd0d28be12b8838c6e2a853b7b8dc950c\nRelated-Bug: #1478071\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/3818f4eb82106418879c21a0208077a4536b50c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/3818f4eb82106418879c21a0208077a4536b50c1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}