)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"bda2dc18ddd49d0d094630b2dbc70da164b8f55a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3b9209b_93ae4977","updated":"2021-12-02 13:50:36.000000000","message":"lgtm","commit_id":"fcd582731b0fb75d3715c2b871266289e999a5e8"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2e36e16ca2d667d77b1a135dfcb40f2b8ba9a9e7","unresolved":true,"context_lines":[{"line_number":90,"context_line":"nova_galera_address: \"{{ galera_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":91,"context_line":"nova_galera_user: nova"},{"line_number":92,"context_line":"nova_galera_database: nova"},{"line_number":93,"context_line":"nova_db_max_overflow: \"{{ openstack_db_max_overflow }}\""},{"line_number":94,"context_line":"nova_db_max_pool_size: \"{{ openstack_db_max_pool_size }}\""},{"line_number":95,"context_line":"nova_db_pool_timeout: \"{{ openstack_db_pool_timeout }}\""},{"line_number":96,"context_line":"nova_db_connection_recycle_time: \"{{ openstack_db_connection_recycle_time }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"43a921db_7cb1a41e","line":93,"range":{"start_line":93,"start_character":26,"end_line":93,"end_character":51},"updated":"2021-11-26 11:22:26.000000000","message":"let\u0027s add `| default(\u002750\u0027)`\n\nsame for others","commit_id":"7056fcc395e5021756fb993e4cc91e181bf4c345"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8b31b3e3ced3a8196434dc26f089010c054c7915","unresolved":true,"context_lines":[{"line_number":90,"context_line":"nova_galera_address: \"{{ galera_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":91,"context_line":"nova_galera_user: nova"},{"line_number":92,"context_line":"nova_galera_database: nova"},{"line_number":93,"context_line":"nova_db_max_overflow: \"{{ openstack_db_max_overflow }}\""},{"line_number":94,"context_line":"nova_db_max_pool_size: \"{{ openstack_db_max_pool_size }}\""},{"line_number":95,"context_line":"nova_db_pool_timeout: \"{{ openstack_db_pool_timeout }}\""},{"line_number":96,"context_line":"nova_db_connection_recycle_time: \"{{ openstack_db_connection_recycle_time }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2fbc0f94_22a6cc72","line":93,"range":{"start_line":93,"start_character":26,"end_line":93,"end_character":51},"in_reply_to":"110c799c_a6365e3f","updated":"2021-12-01 10:19:35.000000000","message":"yep, for each value in the change.\nAs eventually we rely on the value in other repo to exist, which means that role will just fail to execute without it. And we want roles to be as much self-contained as possible.\n\nI\u0027d actually say we rather not define https://review.opendev.org/c/openstack/openstack-ansible/+/819424/2/inventory/group_vars/all/infra.yml#39 then don\u0027t do define default in role. As it\u0027s basically good for performance to reduce amount of variables that are defined in group_vars.\n\nAnd having openstack_db_* is great if you want to apply change for all services at once.","commit_id":"7056fcc395e5021756fb993e4cc91e181bf4c345"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"be44095a214e19ba35ea64671f652ece19e27080","unresolved":false,"context_lines":[{"line_number":90,"context_line":"nova_galera_address: \"{{ galera_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":91,"context_line":"nova_galera_user: nova"},{"line_number":92,"context_line":"nova_galera_database: nova"},{"line_number":93,"context_line":"nova_db_max_overflow: \"{{ openstack_db_max_overflow }}\""},{"line_number":94,"context_line":"nova_db_max_pool_size: \"{{ openstack_db_max_pool_size }}\""},{"line_number":95,"context_line":"nova_db_pool_timeout: \"{{ openstack_db_pool_timeout }}\""},{"line_number":96,"context_line":"nova_db_connection_recycle_time: \"{{ openstack_db_connection_recycle_time }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bbcf39ff_5fbcb9f1","line":93,"range":{"start_line":93,"start_character":26,"end_line":93,"end_character":51},"in_reply_to":"2fbc0f94_22a6cc72","updated":"2021-12-01 21:24:30.000000000","message":"well, it kind of makes sense. I fixed it, even I can\u0027t imagine a scenario when You want to use this repo outside of openstack-ansible :D\n\nand that\u0027s exactly why I defined openstack_db_* in OSA main repository - when You want to change these values, You most likely want to change them for all services. Now it\u0027s done in exactly the same way like `openstack_service_publicuri_proto` for ex.","commit_id":"7056fcc395e5021756fb993e4cc91e181bf4c345"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"033daeac174c84242b2527b097e4067bb96f97b7","unresolved":true,"context_lines":[{"line_number":90,"context_line":"nova_galera_address: \"{{ galera_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":91,"context_line":"nova_galera_user: nova"},{"line_number":92,"context_line":"nova_galera_database: nova"},{"line_number":93,"context_line":"nova_db_max_overflow: \"{{ openstack_db_max_overflow }}\""},{"line_number":94,"context_line":"nova_db_max_pool_size: \"{{ openstack_db_max_pool_size }}\""},{"line_number":95,"context_line":"nova_db_pool_timeout: \"{{ openstack_db_pool_timeout }}\""},{"line_number":96,"context_line":"nova_db_connection_recycle_time: \"{{ openstack_db_connection_recycle_time }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"81fe91cf_ae22e5ba","line":93,"range":{"start_line":93,"start_character":26,"end_line":93,"end_character":51},"in_reply_to":"43a921db_7cb1a41e","updated":"2021-11-30 13:52:00.000000000","message":"I was about to say the same. Otherwise this all looks sensible to me.","commit_id":"7056fcc395e5021756fb993e4cc91e181bf4c345"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1bdfbfe3e419772f2cde9b37dbee21ac953da833","unresolved":true,"context_lines":[{"line_number":90,"context_line":"nova_galera_address: \"{{ galera_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":91,"context_line":"nova_galera_user: nova"},{"line_number":92,"context_line":"nova_galera_database: nova"},{"line_number":93,"context_line":"nova_db_max_overflow: \"{{ openstack_db_max_overflow }}\""},{"line_number":94,"context_line":"nova_db_max_pool_size: \"{{ openstack_db_max_pool_size }}\""},{"line_number":95,"context_line":"nova_db_pool_timeout: \"{{ openstack_db_pool_timeout }}\""},{"line_number":96,"context_line":"nova_db_connection_recycle_time: \"{{ openstack_db_connection_recycle_time }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"110c799c_a6365e3f","line":93,"range":{"start_line":93,"start_character":26,"end_line":93,"end_character":51},"in_reply_to":"81fe91cf_ae22e5ba","updated":"2021-12-01 10:06:29.000000000","message":"Thanks for the suggestion.\nI believe there is a reason for it, but can You please explain me why do we want to set default value twice?\nI mean, the default value for openstack_db_max_overflow is already set here: https://review.opendev.org/c/openstack/openstack-ansible/+/819424/2/inventory/group_vars/all/infra.yml#39\n\nAdditionally, do You suggest to add `| default(\u0027X\u0027)` for each variable in this change or only for `nova_db_max_overflow`?","commit_id":"7056fcc395e5021756fb993e4cc91e181bf4c345"}]}