)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"5717a680c46929764a42d56960c39c4c58a19769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f1550e40_6324adb2","updated":"2022-01-25 14:25:10.000000000","message":"recheck","commit_id":"095c09b8e804fa584fee45aad48075f89d3f9939"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"7b87effa63257ea32530b62e42d721a4e00a51f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3162fad2_4490ad6a","updated":"2022-01-28 11:58:29.000000000","message":"recheck","commit_id":"c8c825afcb076f40ebe11a9f0da52349a8c5d8a2"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"a71a4f6289587b1f6fe0b8e25e706d576d8ad4ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ce2b36ee_fabe8bb5","updated":"2022-02-08 12:31:59.000000000","message":"recheck","commit_id":"127e9e8119f5c2974aefca1332c9b4d3d5ae1e1c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b2c15a18ab51175c5a4ee54206f4f1d68dec0bfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"06ef89fe_ce93c67a","updated":"2022-03-31 12:20:14.000000000","message":"recheck","commit_id":"0ba9086eeb04d65d56f9470fc85e6d76158c022e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4de9058c1f8123a194ea1155c609d43ee1a3418b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"71f4091b_ecef4391","updated":"2022-03-24 10:41:33.000000000","message":"recheck","commit_id":"0ba9086eeb04d65d56f9470fc85e6d76158c022e"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"ec21a671e4138543dc2022401223032ff28a3b5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b8833ace_ab66a420","updated":"2022-02-11 20:20:59.000000000","message":"recheck","commit_id":"0ba9086eeb04d65d56f9470fc85e6d76158c022e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c6c3a6a3bc7dccb1a39db30207580aeb9758dd47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d49d7b53_bc5907bf","updated":"2022-02-11 18:12:47.000000000","message":"recheck","commit_id":"0ba9086eeb04d65d56f9470fc85e6d76158c022e"}],"tasks/nova_compute.yml":[{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"cf231e9d142dfebe3d31e2e2b468ea2881bf505c","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    state: absent"},{"line_number":39,"context_line":"  with_items:"},{"line_number":40,"context_line":"    - \"/usr/local/bin/openstack-nova-key.sh\""},{"line_number":41,"context_line":"    - \"{{ nova_system_user_name }}/.ssh/authorized_keys\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Create ssh keys and config for cold migrations"},{"line_number":44,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"beba761f_d2906215","line":41,"updated":"2022-01-26 08:52:14.000000000","message":"Should this be the home folder rather than username?","commit_id":"095c09b8e804fa584fee45aad48075f89d3f9939"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"6f5857998089d330db4db1128522c7e01df2b2ce","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    state: absent"},{"line_number":39,"context_line":"  with_items:"},{"line_number":40,"context_line":"    - \"/usr/local/bin/openstack-nova-key.sh\""},{"line_number":41,"context_line":"    - \"{{ nova_system_user_name }}/.ssh/authorized_keys\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Create ssh keys and config for cold migrations"},{"line_number":44,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4fdb424d_50ea1801","line":41,"in_reply_to":"beba761f_d2906215","updated":"2022-01-26 10:08:58.000000000","message":"Done","commit_id":"095c09b8e804fa584fee45aad48075f89d3f9939"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"683275842d0bd31518ca9bd82ff9562066e56e05","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  tags:"},{"line_number":32,"context_line":"    - nova-key"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# NOTE(jrosser) Remove this task in the Z development cycle"},{"line_number":35,"context_line":"- name: Clean up legacy ssh keys configuration"},{"line_number":36,"context_line":"  file:"},{"line_number":37,"context_line":"    path: \"{{ item }}\""},{"line_number":38,"context_line":"    state: absent"},{"line_number":39,"context_line":"  with_items:"},{"line_number":40,"context_line":"    - \"/usr/local/bin/openstack-nova-key.sh\""},{"line_number":41,"context_line":"    - \"{{ nova_system_home_folder }}/.ssh/authorized_keys\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Create ssh keys and config for cold migrations"},{"line_number":44,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ad09402a_37a39833","line":41,"range":{"start_line":34,"start_character":0,"end_line":41,"end_character":58},"updated":"2022-01-28 12:15:20.000000000","message":"needs nova-key tag","commit_id":"c8c825afcb076f40ebe11a9f0da52349a8c5d8a2"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0b1e2f235caa7171445b4be2a7bdc28ace459472","unresolved":true,"context_lines":[{"line_number":57,"context_line":"      ssh_keypairs_principals: \"{{ nova_ssh_keypairs_principals }}\""},{"line_number":58,"context_line":"  tags:"},{"line_number":59,"context_line":"    - always"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- name: Run the systemd mount role"},{"line_number":62,"context_line":"  include_role:"},{"line_number":63,"context_line":"    name: systemd_mount"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e0ac408d_29fa201a","line":60,"updated":"2022-02-11 16:23:50.000000000","message":"should we also include conditionally, ie:\n\n  when: groups[\u0027nova_compute\u0027] | length \u003e 1","commit_id":"2e00ca9e0ea3c373daff9187686dd1a8e16ba730"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"6857ea4fb0137b2c2f32f13d69868147a3fdb1b9","unresolved":true,"context_lines":[{"line_number":57,"context_line":"      ssh_keypairs_principals: \"{{ nova_ssh_keypairs_principals }}\""},{"line_number":58,"context_line":"  tags:"},{"line_number":59,"context_line":"    - always"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- name: Run the systemd mount role"},{"line_number":62,"context_line":"  include_role:"},{"line_number":63,"context_line":"    name: systemd_mount"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6942161d_540f4676","line":60,"in_reply_to":"e0ac408d_29fa201a","updated":"2022-02-11 16:45:06.000000000","message":"this is a compute specific tasks file https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/main.yml#L257-L262, or do you want to skip when there is only one compute? Theres a risk of regression in AIO/CI if we skip it?","commit_id":"2e00ca9e0ea3c373daff9187686dd1a8e16ba730"}]}
