)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"d57fd6506145e5bf3124dc57412c208fffb67787","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c31cdfd9_9ad4bac2","updated":"2023-08-04 13:06:51.000000000","message":"I need to add a release note here, and will do so once it\u0027s had a pass through CI.","commit_id":"ae0801d036baf39bb2f0ce637022c460208d1440"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"e8664bf71020cd0c462e31573bf553cc72c23ae8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b5d94af_f1e0c6bf","updated":"2023-08-04 13:01:28.000000000","message":"I\u0027ve chosen to simplify the logic in nova.conf here, so deployments with a mix of console types will end up with surplus config for some hosts. For example when novnc and serialconsole proxies are both deployed, compute hosts which only enable novnc will also have (potentially invalid) serialconsole config in the file. I don\u0027t believe this will have any adverse impact, but it simplifies having to work out which variables are required just on compute hosts, just on the console proxy hosts, or on both, which is not documented.","commit_id":"ae0801d036baf39bb2f0ce637022c460208d1440"}],"releasenotes/notes/nova_console_proxies-98f7705e3ecec051.yaml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7b19385b2d5dbe99d923bb55bc4f7811e530743c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added ``nova_console_proxy_types`` list variable for use when deployments"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1503c449_5e84bfbd","line":1,"updated":"2023-08-16 09:53:22.000000000","message":"should we also add `nova_console_type` as a deprecated variable? Given all conditions can be based just on `nova_console_proxy_types` ofc","commit_id":"d0877c6fd315e5fb99a3515e527f46186305e86a"}],"templates/nova.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7b19385b2d5dbe99d923bb55bc4f7811e530743c","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"[spice]"},{"line_number":84,"context_line":"agent_enabled \u003d {{ nova_spice_console_agent_enabled }}"},{"line_number":85,"context_line":"enabled \u003d {{ (nova_console_type \u003d\u003d \u0027spice\u0027) | ternary(True, False) }}"},{"line_number":86,"context_line":"{% if \u0027spice\u0027 in nova_console_proxy_types %}"},{"line_number":87,"context_line":"html5proxy_base_url \u003d {{ nova_spice_html5proxy_base_url }}"},{"line_number":88,"context_line":"html5proxy_host \u003d {% if nova_management_address \u003d\u003d \u0027localhost\u0027 %}127.0.0.1{% else %}{{ nova_management_address }}{% endif %}"},{"line_number":89,"context_line":"server_listen \u003d {% if nova_management_address \u003d\u003d \u0027localhost\u0027 %}127.0.0.1{% else %}{{ nova_management_address }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"32d56dd7_2aa15ff9","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":44},"updated":"2023-08-16 09:53:22.000000000","message":"why these conditions differ?\n\nIn case I override `nova_console_proxy_types` and add spice there, but won\u0027t add it to nova_console_type - then we end up with disabled console but bunch of params that don\u0027t make sense overall?","commit_id":"d0877c6fd315e5fb99a3515e527f46186305e86a"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"75315e66979eb19fdab422e380955a9618f9474c","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"[spice]"},{"line_number":84,"context_line":"agent_enabled \u003d {{ nova_spice_console_agent_enabled }}"},{"line_number":85,"context_line":"enabled \u003d {{ (nova_console_type \u003d\u003d \u0027spice\u0027) | ternary(True, False) }}"},{"line_number":86,"context_line":"{% if \u0027spice\u0027 in nova_console_proxy_types %}"},{"line_number":87,"context_line":"html5proxy_base_url \u003d {{ nova_spice_html5proxy_base_url }}"},{"line_number":88,"context_line":"html5proxy_host \u003d {% if nova_management_address \u003d\u003d \u0027localhost\u0027 %}127.0.0.1{% else %}{{ nova_management_address }}{% endif %}"},{"line_number":89,"context_line":"server_listen \u003d {% if nova_management_address \u003d\u003d \u0027localhost\u0027 %}127.0.0.1{% else %}{{ nova_management_address }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"43db71c7_c1dbb188","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":44},"in_reply_to":"32d56dd7_2aa15ff9","updated":"2023-08-16 14:16:06.000000000","message":"On the individual compute node, nova_console_type determines which one is enabled in nova.conf. For console proxy nodes, nova_console_proxy_types ensures multiple proxy services can be deployed. nova_console_type is still important (hence why I haven\u0027t deprecated it), because it may need to differ on different hosts. In our case x86 compute hosts need nova_console_type of \u0027novnc\u0027, but arm compute hosts use \u0027serialconsole\u0027. In this case nova_console_proxy_types needs to contain both of these (no matter what architecture it is deployed onto), but it\u0027s important the compute node only enables the correct one.","commit_id":"d0877c6fd315e5fb99a3515e527f46186305e86a"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"6981f0b6b994aa6994a02d922fba7577965afe8a","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"[spice]"},{"line_number":84,"context_line":"agent_enabled \u003d {{ nova_spice_console_agent_enabled }}"},{"line_number":85,"context_line":"enabled \u003d {{ (nova_console_type \u003d\u003d \u0027spice\u0027) | ternary(True, False) }}"},{"line_number":86,"context_line":"{% if \u0027spice\u0027 in nova_console_proxy_types %}"},{"line_number":87,"context_line":"html5proxy_base_url \u003d {{ nova_spice_html5proxy_base_url }}"},{"line_number":88,"context_line":"html5proxy_host \u003d {% if nova_management_address \u003d\u003d \u0027localhost\u0027 %}127.0.0.1{% else %}{{ nova_management_address }}{% endif %}"},{"line_number":89,"context_line":"server_listen \u003d {% if nova_management_address \u003d\u003d \u0027localhost\u0027 %}127.0.0.1{% else %}{{ nova_management_address }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7a08e9fa_8e9aff4d","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":44},"in_reply_to":"43db71c7_c1dbb188","updated":"2023-08-18 06:24:00.000000000","message":"Yes this is two independent things, the set of proxies to run vs. the specific console type to enable per compute either in user_variables or more granularly in group/host vars.","commit_id":"d0877c6fd315e5fb99a3515e527f46186305e86a"}]}