)]}'
{"id":"openstack%2Fopenstack-ansible-os_nova~898779","triplet_id":"openstack%2Fopenstack-ansible-os_nova~stable%2F2023.1~I3deea859a4017ff96919290ba50cb375c0f960ea","project":"openstack/openstack-ansible-os_nova","branch":"stable/2023.1","attention_set":{},"removed_from_attention_set":{"28619":{"account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"last_update":"2023-10-20 13:54:38.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3deea859a4017ff96919290ba50cb375c0f960ea","subject":"Fix logic of discovering hosts by service","status":"MERGED","created":"2023-10-20 09:19:49.000000000","updated":"2023-10-20 13:55:36.000000000","submitted":"2023-10-20 13:54:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"898779","cherry_pick_of_change":898749,"cherry_pick_of_patch_set":2,"meta_rev_id":"0b931a93ca0605d1a67c627adcca5effbd0088b7","_number":898779,"virtual_id_number":898779,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-10-20 13:54:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"all":[{"value":2,"date":"2023-10-20 12:08:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},{"value":2,"date":"2023-10-20 12:08:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"all":[{"value":1,"date":"2023-10-20 12:08:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-10-20 12:07:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-10-20 12:08:52.000000000","updated_by":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"reviewer":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"state":"REVIEWER"}],"messages":[{"id":"6197592cce7a1c5ee842ff3bc6564e84c440ea2c","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-10-20 09:19:49.000000000","message":"Patch Set 1: Cherry Picked from branch master.\n\nThe following files contain Git conflicts:\n* tasks/nova_db_post_setup.yml","accounts_in_message":[],"_revision_number":1},{"id":"de88ad28a8782463bc5220d87079e4a8b93391fe","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-10-20 09:20:34.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"df5c724d2437514725c864c3ea2906f012ed6ed5","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-10-20 09:20:48.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":2},{"id":"aecef8cc4cae0c9165e94a2dea8224738e36291e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-20 12:07:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8e0fecd244154482ab50a3ea3c96bd65\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7a48202da7f14b8d8dc91e39843abb89 : SUCCESS in 11m 32s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/c1a81eabcd434b919294c7a3c8c1df68 : SUCCESS in 1h 25m 59s\n- openstack-ansible-deploy-aio_metal-centos-9-stream https://zuul.opendev.org/t/openstack/build/7bbb6ad40af44d2b8f17d6484f934f11 : SUCCESS in 1h 37m 51s (non-voting)\n- openstack-ansible-deploy-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/72f1f6bb46d54af4ad043831245b5014 : SUCCESS in 1h 43m 18s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0703224288d24dc1899ada580cd94464 : SUCCESS in 1h 36m 44s\n- openstack-ansible-deploy-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/d8b930e6d30541c497816c66cda62d84 : SUCCESS in 1h 35m 16s\n- openstack-ansible-deploy-aio_metal_tls-rockylinux-9 https://zuul.opendev.org/t/openstack/build/445b13a0679b4b0cbfa7868e059d9618 : SUCCESS in 1h 31m 43s\n- openstack-ansible-deploy-aio_metal_tls-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/9ff0414dca0249f38a3d2fa9950a3006 : SUCCESS in 1h 20m 11s\n- openstack-ansible-upgrade-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/64f35bc9c075413e9d3283fc795f655e : SUCCESS in 2h 03m 41s\n- openstack-ansible-upgrade-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/2bfe5a1a0bf948878fcc9bb455551ceb : SUCCESS in 2h 27m 39s\n- openstack-ansible-upgrade_yoga-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9f6c7d0760f14776b93a18b3ec4046fe : SUCCESS in 1h 37m 19s\n- openstack-ansible-deploy-aio_distro_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/a15ce7b51d904f74ab8b29f495e0a2ed : SUCCESS in 1h 09m 00s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/bd96a37f475a4a0fa8bb2f35b98f71e6 : SUCCESS in 55m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c6af733b747d4521862b08e199720981 : SUCCESS in 4m 25s","accounts_in_message":[],"_revision_number":2},{"id":"c1fceebb45aa8ffa19f29e67795ab1272edfb12a","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-10-20 12:08:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"af00a2732ce61cdbebab673fc6822292a339dd5a","author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"date":"2023-10-20 12:08:52.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"33fddac41c72f2406eb1253c54543bff5f33e5ab","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-20 12:10:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c55b524d49ebe84c485b223b95b401ae82c4a2f4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-20 13:54:38.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ec715c737f4349008e51f4e061e46aca\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ed04732588bf4d93a0132ebe14ea3983 : SUCCESS in 17m 09s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/f6e778f7af454616b944df23e40ac9c6 : SUCCESS in 1h 28m 34s\n- openstack-ansible-deploy-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/735ee158a7f04b018fc5c68b9fc3a5ba : SUCCESS in 1h 36m 04s\n- openstack-ansible-deploy-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/af621da43ba14ad7872d4b6cce371e74 : SUCCESS in 1h 28m 18s\n- openstack-ansible-deploy-aio_metal_tls-rockylinux-9 https://zuul.opendev.org/t/openstack/build/af7ee86ce86e4e48aea09485c71b0059 : SUCCESS in 1h 39m 32s\n- openstack-ansible-deploy-aio_metal_tls-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/cec13012953f4ee499e06ea2b7fd093a : SUCCESS in 1h 27m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/99e883b36eb14fd5a898c9d85a4270c6 : SUCCESS in 4m 17s","accounts_in_message":[],"_revision_number":2},{"id":"e0e42c14a0681abed2e0105fd033f89fa9035114","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-20 13:54:38.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"0b931a93ca0605d1a67c627adcca5effbd0088b7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-20 13:55:36.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7f80a7a76dbb4fa886a3170ac913c9b7\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8d7b9af05dd847fe9bc9a98020ef1730 : SUCCESS in 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"77c06d452048b837984118d801f1e62122f3b7e6","revisions":{"371183a7b159aedf469165e4a225dbb223b8b139":{"kind":"REWORK","_number":1,"created":"2023-10-20 09:19:49.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/79/898779/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/79/898779/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/79/898779/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/79/898779/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/79/898779/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/79/898779/1"}}},"commit":{"parents":[{"commit":"b2835499fd5da33e800519de2fdfb7dbad9fe04c","subject":"Add barbican_service_user section","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/b2835499fd5da33e800519de2fdfb7dbad9fe04c"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-10-18 17:04:46.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","date":"2023-10-20 09:19:49.000000000","tz":0},"subject":"Fix logic of discovering hosts by service","message":"Fix logic of discovering hosts by service\n\nFor quite some time, we relate usage of --by-service flag for\nnova-manage cell_v2 discover_hosts command to the used nova_virt_type.\nHowever, we run db_post_setup tasks only once and delegating to the\nconductor host. With latest changes to the logic, when this task in\nincluded from the playbook level it makes even less sense, since\ndefinition of nova_virt_type for conductor is weird and wrong.\n\nInstead, we attempt to detect if ironic is in use by checking hostvars\nof all compute nodes for that. It will include host_vars, group_vars,\nall sort of extra variables, etc.\n\nThus, ironic hosts should be better discovered now with nova-manage\ncommand.\n\nRelated-Bug: #2034583\nChange-Id: I3deea859a4017ff96919290ba50cb375c0f960ea\n(cherry picked from commit 4aa65eb60691c50c9022c22848e3338c8f350af3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/371183a7b159aedf469165e4a225dbb223b8b139"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/371183a7b159aedf469165e4a225dbb223b8b139"}]},"branch":"refs/heads/stable/2023.1"},"77c06d452048b837984118d801f1e62122f3b7e6":{"kind":"REWORK","_number":2,"created":"2023-10-20 09:20:34.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/79/898779/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_nova","ref":"refs/changes/79/898779/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/79/898779/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/79/898779/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/79/898779/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_nova refs/changes/79/898779/2"}}},"commit":{"parents":[{"commit":"b2835499fd5da33e800519de2fdfb7dbad9fe04c","subject":"Add barbican_service_user section","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/b2835499fd5da33e800519de2fdfb7dbad9fe04c"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-10-18 17:04:46.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","date":"2023-10-20 09:20:34.000000000","tz":0},"subject":"Fix logic of discovering hosts by service","message":"Fix logic of discovering hosts by service\n\nFor quite some time, we relate usage of --by-service flag for\nnova-manage cell_v2 discover_hosts command to the used nova_virt_type.\nHowever, we run db_post_setup tasks only once and delegating to the\nconductor host. With latest changes to the logic, when this task in\nincluded from the playbook level it makes even less sense, since\ndefinition of nova_virt_type for conductor is weird and wrong.\n\nInstead, we attempt to detect if ironic is in use by checking hostvars\nof all compute nodes for that. It will include host_vars, group_vars,\nall sort of extra variables, etc.\n\nThus, ironic hosts should be better discovered now with nova-manage\ncommand.\n\nRelated-Bug: #2034583\nChange-Id: I3deea859a4017ff96919290ba50cb375c0f960ea\n(cherry picked from commit 4aa65eb60691c50c9022c22848e3338c8f350af3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/77c06d452048b837984118d801f1e62122f3b7e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_nova/commit/77c06d452048b837984118d801f1e62122f3b7e6"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}