)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d8f32b94247cb31c975968c208133eb5d5d937a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1420622b_7437d14e","updated":"2024-03-12 17:00:33.000000000","message":"I guess I\u0027d suggest adding a new variable, that would make possible to manage the overrides for `usr.lib.libvirt.virt-aa-helper`, as I\u0027d had a usecase back in the days to add an NFS mount to allowed path as well, ie `/var/lib/nova/mnt/** rk`","commit_id":"d2004fffb3734f52f5249d84dd2bfff852370d15"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"3bca66b4e7d3c37ea04adcaf2452024135ad278b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a5cb27cc_6855f49d","updated":"2024-05-02 08:58:33.000000000","message":"recheck - gates should be fixed now","commit_id":"7bec243c626d674b64a79b9f3e961944cbf55603"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9835444d6be6412ecbb742974b20bfda20a2e277","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40148c28_83316407","updated":"2024-03-27 09:57:48.000000000","message":"recheck - ovn repos for rocky linux are now fixed","commit_id":"7bec243c626d674b64a79b9f3e961944cbf55603"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"53046687fa4fbd26b149aaa0493bb2ec8d270209","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70e512ad_e3229553","updated":"2024-03-18 18:20:37.000000000","message":"recheck timeout","commit_id":"7bec243c626d674b64a79b9f3e961944cbf55603"}],"tasks/drivers/kvm/nova_compute_kvm.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d8f32b94247cb31c975968c208133eb5d5d937a1","unresolved":true,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Set apparmor config (Ubuntu/Debian)"},{"line_number":139,"context_line":"  lineinfile:"},{"line_number":140,"context_line":"    dest: \"/etc/apparmor.d/usr.lib.libvirt.virt-aa-helper\""},{"line_number":141,"context_line":"    line: \"  {{ nova_home }}/instances/_base/* r\""},{"line_number":142,"context_line":"    regexp: \"/var/lib/nova/instances/_base/\\\\* r\""},{"line_number":143,"context_line":"    backup: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb327df_e05abdbf","line":140,"range":{"start_line":140,"start_character":11,"end_line":140,"end_character":57},"updated":"2024-03-12 17:00:33.000000000","message":"I think it should be `/etc/apparmor.d/local/usr.lib.libvirt.virt-aa-helper` for leveraging local overrides mechanism.\n\nIt should take precedence over the default rules file.\n\nAlso then I\u0027m not sure if should be lineinfile or just some copy with content. As to proper insure idempotency you;\u0027d need to fetch content and ensure that  `/var/lib/nova` is not there.","commit_id":"d2004fffb3734f52f5249d84dd2bfff852370d15"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"badf5fff7046fa2320b997d2a02bc2f6c8afd7c2","unresolved":true,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Set apparmor config (Ubuntu/Debian)"},{"line_number":139,"context_line":"  lineinfile:"},{"line_number":140,"context_line":"    dest: \"/etc/apparmor.d/usr.lib.libvirt.virt-aa-helper\""},{"line_number":141,"context_line":"    line: \"  {{ nova_home }}/instances/_base/* r\""},{"line_number":142,"context_line":"    regexp: \"/var/lib/nova/instances/_base/\\\\* r\""},{"line_number":143,"context_line":"    backup: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"306cc076_6cafa3d7","line":140,"range":{"start_line":140,"start_character":11,"end_line":140,"end_character":57},"in_reply_to":"b4c94da5_ed3e309b","updated":"2024-03-14 15:27:50.000000000","message":"Hm, maybe `blockinfile` then?\n\nI mean - there\u0027re other legit usecases when you want to modify `usr.lib.libvirt.virt-aa-helper` so it would make sense to me at least to have a variable that allows you to define an extra content to apparmor profile","commit_id":"d2004fffb3734f52f5249d84dd2bfff852370d15"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"b58028c713f866aff06e3f1561343da12e8b0b34","unresolved":true,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Set apparmor config (Ubuntu/Debian)"},{"line_number":139,"context_line":"  lineinfile:"},{"line_number":140,"context_line":"    dest: \"/etc/apparmor.d/usr.lib.libvirt.virt-aa-helper\""},{"line_number":141,"context_line":"    line: \"  {{ nova_home }}/instances/_base/* r\""},{"line_number":142,"context_line":"    regexp: \"/var/lib/nova/instances/_base/\\\\* r\""},{"line_number":143,"context_line":"    backup: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b4c94da5_ed3e309b","line":140,"range":{"start_line":140,"start_character":11,"end_line":140,"end_character":57},"in_reply_to":"bfb327df_e05abdbf","updated":"2024-03-14 14:07:10.000000000","message":"I suppose lineinfile is ok in case of utilising /etc/apparmor.d/local/usr.lib.libvirt.virt-aa-helper\nThat should allow left intact possible customisations and ensure that our line is there anyway.","commit_id":"d2004fffb3734f52f5249d84dd2bfff852370d15"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"367a663979656edbacdaf22d941b58e8552d216a","unresolved":true,"context_lines":[{"line_number":138,"context_line":"- name: Set apparmor config (Ubuntu/Debian)"},{"line_number":139,"context_line":"  lineinfile:"},{"line_number":140,"context_line":"    dest: \"/etc/apparmor.d/usr.lib.libvirt.virt-aa-helper\""},{"line_number":141,"context_line":"    line: \"  {{ nova_home }}/instances/_base/* r\""},{"line_number":142,"context_line":"    regexp: \"/var/lib/nova/instances/_base/\\\\* r\""},{"line_number":143,"context_line":"    backup: true"},{"line_number":144,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"44a214e7_fc148a7f","line":141,"range":{"start_line":141,"start_character":16,"end_line":141,"end_character":25},"updated":"2024-03-12 17:02:07.000000000","message":"`nova_system_home_folder`","commit_id":"d2004fffb3734f52f5249d84dd2bfff852370d15"}]}