)]}'
{"templates/nova.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5907382d93f24aedf34d052c9119118b20fe44cf","unresolved":true,"context_lines":[{"line_number":344,"context_line":"# PCI devices available to VMs"},{"line_number":345,"context_line":"{% if nova_device_spec is string %}"},{"line_number":346,"context_line":"device_spec \u003d {{ nova_device_spec }}"},{"line_number":347,"context_line":"{% elif nova_device_spec is mapping %}"},{"line_number":348,"context_line":"device_spec \u003d {{ nova_device_spec | to_json }}"},{"line_number":349,"context_line":"{% else %}"},{"line_number":350,"context_line":"{% for item in nova_device_spec %}"},{"line_number":351,"context_line":"device_spec \u003d {{ item }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"25ca811a_6cc2e4b6","line":348,"range":{"start_line":347,"start_character":0,"end_line":348,"end_character":46},"updated":"2024-03-14 18:36:01.000000000","message":"wait, are you sure that\u0027s needed? As according to your report, mapping looks correctly handled? only string is not?","commit_id":"d02568a0c1c69e62c911947e4fe980153e35fc1e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"224ce9e62db1de8a7e39d58cb187f7a32dadb7f1","unresolved":false,"context_lines":[{"line_number":344,"context_line":"# PCI devices available to VMs"},{"line_number":345,"context_line":"{% if nova_device_spec is string %}"},{"line_number":346,"context_line":"device_spec \u003d {{ nova_device_spec }}"},{"line_number":347,"context_line":"{% elif nova_device_spec is mapping %}"},{"line_number":348,"context_line":"device_spec \u003d {{ nova_device_spec | to_json }}"},{"line_number":349,"context_line":"{% else %}"},{"line_number":350,"context_line":"{% for item in nova_device_spec %}"},{"line_number":351,"context_line":"device_spec \u003d {{ item }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d0451b37_c604a4a9","line":348,"range":{"start_line":347,"start_character":0,"end_line":348,"end_character":46},"in_reply_to":"25ca811a_6cc2e4b6","updated":"2024-03-14 18:38:42.000000000","message":"Acknowledged","commit_id":"d02568a0c1c69e62c911947e4fe980153e35fc1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"e817f594abfdb1c8cb5fa0b00bbe8e6c9767620a","unresolved":true,"context_lines":[{"line_number":344,"context_line":"# PCI devices available to VMs"},{"line_number":345,"context_line":"{% if nova_device_spec is string %}"},{"line_number":346,"context_line":"device_spec \u003d {{ nova_device_spec }}"},{"line_number":347,"context_line":"{% elif nova_device_spec is mapping %}"},{"line_number":348,"context_line":"device_spec \u003d {{ nova_device_spec | to_json }}"},{"line_number":349,"context_line":"{% else %}"},{"line_number":350,"context_line":"{% for item in nova_device_spec %}"},{"line_number":351,"context_line":"device_spec \u003d {{ item }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5e8edc85_d8b12ea6","line":348,"range":{"start_line":347,"start_character":0,"end_line":348,"end_character":46},"in_reply_to":"25ca811a_6cc2e4b6","updated":"2024-03-14 18:38:41.000000000","message":"It\u0027s needed for mapping too.\nI tried using a mapping and nova complained since it\u0027s using single quotes.\n\n2024-03-14 17:34:32.835 17293 ERROR nova nova.exception.PciConfigInvalidSpec: Invalid [pci]device_spec config: Invalid entry: \u0027{\u0027devname\u0027: \u0027if1\u0027, \u0027physical_network\u0027: \u0027vlan\u0027}\u0027","commit_id":"d02568a0c1c69e62c911947e4fe980153e35fc1e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"56ff62d3366b88c9989b50c40d2efef2eedc0e8f","unresolved":true,"context_lines":[{"line_number":348,"context_line":"device_spec \u003d {{ nova_device_spec | to_json }}"},{"line_number":349,"context_line":"{% else %}"},{"line_number":350,"context_line":"{% for item in nova_device_spec %}"},{"line_number":351,"context_line":"device_spec \u003d {{ item }}"},{"line_number":352,"context_line":"{% endfor %}"},{"line_number":353,"context_line":"{% endif %}"},{"line_number":354,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c4fdabc9_2b1489b9","line":351,"range":{"start_line":351,"start_character":14,"end_line":351,"end_character":24},"updated":"2024-03-14 18:38:14.000000000","message":"oh, ok, I guess I see now... \nBut then I assume it should be also `{{ item | to_json }}`?","commit_id":"d02568a0c1c69e62c911947e4fe980153e35fc1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"565abcbce3e030b76227333c9e3acabf33548bac","unresolved":true,"context_lines":[{"line_number":348,"context_line":"device_spec \u003d {{ nova_device_spec | to_json }}"},{"line_number":349,"context_line":"{% else %}"},{"line_number":350,"context_line":"{% for item in nova_device_spec %}"},{"line_number":351,"context_line":"device_spec \u003d {{ item }}"},{"line_number":352,"context_line":"{% endfor %}"},{"line_number":353,"context_line":"{% endif %}"},{"line_number":354,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e0b1e2c0_81708308","line":351,"range":{"start_line":351,"start_character":14,"end_line":351,"end_character":24},"in_reply_to":"c4fdabc9_2b1489b9","updated":"2024-03-14 19:06:26.000000000","message":"If given a list containing maps, yes.\n\nThe json strings needed to be templated directly.\n{{ string | to_json }} adds a bunch of escaped quotes.\nInvalid entry: \u0027{ \\\"physical_network\\\": \\\"vlan\\\", \\\"devname\\\": \\\"if1\\\" }\u0027","commit_id":"d02568a0c1c69e62c911947e4fe980153e35fc1e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ab83cc8ce2a1cbbb3e7905efac6b25f51d9c0b70","unresolved":false,"context_lines":[{"line_number":348,"context_line":"device_spec \u003d {{ nova_device_spec | to_json }}"},{"line_number":349,"context_line":"{% else %}"},{"line_number":350,"context_line":"{% for item in nova_device_spec %}"},{"line_number":351,"context_line":"device_spec \u003d {{ item }}"},{"line_number":352,"context_line":"{% endfor %}"},{"line_number":353,"context_line":"{% endif %}"},{"line_number":354,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"db12647c_75238ae6","line":351,"range":{"start_line":351,"start_character":14,"end_line":351,"end_character":24},"in_reply_to":"e0b1e2c0_81708308","updated":"2024-03-14 19:11:26.000000000","message":"Done","commit_id":"d02568a0c1c69e62c911947e4fe980153e35fc1e"}]}