)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b66ed15ca0c29be9f18ee533fdbc0cf742760854","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e8e8d88_bc936525","updated":"2024-11-16 07:43:05.000000000","message":"this lgtm code-wise. I assume you\u0027re still testing if that solves the issue you\u0027ve originally tried to solve","commit_id":"61be9e722dc84c5b4fb8ce6848fd0ee46fd3d7da"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"79a535a51bf58e4390f9ef5194502be14d65d31b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ffa065a4_d164e438","in_reply_to":"8e8e8d88_bc936525","updated":"2024-11-18 11:05:11.000000000","message":"To be honest it\u0027ll be hard to test properly until we do our next upgrade at scale, so as long as it\u0027s looking ok I\u0027ll take off the WIP. I still need to come back and look at the other roles, but this one has had the greatest impact to date.","commit_id":"61be9e722dc84c5b4fb8ce6848fd0ee46fd3d7da"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c6595612b3f73e4e5a46e1672e8e9a3f19cbfb5a","unresolved":true,"context_lines":[{"line_number":330,"context_line":"  - \"{{ nova_ironic_console_type }}\""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"# Nova console ssl info, presently only used by novnc console type"},{"line_number":333,"context_line":"nova_console_ssl_dir: \"{{ nova_conf_version_dir }}/ssl\""},{"line_number":334,"context_line":"nova_console_ssl_cert: \"{{ nova_console_ssl_dir }}/nova-console.pem\""},{"line_number":335,"context_line":"nova_console_ssl_key: \"{{ nova_console_ssl_dir }}/nova-console.key\""},{"line_number":336,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0787fe22_7f0c53dc","line":333,"range":{"start_line":333,"start_character":0,"end_line":333,"end_character":55},"updated":"2024-11-13 10:37:31.000000000","message":"I wonder if it should be in `/etc/nova` at all, as make sense to place it outside of versioned dirs and /etc/nova as a whole.\n\nAs certs are not gonna change with nova rebuilds.","commit_id":"9d1fcac590af8e6b0404f9c329587f03458de9a3"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c6595612b3f73e4e5a46e1672e8e9a3f19cbfb5a","unresolved":true,"context_lines":[{"line_number":832,"context_line":"    condition: \"{{ nova_pki_certificates_condition | bool }}\""},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"# nova destination files for SSL certificates"},{"line_number":835,"context_line":"nova_ssl_cert: \"{{ nova_conf_version_dir }}/nova.pem\""},{"line_number":836,"context_line":"nova_ssl_key: \"{{ nova_conf_version_dir }}/nova.key\""},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"# Installation details for SSL certificates"},{"line_number":839,"context_line":"nova_pki_install_certificates:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"55d939b7_d4737c13","line":836,"range":{"start_line":835,"start_character":0,"end_line":836,"end_character":52},"updated":"2024-11-13 10:37:31.000000000","message":"ditto","commit_id":"9d1fcac590af8e6b0404f9c329587f03458de9a3"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"03f993d4117ff8f2a5128ed4aef7c89e68e06445","unresolved":true,"context_lines":[{"line_number":832,"context_line":"    condition: \"{{ nova_pki_certificates_condition | bool }}\""},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"# nova destination files for SSL certificates"},{"line_number":835,"context_line":"nova_ssl_cert: \"{{ nova_conf_version_dir }}/nova.pem\""},{"line_number":836,"context_line":"nova_ssl_key: \"{{ nova_conf_version_dir }}/nova.key\""},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"# Installation details for SSL certificates"},{"line_number":839,"context_line":"nova_pki_install_certificates:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2da1f4a5_75fb0589","line":836,"range":{"start_line":835,"start_character":0,"end_line":836,"end_character":52},"in_reply_to":"55d939b7_d4737c13","updated":"2024-11-13 13:39:09.000000000","message":"Would /var/lib/nova be best for these? Neutron does similar which we could adjust.","commit_id":"9d1fcac590af8e6b0404f9c329587f03458de9a3"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b66ed15ca0c29be9f18ee533fdbc0cf742760854","unresolved":true,"context_lines":[{"line_number":832,"context_line":"    condition: \"{{ nova_pki_certificates_condition | bool }}\""},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"# nova destination files for SSL certificates"},{"line_number":835,"context_line":"nova_ssl_cert: \"{{ nova_system_home_folder }}/nova.pem\""},{"line_number":836,"context_line":"nova_ssl_key: \"{{ nova_system_home_folder }}/nova.key\""},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"# Installation details for SSL certificates"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c73f54f2_8c96940b","line":835,"range":{"start_line":835,"start_character":19,"end_line":835,"end_character":42},"updated":"2024-11-16 07:43:05.000000000","message":"oh, that\u0027s actually a very good idea - homedir was always under my radar somehow","commit_id":"61be9e722dc84c5b4fb8ce6848fd0ee46fd3d7da"}],"tasks/nova_post_install.yml":[{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"a4e78c5764a9c77b490fb1f3847ccf5ead6130c4","unresolved":true,"context_lines":[{"line_number":164,"context_line":"  run_once: true"},{"line_number":165,"context_line":"  with_items: \"{{ nova_core_files }}\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- name: Remove nova-compute config"},{"line_number":168,"context_line":"  file:"},{"line_number":169,"context_line":"    path: /etc/nova/nova-compute.conf"},{"line_number":170,"context_line":"    state: absent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9914ee9b_f371c310","side":"PARENT","line":167,"updated":"2024-11-13 10:27:24.000000000","message":"This needs a sanity check - it looks like a legacy step we can safely remove.","commit_id":"d106a515eb2fc0f1d1f5fbbd237611266c4e53d8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c6595612b3f73e4e5a46e1672e8e9a3f19cbfb5a","unresolved":true,"context_lines":[{"line_number":164,"context_line":"  run_once: true"},{"line_number":165,"context_line":"  with_items: \"{{ nova_core_files }}\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- name: Remove nova-compute config"},{"line_number":168,"context_line":"  file:"},{"line_number":169,"context_line":"    path: /etc/nova/nova-compute.conf"},{"line_number":170,"context_line":"    state: absent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a4f1b083_cdaab050","side":"PARENT","line":167,"in_reply_to":"9914ee9b_f371c310","updated":"2024-11-13 10:37:31.000000000","message":"we might need for `distro` path, but not sure.","commit_id":"d106a515eb2fc0f1d1f5fbbd237611266c4e53d8"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"03f993d4117ff8f2a5128ed4aef7c89e68e06445","unresolved":true,"context_lines":[{"line_number":164,"context_line":"  run_once: true"},{"line_number":165,"context_line":"  with_items: \"{{ nova_core_files }}\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- name: Remove nova-compute config"},{"line_number":168,"context_line":"  file:"},{"line_number":169,"context_line":"    path: /etc/nova/nova-compute.conf"},{"line_number":170,"context_line":"    state: absent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8db4b1d0_9199433e","side":"PARENT","line":167,"in_reply_to":"a4f1b083_cdaab050","updated":"2024-11-13 13:39:09.000000000","message":"You\u0027re right, I\u0027ll reinstate: https://packages.ubuntu.com/oracular/all/nova-compute-qemu/filelist","commit_id":"d106a515eb2fc0f1d1f5fbbd237611266c4e53d8"}]}