)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22111,"name":"Ravi Gummadi","email":"ravigumm@in.ibm.com","username":"ravigumm"},"change_message_id":"2702a6f2cd85148d576969abfbe058b2e9767efd","unresolved":false,"context_lines":[{"line_number":14,"context_line":" - Tests now run with an extra octavia network"},{"line_number":15,"context_line":" - renamed mgmt network to octavia-mgmt"},{"line_number":16,"context_line":" - added saving of iptable rules and added restore"},{"line_number":17,"context_line":"   command to rc.local to survibe reboots"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I761ce0d2dce73d018c2ba2022798a3962e44b235"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dfeb2761_4cf06391","line":17,"range":{"start_line":17,"start_character":26,"end_line":17,"end_character":33},"updated":"2017-03-31 15:57:27.000000000","message":"survive","commit_id":"66c94793f9da3355a5dc0cc1cd30efd3a6cd7175"}],"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4480160b0cfe42958b094895d4481d33c2a66d74","unresolved":false,"context_lines":[{"line_number":266,"context_line":"# Set this to true to drop the iptables rules"},{"line_number":267,"context_line":"octavia_ip_tables_fw: True"},{"line_number":268,"context_line":"# The iptable rules"},{"line_number":269,"context_line":"iptables_rules:"},{"line_number":270,"context_line":"  # Allow icmp"},{"line_number":271,"context_line":"  - \"-A INPUT -p icmp -m state --state NEW -m icmp --icmp-type 8 -j ACCEPT\""},{"line_number":272,"context_line":"  # Allow existing connections"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a1ced50_97e7d445","line":269,"range":{"start_line":269,"start_character":0,"end_line":269,"end_character":15},"updated":"2017-03-23 16:32:32.000000000","message":"Is there a reason this var is not namespaced?","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"16a5b1c1406481cf0ecbbee408607c0b5f8dde35","unresolved":false,"context_lines":[{"line_number":266,"context_line":"# Set this to true to drop the iptables rules"},{"line_number":267,"context_line":"octavia_ip_tables_fw: True"},{"line_number":268,"context_line":"# The iptable rules"},{"line_number":269,"context_line":"iptables_rules:"},{"line_number":270,"context_line":"  # Allow icmp"},{"line_number":271,"context_line":"  - \"-A INPUT -p icmp -m state --state NEW -m icmp --icmp-type 8 -j ACCEPT\""},{"line_number":272,"context_line":"  # Allow existing connections"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_28a9887a","line":269,"range":{"start_line":269,"start_character":0,"end_line":269,"end_character":15},"in_reply_to":"1a1ced50_97e7d445","updated":"2017-03-24 15:42:13.000000000","message":"Done","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4480160b0cfe42958b094895d4481d33c2a66d74","unresolved":false,"context_lines":[{"line_number":280,"context_line":"  - \"-A INPUT -i {{ octavia_container_interface }} -j REJECT --reject-with icmp-port-unreachable\""},{"line_number":281,"context_line":"  - \"-A FORWARD -i {{ octavia_container_interface }} -j REJECT --reject-with icmp-port-unreachable\""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"ip6tables_rules:"},{"line_number":284,"context_line":"  # Allow ping6"},{"line_number":285,"context_line":"  - \"-A INPUT -p icmpv6 -j ACCEPT\""},{"line_number":286,"context_line":"  # Allow heartbeat"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a1ced50_3792a0a0","line":283,"range":{"start_line":283,"start_character":0,"end_line":283,"end_character":16},"updated":"2017-03-23 16:32:32.000000000","message":"Is there a reason this var is not namespaced?","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"16a5b1c1406481cf0ecbbee408607c0b5f8dde35","unresolved":false,"context_lines":[{"line_number":280,"context_line":"  - \"-A INPUT -i {{ octavia_container_interface }} -j REJECT --reject-with icmp-port-unreachable\""},{"line_number":281,"context_line":"  - \"-A FORWARD -i {{ octavia_container_interface }} -j REJECT --reject-with icmp-port-unreachable\""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"ip6tables_rules:"},{"line_number":284,"context_line":"  # Allow ping6"},{"line_number":285,"context_line":"  - \"-A INPUT -p icmpv6 -j ACCEPT\""},{"line_number":286,"context_line":"  # Allow heartbeat"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_08b804c6","line":283,"range":{"start_line":283,"start_character":0,"end_line":283,"end_character":16},"in_reply_to":"1a1ced50_3792a0a0","updated":"2017-03-24 15:42:13.000000000","message":"Done","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"}],"doc/source/configure-octavia.rst":[{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"0f2eabea6f0fbc40f80affe4f14374acb7cb4f18","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Setup a neutron network for use by octavia"},{"line_number":25,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Octavia needs connectivity between the control plane and the"},{"line_number":28,"context_line":"load balancing VMs. For this purpose a provider network should be"},{"line_number":29,"context_line":"created which bridges containers (if the control plane is installed"},{"line_number":30,"context_line":"in a container) or hosts with vms. Refer to the appropriate documentation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_65e3abd9","line":27,"updated":"2017-03-22 22:34:48.000000000","message":"I think what you\u0027re trying to say in this paragraph is that you can setup the control plane in either guest VMs or use the existing OSA control plane that is setup in containers.\n\nIf the OSA container control plane is used then:\n- Shouldn\u0027t you give guidance of how to update the openstack_user_config.yml to declare the network and show which groups to bind to? Like the octavia group and neutron agent at a minimum.\n- Shouldn\u0027t the user reserve some addresses via the \u0027used_ips:\u0027 for the network and specify those addresses as the dhcp range of the subnet. (i see 172.19.1.100-200 are in the example, but were they reserved)?","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"b9786c4b49440e2b0d4b88f662ef3fdb2d63704e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Setup a neutron network for use by octavia"},{"line_number":25,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Octavia needs connectivity between the control plane and the"},{"line_number":28,"context_line":"load balancing VMs. For this purpose a provider network should be"},{"line_number":29,"context_line":"created which bridges containers (if the control plane is installed"},{"line_number":30,"context_line":"in a container) or hosts with vms. Refer to the appropriate documentation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_eecf5c26","line":27,"in_reply_to":"1a1ced50_65e3abd9","updated":"2017-03-23 14:34:53.000000000","message":"I will adjust the docs though all those things are highly dependent on the setup of the network.","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"0f2eabea6f0fbc40f80affe4f14374acb7cb4f18","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Octavia needs connectivity between the control plane and the"},{"line_number":28,"context_line":"load balancing VMs. For this purpose a provider network should be"},{"line_number":29,"context_line":"created which bridges containers (if the control plane is installed"},{"line_number":30,"context_line":"in a container) or hosts with vms. Refer to the appropriate documentation"},{"line_number":31,"context_line":"and consult the tests in this project. In a general case, neutron networking"},{"line_number":32,"context_line":"can be a simple flat network. However in a complex case, this can be whatever"},{"line_number":33,"context_line":"you need and want. Ensure you adjust the deployment accordingly. There are"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_c5429fad","line":30,"range":{"start_line":30,"start_character":30,"end_line":30,"end_character":32},"updated":"2017-03-22 22:34:48.000000000","message":"\u0027VMs\u0027 to be consistent with line 28.","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"b9786c4b49440e2b0d4b88f662ef3fdb2d63704e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Octavia needs connectivity between the control plane and the"},{"line_number":28,"context_line":"load balancing VMs. For this purpose a provider network should be"},{"line_number":29,"context_line":"created which bridges containers (if the control plane is installed"},{"line_number":30,"context_line":"in a container) or hosts with vms. Refer to the appropriate documentation"},{"line_number":31,"context_line":"and consult the tests in this project. In a general case, neutron networking"},{"line_number":32,"context_line":"can be a simple flat network. However in a complex case, this can be whatever"},{"line_number":33,"context_line":"you need and want. Ensure you adjust the deployment accordingly. There are"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_ae65641e","line":30,"range":{"start_line":30,"start_character":30,"end_line":30,"end_character":32},"in_reply_to":"1a1ced50_c5429fad","updated":"2017-03-23 14:34:53.000000000","message":"Done","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"ae70633cc76b675fa525230b196db6d816e5bc11","unresolved":false,"context_lines":[{"line_number":31,"context_line":"and consult the tests in this project. In a general case, neutron networking"},{"line_number":32,"context_line":"can be a simple flat network. However in a complex case, this can be whatever"},{"line_number":33,"context_line":"you need and want. Ensure you adjust the deployment accordingly. There are"},{"line_number":34,"context_line":"a couple of variables who need to be adjusted if you don\u0027t use ``octavia``"},{"line_number":35,"context_line":"for the provider network name and ``mgmt`` for the neutron name. Furthermore,"},{"line_number":36,"context_line":"the system tries to infer certain values based on the inventory which might"},{"line_number":37,"context_line":"not always work and hence might need to be explicitly declared. Review the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_965703c9","line":34,"range":{"start_line":34,"start_character":22,"end_line":34,"end_character":25},"updated":"2017-03-22 20:01:45.000000000","message":"which","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"b9786c4b49440e2b0d4b88f662ef3fdb2d63704e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"and consult the tests in this project. In a general case, neutron networking"},{"line_number":32,"context_line":"can be a simple flat network. However in a complex case, this can be whatever"},{"line_number":33,"context_line":"you need and want. Ensure you adjust the deployment accordingly. There are"},{"line_number":34,"context_line":"a couple of variables who need to be adjusted if you don\u0027t use ``octavia``"},{"line_number":35,"context_line":"for the provider network name and ``mgmt`` for the neutron name. Furthermore,"},{"line_number":36,"context_line":"the system tries to infer certain values based on the inventory which might"},{"line_number":37,"context_line":"not always work and hence might need to be explicitly declared. Review the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_6e80cc8b","line":34,"range":{"start_line":34,"start_character":22,"end_line":34,"end_character":25},"in_reply_to":"1a1ced50_965703c9","updated":"2017-03-23 14:34:53.000000000","message":"Done","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"0f2eabea6f0fbc40f80affe4f14374acb7cb4f18","unresolved":false,"context_lines":[{"line_number":32,"context_line":"can be a simple flat network. However in a complex case, this can be whatever"},{"line_number":33,"context_line":"you need and want. Ensure you adjust the deployment accordingly. There are"},{"line_number":34,"context_line":"a couple of variables who need to be adjusted if you don\u0027t use ``octavia``"},{"line_number":35,"context_line":"for the provider network name and ``mgmt`` for the neutron name. Furthermore,"},{"line_number":36,"context_line":"the system tries to infer certain values based on the inventory which might"},{"line_number":37,"context_line":"not always work and hence might need to be explicitly declared. Review the"},{"line_number":38,"context_line":"file ``defaults\\main.xml`` for more information."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_c529bfe7","line":35,"range":{"start_line":35,"start_character":36,"end_line":35,"end_character":40},"updated":"2017-03-22 22:34:48.000000000","message":"This seems to general of a default name.  Should it be \u0027octavia_mgmt\u0027?","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"b9786c4b49440e2b0d4b88f662ef3fdb2d63704e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"can be a simple flat network. However in a complex case, this can be whatever"},{"line_number":33,"context_line":"you need and want. Ensure you adjust the deployment accordingly. There are"},{"line_number":34,"context_line":"a couple of variables who need to be adjusted if you don\u0027t use ``octavia``"},{"line_number":35,"context_line":"for the provider network name and ``mgmt`` for the neutron name. Furthermore,"},{"line_number":36,"context_line":"the system tries to infer certain values based on the inventory which might"},{"line_number":37,"context_line":"not always work and hence might need to be explicitly declared. Review the"},{"line_number":38,"context_line":"file ``defaults\\main.xml`` for more information."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_ee42fc66","line":35,"range":{"start_line":35,"start_character":36,"end_line":35,"end_character":40},"in_reply_to":"1a1ced50_c529bfe7","updated":"2017-03-23 14:34:53.000000000","message":"Done","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"0f2eabea6f0fbc40f80affe4f14374acb7cb4f18","unresolved":false,"context_lines":[{"line_number":35,"context_line":"for the provider network name and ``mgmt`` for the neutron name. Furthermore,"},{"line_number":36,"context_line":"the system tries to infer certain values based on the inventory which might"},{"line_number":37,"context_line":"not always work and hence might need to be explicitly declared. Review the"},{"line_number":38,"context_line":"file ``defaults\\main.xml`` for more information."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The following is an example how to set up a provider network in neutron:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_45bdcfd6","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":22},"updated":"2017-03-22 22:34:48.000000000","message":"yml.  (I write and say xml all the time too...old school. ;-)","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"b9786c4b49440e2b0d4b88f662ef3fdb2d63704e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"for the provider network name and ``mgmt`` for the neutron name. Furthermore,"},{"line_number":36,"context_line":"the system tries to infer certain values based on the inventory which might"},{"line_number":37,"context_line":"not always work and hence might need to be explicitly declared. Review the"},{"line_number":38,"context_line":"file ``defaults\\main.xml`` for more information."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The following is an example how to set up a provider network in neutron:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_ae33a412","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":22},"in_reply_to":"1a1ced50_45bdcfd6","updated":"2017-03-23 14:34:53.000000000","message":"Done","commit_id":"593314f4520cc03034c018e9135aa5e365eef468"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"cdd1a97f677436b9a4975c795673b6e3a91b5aa0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"``octavia`` for the provider network name and ``octavia-mgmt`` for the neutron"},{"line_number":56,"context_line":"name. Furthermore, the system tries to infer certain values based on the"},{"line_number":57,"context_line":"inventory which might not always work and hence might need to be explicitly"},{"line_number":58,"context_line":"declared.Review the file ``defaults\\main.yml`` for more information."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The following is an example how to set up a provider network in neutron:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_8cf8a64b","line":58,"updated":"2017-03-23 18:00:39.000000000","message":"Need a space between \u0027delcared.\u0027 and \u0027Review\u0027.","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"16a5b1c1406481cf0ecbbee408607c0b5f8dde35","unresolved":false,"context_lines":[{"line_number":55,"context_line":"``octavia`` for the provider network name and ``octavia-mgmt`` for the neutron"},{"line_number":56,"context_line":"name. Furthermore, the system tries to infer certain values based on the"},{"line_number":57,"context_line":"inventory which might not always work and hence might need to be explicitly"},{"line_number":58,"context_line":"declared.Review the file ``defaults\\main.yml`` for more information."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The following is an example how to set up a provider network in neutron:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffe62b97_48f04cca","line":58,"in_reply_to":"1a1ced50_8cf8a64b","updated":"2017-03-24 15:42:13.000000000","message":"Done","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"cdd1a97f677436b9a4975c795673b6e3a91b5aa0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                          --enable-dhcp \\"},{"line_number":73,"context_line":"                          --dns-nameservers list\u003dtrue 8.8.4.4 8.8.8.8"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Special attention needs to be apid to the ``--allocation-pool`` to not have ips"},{"line_number":76,"context_line":"which overlap with ips assigned to hosts or containers."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_4c85ceab","line":75,"range":{"start_line":75,"start_character":30,"end_line":75,"end_character":34},"updated":"2017-03-23 18:00:39.000000000","message":"applied?","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"16a5b1c1406481cf0ecbbee408607c0b5f8dde35","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                          --enable-dhcp \\"},{"line_number":73,"context_line":"                          --dns-nameservers list\u003dtrue 8.8.4.4 8.8.8.8"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Special attention needs to be apid to the ``--allocation-pool`` to not have ips"},{"line_number":76,"context_line":"which overlap with ips assigned to hosts or containers."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffe62b97_88cf747e","line":75,"range":{"start_line":75,"start_character":30,"end_line":75,"end_character":34},"in_reply_to":"1a1ced50_4c85ceab","updated":"2017-03-24 15:42:13.000000000","message":"Done","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"cdd1a97f677436b9a4975c795673b6e3a91b5aa0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                          --dns-nameservers list\u003dtrue 8.8.4.4 8.8.8.8"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Special attention needs to be apid to the ``--allocation-pool`` to not have ips"},{"line_number":76,"context_line":"which overlap with ips assigned to hosts or containers."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. note::"},{"line_number":79,"context_line":"    The system will deploy an iptables firewall if ``octavia_ip_tables_fw`` is set"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_0c7116e1","line":76,"range":{"start_line":76,"start_character":54,"end_line":76,"end_character":55},"updated":"2017-03-23 18:00:39.000000000","message":"Might want to mention \u0027used_ips\u0027 can be used to reverse the address in the openstack_user_config.yml file.","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"16a5b1c1406481cf0ecbbee408607c0b5f8dde35","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                          --dns-nameservers list\u003dtrue 8.8.4.4 8.8.8.8"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Special attention needs to be apid to the ``--allocation-pool`` to not have ips"},{"line_number":76,"context_line":"which overlap with ips assigned to hosts or containers."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. note::"},{"line_number":79,"context_line":"    The system will deploy an iptables firewall if ``octavia_ip_tables_fw`` is set"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffe62b97_088fe423","line":76,"range":{"start_line":76,"start_character":54,"end_line":76,"end_character":55},"in_reply_to":"1a1ced50_0c7116e1","updated":"2017-03-24 15:42:13.000000000","message":"Done","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"}],"tasks/octavia_post_install.yml":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"a1ff9f1abfd8654b4f181085364c2e3bf98da1bc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Setup iptables"},{"line_number":17,"context_line":"  command: \"iptables {{ item }}\""},{"line_number":18,"context_line":"  with_items: \"{{ iptables_rules }}\""},{"line_number":19,"context_line":"  when: octavia_ip_tables_fw|bool \u003d\u003d true"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a1ced50_171f640a","line":17,"updated":"2017-03-23 16:28:40.000000000","message":"Why not use the iptables module here?\nhttps://docs.ansible.com/ansible/iptables_module.html","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4480160b0cfe42958b094895d4481d33c2a66d74","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Setup iptables"},{"line_number":17,"context_line":"  command: \"iptables {{ item }}\""},{"line_number":18,"context_line":"  with_items: \"{{ iptables_rules }}\""},{"line_number":19,"context_line":"  when: octavia_ip_tables_fw|bool \u003d\u003d true"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a1ced50_57c71c64","line":17,"in_reply_to":"1a1ced50_171f640a","updated":"2017-03-23 16:32:32.000000000","message":"Agreed - if possible please use the module as it is idempotent and will likely execute faster.","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"16a5b1c1406481cf0ecbbee408607c0b5f8dde35","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Setup iptables"},{"line_number":17,"context_line":"  command: \"iptables {{ item }}\""},{"line_number":18,"context_line":"  with_items: \"{{ iptables_rules }}\""},{"line_number":19,"context_line":"  when: octavia_ip_tables_fw|bool \u003d\u003d true"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_a81238b0","line":17,"in_reply_to":"1a1ced50_57c71c64","updated":"2017-03-24 15:42:13.000000000","message":"I added the module but it has two drawbacks:\n- You can\u0027t insert rules to log rejected traffic - wasn\u0027t using that anyway but kept it as a \"convenience\" for the operator\n- For some reason it doesn\u0027t interpret \"\" as a null value so I had to do something which is being deprecated to keep the functionality for the user to set the rules. \n\nMy hope is that the module improves and I can add that in a later iteration of Octavia","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d4ae48664ca4cdc03590f170c5892de514c9cc93","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  with_items: \"{{ octavia_iptables_rules }}\""},{"line_number":21,"context_line":"  when: octavia_ip_tables_fw|bool \u003d\u003d true"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: save iptables rules"},{"line_number":24,"context_line":"  shell: iptables-save \u003e /etc/iptables_rules"},{"line_number":25,"context_line":"  args:"},{"line_number":26,"context_line":"    creates: /etc/iptables_rules"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dfeb2761_c903f772","line":23,"updated":"2017-04-04 03:05:08.000000000","message":"I think this could be removed should we use the \"iptables-persist\" package.","commit_id":"a367d44dd357f38d7666e94e3d96ae6fc5f7f1c8"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4aa1cf6269cf64dce8a2f09adfc505569b14cee6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  with_items: \"{{ octavia_iptables_rules }}\""},{"line_number":21,"context_line":"  when: octavia_ip_tables_fw|bool \u003d\u003d true"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: save iptables rules"},{"line_number":24,"context_line":"  shell: iptables-save \u003e /etc/iptables_rules"},{"line_number":25,"context_line":"  args:"},{"line_number":26,"context_line":"    creates: /etc/iptables_rules"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dfeb2761_457e9aaf","line":23,"in_reply_to":"dfeb2761_c903f772","updated":"2017-04-04 13:48:22.000000000","message":"Done","commit_id":"a367d44dd357f38d7666e94e3d96ae6fc5f7f1c8"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d4ae48664ca4cdc03590f170c5892de514c9cc93","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  args:"},{"line_number":26,"context_line":"    creates: /etc/iptables_rules"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Add restore to rc.local"},{"line_number":29,"context_line":"  lineinfile:"},{"line_number":30,"context_line":"    dest: /etc/rc.local"},{"line_number":31,"context_line":"    insertbefore: \u0027^exit 0\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dfeb2761_2915c39c","line":28,"updated":"2017-04-04 03:05:08.000000000","message":"I\u0027d rather we not do this and simply run with the \"iptables-persist\" package on ubuntu and using the iptables service on centos.\n\nUbuntu:\n  invoke-rc.d iptables-persistent save\n\nCentOS:\n  /sbin/service iptables save","commit_id":"a367d44dd357f38d7666e94e3d96ae6fc5f7f1c8"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"599634d0c059477133f0579e8d770a3d01153a2a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  args:"},{"line_number":26,"context_line":"    creates: /etc/iptables_rules"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Add restore to rc.local"},{"line_number":29,"context_line":"  lineinfile:"},{"line_number":30,"context_line":"    dest: /etc/rc.local"},{"line_number":31,"context_line":"    insertbefore: \u0027^exit 0\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dfeb2761_89684f21","line":28,"in_reply_to":"dfeb2761_2915c39c","updated":"2017-04-04 03:09:14.000000000","message":"Yep agreed.. I think the package is actually called \"iptables-persistent\" and the command to save on xenial is now \"netfilter-persistent save\" although the old upstart save method may still work.. not sure","commit_id":"a367d44dd357f38d7666e94e3d96ae6fc5f7f1c8"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4aa1cf6269cf64dce8a2f09adfc505569b14cee6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  args:"},{"line_number":26,"context_line":"    creates: /etc/iptables_rules"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Add restore to rc.local"},{"line_number":29,"context_line":"  lineinfile:"},{"line_number":30,"context_line":"    dest: /etc/rc.local"},{"line_number":31,"context_line":"    insertbefore: \u0027^exit 0\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dfeb2761_e5524e3b","line":28,"in_reply_to":"dfeb2761_89684f21","updated":"2017-04-04 13:48:22.000000000","message":"I was testing this but the table you suggested always returned an error so I made it ignore_errors\u003dtrue; Done anyway","commit_id":"a367d44dd357f38d7666e94e3d96ae6fc5f7f1c8"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  ignore_errors: yes"},{"line_number":29,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002716.04\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#- name: save iptables rules (Ubuntu 14.04)"},{"line_number":32,"context_line":"#  command:  invoke-rc.d iptables-persistent save"},{"line_number":33,"context_line":"#  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002714.04\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_08a9327a","line":31,"updated":"2017-04-06 01:37:11.000000000","message":"I think this can simply be removed. It\u0027s not relevant in Ocata+","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"428d628a022a381f52b172b918122d2c426d3ef0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  ignore_errors: yes"},{"line_number":29,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002716.04\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#- name: save iptables rules (Ubuntu 14.04)"},{"line_number":32,"context_line":"#  command:  invoke-rc.d iptables-persistent save"},{"line_number":33,"context_line":"#  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002714.04\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_d4c2ae85","line":31,"in_reply_to":"bff0334d_08a9327a","updated":"2017-04-06 12:44:11.000000000","message":"Done","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002716.04\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#- name: save iptables rules (Ubuntu 14.04)"},{"line_number":32,"context_line":"#  command:  invoke-rc.d iptables-persistent save"},{"line_number":33,"context_line":"#  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002714.04\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: save iptables rules (CentOS \u0026 RHEL)"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_28c5163d","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":13},"updated":"2017-04-06 01:37:11.000000000","message":"NITPICK: too many spaces.","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"428d628a022a381f52b172b918122d2c426d3ef0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002716.04\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#- name: save iptables rules (Ubuntu 14.04)"},{"line_number":32,"context_line":"#  command:  invoke-rc.d iptables-persistent save"},{"line_number":33,"context_line":"#  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002714.04\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: save iptables rules (CentOS \u0026 RHEL)"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_3441da0c","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":13},"in_reply_to":"bff0334d_28c5163d","updated":"2017-04-06 12:44:11.000000000","message":"Done","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002714.04\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: save iptables rules (CentOS \u0026 RHEL)"},{"line_number":36,"context_line":"  command:  service iptables save"},{"line_number":37,"context_line":"  args:"},{"line_number":38,"context_line":"    warn: False # since we use save service module doesn\u0027t apply"},{"line_number":39,"context_line":"  when: ansible_distribution \u003d\u003d \u0027CentOS\u0027 or ansible_distribution \u003d\u003d \u0027Red Hat Enterprise Linux\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_a8b126e4","line":36,"range":{"start_line":36,"start_character":10,"end_line":36,"end_character":12},"updated":"2017-04-06 01:37:11.000000000","message":"NITPICK: too many spaces.","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"428d628a022a381f52b172b918122d2c426d3ef0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#  when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version \u003d\u003d \u002714.04\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: save iptables rules (CentOS \u0026 RHEL)"},{"line_number":36,"context_line":"  command:  service iptables save"},{"line_number":37,"context_line":"  args:"},{"line_number":38,"context_line":"    warn: False # since we use save service module doesn\u0027t apply"},{"line_number":39,"context_line":"  when: ansible_distribution \u003d\u003d \u0027CentOS\u0027 or ansible_distribution \u003d\u003d \u0027Red Hat Enterprise Linux\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_f473727f","line":36,"range":{"start_line":36,"start_character":10,"end_line":36,"end_character":12},"in_reply_to":"bff0334d_a8b126e4","updated":"2017-04-06 12:44:11.000000000","message":"Done","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"}],"tests/host_vars/localhost.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    veth_peer: \"eth12\""},{"line_number":27,"context_line":"  - name: \"br-storage\""},{"line_number":28,"context_line":"    ip_addr: \"10.1.5.1\""},{"line_number":29,"context_line":"  - name: \"br-octavia\""},{"line_number":30,"context_line":"    ip_addr: \"10.1.7.1\""},{"line_number":31,"context_line":"    veth_peer: \"eth14\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_48cdfa5b","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":21},"updated":"2017-04-06 01:37:11.000000000","message":"maybe this should just be \"br-lb\" or \"br-loadbalancer\". IMO it seems off to name the bridge after the service.","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"428d628a022a381f52b172b918122d2c426d3ef0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    veth_peer: \"eth12\""},{"line_number":27,"context_line":"  - name: \"br-storage\""},{"line_number":28,"context_line":"    ip_addr: \"10.1.5.1\""},{"line_number":29,"context_line":"  - name: \"br-octavia\""},{"line_number":30,"context_line":"    ip_addr: \"10.1.7.1\""},{"line_number":31,"context_line":"    veth_peer: \"eth14\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_b4c96a79","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":21},"in_reply_to":"bff0334d_48cdfa5b","updated":"2017-04-06 12:44:11.000000000","message":"If you deploy a different load balancer, e.g. F5 you won\u0027t need the bridge - so it\u0027s very specific to Octavia. Not sure if naming it br-lb is less or more confusing though,","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"e64625626e404f6a24eea1d14d8e97bfa2cf719f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    veth_peer: \"eth12\""},{"line_number":27,"context_line":"  - name: \"br-storage\""},{"line_number":28,"context_line":"    ip_addr: \"10.1.5.1\""},{"line_number":29,"context_line":"  - name: \"br-octavia\""},{"line_number":30,"context_line":"    ip_addr: \"10.1.7.1\""},{"line_number":31,"context_line":"    veth_peer: \"eth14\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_4bff1801","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":21},"in_reply_to":"bff0334d_b4c96a79","updated":"2017-04-06 15:23:24.000000000","message":"how about br-lbaas\nI don\u0027t think it matters too much since it\u0027s just testing, but for clarity and perhaps for docs that is a good name? That way its clear it\u0027s not for your F5/other LB (e.g. haproxy) but is infact for the LBaaS solution (in this case octavia)","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"}],"tests/host_vars/octavia1.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    type: \"veth\""},{"line_number":27,"context_line":"  octavia_address:"},{"line_number":28,"context_line":"    address: \"{{ octavia_address }}\""},{"line_number":29,"context_line":"    bridge: \"br-octavia\""},{"line_number":30,"context_line":"    interface: \"eth14\""},{"line_number":31,"context_line":"    netmask: \"255.255.255.0\""},{"line_number":32,"context_line":"    type: \"veth\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_e805ee7b","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":23},"updated":"2017-04-06 01:37:11.000000000","message":"maybe this should just be \"br-lb\" or \"br-loadbalancer\". IMO it seems off to name the bridge after the service.","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"}],"tests/os_octavia-overrides.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":66,"context_line":"neutron_provider_networks:"},{"line_number":67,"context_line":"  network_types: \"vxlan,flat\""},{"line_number":68,"context_line":"  network_vxlan_ranges: \"1:1000\""},{"line_number":69,"context_line":"  network_flat_networks: \"flat,octavia\""},{"line_number":70,"context_line":"  network_mappings: \"flat:eth12,octavia:eth14\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#couldn\u0027t find provider_networks inventory var?"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_68f9de7e","line":69,"range":{"start_line":69,"start_character":31,"end_line":69,"end_character":38},"updated":"2017-04-06 01:37:11.000000000","message":"if the bridge is renamed to be more generic this would change too.","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  network_types: \"vxlan,flat\""},{"line_number":68,"context_line":"  network_vxlan_ranges: \"1:1000\""},{"line_number":69,"context_line":"  network_flat_networks: \"flat,octavia\""},{"line_number":70,"context_line":"  network_mappings: \"flat:eth12,octavia:eth14\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#couldn\u0027t find provider_networks inventory var?"},{"line_number":73,"context_line":"octavia_container_interface: \"eth14\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_a8ffe665","line":70,"range":{"start_line":70,"start_character":32,"end_line":70,"end_character":39},"updated":"2017-04-06 01:37:11.000000000","message":"maybe this should just be \"br-lb\" or \"br-loadbalancer\". IMO it seems off to name the bridge after the service.","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"}],"tests/test-configure-octavia.yml":[{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"cdd1a97f677436b9a4975c795673b6e3a91b5aa0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      until: install_packages|success"},{"line_number":82,"context_line":"      retries: 5"},{"line_number":83,"context_line":"      delay: 2"},{"line_number":84,"context_line":"    - name: Create mgmt network"},{"line_number":85,"context_line":"      neutron:"},{"line_number":86,"context_line":"        command: create_network"},{"line_number":87,"context_line":"        openrc_path: /root/openrc"},{"line_number":88,"context_line":"        net_name: \"{{ octavia_neutron_management_network_name }}\""},{"line_number":89,"context_line":"        provider_network_type: flat"},{"line_number":90,"context_line":"        provider_physical_network: octavia"},{"line_number":91,"context_line":"        insecure: \"{{ keystone_service_internaluri_insecure }}\""},{"line_number":92,"context_line":"    - name: Ensure mgmt subnet exists"},{"line_number":93,"context_line":"      neutron:"},{"line_number":94,"context_line":"        command: create_subnet"},{"line_number":95,"context_line":"        openrc_path: /root/openrc"},{"line_number":96,"context_line":"        net_name: \"{{ octavia_neutron_management_network_name }}\""},{"line_number":97,"context_line":"        subnet_name: \"octavia-mgmt-subnet\""},{"line_number":98,"context_line":"        cidr: \"10.1.7.0/24\""},{"line_number":99,"context_line":"        insecure: \"{{ keystone_service_internaluri_insecure }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  vars_files:"},{"line_number":102,"context_line":"    - common/test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a1ced50_6c760a08","line":99,"range":{"start_line":84,"start_character":0,"end_line":99,"end_character":63},"updated":"2017-03-23 18:00:39.000000000","message":"Forgive me if this comment is out of the scope of this review, but is there any reason these tasks can\u0027t be part os_octavia/tasks?  \n\nI didn\u0027t trace it much but it seems the existing octavia_mgmt_network.yml is attempting to retrieve the UUID of this network to use later while dropping the octavia.conf file.  So in a full OSA deployment from nothing up to octavia, wouldn\u0027t these tasks need to be in the mainline?  With these manual steps it seems the user needs to deploy base OS then configure these networks then run the playbook to deploy octavia.","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"16a5b1c1406481cf0ecbbee408607c0b5f8dde35","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      until: install_packages|success"},{"line_number":82,"context_line":"      retries: 5"},{"line_number":83,"context_line":"      delay: 2"},{"line_number":84,"context_line":"    - name: Create mgmt network"},{"line_number":85,"context_line":"      neutron:"},{"line_number":86,"context_line":"        command: create_network"},{"line_number":87,"context_line":"        openrc_path: /root/openrc"},{"line_number":88,"context_line":"        net_name: \"{{ octavia_neutron_management_network_name }}\""},{"line_number":89,"context_line":"        provider_network_type: flat"},{"line_number":90,"context_line":"        provider_physical_network: octavia"},{"line_number":91,"context_line":"        insecure: \"{{ keystone_service_internaluri_insecure }}\""},{"line_number":92,"context_line":"    - name: Ensure mgmt subnet exists"},{"line_number":93,"context_line":"      neutron:"},{"line_number":94,"context_line":"        command: create_subnet"},{"line_number":95,"context_line":"        openrc_path: /root/openrc"},{"line_number":96,"context_line":"        net_name: \"{{ octavia_neutron_management_network_name }}\""},{"line_number":97,"context_line":"        subnet_name: \"octavia-mgmt-subnet\""},{"line_number":98,"context_line":"        cidr: \"10.1.7.0/24\""},{"line_number":99,"context_line":"        insecure: \"{{ keystone_service_internaluri_insecure }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  vars_files:"},{"line_number":102,"context_line":"    - common/test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_c827bc64","line":99,"range":{"start_line":84,"start_character":0,"end_line":99,"end_character":63},"in_reply_to":"1a1ced50_6c760a08","updated":"2017-03-24 15:42:13.000000000","message":"There are several different ways to span a network (e.g. vlan, share a network with other services, etc.) so I didn\u0027t want to put that in since it only helps operators who are running a flat network...","commit_id":"cb0e839c56594a91a374bfcb2f16d77878a5ff96"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        openrc_path: /root/openrc"},{"line_number":88,"context_line":"        net_name: \"{{ octavia_neutron_management_network_name }}\""},{"line_number":89,"context_line":"        provider_network_type: flat"},{"line_number":90,"context_line":"        provider_physical_network: octavia"},{"line_number":91,"context_line":"        insecure: \"{{ keystone_service_internaluri_insecure }}\""},{"line_number":92,"context_line":"    - name: Ensure mgmt subnet exists"},{"line_number":93,"context_line":"      neutron:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_c82fcaf4","line":90,"range":{"start_line":90,"start_character":35,"end_line":90,"end_character":42},"updated":"2017-04-06 01:37:11.000000000","message":"as said elsewhere I dislike the bridge named after the service.","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"34355a68917a48cf941b738bd0e52bd9931a6966","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        command: create_subnet"},{"line_number":95,"context_line":"        openrc_path: /root/openrc"},{"line_number":96,"context_line":"        net_name: \"{{ octavia_neutron_management_network_name }}\""},{"line_number":97,"context_line":"        subnet_name: \"octavia-mgmt-subnet\""},{"line_number":98,"context_line":"        cidr: \"10.1.7.0/24\""},{"line_number":99,"context_line":"        insecure: \"{{ keystone_service_internaluri_insecure }}\""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bff0334d_284876ca","line":97,"range":{"start_line":97,"start_character":22,"end_line":97,"end_character":29},"updated":"2017-04-06 01:37:11.000000000","message":"this should be more generic IMO.","commit_id":"735349d1c913aabcfc9499d8fe21b8c09e3f81ae"}]}