)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"52512c39156d0263f4ea3d888441b0da9f16c60c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set octavia_amp_image_owner_id by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch sets the octavia_amp_image_owner_id default so that the"},{"line_number":10,"context_line":"Octavia configuration file has amp_image_owner_id populated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia86d96911ce7419afd691c84b47ac67b73098b9d"},{"line_number":13,"context_line":"Closes-Bug: 1822348"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_fd0d33e8","line":10,"updated":"2019-04-04 09:14:41.000000000","message":"I\u0027m not sure that this achieves the goal because this runs once, delegated to the service setup host and so the fact is set only for that host - not all hosts in the group. I could be wrong though.\n\nI\u0027m also not sure whether add_service.user.default_project_id will exist on a second run - I think it might only exist on the first execution of the task.\n\nHas this been tested in a multi-node environment at all?\n\nThere is a precedent for this - see https://github.com/openstack/openstack-ansible-os_octavia/blob/7aa511643a2874dc00e78fb31ddde4a894231e61/tasks/octavia_post_install.yml#L68-L93 - with something like that, it definitely works. You\u0027ll notice that https://github.com/openstack/openstack-ansible-os_octavia/commit/e0a69d0bda3f55fdaf1e4cdb40baffe3a638d201 (which added those tasks) explains exactly the problem that I think it going to happen with this patch.","commit_id":"852c0fe1e27c051fda8e746506a9b7f341a2732e"}],"defaults/main.yml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"df03276bf6ce4161b62d0291b29a8df37447df61","unresolved":false,"context_lines":[{"line_number":238,"context_line":"# Image tag for the amphora image in glance"},{"line_number":239,"context_line":"octavia_glance_image_tag: octavia-amphora-image"},{"line_number":240,"context_line":"# add here the id of the image owner to avoid faked images being used"},{"line_number":241,"context_line":"octavia_amp_image_owner_id: \"{{ octavia_user_project_uuid }}\""},{"line_number":242,"context_line":"# add here the glance image id if tagging is not used (not recommended for prod)"},{"line_number":243,"context_line":"octavia_amp_image_id:"},{"line_number":244,"context_line":"# download the image from an artefact server"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_96eb0d11","line":241,"range":{"start_line":241,"start_character":28,"end_line":241,"end_character":61},"updated":"2019-03-29 18:29:53.000000000","message":"This will not do what I think you expect it to do. Defaults will load before tasks are run. As you\u0027re proposing, \"octavia_user_project_uuid\" would need to be passed in as an extra var or defined in the play.","commit_id":"3e7919f8a91616f41b427f2ba11f5d9accb5d63e"}],"tasks/octavia_service_add.yml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"df03276bf6ce4161b62d0291b29a8df37447df61","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    - name: Set Octavia project UUID fact"},{"line_number":58,"context_line":"      set_fact:"},{"line_number":59,"context_line":"          octavia_user_project_uuid: \"{{ user.default_project_id }}\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    - name: Add service user to admin role"},{"line_number":62,"context_line":"      os_user_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_56f5a5ec","line":59,"range":{"start_line":59,"start_character":10,"end_line":59,"end_character":35},"updated":"2019-03-29 18:29:53.000000000","message":"... what you want is to set \"octavia_amp_image_owner_id\" here.","commit_id":"3e7919f8a91616f41b427f2ba11f5d9accb5d63e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"52512c39156d0263f4ea3d888441b0da9f16c60c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      delay: 10"},{"line_number":55,"context_line":"      no_log: True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    - name: Set Octavia amphora image onwer ID fact"},{"line_number":58,"context_line":"      set_fact:"},{"line_number":59,"context_line":"          octavia_amp_image_owner_id: \"{{ add_service.user.default_project_id }}\""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5fc1f717_9de0af28","line":57,"range":{"start_line":57,"start_character":38,"end_line":57,"end_character":43},"updated":"2019-04-04 09:14:41.000000000","message":"I think you meant \u0027owner\u0027 ?","commit_id":"852c0fe1e27c051fda8e746506a9b7f341a2732e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"52512c39156d0263f4ea3d888441b0da9f16c60c","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    - name: Set Octavia amphora image onwer ID fact"},{"line_number":58,"context_line":"      set_fact:"},{"line_number":59,"context_line":"          octavia_amp_image_owner_id: \"{{ add_service.user.default_project_id }}\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    - name: Add service user to admin role"},{"line_number":62,"context_line":"      os_user_role:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5fc1f717_fdca139f","line":59,"range":{"start_line":59,"start_character":6,"end_line":59,"end_character":10},"updated":"2019-04-04 09:14:41.000000000","message":"nit: This only needs to be two spaces.","commit_id":"852c0fe1e27c051fda8e746506a9b7f341a2732e"}]}
