)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"877c7800910136d01f64856ac35575950a93a967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0da99b1b_f2015003","updated":"2024-08-28 08:32:30.000000000","message":"also, please, create a release note describing new variable as a `feature` one.\nYou can check this doc on how to do that: https://docs.openstack.org/reno/latest/user/usage.html","commit_id":"442effa410e4c3a81dd7d0da936d2600a5f2a4ae"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"31db66ce6bca3eb2250bbac2d87e6bf0e490340f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d1023a32_122fcc60","updated":"2024-08-28 07:52:19.000000000","message":"it looks good overall, just a small nit with condition I\u0027ve mentioned.","commit_id":"442effa410e4c3a81dd7d0da936d2600a5f2a4ae"},{"author":{"_account_id":37261,"name":"Yuki Hirano","email":"yuuki0xff@gmail.com","username":"yuuki0xff"},"change_message_id":"185ae510c839f3b39b46a390c59ca8a2fc03b889","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"22a43c01_4274ed92","in_reply_to":"0da99b1b_f2015003","updated":"2024-08-28 09:13:51.000000000","message":"I added a release note.","commit_id":"442effa410e4c3a81dd7d0da936d2600a5f2a4ae"},{"author":{"_account_id":37261,"name":"Yuki Hirano","email":"yuuki0xff@gmail.com","username":"yuuki0xff"},"change_message_id":"703c7e4fca99ba172426bcab175f97bd3b1366ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11fd1995_9611b6a1","in_reply_to":"22a43c01_4274ed92","updated":"2024-08-29 06:18:26.000000000","message":"Done","commit_id":"442effa410e4c3a81dd7d0da936d2600a5f2a4ae"},{"author":{"_account_id":37261,"name":"Yuki Hirano","email":"yuuki0xff@gmail.com","username":"yuuki0xff"},"change_message_id":"6932631a22c4b8c3002843f9b9ecf6d2948190af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c1b1c457_b25085b7","updated":"2024-08-29 06:20:37.000000000","message":"recheck","commit_id":"1b745fea66793593cf08fe2865953ea4efa89776"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"863070ed69184972ee319d384c813fdda47f4788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ac381fe_9b7cb9f6","updated":"2024-08-28 09:11:30.000000000","message":"thanks!","commit_id":"1b745fea66793593cf08fe2865953ea4efa89776"}],"tasks/octavia_resources.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"fdc17ea3574967e8bda7a81152c862f12bc29e41","unresolved":true,"context_lines":[{"line_number":97,"context_line":"            {% if octavia_management_net_dhcp %}"},{"line_number":98,"context_line":"            {%   set _ \u003d rules.append(_octavia_security_rule_dhcp) %}"},{"line_number":99,"context_line":"            {% endif %}"},{"line_number":100,"context_line":"            {% if octavia_security_group_additional_rules is defined %}"},{"line_number":101,"context_line":"            {%   set _ \u003d rules.extend(octavia_security_group_additional_rules) %}"},{"line_number":102,"context_line":"            {% endif %}"},{"line_number":103,"context_line":"            {{ rules }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"47220f35_ae6d47b6","line":100,"range":{"start_line":100,"start_character":15,"end_line":100,"end_character":68},"updated":"2024-08-28 07:51:11.000000000","message":"`octavia_security_group_additional_rules` is in role defaults, so it\u0027s always defined.\nso I think you can extend unconditionally here","commit_id":"442effa410e4c3a81dd7d0da936d2600a5f2a4ae"},{"author":{"_account_id":37261,"name":"Yuki Hirano","email":"yuuki0xff@gmail.com","username":"yuuki0xff"},"change_message_id":"703c7e4fca99ba172426bcab175f97bd3b1366ae","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            {% if octavia_management_net_dhcp %}"},{"line_number":98,"context_line":"            {%   set _ \u003d rules.append(_octavia_security_rule_dhcp) %}"},{"line_number":99,"context_line":"            {% endif %}"},{"line_number":100,"context_line":"            {% if octavia_security_group_additional_rules is defined %}"},{"line_number":101,"context_line":"            {%   set _ \u003d rules.extend(octavia_security_group_additional_rules) %}"},{"line_number":102,"context_line":"            {% endif %}"},{"line_number":103,"context_line":"            {{ rules }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"189b197f_18273573","line":100,"range":{"start_line":100,"start_character":15,"end_line":100,"end_character":68},"in_reply_to":"1986886a_96b8769d","updated":"2024-08-29 06:18:26.000000000","message":"Done","commit_id":"442effa410e4c3a81dd7d0da936d2600a5f2a4ae"},{"author":{"_account_id":37261,"name":"Yuki Hirano","email":"yuuki0xff@gmail.com","username":"yuuki0xff"},"change_message_id":"185ae510c839f3b39b46a390c59ca8a2fc03b889","unresolved":true,"context_lines":[{"line_number":97,"context_line":"            {% if octavia_management_net_dhcp %}"},{"line_number":98,"context_line":"            {%   set _ \u003d rules.append(_octavia_security_rule_dhcp) %}"},{"line_number":99,"context_line":"            {% endif %}"},{"line_number":100,"context_line":"            {% if octavia_security_group_additional_rules is defined %}"},{"line_number":101,"context_line":"            {%   set _ \u003d rules.extend(octavia_security_group_additional_rules) %}"},{"line_number":102,"context_line":"            {% endif %}"},{"line_number":103,"context_line":"            {{ rules }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1986886a_96b8769d","line":100,"range":{"start_line":100,"start_character":15,"end_line":100,"end_character":68},"in_reply_to":"47220f35_ae6d47b6","updated":"2024-08-28 09:13:51.000000000","message":"I modified the patch as you pointed out.","commit_id":"442effa410e4c3a81dd7d0da936d2600a5f2a4ae"}]}