)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"de03e540697344f8413556d8d6071c4c23911c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0738513a_8ceaad41","updated":"2026-06-26 13:15:26.000000000","message":"recheck - intermittent","commit_id":"c32f758433c011e5ee27298c0207f35d29c548a8"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"8b052d0f559bd62ab681e8bbf1c9d12fe677c5b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0cbc11ab_4525093c","in_reply_to":"0738513a_8ceaad41","updated":"2026-06-26 13:17:01.000000000","message":"Need fix for 26.04, wait merge in octavia.","commit_id":"c32f758433c011e5ee27298c0207f35d29c548a8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e89c55ad275909929341cd458435625aee269520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5c0d479_338f2a49","in_reply_to":"0cbc11ab_4525093c","updated":"2026-06-26 14:29:21.000000000","message":"I wonder if we should add a resolute job override to NV for octavia until then?","commit_id":"c32f758433c011e5ee27298c0207f35d29c548a8"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"e15189bce2245ea6fc7f210476a8a3d00578c9b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aa939a34_b0b64462","in_reply_to":"a5c0d479_338f2a49","updated":"2026-06-26 14:32:34.000000000","message":"I touch Octavia team again, lets wait next week.","commit_id":"c32f758433c011e5ee27298c0207f35d29c548a8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e1bb45d9af837bfe7825c7e9f3e3344dfa6bb5e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cb3e75b6_5c68481f","in_reply_to":"aa939a34_b0b64462","updated":"2026-06-26 16:36:45.000000000","message":"I will try to make a patch for depends-on to Octavia to work in the meanwhile. Maybe it will convince them 😉","commit_id":"c32f758433c011e5ee27298c0207f35d29c548a8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a00404cc2c8171a39a727d0ce00272f83758db1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5384dbc3_52e40d22","updated":"2026-06-27 08:22:57.000000000","message":"recheck - dependent patch updated","commit_id":"aad8a846d47e8e7305dee3cd49c30c0b3cc164a6"}],"tasks/octavia_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"16edc3e9a672dae65d3a7faa5fce911ee0d2d09e","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# way to get a configurable rule definition in right now"},{"line_number":18,"context_line":"- name: IPtables rules"},{"line_number":19,"context_line":"  ansible.builtin.iptables: \"{{ item }}\""},{"line_number":20,"context_line":"  loop: \"{{ octavia_iptables_rules }}\""},{"line_number":21,"context_line":"  when: octavia_ip_tables_fw | bool"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# This is totally odd: If you run the commands via run-parts (as the script"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"73a9bae4_5c8a1971","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":38},"updated":"2026-06-25 09:33:32.000000000","message":"why this change?","commit_id":"4d31b1ab92981fabe97561daa0e9e340c21b3688"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"73d28d0eec004c8624b117e4cc34bddbdae16fca","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# way to get a configurable rule definition in right now"},{"line_number":18,"context_line":"- name: IPtables rules"},{"line_number":19,"context_line":"  ansible.builtin.iptables: \"{{ item }}\""},{"line_number":20,"context_line":"  loop: \"{{ octavia_iptables_rules }}\""},{"line_number":21,"context_line":"  when: octavia_ip_tables_fw | bool"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# This is totally odd: If you run the commands via run-parts (as the script"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e84bc16b_b83ebdaf","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":38},"in_reply_to":"1063bca2_b7a7d744","updated":"2026-06-25 09:44:06.000000000","message":"Done","commit_id":"4d31b1ab92981fabe97561daa0e9e340c21b3688"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"86bf027aee17524bb982a317c1a7fa10cdcf9b08","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# way to get a configurable rule definition in right now"},{"line_number":18,"context_line":"- name: IPtables rules"},{"line_number":19,"context_line":"  ansible.builtin.iptables: \"{{ item }}\""},{"line_number":20,"context_line":"  loop: \"{{ octavia_iptables_rules }}\""},{"line_number":21,"context_line":"  when: octavia_ip_tables_fw | bool"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# This is totally odd: If you run the commands via run-parts (as the script"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1063bca2_b7a7d744","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":38},"in_reply_to":"73a9bae4_5c8a1971","updated":"2026-06-25 09:42:50.000000000","message":"https://docs.ansible.com/projects/ansible/latest/playbook_guide/playbooks_loops.html\n\nWe\u0027re not really changing anything with this, we\u0027re just moving away from designs that are still available, but it\u0027s better to use current methods, according to the documentation, and I think this looks more promising.","commit_id":"4d31b1ab92981fabe97561daa0e9e340c21b3688"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"8b052d0f559bd62ab681e8bbf1c9d12fe677c5b4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# way to get a configurable rule definition in right now"},{"line_number":18,"context_line":"- name: IPtables rules"},{"line_number":19,"context_line":"  ansible.builtin.iptables: \"{{ item }}\""},{"line_number":20,"context_line":"  loop: \"{{ octavia_iptables_rules }}\""},{"line_number":21,"context_line":"  when: octavia_ip_tables_fw | bool"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# This is totally odd: If you run the commands via run-parts (as the script"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e3715861_d9a5b801","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":38},"in_reply_to":"76747edd_23945cc2","updated":"2026-06-26 13:17:01.000000000","message":"Your right, do it in future.","commit_id":"4d31b1ab92981fabe97561daa0e9e340c21b3688"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bf32b0d5568d9afb472de67cfc3ed5c653ee06ba","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# way to get a configurable rule definition in right now"},{"line_number":18,"context_line":"- name: IPtables rules"},{"line_number":19,"context_line":"  ansible.builtin.iptables: \"{{ item }}\""},{"line_number":20,"context_line":"  loop: \"{{ octavia_iptables_rules }}\""},{"line_number":21,"context_line":"  when: octavia_ip_tables_fw | bool"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# This is totally odd: If you run the commands via run-parts (as the script"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"76747edd_23945cc2","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":38},"in_reply_to":"e84bc16b_b83ebdaf","updated":"2026-06-26 13:14:49.000000000","message":"We do change, as one-to-one replacement for `with_items` is with `flatten` filter applied.\nAnd then the change is quite sporadical - we use loops in many more places in the role. If we have a goal to replace them with new syntax - let\u0027s cover all occasions.\n\nBut the goal of the patch seems to be different, so this change is just unrelated.","commit_id":"4d31b1ab92981fabe97561daa0e9e340c21b3688"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"16edc3e9a672dae65d3a7faa5fce911ee0d2d09e","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  ansible.builtin.shell: iptables-save \u003e /etc/sysconfig/iptables"},{"line_number":34,"context_line":"  changed_when: false"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Copy user provided HAProxy templates"},{"line_number":39,"context_line":"  ansible.builtin.copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"534156ed_b33feaec","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":47},"updated":"2026-06-25 09:33:32.000000000","message":"I think this is wrong. It should have been os_family, not distribution.","commit_id":"4d31b1ab92981fabe97561daa0e9e340c21b3688"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"86bf027aee17524bb982a317c1a7fa10cdcf9b08","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  ansible.builtin.shell: iptables-save \u003e /etc/sysconfig/iptables"},{"line_number":34,"context_line":"  changed_when: false"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Copy user provided HAProxy templates"},{"line_number":39,"context_line":"  ansible.builtin.copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"71a74869_67fcfe19","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":47},"in_reply_to":"534156ed_b33feaec","updated":"2026-06-25 09:42:50.000000000","message":"Done","commit_id":"4d31b1ab92981fabe97561daa0e9e340c21b3688"}]}
