)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c31cfea741bd4569875ea0465dc16efab22b769e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"sahara_service_internaluri: \"{{ sahara_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ sahara_service_port }}\""},{"line_number":110,"context_line":"sahara_service_internalurl: \"{{ sahara_service_internaluri }}\""},{"line_number":111,"context_line":"sahara_service_adminuri: \"{{ sahara_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ sahara_service_port }}\""},{"line_number":112,"context_line":"sahara_service_adminurl: \"{{ sahara_service_adminuri }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"## Keystone authentication middleware"},{"line_number":115,"context_line":"sahara_keystone_auth_plugin: password"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_f23e93e1","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":56},"updated":"2018-07-17 18:29:54.000000000","message":"Instead of now carrying two vars for the same thing, could we perhaps reduce down to a single var for each endpoint and adjust all uses of the \u0027url\u0027 vars to now just use \u0027uri\u0027 instead?","commit_id":"905cb6fc77683f295e449104a98e3d3646a43f85"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a990d988583c8c82d1e8d2dc8374ea9357cd47bc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"sahara_service_internaluri: \"{{ sahara_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ sahara_service_port }}\""},{"line_number":110,"context_line":"sahara_service_internalurl: \"{{ sahara_service_internaluri }}\""},{"line_number":111,"context_line":"sahara_service_adminuri: \"{{ sahara_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ sahara_service_port }}\""},{"line_number":112,"context_line":"sahara_service_adminurl: \"{{ sahara_service_adminuri }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"## Keystone authentication middleware"},{"line_number":115,"context_line":"sahara_keystone_auth_plugin: password"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_c6c5d53e","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":56},"in_reply_to":"5f7c97a3_15f1b900","updated":"2018-07-17 21:31:59.000000000","message":"Yeah, for anything that\u0027s using a versionless endpoint we\u0027re trying to move all the roles to using a single var per endpoint. It\u0027s not super-high on the priority list, but something we\u0027d like done. Less vars \u003d less memory consumption when deploying.\n\nGiven that this is not yet a pervasive pattern and you\u0027re now aware, I\u0027ll remove the -1 as this should not stop the change as-is, which is good.","commit_id":"905cb6fc77683f295e449104a98e3d3646a43f85"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7519cb2491323de1707748a5fb91c2e3987c47c1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"sahara_service_internaluri: \"{{ sahara_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ sahara_service_port }}\""},{"line_number":110,"context_line":"sahara_service_internalurl: \"{{ sahara_service_internaluri }}\""},{"line_number":111,"context_line":"sahara_service_adminuri: \"{{ sahara_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ sahara_service_port }}\""},{"line_number":112,"context_line":"sahara_service_adminurl: \"{{ sahara_service_adminuri }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"## Keystone authentication middleware"},{"line_number":115,"context_line":"sahara_keystone_auth_plugin: password"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_15f1b900","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":56},"in_reply_to":"5f7c97a3_f23e93e1","updated":"2018-07-17 18:41:52.000000000","message":"If this is the common pattern for services which expose an unversioned endpoint, sure.\nAnother thing to consider is the usage of the *uri vs *url variable in other openstack-ansible-os_* project, and if keeping the variable names consistent is valued important or not.","commit_id":"905cb6fc77683f295e449104a98e3d3646a43f85"}]}