)]}'
{"tasks/swift_key_distribute.yml":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"9985eae75fc9b4ba06877187564c77706fa7809d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    key: \"{{ hostvars[item][\u0027swift_pubkey\u0027] | b64decode }}\""},{"line_number":20,"context_line":"  with_items: \"{{ groups[\u0027swift_all\u0027] + groups[\u0027swift_remote_all\u0027] }}\""},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - hostvars[item] is defined"},{"line_number":23,"context_line":"    - hostvars[item][\u0027swift_pubkey\u0027] is defined"},{"line_number":24,"context_line":"  tags:"},{"line_number":25,"context_line":"    - swift-key"},{"line_number":26,"context_line":"    - swift-key-create"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_1e6d8799","line":23,"range":{"start_line":22,"start_character":5,"end_line":23,"end_character":47},"updated":"2016-07-10 08:49:53.000000000","message":"is the idea here to skip hosts that have failed?\nThat concerns me a little, I\u0027m not sure if it would be better to allow that to happen or to just fail - if I\u0027m not expecting any hosts to be down then some hosts may stop working.\n\nAlternatively, if I do a few copies and then fail that creates the same problem - it would list a failure on the hosts that failed out earlier - unless there is an edge case where the host doesn\u0027t fail but somehow doesn\u0027t generate a swift_pubkey (or a bug that means the pubkey is created incorrectly).","commit_id":"23b17074ec8caeca2cb3e57a45b0b86c0dcd001b"}],"tasks/swift_rings_check.yml":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"9985eae75fc9b4ba06877187564c77706fa7809d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"       do not match {{ inventory_hostname }}:{{ md5sum.stdout }}"},{"line_number":37,"context_line":"       and are not empty on the remote host\""},{"line_number":38,"context_line":"  when:"},{"line_number":39,"context_line":"    - hostvars[item] is defined"},{"line_number":40,"context_line":"    - hostvars[item][\u0027builder_md5sum\u0027] is defined"},{"line_number":41,"context_line":"    - hostvars[item][\u0027builder_md5sum\u0027] !\u003d empty_md5sum.stdout"},{"line_number":42,"context_line":"    - hostvars[item][\u0027builder_md5sum\u0027] !\u003d md5sum.stdout"},{"line_number":43,"context_line":"  with_items: \"{{ groups[\u0027swift_all\u0027] + groups[\u0027swift_remote_all\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_3ef963c9","line":40,"range":{"start_line":39,"start_character":3,"end_line":40,"end_character":49},"updated":"2016-07-10 08:49:53.000000000","message":"pretty similar to the pubkey check - although inconsistent rings are not a good idea, so if a host is offline and will come back later (and the ring has changed in any way) we probably don\u0027t want to not fail on this.\nI\u0027m not sure an operator should be distributing the ring if some hosts are in a failed state (and they anticipate the hosts coming back at some point in the future).\nI could be persuaded otherwise though - so if you have any thoughts lets discuss.","commit_id":"23b17074ec8caeca2cb3e57a45b0b86c0dcd001b"}],"tasks/swift_storage_hosts_setup.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"01fbee503fde63606dd7a27cb15fcba954282bb4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    owner: \"{{ swift_system_user_name }}\""},{"line_number":63,"context_line":"    group: \"{{ swift_system_group_name }}\""},{"line_number":64,"context_line":"    state: \"directory\""},{"line_number":65,"context_line":"  with_items: \"{{ swift_vars.drives| default(swift.drives) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7aa08908_fc1b9271","line":65,"range":{"start_line":65,"start_character":2,"end_line":65,"end_character":62},"updated":"2016-06-15 19:42:52.000000000","message":"This \u0027looks\u0027 functionally equivalent and is actually a nice consolidation. I\u0027d rather get Andy McCrae\u0027s vote though as there may be an edge case we\u0027re not testing which this breaks.","commit_id":"23b17074ec8caeca2cb3e57a45b0b86c0dcd001b"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"9985eae75fc9b4ba06877187564c77706fa7809d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    owner: \"{{ swift_system_user_name }}\""},{"line_number":63,"context_line":"    group: \"{{ swift_system_group_name }}\""},{"line_number":64,"context_line":"    state: \"directory\""},{"line_number":65,"context_line":"  with_items: \"{{ swift_vars.drives| default(swift.drives) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_5e670fb7","line":65,"range":{"start_line":65,"start_character":2,"end_line":65,"end_character":62},"in_reply_to":"7aa08908_fc1b9271","updated":"2016-07-10 08:49:53.000000000","message":"Happy with this - nice change! I\u0027ve been trying to do a couple others myself because the swift tasks have a lot of unnecessary duplication.","commit_id":"23b17074ec8caeca2cb3e57a45b0b86c0dcd001b"}]}
