)]}'
{"defaults/main.yml":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"e8cf7f72bc64c893a7cafa5f656fa3db1407d220","unresolved":false,"context_lines":[{"line_number":83,"context_line":"# This will update the ring, on the next playbook run,"},{"line_number":84,"context_line":"# without requiring a rebalance."},{"line_number":85,"context_line":"# NB: There is service downtime, during the run, between"},{"line_number":86,"context_line":"# the service restart and the ring updating."},{"line_number":87,"context_line":"swift_object_port: \"6000\""},{"line_number":88,"context_line":"swift_container_port: \"6001\""},{"line_number":89,"context_line":"swift_account_port: \"6002\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_6cace835","line":86,"updated":"2016-08-16 07:18:19.000000000","message":"Yeah cool, so long as when deployed people use a concurrency value (so they all don\u0027t happen at once) then yeah cool.","commit_id":"7178fa0778c76467311b8c249386f605c3dcf743"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"2bb0404e4f2fb98828f735667a9045a868ba0c85","unresolved":false,"context_lines":[{"line_number":83,"context_line":"# This will update the ring, on the next playbook run,"},{"line_number":84,"context_line":"# without requiring a rebalance."},{"line_number":85,"context_line":"# NB: There is service downtime, during the run, between"},{"line_number":86,"context_line":"# the service restart and the ring updating."},{"line_number":87,"context_line":"swift_object_port: \"6000\""},{"line_number":88,"context_line":"swift_container_port: \"6001\""},{"line_number":89,"context_line":"swift_account_port: \"6002\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_4afa9abe","line":86,"in_reply_to":"3ac371cc_6cace835","updated":"2016-08-16 12:34:53.000000000","message":"Yeah I think if you were to upgrade/change your port number it would require some planning - e.g. change the port value per host 1 at a time or in small batches - that way your availability should remain high. That is largely an operational issue. I would probably advise leaving your port in place, the default upstream changed (so I\u0027d like to change that so OSA follows) but you could just override that value and leave it.","commit_id":"7178fa0778c76467311b8c249386f605c3dcf743"}],"templates/swift_rings.py.j2":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"bfb4e7d202f66b391d3149d46060bb9f115db9f1","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                    rb_main, [\"swift-ring-builder\", build_file,"},{"line_number":188,"context_line":"                              \"pretend_min_part_hours_passed\"]"},{"line_number":189,"context_line":"                )"},{"line_number":190,"context_line":"            run_and_wait("},{"line_number":191,"context_line":"                rb_main, [\"swift-ring-builder\", build_file, \"rebalance\"]"},{"line_number":192,"context_line":"            )"},{"line_number":193,"context_line":"            # In case no changes that require a rebalance have happened"},{"line_number":194,"context_line":"            # We may still need to write the ring for device changes."},{"line_number":195,"context_line":"            run_and_wait("},{"line_number":196,"context_line":"                rb_main, [\"swift-ring-builder\", build_file, \"write_ring\"]"},{"line_number":197,"context_line":"            )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"def main(setup, region, reset_mph_clock):"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_e6cb6270","line":197,"range":{"start_line":190,"start_character":0,"end_line":197,"end_character":13},"updated":"2016-08-05 14:24:49.000000000","message":"This appears both statements will execute.","commit_id":"40fb731369327c3d79866154a694d29c49efa742"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"2c1df45b3a52119b3e73bdc2114983a2d5a3335a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                    rb_main, [\"swift-ring-builder\", build_file,"},{"line_number":188,"context_line":"                              \"pretend_min_part_hours_passed\"]"},{"line_number":189,"context_line":"                )"},{"line_number":190,"context_line":"            run_and_wait("},{"line_number":191,"context_line":"                rb_main, [\"swift-ring-builder\", build_file, \"rebalance\"]"},{"line_number":192,"context_line":"            )"},{"line_number":193,"context_line":"            # In case no changes that require a rebalance have happened"},{"line_number":194,"context_line":"            # We may still need to write the ring for device changes."},{"line_number":195,"context_line":"            run_and_wait("},{"line_number":196,"context_line":"                rb_main, [\"swift-ring-builder\", build_file, \"write_ring\"]"},{"line_number":197,"context_line":"            )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"def main(setup, region, reset_mph_clock):"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_e9da1577","line":197,"range":{"start_line":190,"start_character":0,"end_line":197,"end_character":13},"in_reply_to":"bacf61ea_e6cb6270","updated":"2016-08-05 14:39:03.000000000","message":"I\u0027m not sure there is a better way - a rebalance will perform a write_ring, BUT if nothing has changed that requires a rebalance (e.g. you just change a port number) it will not write the ring, and so you will end up with failures (e.g. the service will reconfigure to listen on the new port but the ring will not have been written so it still tries to connect to the old port).\n\nTo fix this we need to write the ring, if the ring is rebalanced then a write will happen twice which is inefficient, but I\u0027m not sure there is a better way to do this.","commit_id":"40fb731369327c3d79866154a694d29c49efa742"}],"templates/swift_rings_check.py.j2":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"bfb4e7d202f66b391d3149d46060bb9f115db9f1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    if content_repl_port !\u003d ring_repl_port:"},{"line_number":82,"context_line":"        raise RingComparisonError(\u0027Replication Port for device %s differs \u0027"},{"line_number":83,"context_line":"                                  \u0027to the ring.\u0027 % devstr)"},{"line_number":84,"context_line":"    if content_weight !\u003d ring_weight:"},{"line_number":85,"context_line":"        raise RingComparisonError(\u0027Device weight for device %s differs to the \u0027"},{"line_number":86,"context_line":"                                  \u0027ring.\u0027 % devstr)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def check_ring(build_name, repl, min_part_hours, part_power, content_hosts,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_631da472","side":"PARENT","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":51},"updated":"2016-08-05 14:24:49.000000000","message":"This functionality does not seem to be included in the new code.  Why is this no longer being checked?","commit_id":"ae8ca494f96ff9cf7f7d4830640da69cdf620832"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"2c1df45b3a52119b3e73bdc2114983a2d5a3335a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    if content_repl_port !\u003d ring_repl_port:"},{"line_number":82,"context_line":"        raise RingComparisonError(\u0027Replication Port for device %s differs \u0027"},{"line_number":83,"context_line":"                                  \u0027to the ring.\u0027 % devstr)"},{"line_number":84,"context_line":"    if content_weight !\u003d ring_weight:"},{"line_number":85,"context_line":"        raise RingComparisonError(\u0027Device weight for device %s differs to the \u0027"},{"line_number":86,"context_line":"                                  \u0027ring.\u0027 % devstr)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def check_ring(build_name, repl, min_part_hours, part_power, content_hosts,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_89d2795a","side":"PARENT","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":51},"in_reply_to":"bacf61ea_631da472","updated":"2016-08-05 14:39:03.000000000","message":"Nice catch! Fixed by changing the FULL_HOST_KEY in the ring_check to include weight.","commit_id":"ae8ca494f96ff9cf7f7d4830640da69cdf620832"}]}
