)]}'
{"id":"openstack%2Fopenstack-ansible-os_swift~377603","triplet_id":"openstack%2Fopenstack-ansible-os_swift~master~Ic0aedbd1a5a5faafd0a1191b50ade90d46503057","project":"openstack/openstack-ansible-os_swift","branch":"master","topic":"bool_fix","hashtags":[],"change_id":"Ic0aedbd1a5a5faafd0a1191b50ade90d46503057","subject":"Fix bool evaluation for dedicated repl network","status":"MERGED","created":"2016-09-27 10:45:28.000000000","updated":"2016-09-27 13:52:01.000000000","submitted":"2016-09-27 13:52:01.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2bcb072af3b3ee32b719da72a3472b5077301978","_number":377603,"virtual_id_number":377603,"owner":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2016-09-27 13:52:01.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2016-09-27 11:18:13.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-27 13:21:12.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-27 13:21:12.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-27 11:18:13.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2016-09-27 13:21:12.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2016-09-27 13:52:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6b4acddb9bf4b8cb57a2e669975b438759f728ad","author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"date":"2016-09-27 10:45:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"72a36835c488d80c1cfb69c29c99ddd2fc74e8c8","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-09-27 11:15:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"781d7962dfeaebfcae10710d525fb4a5c3936220","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-09-27 11:18:13.000000000","message":"Patch Set 1: Code-Review+2\n\nIt\u0027s working for the gate it seems, and is a sensible fix. Filter precedence in Ansible is confusing.","accounts_in_message":[],"_revision_number":1},{"id":"1c80ace1601f280e885c2f832408142df343e39d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-27 12:25:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-os_swift-docs-ubuntu-xenial http://docs-draft.openstack.org/03/377603/1/check/gate-openstack-ansible-os_swift-docs-ubuntu-xenial/a57b25e//doc/build/html/ : SUCCESS in 1m 40s\n- gate-openstack-ansible-os_swift-linters-ubuntu-xenial http://logs.openstack.org/03/377603/1/check/gate-openstack-ansible-os_swift-linters-ubuntu-xenial/d302a75/ : SUCCESS in 2m 24s\n- gate-openstack-ansible-os_swift-ansible-func-centos-7-nv http://logs.openstack.org/03/377603/1/check/gate-openstack-ansible-os_swift-ansible-func-centos-7-nv/67347f8/ : FAILURE in 27m 32s (non-voting)\n- gate-openstack-ansible-os_swift-ansible-func-ubuntu-trusty http://logs.openstack.org/03/377603/1/check/gate-openstack-ansible-os_swift-ansible-func-ubuntu-trusty/3cbd7c6/ : SUCCESS in 23m 17s\n- gate-openstack-ansible-os_swift-ansible-func-ubuntu-xenial http://logs.openstack.org/03/377603/1/check/gate-openstack-ansible-os_swift-ansible-func-ubuntu-xenial/875f43a/ : SUCCESS in 43m 09s\n- gate-openstack-ansible-os_swift-ansible-multi_reg-centos-7-nv http://logs.openstack.org/03/377603/1/check/gate-openstack-ansible-os_swift-ansible-multi_reg-centos-7-nv/e5088db/ : FAILURE in 23m 44s (non-voting)\n- gate-openstack-ansible-os_swift-ansible-multi_reg-ubuntu-trusty-nv http://logs.openstack.org/03/377603/1/check/gate-openstack-ansible-os_swift-ansible-multi_reg-ubuntu-trusty-nv/b9626a6/ : SUCCESS in 28m 23s (non-voting)\n- gate-openstack-ansible-os_swift-ansible-multi_reg-ubuntu-xenial-nv http://logs.openstack.org/03/377603/1/check/gate-openstack-ansible-os_swift-ansible-multi_reg-ubuntu-xenial-nv/75fbf33/ : FAILURE in 1h 04m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"97bc6f4f0b3248ddc9e8b35b8a26684813d7c786","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2016-09-27 13:21:12.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5ffa45942367102ac98f1f2d13d5dcf481dc4e51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-27 13:21:23.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f305f79b75f1408acf805b56f393e90773c8face","date":"2016-09-27 13:52:01.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"a974160add11f76e2429a2ed898b2fe2eda8f3b7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-27 13:52:01.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-os_swift-docs-ubuntu-xenial http://docs-draft.openstack.org/03/377603/1/gate/gate-openstack-ansible-os_swift-docs-ubuntu-xenial/6df01c9//doc/build/html/ : SUCCESS in 56s\n- gate-openstack-ansible-os_swift-linters-ubuntu-xenial http://logs.openstack.org/03/377603/1/gate/gate-openstack-ansible-os_swift-linters-ubuntu-xenial/247c57a/ : SUCCESS in 1m 22s\n- gate-openstack-ansible-os_swift-ansible-func-ubuntu-trusty http://logs.openstack.org/03/377603/1/gate/gate-openstack-ansible-os_swift-ansible-func-ubuntu-trusty/079c45a/ : SUCCESS in 21m 17s\n- gate-openstack-ansible-os_swift-ansible-func-ubuntu-xenial http://logs.openstack.org/03/377603/1/gate/gate-openstack-ansible-os_swift-ansible-func-ubuntu-xenial/5937156/ : SUCCESS in 29m 55s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2a3b1840eb68fdff8e8dfaa7826e769003d6f33e","revisions":{"2a3b1840eb68fdff8e8dfaa7826e769003d6f33e":{"kind":"REWORK","_number":1,"created":"2016-09-27 10:45:28.000000000","uploader":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"ref":"refs/changes/03/377603/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_swift","ref":"refs/changes/03/377603/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_swift refs/changes/03/377603/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_swift refs/changes/03/377603/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_swift refs/changes/03/377603/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_swift refs/changes/03/377603/1"}}},"commit":{"parents":[{"commit":"768b47ab292979f37ffd03871ec5af70f4114b5e","subject":"Force Ansible to use dynamic includes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_swift/commit/768b47ab292979f37ffd03871ec5af70f4114b5e"}]}],"author":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2016-09-27 10:35:03.000000000","tz":60},"committer":{"name":"Andy McCrae","email":"andy.mccrae@gmail.com","date":"2016-09-27 10:35:03.000000000","tz":60},"subject":"Fix bool evaluation for dedicated repl network","message":"Fix bool evaluation for dedicated repl network\n\nThe | bool was forcing the second var to be a \"bool\" meaning the\nstatement always evaluated to true.\n\nThis fixes the issue and ensures that when the addresses are the same\nthe \"swift_dedicated_replication\" setting evaluates to \"False\", and when\nthey are different it evaluates to \"True\".\n\nChange-Id: Ic0aedbd1a5a5faafd0a1191b50ade90d46503057\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_swift/commit/2a3b1840eb68fdff8e8dfaa7826e769003d6f33e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_swift/commit/2a3b1840eb68fdff8e8dfaa7826e769003d6f33e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}