)]}'
{"tasks/swift_rings.yml":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"2b5b80c3977e3a77401720efeaf62898314c684c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  run_once: true"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- include: swift_rings_build.yml"},{"line_number":27,"context_line":"  run_once: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- include: swift_rings_distribute.yml"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_488c1ad6","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":16},"updated":"2017-07-06 14:05:14.000000000","message":"I\u0027m not sure this will work - since in the rings_build we specify swift_hosts[0] as the location to retrieve the ring from.\n\nIn testing it works because I\u0027m guessing swift_hosts[0] is the same as the host that would\u0027ve been \"swift_hosts\" run_once: True\n\nBut if those hosts are different then that would no longer work - or worse, it \"works\" because it can retrieve the ring and ship it to other locations, but it doesn\u0027t get updated.\n\nI\u0027m also slightly concerned by the ring distribution in general - if we update the ring in any way we need to sync it to all hosts - if we don\u0027t update it then we can skip over the sync.\n\nAdditionally, if we run against a subset of hosts, and update the ring - then we will only sync to the same subset of hosts, which would be a big issue, because the ring could be inconsistent on all other hosts. (E.g. run will succeed but cluster will be broken)","commit_id":"fc80e0149539821726745ded046c0c4d64141399"}]}
